Details

Reviewers

deadalnix
Fabien
jasonbcox
markblundeberg

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING71da2efe0b6c: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet
rABC71da2efe0b6c: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet

Summary

41ba061 [docs] Add release notes for wallet 'label' API. (John Newbery)
189e0ef [wallet] [rpc] introduce 'label' API for wallet (Wladimir J. van der Laan)

Pull request description:

Add label API to wallet RPC.

This is one step towards #3816 ("Remove bolt-on account system") although it doesn't
actually remove anything yet.

These initially mirror the account functions, with the following differences:

- These functions aren't DEPRECATED in the help
- Help mentions 'label' instead of accounts. In the language used, labels are
  associated with addresses, instead of addresses associated with labels. (unlike
  with accounts.)
- Labels have no balance
  - No balances in `listlabels`
  - `listlabels` has no minconf or watchonly argument
- Like in the GUI, labels can be set on any address, not just receiving addreses
- Unlike accounts, labels can be deleted.
  Being unable to delete them is a common annoyance (see #1231).
  Currently only by reassigning all addresses using `setlabel`, but an explicit
  call `deletelabel` which assigns all address to the default label may make
  sense.

Tree-SHA512: 45cc313c68ad529ce3a15c02181d2ab0083a7e14fe824e2cde34972713fecce512e3d4b9aa46db5355f2baa857c44b234d4fe9709225bc23c7ebbc0e03febbf5

Backport of Core PR12892
https://github.com/bitcoin/bitcoin/pull/12892/

Depends on D3308

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12892

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7874
Build 13763: Bitcoin ABC Buildbot (legacy)
Build 13762: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 26 2019, 20:38

Owners added a reviewer: Restricted Owners Package.Aug 26 2019, 20:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2019, 20:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7244: Diff 10965.Aug 26 2019, 20:51

nakihito added a child revision: D3950: Merge #12953: Deprecate accounts.Aug 26 2019, 20:51

nakihito added a reviewer: markblundeberg.Aug 26 2019, 20:53

Fabien requested changes to this revision.Aug 27 2019, 10:13

Fabien added inline comments.

src/wallet/rpcwallet.cpp
375 ↗	(On Diff #10965)	Nit: `:` => `.`, or remove uppercase `If` => `if`
4489 ↗	(On Diff #10965)	Move the block between `walletpassphrase` and `generate`.
test/functional/timing.json
403 ↗	(On Diff #10965)	This is a duplicate (see 4 lines above). You don't have to edit this file when updating a test unless there is a massive timing change from the previous version, which is obviously not the case here.

This revision now requires changes to proceed.Aug 27 2019, 10:13

nakihito added inline comments.Aug 27 2019, 17:55

src/wallet/rpcwallet.cpp

4489 ↗

(On Diff #10965)

So it should look like:

{ "wallet",             "walletpassphrase",             walletpassphrase,             {"passphrase","timeout"} },
/** Account functions (deprecated) */
{ "wallet",             "getaccountaddress",            getlabeladdress,              {"account"} },
...
{ "wallet",             "setlabel",                     setlabel,                     {"address","label"} },
{ "generating",         "generate",                     generate,                     {"nblocks","maxtries"} },
};