Page MenuHomePhabricator
Differential D7104

[backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI
ClosedPublic
Actions

Authored by majcosta on Jul 31 2020, 13:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb7a031448919: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI
Summary

Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>

https://github.com/bitcoin/bitcoin/pull/15450/commits/78863e290006e61060622dbdbecc5b58c0fefa05

Depends on D7103

Partial backport of Core PR15450

Test Plan
ninja check

Diff Detail

Event Timeline

majcosta created this revision.Jul 31 2020, 13:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2020, 13:08
majcosta requested review of this revision.Jul 31 2020, 13:08
teamcity edited the summary of this revision. (Show Details)Jul 31 2020, 13:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.Jul 31 2020, 13:09
Harbormaster completed remote builds in B12261: Diff 22666.Jul 31 2020, 13:31
majcosta updated this revision to Diff 22675.Jul 31 2020, 15:35

rebase on D7108

Harbormaster completed remote builds in B12268: Diff 22675.Jul 31 2020, 15:54
Fabien requested changes to this revision.Aug 3 2020, 08:42
Fabien added a subscriber: Fabien.

Please make sure you tested the new dialog as it doesn't appear in your test plan.

src/qt/createwalletdialog.h
16

Layout

This revision now requires changes to proceed.Aug 3 2020, 08:42
Fabien mentioned this in D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.Aug 3 2020, 08:54
Fabien accepted this revision.Aug 3 2020, 08:57

Just seen the test plan from D7106

This revision is now accepted and ready to land.Aug 3 2020, 08:57
Closed by commit rABCb7a031448919: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 3 2020, 15:05
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCb7a031448919: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI.

Revision Contents
Changeset List

PathSize
contrib/
1 line
src/
4 lines
qt/
2 lines
34 lines
58 lines
forms/
151 lines

Diff 22675

View Options

contrib/bitcoin-qt.pro

Loading...
View Options

src/Makefile.qt.include

Loading...
View Options

src/qt/CMakeLists.txt

Loading...
View Options

src/qt/createwalletdialog.h

Loading...
View Options

src/qt/createwalletdialog.cpp

Loading...
View Options

src/qt/forms/createwalletdialog.ui

Loading...