Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
https://github.com/bitcoin/bitcoin/pull/15450/commits/613de61a04c210a51af9997e69f66439a17a632a
Depends on D7105
Concludes backport of Core PR15450
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCa87a2f00aec6: [backport#15450 5/5] Add Create Wallet menu action
ninja check check-functional
Used the bitcoin-qt wallet on regtest mode to create wallets and make sure behavior is expected
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- pr15450
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 12271 Build 24753: Build Diff build-without-wallet · build-clang-tidy · build-diff · build-clang-10 Build 24752: arc lint + arc unit
Event Timeline
Comment Actions
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
Snippet of first build failure:
[370/423] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/prevector.cpp.o [371/423] Generating forms/ui_modaloverlay.h [372/423] Generating forms/ui_overviewpage.h [373/423] Generating forms/ui_receivecoinsdialog.h [374/423] Generating forms/ui_receiverequestdialog.h [375/423] Generating forms/ui_sendcoinsdialog.h [376/423] Generating forms/ui_sendcoinsentry.h [377/423] Generating forms/ui_signverifymessagedialog.h [378/423] Generating forms/ui_transactiondescdialog.h [379/423] Generating temp_bitcoin_locale.qrc [380/423] Generating qrc_bitcoin.cpp [381/423] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/ccoins_caching.cpp.o [382/423] Generating qrc_bitcoin_locale.cpp [383/423] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/checkqueue.cpp.o [384/423] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/data.cpp.o [385/423] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/rpc_blockchain.cpp.o [386/423] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/duplicate_inputs.cpp.o [387/423] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/block_assemble.cpp.o [388/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoinunits.cpp.o [389/423] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/mempool_eviction.cpp.o [390/423] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/rpc_mempool.cpp.o [391/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoinaddressvalidator.cpp.o [392/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoinamountfield.cpp.o [393/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/csvmodelwriter.cpp.o [394/423] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/__/test/util.cpp.o [395/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bantablemodel.cpp.o [396/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/networkstyle.cpp.o [397/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoin-qt-base_autogen/mocs_compilation.cpp.o [398/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/modaloverlay.cpp.o [399/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/platformstyle.cpp.o [400/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qvalidatedlineedit.cpp.o [401/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/clientmodel.cpp.o [402/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/notificator.cpp.o [403/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qvaluecombobox.cpp.o [404/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o [405/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoin.cpp.o [406/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrc_bitcoin.cpp.o [407/423] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/bench.cpp.o [408/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/intro.cpp.o [409/423] Linking CXX executable src/bench/bitcoin-bench [410/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsdialog.cpp.o [411/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o [412/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/guiutil.cpp.o [413/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/trafficgraphwidget.cpp.o [414/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/utilitydialog.cpp.o [415/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/peertablemodel.cpp.o [416/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/splashscreen.cpp.o [417/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrc_bitcoin_locale.cpp.o [418/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o [419/423] Linking CXX static library src/qt/libbitcoin-qt-base.a [420/423] Automatic MOC for target bitcoin-qt [421/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/bitcoin-qt_autogen/mocs_compilation.cpp.o [422/423] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/main.cpp.o [423/423] Linking CXX executable src/qt/bitcoin-qt FAILED: src/qt/bitcoin-qt : && /usr/bin/c++ -Werror -g -O2 -fuse-ld=gold -Wl,-z,relro -Wl,-z,now -fPIE -pie src/qt/CMakeFiles/bitcoin-qt.dir/bitcoin-qt_autogen/mocs_compilation.cpp.o src/qt/CMakeFiles/bitcoin-qt.dir/main.cpp.o -o src/qt/bitcoin-qt /usr/lib/x86_64-linux-gnu/libjemalloc_pic.a src/qt/libbitcoin-qt-base.a src/libserver.a src/libbitcoinconsensus.a src/libscript.a src/libcommon.a src/libscript.a src/libcommon.a src/secp256k1/libsecp256k1.a src/leveldb/libleveldb.a src/leveldb/libleveldb-sse4.2.a src/leveldb/libmemenv.a /usr/lib/x86_64-linux-gnu/libevent_pthreads.so /usr/lib/x86_64-linux-gnu/libminiupnpc.so src/zmq/libzmq.a /usr/lib/x86_64-linux-gnu/libzmq.so src/librpcclient.a src/libutil.a /usr/lib/x86_64-linux-gnu/libevent.so src/univalue/libunivalue.a src/crypto/libcrypto.a src/crypto/libcrypto_sse4.1.a src/crypto/libcrypto_avx2.a src/crypto/libcrypto_shani.a /usr/lib/x86_64-linux-gnu/libboost_filesystem.so /usr/lib/x86_64-linux-gnu/libboost_thread.so /usr/lib/x86_64-linux-gnu/libboost_chrono.so /usr/lib/x86_64-linux-gnu/libboost_system.so /usr/lib/x86_64-linux-gnu/libboost_date_time.so /usr/lib/x86_64-linux-gnu/libboost_atomic.so /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.3 /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.3 /usr/lib/x86_64-linux-gnu/libQt5Network.so.5.11.3 /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.11.3 /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.11.3 /usr/lib/x86_64-linux-gnu/libssl.so /usr/lib/x86_64-linux-gnu/libcrypto.so /usr/lib/x86_64-linux-gnu/libjemalloc_pic.a -lm -ldl -pthread /usr/lib/x86_64-linux-gnu/libprotobuf.so && : ../../src/interfaces/node.cpp:293: error: undefined reference to 'CreateWallet(CChainParams const&, interfaces::Chain&, std::__cxx11::basic_string<char, std::char_traits<char>, secure_allocator<char> > const&, unsigned long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, std::shared_ptr<CWallet>&)' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. Build build-without-wallet failed with exit code 1