Additional test case also looks good. Accepting.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 21 2017
Jun 21 2017
Herald added 1 blocking reviewer(s) for D243: Implement setting of UAHF start time via RPC: Restricted Project.
Most likely needs changes after recent D230 changes.
The SimpleInitializeTest might be obsolete.
Please modify Test Plan to use the new name of the test (use Edit Revision to change).
Jun 20 2017
Jun 20 2017
freetrader closed Restricted Maniphest Task, a subtask of T46: Get the release in shape, as Resolved.
freetrader accepted D230: Implement expected stderr output checks and out-of-tree single test execution.
Tested, thanks for the fixes, extraction and cleanup, deadalnix.
freetrader added a comment to D230: Implement expected stderr output checks and out-of-tree single test execution.
General comment:
Herald added 1 blocking reviewer(s) for D237: Add two simple test framework self-tests: Restricted Project.
freetrader added inline comments to D230: Implement expected stderr output checks and out-of-tree single test execution.
This task must wait until post release / fork.
Jun 20 2017, 12:32 · Restricted Project
freetrader updated the diff for D230: Implement expected stderr output checks and out-of-tree single test execution.
Implement passing of OutputCheckers to initialize_chain() as requested by deadalnix
Jun 19 2017
Jun 19 2017
Ran all extended regtests excluding pruning, all passed.
freetrader added inline comments to D230: Implement expected stderr output checks and out-of-tree single test execution.
It looks ok to me, but I'd like another pair of eyes (or several) on this.
Tested ok, accepting.
Jun 19 2017, 21:44 · Restricted Project
Looks ok, but still need to run tests.
I'm accepting, since I think those doxygen comments can be repaired later, as well as the comment typo.
freetrader added a comment to D230: Implement expected stderr output checks and out-of-tree single test execution.
Will look at passing through OutputChecker object via initialize_chain().
just cleanups
freetrader added a comment to D229: Remove unused error code and ensure SCRIPT_ERR_CLEANSTACK has an associated error message.
Builds and passes make check, change looks sensible to me.
freetrader updated the diff for D230: Implement expected stderr output checks and out-of-tree single test execution.
Fix nits spotted during self-check of Diff
freetrader added inline comments to D230: Implement expected stderr output checks and out-of-tree single test execution.
Abandoned since superceded by D230 .
Herald added 1 blocking reviewer(s) for D230: Implement expected stderr output checks and out-of-tree single test execution: Restricted Project.
Updated on top of reformatted files
Format hash.cpp
Format tinyformat.h
Abandoning this as I have a better fix implemented now (in final testing).
Ok, I will re-format and change comment style to be consistent with the file.
Herald added 1 blocking reviewer(s) for D224: Mark fall-through cases in our code clearly: Restricted Project.
Could you please add a unit test for getSubVersionEB() .
This issue was most likely caused by a local configuration problem, therefore I am withdrawing the change.
Jun 18 2017
Jun 18 2017
Herald added 1 blocking reviewer(s) for D219: Fix re-use of BITCOIN_CONFIG_H (collision between two headers): Restricted Project.
Jun 17 2017
Jun 17 2017
Jun 16 2017
Jun 16 2017
freetrader added inline comments to D216: Implement test framework feature to check for expected stderr outputs.
freetrader planned changes to D216: Implement test framework feature to check for expected stderr outputs.
As discussed on Slack, it would be better to have the framework's node class deal with all aspects of collecting and verifying the stderr data.
The node class would be extended with methods to invoke stderr verification, but would do it on node stop in any case.
If mismatches between expected and present outputs are found, an exception would be raised to fail the test.
freetrader updated the diff for D216: Implement test framework feature to check for expected stderr outputs.
Minor fixes from self-review of diff on website
Herald added 1 blocking reviewer(s) for D216: Implement test framework feature to check for expected stderr outputs: Restricted Project.
As discussed on Slack, this is being held back since current ABC code already has the feature to refuse >1MB blocks before the fork activation time, so it cannot nicely play on nolnet anymore.
All review comments addressed, accepting.
freetrader requested changes to D207: Change default for excessive block size and generated block size.
Just revert the Python wildcard import please, rest is fine.
freetrader added inline comments to D206: Compute max generated block size depending on UAHF activation.
Code changes look ok for current test, and I can accept on that basis.
Jun 15 2017
Jun 15 2017
Ran the test on my Linux machine, it passed.
Fix up clang-style mess
Fix outdated -nolnet picked up by review
Jun 14 2017
Jun 14 2017
freetrader added inline comments to D200: Enforce that a large block is produced when the HF triggers.
Code comments updated by author via online discussion.
Please change test plan to run the '-extended' regression tests.
Changing block validity like this could impact the other tests.
Looks good to me, tests passed and I couldn't find meaningful cases missing.
freetrader accepted D186: Add SCRIPT_ENABLE_SIGHASH_FORKID to the CheckInputs sanity check in AcceptToMemoryPoolWorker.
No objections.
Tested ok for me on Linux, will put it through Travis to see about the Windows build.
Jun 13 2017
Jun 13 2017
Rebased after submitting diffs to split out the clang-format changes
Format guiutil.h and guiutil.cpp
updated with review fixes
Fixes from review
freetrader committed rABCe3aa0deb8fca: Format networkstyle.h and networkstyle.cpp (authored by freetrader).
Format networkstyle.h and networkstyle.cpp
Format chainparamsbase.{h,cpp}
freetrader closed D193: Format chainparamsbase.{h,cpp} by committing rABCa88feb51c5b4: Format chainparamsbase.{h,cpp}.
Herald added 1 blocking reviewer(s) for D196: Format networkstyle.h and networkstyle.cpp: Restricted Project.