Page MenuHomePhabricator
Feed Advanced Search

Nov 13 2018

schancel updated the diff for D2047: [mining] Ensure sigops and fees follow transactions during sorting.

Use emplace_back

Nov 13 2018, 19:06
schancel added inline comments to D2047: [mining] Ensure sigops and fees follow transactions during sorting.
Nov 13 2018, 19:03
schancel committed rABCbbb88c512e86: [cleanup] De-globalize rpc configuration variables (authored by schancel).
[cleanup] De-globalize rpc configuration variables
Nov 13 2018, 18:57
schancel closed D2017: [cleanup] De-globalize rpc configuration variables.
Nov 13 2018, 18:57
schancel updated the test plan for D2017: [cleanup] De-globalize rpc configuration variables.
Nov 13 2018, 18:30
schancel added inline comments to D2052: Revert "Cleanup unused contrib scripts".
Nov 13 2018, 07:09
schancel added inline comments to D2052: Revert "Cleanup unused contrib scripts".
Nov 13 2018, 06:34
schancel updated the diff for D2047: [mining] Ensure sigops and fees follow transactions during sorting.

Add release note line

Nov 13 2018, 05:13
schancel changed the visibility for D2047: [mining] Ensure sigops and fees follow transactions during sorting.
Nov 13 2018, 05:10
schancel updated the diff for D2047: [mining] Ensure sigops and fees follow transactions during sorting.

Rebase and add comments to a ticket

Nov 13 2018, 05:10
schancel committed rABCe5bc797172e1: [macOS] Remove DS_Store WindowBounds bytes object (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[macOS] Remove DS_Store WindowBounds bytes object
Nov 13 2018, 04:54
schancel closed D2053: [macOS] Remove DS_Store WindowBounds bytes object.
Nov 13 2018, 04:54
schancel added inline comments to D2037: Update mempool fee estimator to factor in rollingMinimumFeerate.
Nov 13 2018, 04:46
schancel added inline comments to D2037: Update mempool fee estimator to factor in rollingMinimumFeerate.
Nov 13 2018, 04:43
schancel updated the diff for D2048: [minig] make CBlockAssembler take a mempool for unit testing..

Address feedback

Nov 13 2018, 04:38
schancel updated the summary of D2048: [minig] make CBlockAssembler take a mempool for unit testing..
Nov 13 2018, 04:30
Herald added a reviewer for D2058: [rename only] mempool to g_mempool: Restricted Project.
Nov 13 2018, 04:19

Nov 12 2018

schancel committed rABC324072d22cb2: Disable wallet and address book Qt tests on macOS minimal platform (authored by Russell Yanofsky <russ@yanofsky.org>).
Disable wallet and address book Qt tests on macOS minimal platform
Nov 12 2018, 23:07
schancel closed D2054: Disable wallet and address book Qt tests on macOS minimal platform.
Nov 12 2018, 23:07
Herald added a reviewer for D2054: Disable wallet and address book Qt tests on macOS minimal platform: Restricted Project.
Nov 12 2018, 22:51
Herald added a reviewer for D2053: [macOS] Remove DS_Store WindowBounds bytes object: Restricted Project.
Nov 12 2018, 22:30
schancel updated the diff for D2037: Update mempool fee estimator to factor in rollingMinimumFeerate.

Address feedback

Nov 12 2018, 21:56
schancel updated the diff for D2047: [mining] Ensure sigops and fees follow transactions during sorting.

Update timing.json

Nov 12 2018, 21:53
schancel accepted D2045: [avalanche] Report the list of finalized blocks when votes are accounted for.
Nov 12 2018, 21:19
schancel accepted D2044: [avalanche] Add a facility to select invs to poll.
Nov 12 2018, 21:15
schancel accepted D2043: [avalanche] Create an event loop facility..
Nov 12 2018, 21:02
schancel accepted D2042: [avalanche] Add a block registry and facility to register votes on these blocks..
Nov 12 2018, 20:58
schancel added inline comments to D2047: [mining] Ensure sigops and fees follow transactions during sorting.
Nov 12 2018, 20:13
schancel updated the diff for D2047: [mining] Ensure sigops and fees follow transactions during sorting.

Rebase on master

Nov 12 2018, 20:07
schancel updated the diff for D2047: [mining] Ensure sigops and fees follow transactions during sorting.

Fix comment errors and renamed mnode

Nov 12 2018, 18:30
schancel added inline comments to D2047: [mining] Ensure sigops and fees follow transactions during sorting.
Nov 12 2018, 18:29
schancel added inline comments to D2037: Update mempool fee estimator to factor in rollingMinimumFeerate.
Nov 12 2018, 17:31
schancel added inline comments to D2047: [mining] Ensure sigops and fees follow transactions during sorting.
Nov 12 2018, 05:23
schancel updated the diff for D2047: [mining] Ensure sigops and fees follow transactions during sorting.

Fix the test description

Nov 12 2018, 05:22
schancel updated the diff for D2047: [mining] Ensure sigops and fees follow transactions during sorting.

Remove junk

Nov 12 2018, 05:21
schancel updated the diff for D2047: [mining] Ensure sigops and fees follow transactions during sorting.

Fix a comment

Nov 12 2018, 05:18
schancel updated the diff for D2047: [mining] Ensure sigops and fees follow transactions during sorting.

Add integration test

Nov 12 2018, 05:16

Nov 11 2018

Herald added a reviewer for D2048: [minig] make CBlockAssembler take a mempool for unit testing.: Restricted Project.
Nov 11 2018, 23:10
schancel changed the visibility for D2047: [mining] Ensure sigops and fees follow transactions during sorting.
Nov 11 2018, 22:21
Herald added a reviewer for D2047: [mining] Ensure sigops and fees follow transactions during sorting: Restricted Project.
Nov 11 2018, 22:21
schancel added inline comments to D2042: [avalanche] Add a block registry and facility to register votes on these blocks..
Nov 11 2018, 18:37
schancel updated the diff for D2037: Update mempool fee estimator to factor in rollingMinimumFeerate.

Add a test

Nov 11 2018, 08:23
schancel accepted D2040: [avalanche] Create a structure to accumulate avalanche votes.
Nov 11 2018, 03:10
schancel added inline comments to D2042: [avalanche] Add a block registry and facility to register votes on these blocks..
Nov 11 2018, 03:09
schancel accepted D2039: Nits in arith_uint256_tests.cpp.
Nov 11 2018, 02:30
schancel accepted D2041: Add braces in net.h.
Nov 11 2018, 02:30
schancel added inline comments to D2040: [avalanche] Create a structure to accumulate avalanche votes.
Nov 11 2018, 02:13
schancel updated the diff for D2037: Update mempool fee estimator to factor in rollingMinimumFeerate.

Finish patch

Nov 11 2018, 00:24

Nov 10 2018

Herald added a reviewer for D2037: Update mempool fee estimator to factor in rollingMinimumFeerate: Restricted Project.
Nov 10 2018, 22:46
Herald added a reviewer for D2036: [doc] update release process: Restricted Project.
Nov 10 2018, 19:28

Nov 9 2018

schancel added inline comments to D2025: build: Add format string linter.
Nov 9 2018, 23:11
schancel accepted D2034: Fix functional test --help raising an exception.
Nov 9 2018, 23:07
schancel added inline comments to D2019: Rename BCLog::DB to BCLog::WALLETDB.
Nov 9 2018, 05:52

Nov 8 2018

schancel accepted D2030: Fixed disclosure policy formatting.
Nov 8 2018, 23:37
schancel added inline comments to D2019: Rename BCLog::DB to BCLog::WALLETDB.
Nov 8 2018, 23:28
schancel added inline comments to D2025: build: Add format string linter.
Nov 8 2018, 23:28
schancel committed rABC66688f368c69: [ci] Add IBD parameters for CI. (authored by schancel).
[ci] Add IBD parameters for CI.
Nov 8 2018, 19:10
schancel closed D2027: [ci] Add IBD parameters for CI..
Nov 8 2018, 19:10
Herald added a reviewer for D2027: [ci] Add IBD parameters for CI.: Restricted Project.
Nov 8 2018, 02:15

Nov 7 2018

schancel requested changes to D2025: build: Add format string linter.
➜  bitcoin-abc git:(arcpatch-D2025) ✗ ./test/lint/lint-format-strings.sh
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
./test/lint/lint-format-strings.sh: line 35: mapfile: command not found
Nov 7 2018, 22:31
schancel accepted D2020: Fix up release note on parked chain RPC.
Nov 7 2018, 17:28
schancel committed rABCa4c86bad8530: [rpc] Undeprecate estimatefee (authored by schancel).
[rpc] Undeprecate estimatefee
Nov 7 2018, 17:19
schancel added a reverting change for rABC49ff27fedd36: [rpc] Deprecate estimatefee RPC: rABCa4c86bad8530: [rpc] Undeprecate estimatefee.
Nov 7 2018, 17:19
schancel closed D2012: [rpc] Undeprecate estimatefee.
Nov 7 2018, 17:19
schancel added a comment to D2012: [rpc] Undeprecate estimatefee.

This should change the release notes.

Nov 7 2018, 16:50
schancel added a comment to D2014: [move only] move default global vars to defaults.h.

There's also a few things in policy.h

Nov 7 2018, 02:56
schancel updated the diff for D2006: Ensure config variables are initalized.

Fix default initializers

Nov 7 2018, 02:46
schancel updated the summary of D1936: Move handling for `-maxtxfee` to the config object.
Nov 7 2018, 02:36
schancel retitled D2018: [cleanup] De-globalize blocksize related parameters from [cleanup] Deglobalize blocksize related parameters to [cleanup] De-globalize blocksize related parameters.
Nov 7 2018, 02:31
Herald added a reviewer for D2018: [cleanup] De-globalize blocksize related parameters: Restricted Project.
Nov 7 2018, 02:30
schancel updated subscribers of D2014: [move only] move default global vars to defaults.h.
/** Default setting for maximum allowed size for a block, in bytes */
static const uint64_t DEFAULT_MAX_BLOCK_SIZE = 32 * ONE_MEGABYTE;

from consensus.h be moved here? I think it should be.

Nov 7 2018, 02:21
Herald added a reviewer for D2017: [cleanup] De-globalize rpc configuration variables: Restricted Project.
Nov 7 2018, 02:15
schancel awarded D2016: Remove LogPrintf, use LogPrint everywhere instead a Yellow Medal token.
Nov 7 2018, 00:39
schancel requested changes to D2016: Remove LogPrintf, use LogPrint everywhere instead.

This is great. However we need to introduce a LogPrintLn, and a LogPrint. LogPrintLn should print a newline included, LogPrint should not. There's multiple log places which used LogPrintf to be able to print a single log line in multiple calls. (or maybe it was the other way around... I don't remember which one prints the newline and which doesn't)

Nov 7 2018, 00:39
schancel retitled D2016: Remove LogPrintf, use LogPrint everywhere instead from Remove LogPrintf, use LogPrint everywhere insteadCompletes T214 to Remove LogPrintf, use LogPrint everywhere instead.
Nov 7 2018, 00:36
schancel committed rABCc42521518207: [qa] fix abc-p2p-compactblocks test to use add_argument (authored by schancel).
[qa] fix abc-p2p-compactblocks test to use add_argument
Nov 7 2018, 00:27
schancel closed D2015: [qa] fix abc-p2p-compactblocks test to use add_argument.
Nov 7 2018, 00:26
schancel retitled D2015: [qa] fix abc-p2p-compactblocks test to use add_argument from [qa] fix abc-p2p-compactblocks test to use add_argument and rename add_options to [qa] fix abc-p2p-compactblocks test to use add_argument.
Nov 7 2018, 00:23
schancel updated the diff for D2015: [qa] fix abc-p2p-compactblocks test to use add_argument.

Remove add_options change

Nov 7 2018, 00:23
Herald added a reviewer for D2015: [qa] fix abc-p2p-compactblocks test to use add_argument: Restricted Project.
Nov 7 2018, 00:10
schancel updated the summary of D2002: Disallow using addresses in createmultisig.
Nov 7 2018, 00:04

Nov 6 2018

schancel updated the diff for D2002: Disallow using addresses in createmultisig.

Rebase on IsDeprecatedRPCEnabled parameter update

Nov 6 2018, 23:58
schancel accepted D2005: Add RWCollection, a read-write locked collection with a mostly safe API.
Nov 6 2018, 23:22
schancel updated the summary of D1936: Move handling for `-maxtxfee` to the config object.
Nov 6 2018, 23:13
schancel updated the diff for D1936: Move handling for `-maxtxfee` to the config object.

Rebase on proper defaults branch

Nov 6 2018, 23:08
schancel updated the diff for D2014: [move only] move default global vars to defaults.h.

Add missing header references.

Nov 6 2018, 23:06
schancel added inline comments to D1936: Move handling for `-maxtxfee` to the config object.
Nov 6 2018, 20:32
Herald added a reviewer for D2014: [move only] move default global vars to defaults.h: Restricted Project.
Nov 6 2018, 20:32
schancel committed rABCb4460fcaa584: [rpc] Add a unittest for IsDeprecatedRPCEnabled (authored by schancel).
[rpc] Add a unittest for IsDeprecatedRPCEnabled
Nov 6 2018, 20:00
schancel closed D2013: [rpc] Add a unittest for IsDeprecatedRPCEnabled.
Nov 6 2018, 20:00
schancel updated the diff for D2012: [rpc] Undeprecate estimatefee.

Rebase to add missing server_tests.cpp file

Nov 6 2018, 18:47
schancel updated the diff for D2013: [rpc] Add a unittest for IsDeprecatedRPCEnabled.

Include missing file

Nov 6 2018, 18:46
schancel updated the diff for D2012: [rpc] Undeprecate estimatefee.

Fix feedback by adding a unittest in this stack

Nov 6 2018, 18:45
schancel updated the summary of D2012: [rpc] Undeprecate estimatefee.
Nov 6 2018, 18:44
Herald added a reviewer for D2013: [rpc] Add a unittest for IsDeprecatedRPCEnabled: Restricted Project.
Nov 6 2018, 18:44
schancel updated the summary of D2012: [rpc] Undeprecate estimatefee.
Nov 6 2018, 18:16
schancel added a comment to D2012: [rpc] Undeprecate estimatefee.

Because people use it? It was deprecated in favor of estimatesmartfee which we already removed instead?

Nov 6 2018, 18:13
schancel updated the summary of D2012: [rpc] Undeprecate estimatefee.
Nov 6 2018, 17:51
schancel updated the summary of D2012: [rpc] Undeprecate estimatefee.
Nov 6 2018, 17:51
Herald added a reviewer for D2012: [rpc] Undeprecate estimatefee: Restricted Project.
Nov 6 2018, 17:42