Needs rebase.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Mar 11 2019
Fixed missing lines from the original backport in rpcwallet.cpp
Rebased
Mar 9 2019
Mar 8 2019
Removed reference on Amount
In D2673#62455, @Fabien wrote:I think there is a backport missing in rpcwallet.cpp for the fundrawtransaction RPC: https://github.com/bitcoin/bitcoin/pull/9672/commits/891c5eeec2dbf295d14e8f888de02637367dd930
Mar 7 2019
While refactoring, I realized that this won't be used anymore. There's no use it adding it to the config.
Update with new testnet params
Added testnet params
Moving this off my queue until it's updated.
Rebase + updated release notes comment
The constructor that was moved is already private and made public despite you saying the public constructor was removed.
Mar 6 2019
Rebase on D2662 to cleanly update translation strings
Going to split out refreshing the translation strings for unrelated changes since it's rather large.
Going to split out refreshing the translation strings for unrelated changes since it's rather large.
Updated translation strings
Mar 5 2019
bool cleanup + fixed clearing g_failed_blocks
Feedback
Progress towards T456
Progress towards T456
Mar 4 2019
Added command.cpp and renamed RPCCommandWithRequestContext -> RPCCommand
Rebase
Looks like you missed the second commit in the PR: https://github.com/bitcoin/bitcoin/pull/11593/commits/97932cd2689659addfbb58dc6148928b73af3bd0
Currently there is a grand total of zero commands that are handled by that framework. I'm not even sure this is required or not, but I'm fairly confident that it's better to have something that handle many the RPC calls rather than have something that could handle them all but handle none in practice. Beside priorities, it is also very possible that other limitation in the current design will be uncovered when actually using it, and any complication of the design will get in the way rather than help.