Page MenuHomePhabricator
Feed All Stories

Apr 22 2019

Fabien updated the diff for D2855: Use angle bracket in include for src (part 1).

Add missing newlines

Apr 22 2019, 18:16
teamcity added a comment to D2860: Use angle bracket in include for src (part 6).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 18:10
Fabien updated the diff for D2860: Use angle bracket in include for src (part 6).

Fix ordering

Apr 22 2019, 18:10
teamcity added a comment to D2859: Use angle bracket in include for src (part 5).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 18:05
teamcity added a comment to D2857: Use angle bracket in include for src (part 3).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 18:05
Fabien updated the diff for D2859: Use angle bracket in include for src (part 5).

Fix ordering

Apr 22 2019, 18:04
teamcity added a comment to D2857: Use angle bracket in include for src (part 3).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 17:52
Fabien updated the diff for D2857: Use angle bracket in include for src (part 3).

Fix ordering + missing copyright

Apr 22 2019, 17:52
jasonbcox accepted D2854: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py.
Apr 22 2019, 17:44
jasonbcox requested changes to D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.

This is an existing Core PR. Please apply the entire backport: https://github.com/bitcoin/bitcoin/pull/9801/files

Apr 22 2019, 17:40
jasonbcox accepted D2855: Use angle bracket in include for src (part 1).
Apr 22 2019, 17:37
jasonbcox added inline comments to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Apr 22 2019, 17:37
jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Use existing API for mainnet genesis block.
Revert unnecessary protected change.

Apr 22 2019, 17:36
teamcity added a comment to D2855: Use angle bracket in include for src (part 1).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 17:29
teamcity added a comment to D2855: Use angle bracket in include for src (part 1).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 17:17
Fabien updated the diff for D2855: Use angle bracket in include for src (part 1).

Fix ordering

Apr 22 2019, 17:16
jasonbcox requested changes to D2860: Use angle bracket in include for src (part 6).
Apr 22 2019, 17:07
jasonbcox requested changes to D2859: Use angle bracket in include for src (part 5).
Apr 22 2019, 17:06
jasonbcox accepted D2858: Use angle bracket in include for src (part 4).
Apr 22 2019, 17:03
jasonbcox requested changes to D2857: Use angle bracket in include for src (part 3).
Apr 22 2019, 17:01
teamcity added a comment to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 17:01
teamcity added a comment to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 17:01
jasonbcox requested changes to D2855: Use angle bracket in include for src (part 1).
Apr 22 2019, 16:57
jasonbcox accepted D2856: Use angle bracket in include for src (part 2).
Apr 22 2019, 16:53
jasonbcox committed rABC419d3000d54c: Bump version number to 0.19.5 (authored by jasonbcox).
Bump version number to 0.19.5
Apr 22 2019, 16:48
jasonbcox closed D2861: Bump version number to 0.19.5.
Apr 22 2019, 16:48
teamcity added a comment to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 16:48
teamcity added a comment to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 16:47
jasonbcox updated the diff for D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.

Rebase + fix include ordering

Apr 22 2019, 16:47
jasonbcox updated the diff for D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Rebase

Apr 22 2019, 16:46
Fabien accepted D2861: Bump version number to 0.19.5.
Apr 22 2019, 16:39
teamcity added a comment to D2861: Bump version number to 0.19.5.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 16:34
teamcity added a comment to D2861: Bump version number to 0.19.5.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 16:20
Herald added a reviewer for D2861: Bump version number to 0.19.5: Restricted Project.
Apr 22 2019, 16:20
Fabien requested review of D2849: Use angle bracket in include for test (part 5).
Apr 22 2019, 15:23
teamcity added a comment to D2860: Use angle bracket in include for src (part 6).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 13:21
teamcity added a comment to D2859: Use angle bracket in include for src (part 5).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 13:14
teamcity added a comment to D2860: Use angle bracket in include for src (part 6).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 13:08
Herald added a reviewer for D2860: Use angle bracket in include for src (part 6): deadalnix.
Apr 22 2019, 13:07
teamcity added a comment to D2858: Use angle bracket in include for src (part 4).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 13:05
teamcity added a comment to D2857: Use angle bracket in include for src (part 3).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 12:59
teamcity added a comment to D2859: Use angle bracket in include for src (part 5).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 12:59
Herald added a reviewer for D2859: Use angle bracket in include for src (part 5): deadalnix.
Apr 22 2019, 12:58
teamcity added a comment to D2858: Use angle bracket in include for src (part 4).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 12:52
Herald added a reviewer for D2858: Use angle bracket in include for src (part 4): deadalnix.
Apr 22 2019, 12:51
teamcity added a comment to D2857: Use angle bracket in include for src (part 3).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 12:47
Herald added a reviewer for D2857: Use angle bracket in include for src (part 3): deadalnix.
Apr 22 2019, 12:46
teamcity added a comment to D2856: Use angle bracket in include for src (part 2).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 12:39
teamcity added a comment to D2856: Use angle bracket in include for src (part 2).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 12:26
Herald added a reviewer for D2856: Use angle bracket in include for src (part 2): deadalnix.
Apr 22 2019, 12:25
teamcity added a comment to D2855: Use angle bracket in include for src (part 1).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 11:59
teamcity added a comment to D2855: Use angle bracket in include for src (part 1).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 11:46
Herald added a reviewer for D2855: Use angle bracket in include for src (part 1): deadalnix.
Apr 22 2019, 11:45
Fabien requested changes to D2846: Do not allow users to get keys from keypool without reserving them.

You can add a deprecatedrpc=fundrawtransaction option to allow users to transition between the versions.

Apr 22 2019, 11:12
Fabien accepted D2845: Remove direct bitcoin calls from qt/rpcconsole.cpp.
Apr 22 2019, 11:08
teamcity added a comment to D2854: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 04:23
teamcity added a comment to D2854: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 04:10
Herald added a reviewer for D2854: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py: deadalnix.
Apr 22 2019, 04:09
teamcity added a comment to D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 22 2019, 01:37
teamcity added a comment to D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 22 2019, 01:24
Herald added a reviewer for D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`: deadalnix.
Apr 22 2019, 01:23

Apr 21 2019

Fabien accepted D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Apr 21 2019, 19:55
Fabien accepted D2847: Fix typos..
Apr 21 2019, 18:52
teamcity added a comment to D2847: Fix typos..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 21 2019, 18:50
teamcity added a comment to D2846: Do not allow users to get keys from keypool without reserving them.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 21 2019, 18:38
teamcity added a comment to D2847: Fix typos..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 21 2019, 18:36
nakihito updated the diff for D2847: Fix typos..

Fixed missed typo.

Apr 21 2019, 18:35
teamcity added a comment to D2846: Do not allow users to get keys from keypool without reserving them.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 21 2019, 18:25
nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

Added release note and adjusted version number depreciation note in rpcwallet.cpp.

Apr 21 2019, 18:24
jasonbcox committed rABCf2225b39dcc4: Added missing notes to release notes (authored by jasonbcox).
Added missing notes to release notes
Apr 21 2019, 17:00
jasonbcox closed D2827: Added missing notes to release notes.
Apr 21 2019, 17:00
Fabien committed rABCd845e0192322: Use angle bracket in include for zmq (authored by Fabien).
Use angle bracket in include for zmq
Apr 21 2019, 08:48
Fabien closed D2850: Use angle bracket in include for zmq.
Apr 21 2019, 08:48
Fabien committed rABC29c2cb313bff: Use angle bracket in include for test (part 4) (authored by Fabien).
Use angle bracket in include for test (part 4)
Apr 21 2019, 08:47
Fabien closed D2848: Use angle bracket in include for test (part 4).
Apr 21 2019, 08:47
teamcity added a comment to D2852: [mining] Require priority transactions to be below minimum relay fee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 21 2019, 08:22
teamcity added a comment to D2852: [mining] Require priority transactions to be below minimum relay fee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 21 2019, 08:09
Herald added a reviewer for D2852: [mining] Require priority transactions to be below minimum relay fee: deadalnix.
Apr 21 2019, 08:07
Fabien accepted D2827: Added missing notes to release notes.
Apr 21 2019, 07:27

Apr 20 2019

schancel committed rABC3623cccdc6ff: Nits in abc-high_priority_transaction.py (authored by schancel).
Nits in abc-high_priority_transaction.py
Apr 20 2019, 21:56
schancel closed D2851: Nits in abc-high_priority_transaction.py.
Apr 20 2019, 21:56
deadalnix accepted D2851: Nits in abc-high_priority_transaction.py.
Apr 20 2019, 21:08
teamcity added a comment to D2851: Nits in abc-high_priority_transaction.py.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 20 2019, 20:54
teamcity added a comment to D2851: Nits in abc-high_priority_transaction.py.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 20 2019, 20:41
Herald added a reviewer for D2851: Nits in abc-high_priority_transaction.py: deadalnix.
Apr 20 2019, 20:40
teamcity added a comment to D2827: Added missing notes to release notes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 20 2019, 17:03
teamcity added a comment to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 20 2019, 17:02
teamcity added a comment to D2827: Added missing notes to release notes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 20 2019, 16:50
jasonbcox updated the diff for D2827: Added missing notes to release notes.

Amended note to indicate only bitcoin-cli

Apr 20 2019, 16:49
teamcity added a comment to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 20 2019, 16:47
jasonbcox updated the diff for D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Fixed includes (and angle brackets) + header guards

Apr 20 2019, 16:46
deadalnix requested changes to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Apr 20 2019, 14:56
deadalnix accepted D2848: Use angle bracket in include for test (part 4).
Apr 20 2019, 14:51
deadalnix requested changes to D2849: Use angle bracket in include for test (part 5).
Apr 20 2019, 14:51
deadalnix accepted D2850: Use angle bracket in include for zmq.
Apr 20 2019, 14:50
deadalnix requested changes to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Apr 20 2019, 14:49
teamcity added a comment to D2850: Use angle bracket in include for zmq.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 20 2019, 14:27
teamcity added a comment to D2849: Use angle bracket in include for test (part 5).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 20 2019, 14:21
teamcity added a comment to D2850: Use angle bracket in include for zmq.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 20 2019, 14:14
Herald added a reviewer for D2850: Use angle bracket in include for zmq: deadalnix.
Apr 20 2019, 14:13