fix broken test
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 23 2019
May 23 2019
markblundeberg added reviewers for D2934: db: Make reusable base class for index databases.: jasonbcox, Fabien.
markblundeberg added reviewers for D2935: index: Extract logic from TxIndex into reusable base class.: jasonbcox, Fabien.
markblundeberg added reviewers for D2936: index: Generalize logged statements in BaseIndex.: jasonbcox, Fabien.
markblundeberg added reviewers for D2937: MOVEONLY: Move BaseIndex to its own file.: Fabien, jasonbcox.
markblundeberg added reviewers for D2938: index: Move index DBs into index/ directory.: Fabien, jasonbcox.
markblundeberg added inline comments to D3080: Merge #13527: policy: Remove promiscuousmempoolflags.
remove nonbreaking space from comment (U+00A0)
rebase onto fixed feature_cltv.py; const-ify flags
May 22 2019
May 22 2019
Herald added a reviewer for D3094: [qa] don't pad transactions during make_conform_to_ctor: deadalnix.
markblundeberg retitled D3093: Remove AcceptToMemoryPoolWithTime default args from Revert AcceptToMemoryPoolWithTime default args customization to Remove AcceptToMemoryPoolWithTime default args.
oops, dropped a comment
address comment: rebase onto D3093
more accurate description; add comments
markblundeberg updated the diff for D3075: Merge #11872: [rpc] createrawtransaction: Accept sorted outputs.
mini rebase for release notes
Great to see the end of STANDARD_CHECKDATASIG_VERIFY_FLAGS :-)
markblundeberg added inline comments to D3075: Merge #11872: [rpc] createrawtransaction: Accept sorted outputs.
markblundeberg added inline comments to D3080: Merge #13527: policy: Remove promiscuousmempoolflags.
May 21 2019
May 21 2019
markblundeberg closed T453: Backport Core PR13192, a subtask of T454: Backport Core PR13522, as Resolved.
markblundeberg closed T453: Backport Core PR13192, a subtask of T654: fix p2p_sendheaders, as Resolved.
markblundeberg closed T452: Backport Core PR11707 sendheaders.py, a subtask of T453: Backport Core PR13192, as Resolved.
markblundeberg closed T452: Backport Core PR11707 sendheaders.py, a subtask of T654: fix p2p_sendheaders, as Resolved.
markblundeberg closed T454: Backport Core PR13522, a subtask of T654: fix p2p_sendheaders, as Resolved.
markblundeberg added a revision to T454: Backport Core PR13522: D3089: Merge #13522: [tests] Fix p2p_sendheaders race.
markblundeberg added a comment to D3087: Merge #13192: [tests] Fixed intermittent failure in p2p_sendheaders.py..
Ironically I am having a hard time reproducing the failure mode, now that I actually want to see the before/after change. 🙄
Herald added a reviewer for D3087: Merge #13192: [tests] Fixed intermittent failure in p2p_sendheaders.py.: deadalnix.
Herald added a reviewer for D3086: Merge #12849: Tests: Add logging in loops in p2p_sendhears.py: deadalnix.
markblundeberg added a parent task for T452: Backport Core PR11707 sendheaders.py: T654: fix p2p_sendheaders.
markblundeberg added a subtask for T654: fix p2p_sendheaders: T452: Backport Core PR11707 sendheaders.py.
markblundeberg added a comment to D1442: Discourage selfish mining by favoring blocks with more accurate timestamps.
Regarding this: I noticed in a recent reddit discussion that ProHashing does not use accurate timestamps: https://www.reddit.com/r/btc/comments/bqy05r/sensible_defaults_and_unintended_consequences_of/eo9f9fa/
markblundeberg planned changes to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
This appears to be getting further along now, but still errors out on my machine.
markblundeberg updated the diff for D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
rebased onto D3082
Oh man, does this explain the build failure I have had on D3076?? It was so confusing...
incorporate small follow-up PR12860 too
markblundeberg added inline comments to D3080: Merge #13527: policy: Remove promiscuousmempoolflags.
Given how STANDARD_SCRIPT_VERIFY_FLAGS appears in some important places, please add IBD to the test plan. :-)
markblundeberg added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
Very confusing build failure ... will return at a later date.
May 20 2019
May 20 2019
markblundeberg updated the diff for D2924: [txindex] Activate new transaction index code that runs in background.
rebased (still WIP)
markblundeberg added a comment to D3063: Make tests independent of whether CHECKDATASIG is included in mandatory or standard flags.
I'm happy with this general direction. Given the severity of consequences of not including it in standardness, the checkdatasig_inclusion_in_standard_and_mandatory_flags is nice to have as a fool-proof check. :)
markblundeberg updated the summary of D3078: Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn.
markblundeberg updated the summary of D3078: Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn.
Herald added a reviewer for D3078: Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn: deadalnix.
accidental git dependency
Herald added a reviewer for D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific: deadalnix.
markblundeberg added a revision to T541: Backport Core PR10267 to support includeconf: D3035: New -includeconf argument for including external configuration files.
May 20 2019, 18:04 · Restricted Project
markblundeberg updated the summary of D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
markblundeberg requested review of D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
In D3014#72496, @deadalnix wrote:The test place doesn't cover RPC tests, however, this is clearly changing RPC tests.
markblundeberg updated the test plan for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
markblundeberg added a comment to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
In D3021#72499, @deadalnix wrote:It seems like this would depend on whatever added the get_difficulty_for_null_tip test.
still approve :D
markblundeberg updated the diff for D3075: Merge #11872: [rpc] createrawtransaction: Accept sorted outputs.
braces