Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

	Include stories about projects I am a member of.

Jun 13 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3231: Remove unused DoWarning function.

Jun 13 2019, 01:42

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC1848ecaef208: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning

Jun 13 2019, 01:31

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning.

Jun 13 2019, 01:31

teamcity added a comment to D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 01:21

nakihito added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

In D3308#78110, @markblundeberg wrote:

I tried backporting this one and I noticed that it produced duplicate entries for commands with "label" in the name, and I couldn't figure out why.... Is that still the case now? Can "examine bitcoin-cli help" be added to test plan?

Jun 13 2019, 01:20

markblundeberg added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

I tried backporting this one and I noticed that it produced duplicate entries for commands with "label" in the name, and I couldn't figure out why.... Is that still the case now? Can "examine bitcoin-cli help" be added to test plan?

Jun 13 2019, 01:17

teamcity added a comment to D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 01:15

markblundeberg added a comment to D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning.

rebase for freshness

Jun 13 2019, 01:15

D3308: Merge #9894: remove 'label' filter for rpc command help is now accepted and ready to land.

Jun 13 2019, 01:02

D3283: Merge #10408, #13291, and partial #13163 now requires changes to proceed.

Jun 13 2019, 01:02

teamcity added a comment to D3309: Fix braces in multisig_test.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 00:15

teamcity added a comment to D3309: Fix braces in multisig_test.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 00:09

deadalnix created D3309: Fix braces in multisig_test.

Jun 13 2019, 00:09

teamcity added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 00:09

teamcity added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 00:03

nakihito created D3308: Merge #9894: remove 'label' filter for rpc command help.

Jun 13 2019, 00:03

Jun 12 2019

nakihito added a comment to D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.

core_read.cpp change looks like witness code: https://github.com/bitcoin/bitcoin/pull/10481/files

Jun 12 2019, 23:30

teamcity added a comment to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 21:21

teamcity added a comment to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 21:12

deadalnix created D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).

Jun 12 2019, 21:12

teamcity added a comment to D3306: Fix eligibilty_filter => eligibility_filter.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 20:59

D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning is now accepted and ready to land.

Jun 12 2019, 20:53

teamcity added a comment to D3305: Fix comments in miner.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 20:53

teamcity added a comment to D3306: Fix eligibilty_filter => eligibility_filter.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 20:53

deadalnix created D3306: Fix eligibilty_filter => eligibility_filter.

Jun 12 2019, 20:53

teamcity added a comment to D3305: Fix comments in miner.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 20:47

deadalnix created D3305: Fix comments in miner.h.

Jun 12 2019, 20:46

deadalnix added a comment to D3283: Merge #10408, #13291, and partial #13163.

Why are all of these together ?

Jun 12 2019, 20:07

teamcity added a comment to D3283: Merge #10408, #13291, and partial #13163.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 17:38

teamcity added a comment to D3283: Merge #10408, #13291, and partial #13163.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 17:32

nakihito added a comment to D3283: Merge #10408, #13291, and partial #13163.

Fixed includes ordering.

Jun 12 2019, 17:32

D3253: Remove Schnorr activation now requires changes to proceed.

It is very hard to ensure this is correct.

Jun 12 2019, 17:18

D3254: Revert "add flags to VerifySignature and sigcache" is now accepted and ready to land.

This is correct as long as we "pretend" schnorr always was activated.

Jun 12 2019, 17:15

D3267: check negative CScriptNum.getint() and introduce new error code now requires changes to proceed.

Please don't add more assumptions into the code. Also please explain why this is needed for schnorr multisig.

Jun 12 2019, 17:12

D3299: [LINTER] Run selected linters last now requires changes to proceed.

Jun 12 2019, 17:03

D3300: [LINTER] Run some linter only once now requires changes to proceed.

You can call the linter n times, but only do the work once. You know a configuration is not what you are after because it makes no sense to run that linter multiple time. This is a property of the linter, not of the environment in which it runs so we clearly are facing a new type of linter, not a new workflow to be configured

Jun 12 2019, 17:01

teamcity added a comment to D3304: Add a test to make sure that negative effective values are filtered.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 16:19

teamcity added a comment to D3304: Add a test to make sure that negative effective values are filtered.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 16:12

deadalnix created D3304: Add a test to make sure that negative effective values are filtered.

Jun 12 2019, 16:12

teamcity added a comment to D3303: Benchmark BnB in the worst case where it exhausts.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 15:59

teamcity added a comment to D3303: Benchmark BnB in the worst case where it exhausts.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 15:52

deadalnix created D3303: Benchmark BnB in the worst case where it exhausts.

Jun 12 2019, 15:52

teamcity added a comment to D3302: Build wallet dependent benchmark using cmake.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 15:48

teamcity added a comment to D3302: Build wallet dependent benchmark using cmake.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 15:41

deadalnix created D3302: Build wallet dependent benchmark using cmake.

Jun 12 2019, 15:41

jasonbcox added a comment to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.

Missed Amaury's comment regarding testing. This is a good idea and should be included.

Jun 12 2019, 15:40

deadalnix committed rABCcd606f147cba: Use a struct for output eligibility (authored by Andrew Chow <achow101-github@achow101.com>).

Use a struct for output eligibility

Jun 12 2019, 15:18

deadalnix closed D3246: Use a struct for output eligibility.

Jun 12 2019, 15:18

markblundeberg requested review of D3271: add SCRIPTSIGMINPUSHONLY flag and logic.

Jun 12 2019, 14:52

teamcity added a comment to D3252: Add tests for the Branch and Bound algorithm.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 14:30

teamcity added a comment to D3250: Remove coinselection.h -> wallet.h circular dependency.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 14:27

teamcity added a comment to D3252: Add tests for the Branch and Bound algorithm.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 14:23

teamcity added a comment to D3249: Implement Branch and Bound coin selection in a new file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 14:23

Fabien added inline comments to D3252: Add tests for the Branch and Bound algorithm.

Jun 12 2019, 14:23

deadalnix added a comment to D3252: Add tests for the Branch and Bound algorithm.

Reorder includes

Jun 12 2019, 14:22

deadalnix added inline comments to D3252: Add tests for the Branch and Bound algorithm.

Jun 12 2019, 14:20

teamcity added a comment to D3243: Calculate and store the number of bytes required to spend an input.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 14:19

teamcity added a comment to D3250: Remove coinselection.h -> wallet.h circular dependency.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 14:19

deadalnix added a comment to D3250: Remove coinselection.h -> wallet.h circular dependency.

rebase

Jun 12 2019, 14:18

teamcity added a comment to D3249: Implement Branch and Bound coin selection in a new file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 14:16

deadalnix added a comment to D3249: Implement Branch and Bound coin selection in a new file.

Reoder includes

Jun 12 2019, 14:15

teamcity added a comment to D3243: Calculate and store the number of bytes required to spend an input.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 14:14

teamcity added a comment to D3243: Calculate and store the number of bytes required to spend an input.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 14:11

deadalnix added a comment to D3243: Calculate and store the number of bytes required to spend an input.

rebase

Jun 12 2019, 14:10

teamcity added a comment to D3243: Calculate and store the number of bytes required to spend an input.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 14:07

deadalnix added a comment to D3243: Calculate and store the number of bytes required to spend an input.

Address comments

Jun 12 2019, 14:07

deadalnix committed rABC721d2df22e50: Store effective value, fee, and long term fee in CInputCoin (authored by Andrew Chow <achow101-github@achow101.com>).

Store effective value, fee, and long term fee in CInputCoin

Jun 12 2019, 14:00

deadalnix closed D3248: Store effective value, fee, and long term fee in CInputCoin.

Jun 12 2019, 14:00

deadalnix committed rABCa0f222f20b3e: Move output eligibility to a separate function (authored by Andrew Chow <achow101-github@achow101.com>).

Move output eligibility to a separate function

Jun 12 2019, 13:57

deadalnix closed D3245: Move output eligibility to a separate function.

Jun 12 2019, 13:57

deadalnix committed rABCf578ca9dd0fb: Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee (authored by Andrew Chow <achow101-github@achow101.com>).

Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee

Jun 12 2019, 13:53

deadalnix closed D3251: Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee.

Jun 12 2019, 13:53

deadalnix committed rABCd1dd4f3c22cf: Fix rounding errors in calculation of minimum change size (authored by Alex Morcos <morcos@chaincode.com>).

Fix rounding errors in calculation of minimum change size

Jun 12 2019, 13:51

deadalnix closed D3291: Fix rounding errors in calculation of minimum change size.

Jun 12 2019, 13:51

deadalnix committed rABCf4321052c578: Don't create change at the dust limit, even if it means paying more than… (authored by Alex Morcos <morcos@chaincode.com>).

Don't create change at the dust limit, even if it means paying more than…

Jun 12 2019, 13:49

deadalnix closed D3296: Don't create change at the dust limit, even if it means paying more than expected.

Jun 12 2019, 13:49

deadalnix committed rABC7f206a919424: Eliminate fee overpaying edge case when subtracting fee from recipients (authored by Alex Morcos <morcos@chaincode.com>).

Eliminate fee overpaying edge case when subtracting fee from recipients

Jun 12 2019, 13:47

deadalnix closed D3297: Eliminate fee overpaying edge case when subtracting fee from recipients.

Jun 12 2019, 13:47

Fabien requested review of D3299: [LINTER] Run selected linters last.

Jun 12 2019, 13:14

Fabien added a comment to D3300: [LINTER] Run some linter only once.

Arcanist (and more specifically the ArcanistLintWorkFlow) calls each linter for every path that match the filter.
There is no feature to indicate to run it once, or you have to create another workflow from scratch rather than using a linter.
I evaluated this as well, but that would make a much more complicated solution with no real advantage.

Jun 12 2019, 13:08

D3265: add new encoding checker for Schnorr sigs now requires changes to proceed.

Jun 12 2019, 13:06

D3271: add SCRIPTSIGMINPUSHONLY flag and logic now requires changes to proceed.

Jun 12 2019, 13:02

D3299: [LINTER] Run selected linters last now requires changes to proceed.

Jun 12 2019, 13:00

D3291: Fix rounding errors in calculation of minimum change size is now accepted and ready to land.

Jun 12 2019, 12:57

D3292: Explicitly call out updating makeseeds.py after major releases now requires changes to proceed.

Jun 12 2019, 12:57

D3292: Explicitly call out updating makeseeds.py after major releases is now accepted and ready to land.

Jun 12 2019, 12:56

teamcity added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 12:56

D3300: [LINTER] Run some linter only once now requires changes to proceed.

Why can't the linter un once to begin with, instead o having a linter that run multiple times and then build all kind of scafolding to have it run only once ?

Jun 12 2019, 12:55

deadalnix updated the summary of D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Jun 12 2019, 12:50

deadalnix updated the summary of D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Jun 12 2019, 12:50

deadalnix updated the summary of D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Jun 12 2019, 12:49

teamcity added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 12:48

deadalnix created D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Jun 12 2019, 12:48