Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Mar 8 2020

deadalnix updated the summary of D5447: Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp.

Mar 8 2020, 18:17

deadalnix updated the diff for D5447: Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp.

Add roundtrip and more tests to ParseISO8601DateTime and FormatISO8601DateTime

Mar 8 2020, 18:17

deadalnix created D5447: Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp.

Mar 8 2020, 17:33

deadalnix committed rABCffaaea1a4360: util: Add type safe GetTime (authored by MarcoFalke <falke.marco@gmail.com>).

util: Add type safe GetTime

Mar 8 2020, 17:01

deadalnix closed D5445: util: Add type safe GetTime.

Mar 8 2020, 17:01

deadalnix accepted D5446: [CMAKE] Fix FindBerkeleyDB suffix paths.

Mar 8 2020, 16:57

Mar 7 2020

deadalnix requested changes to D5380: [seeder] Require good seeds to have latest checkpoint.

Mar 7 2020, 03:29

deadalnix created D5445: util: Add type safe GetTime.

Mar 7 2020, 01:48

Mar 6 2020

deadalnix accepted D5395: [DOC] Update developer notes.

Mar 6 2020, 22:02

deadalnix requested changes to D5321: [CMAKE] Add support for generating test coverage reports.

Mar 6 2020, 22:01

deadalnix committed rABCc00e73c8792e: [cmake] check-symbols => symbol-check (authored by deadalnix).

[cmake] check-symbols => symbol-check

Mar 6 2020, 21:26

deadalnix closed D5443: [cmake] check-symbols => symbol-check.

Mar 6 2020, 21:26

deadalnix created D5443: [cmake] check-symbols => symbol-check.

Mar 6 2020, 19:51

deadalnix committed rABC9f762552d710: [cmake] check-security => security-check (authored by deadalnix).

[cmake] check-security => security-check

Mar 6 2020, 19:20

deadalnix closed D5441: [cmake] check-security => security-check.

Mar 6 2020, 19:20

deadalnix created D5441: [cmake] check-security => security-check.

Mar 6 2020, 16:32

deadalnix requested changes to D5395: [DOC] Update developer notes.

Mar 6 2020, 16:18

deadalnix accepted D5429: [SECP256K1] Enable the OpenSSL tests (and benchmark).

Mar 6 2020, 15:24

deadalnix accepted D5393: [CMAKE] Improve FindEvent.

Mar 6 2020, 15:04

deadalnix accepted D5339: [CMAKE] Improve FindBerkeleyDB.

Mar 6 2020, 15:02

deadalnix added a comment to D5380: [seeder] Require good seeds to have latest checkpoint.

You are now parsing new messages. You need to check what happens when these messages are malformed.

Mar 6 2020, 01:31

deadalnix added inline comments to D5395: [DOC] Update developer notes.

Mar 6 2020, 01:30

deadalnix requested changes to D5393: [CMAKE] Improve FindEvent.

Some stuff could be improve, but it looks good overall.

Mar 6 2020, 00:38

Mar 5 2020

deadalnix accepted D5394: [DOC] Update the depends README with dependencies and cmake instructions.

Mar 5 2020, 23:40

deadalnix accepted D5434: [SECP256K1] Fix issue where travis does not show the logs.

Mar 5 2020, 23:37

deadalnix accepted D5428: [SECP256K1] Fix the kitware PPA timeouts issues on Travis.

Mar 5 2020, 23:36

deadalnix requested changes to D5339: [CMAKE] Improve FindBerkeleyDB.

The general direction is good, but it seems like there are details to polish.

Mar 5 2020, 23:35

deadalnix accepted D5435: Merge #13265: wallet: Exit SyncMetaData if there are no transactions to sync.

Mar 5 2020, 23:15

deadalnix accepted D5438: Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type.

Mar 5 2020, 23:13

deadalnix requested changes to D5434: [SECP256K1] Fix issue where travis does not show the logs.

Mar 5 2020, 17:01

deadalnix added a comment to D5434: [SECP256K1] Fix issue where travis does not show the logs.

Why aren't the log printed in the cmake build as well?

Mar 5 2020, 17:01

deadalnix accepted D5433: [SECP256K1] Add valgrind check to travis.

Mar 5 2020, 16:58

deadalnix requested changes to D5429: [SECP256K1] Enable the OpenSSL tests (and benchmark).

Mar 5 2020, 16:54

deadalnix accepted D5431: [SECP256K1] Request --enable-experimental for the multiset module.

Mar 5 2020, 16:52

deadalnix requested changes to D5428: [SECP256K1] Fix the kitware PPA timeouts issues on Travis.

The gain you'll have are reliability gains. If kitware is down,t he build still passes. If travis is down, then the build won't pass regardless of kitware.

Mar 5 2020, 16:51

deadalnix added inline comments to D5430: [SECP256K1] Fix a valgrind issue in multisets.

Mar 5 2020, 16:50

deadalnix accepted D5430: [SECP256K1] Fix a valgrind issue in multisets.

Mar 5 2020, 16:48

deadalnix added a comment to D5428: [SECP256K1] Fix the kitware PPA timeouts issues on Travis.

You need to use travis's cache directory functionality. See https://github.com/SDC-Developers/SDC/blob/master/.travis.yml#L19 or an exemple. This is ensure that you only download cmake once in a while.

Mar 5 2020, 16:25

Mar 4 2020

deadalnix requested changes to D5430: [SECP256K1] Fix a valgrind issue in multisets.

Mar 4 2020, 19:12

deadalnix requested changes to D5379: [CMake] Introduce DEB generator for making .deb packages.

Mar 4 2020, 18:38

deadalnix accepted D5396: [DOC] Update the subtree section from the developer notes.

Mar 4 2020, 18:26

Mar 3 2020

deadalnix committed rABC01d2a4a9c83f: [avalanche] Start event loop at node startup (authored by deadalnix).

[avalanche] Start event loop at node startup

Mar 3 2020, 23:16

deadalnix closed D5391: [avalanche] Start event loop at node startup.

Mar 3 2020, 23:16

deadalnix accepted D5407: [SECP256K1] Fix travis failure on ECMULT_GEN_PRECISION.

Mar 3 2020, 23:11

deadalnix accepted D5408: [SECP256K1] Fix Travis failures due to APT addon.

Mar 3 2020, 23:08

Mar 2 2020

deadalnix added inline comments to D5395: [DOC] Update developer notes.

Mar 2 2020, 23:38

deadalnix added inline comments to D5394: [DOC] Update the depends README with dependencies and cmake instructions.

Mar 2 2020, 23:35

deadalnix requested changes to D5396: [DOC] Update the subtree section from the developer notes.

Mar 2 2020, 23:32

deadalnix accepted D5397: [DOC] Various updates to cmake/ninja.

Mar 2 2020, 23:31

deadalnix requested changes to D5379: [CMake] Introduce DEB generator for making .deb packages.

Please move the thing first so we don't export more of this in unrelated projects.

Mar 2 2020, 23:29

deadalnix updated the diff for D5391: [avalanche] Start event loop at node startup.

Fix Shutdown routine when it gets called before the node completely started up.

Mar 2 2020, 18:23

deadalnix added inline comments to D5395: [DOC] Update developer notes.

Mar 2 2020, 16:43

deadalnix added inline comments to D5395: [DOC] Update developer notes.

Mar 2 2020, 16:34

deadalnix added inline comments to D5395: [DOC] Update developer notes.

Mar 2 2020, 16:14

deadalnix accepted D5342: [CMAKE] Fix the check-bitcoin-* targets when running with Xcode.

Mar 2 2020, 15:55

deadalnix committed rABCe0772f4181f9: Remove secret-dependant non-constant time operation in ecmult_const. (authored by Gregory Maxwell <greg@xiph.org>).

Remove secret-dependant non-constant time operation in ecmult_const.

Mar 2 2020, 15:35

deadalnix closed D5384: Remove secret-dependant non-constant time operation in ecmult_const..

Mar 2 2020, 15:35

deadalnix committed rABCb61e2167a9a2: Preventing compiler optimizations in benchmarks without a memory fence (authored by Elichai Turkel <elichai.turkel@gmail.com>).

Preventing compiler optimizations in benchmarks without a memory fence

Mar 2 2020, 15:33

deadalnix closed D5374: Preventing compiler optimizations in benchmarks without a memory fence.

Mar 2 2020, 15:32

deadalnix committed rABCd4f3b328528e: README: add a section for test coverage (authored by Marko Bencun <mbencun+pgp@gmail.com>).

README: add a section for test coverage

Mar 2 2020, 15:31

deadalnix closed D5387: README: add a section for test coverage.

Mar 2 2020, 15:31

deadalnix committed rABCd10c9798aca8: Overhaul README.md (authored by Tim Ruffing <crypto@timruffing.de>).

Overhaul README.md

Mar 2 2020, 15:30

deadalnix closed D5383: Overhaul README.md.

Mar 2 2020, 15:30

deadalnix committed rABC066ed57b4180: Convert bench.h to fixed-point math (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).

Convert bench.h to fixed-point math

Mar 2 2020, 15:29

deadalnix closed D5378: Convert bench.h to fixed-point math.

Mar 2 2020, 15:28

deadalnix committed rABC30d89966603d: Add SECURITY.md (authored by Jonas Nick <jonasd.nick@gmail.com>).

Add SECURITY.md

Mar 2 2020, 15:27

deadalnix closed D5377: Add SECURITY.md.

Mar 2 2020, 15:27

deadalnix committed rABC70765825f824: Clarify that a secp256k1_ecdh_hash_function must return 0 or 1 (authored by Tim Ruffing <crypto@timruffing.de>).

Clarify that a secp256k1_ecdh_hash_function must return 0 or 1

Mar 2 2020, 15:25

deadalnix closed D5390: Clarify that a secp256k1_ecdh_hash_function must return 0 or 1.

Mar 2 2020, 15:25

deadalnix committed rABCc676868b398c: doc: document the length requirements of output parameter. (authored by Rusty Russell <rusty@rustcorp.com.au>).

doc: document the length requirements of output parameter.

Mar 2 2020, 15:14

deadalnix closed D5389: doc: document the length requirements of output parameter..

Mar 2 2020, 15:14

deadalnix committed rABC400ffebd985d: variable signing precompute table (authored by djb <digitalbitbox@gmail.com>).

variable signing precompute table

Mar 2 2020, 15:13

deadalnix closed D5362: variable signing precompute table.

Mar 2 2020, 15:13

deadalnix committed rABCcf0b65f70de4: Docstrings (authored by Marko Bencun <mbencun+pgp@gmail.com>).

Docstrings

Mar 2 2020, 15:09

deadalnix closed D5388: Docstrings.

Mar 2 2020, 15:09

Mar 1 2020

deadalnix accepted D5392: revert to deprecated protobuf ByteSize() due to compatibility.

Mar 1 2020, 22:42

deadalnix created D5391: [avalanche] Start event loop at node startup.

Mar 1 2020, 14:41

deadalnix accepted D5386: Stop using the deprecated google::protobuf::MessageLite::ByteSize().

Mar 1 2020, 00:42

Feb 29 2020

deadalnix accepted D5385: [backport] qt: Remove obsolete QModelIndex::child() #16707.

Feb 29 2020, 23:04

deadalnix requested changes to D5386: Stop using the deprecated google::protobuf::MessageLite::ByteSize().

Feb 29 2020, 22:54

deadalnix created D5390: Clarify that a secp256k1_ecdh_hash_function must return 0 or 1.

Feb 29 2020, 22:51

deadalnix created D5389: doc: document the length requirements of output parameter..

Feb 29 2020, 18:36

deadalnix created D5388: Docstrings.

Feb 29 2020, 18:23

deadalnix created D5387: README: add a section for test coverage.

Feb 29 2020, 18:10

deadalnix created D5384: Remove secret-dependant non-constant time operation in ecmult_const..

Feb 29 2020, 16:56

deadalnix updated the summary of D5383: Overhaul README.md.

Feb 29 2020, 16:44

deadalnix created D5383: Overhaul README.md.

Feb 29 2020, 16:44

deadalnix accepted D4418: Add simple unit tests for parse_name().

Feb 29 2020, 16:15

deadalnix requested changes to D5380: [seeder] Require good seeds to have latest checkpoint.

Feb 29 2020, 16:14

deadalnix accepted D5382: [backport] qt: Replace obsolete functions of QSslSocket #16708.

Feb 29 2020, 16:01

deadalnix committed rABC00fb6d9fc96d: [validation.cpp] update 'cousins' during UpdateFlags (authored by deadalnix).

[validation.cpp] update 'cousins' during UpdateFlags

Feb 29 2020, 14:31

deadalnix accepted D5373: scripted-diff: replace chainActive -> ::ChainActive().

Feb 29 2020, 00:14

deadalnix accepted D5056: refactoring: introduce unused ChainActive().

Feb 29 2020, 00:12

deadalnix requested changes to D5342: [CMAKE] Fix the check-bitcoin-* targets when running with Xcode.

Overall LGTM, but I don't really understand why the file is copied. Should the buid directory be different for different configuration anyways? I don't get it.

Feb 29 2020, 00:08

Feb 28 2020

deadalnix requested changes to D5056: refactoring: introduce unused ChainActive().

Partial Backport of Bitcoin Core PR15948 (commit a3a609079c):

Feb 28 2020, 23:58

deadalnix accepted D5369: [backport] qt: Replace functions deprecated in Qt 5.13 #16701.

Feb 28 2020, 23:53

deadalnix accepted D5055: rename: CChainState.chainActive -> m_chain.

Feb 28 2020, 23:52

deadalnix updated the summary of D5055: rename: CChainState.chainActive -> m_chain.

Feb 28 2020, 23:51

deadalnix added inline comments to D5321: [CMAKE] Add support for generating test coverage reports.

Feb 28 2020, 23:50

deadalnix accepted D5338: [CMAKE] Fix the build with Xcode as a generator.

Feb 28 2020, 23:50