Page MenuHomePhabricator
Feed Advanced Search

Oct 6 2020

jasonbcox closed T269: Create a `contrib/teamcity/build-cmake.sh` as Resolved.
Oct 6 2020, 17:57 · Bootcamp
jasonbcox closed T248: Add cmake build to teamcity, a subtask of T267: CMake builds, as Resolved.
Oct 6 2020, 17:57
jasonbcox closed T248: Add cmake build to teamcity as Resolved.
Oct 6 2020, 17:57
jasonbcox closed T267: CMake builds, a subtask of T258: Quality Assurance Improvements, as Resolved.
Oct 6 2020, 17:57
jasonbcox closed T267: CMake builds as Resolved.
Oct 6 2020, 17:57
jasonbcox closed T571: Backport Core PR 10973 as Resolved.
Oct 6 2020, 17:50 · Restricted Project
jasonbcox closed T1045: Top 5 Watch Dogs as a Pets as Invalid.
Oct 6 2020, 17:48
jasonbcox closed T1044: Cat Foods as Invalid.
Oct 6 2020, 17:48
jasonbcox closed T638: Backport Core PR 11738 (fix hang in sendrawtransaction) as Resolved.
Oct 6 2020, 17:47
jasonbcox closed T639: Backport Core PR 11877 (tests) as Resolved.
Oct 6 2020, 17:47
jasonbcox closed T682: Backport Core PR 14456 as Resolved.
Oct 6 2020, 17:46
jasonbcox closed T681: Backport Core PR 14119, a subtask of T682: Backport Core PR 14456, as Resolved.
Oct 6 2020, 17:46
jasonbcox closed T681: Backport Core PR 14119 as Resolved.
Oct 6 2020, 17:46
jasonbcox closed T657: New sigops counting as Resolved.
Oct 6 2020, 17:45
jasonbcox closed T336: Phabricator to Github repo sync bot, a subtask of T647: [Epic] Development Automation Base Infra, as Resolved.
Oct 6 2020, 17:45 · Restricted Project, Restricted Project
jasonbcox closed T336: Phabricator to Github repo sync bot as Resolved.
Oct 6 2020, 17:45
jasonbcox closed T383: Generate help page from RPC doc as Resolved.
Oct 6 2020, 17:45
jasonbcox closed T482: Make p2p-compbactblocks work with magnetic anomaly. as Resolved.
Oct 6 2020, 17:41
jasonbcox closed T483: Make invalidateblock work with magnetic anomalty as Resolved.
Oct 6 2020, 17:41
jasonbcox closed T434: Backport Core PR #12909 as Resolved.
Oct 6 2020, 17:40 · Restricted Project
jasonbcox closed T438: Backport core PR 10579 as Resolved.
Oct 6 2020, 17:40 · Restricted Project
jasonbcox closed T661: Backport PR12804 [tests] Fix intermittent rpc_net.py failure. as Resolved.
Oct 6 2020, 17:38
jasonbcox closed T662: Backport PR11389 "Support having SegWit always active in regtest" as Resolved.
Oct 6 2020, 17:38
jasonbcox closed T652: Backport PR13126 as Resolved.
Oct 6 2020, 17:38
jasonbcox closed T996: LOOKING FOR EXPERT’S SEO SERVICES? as Invalid.
Oct 6 2020, 17:36
jasonbcox closed T495: Fix bip65-cltv-p2p.py for post-fork conditions as Resolved.
Oct 6 2020, 17:33
jasonbcox closed T1050: Reasons Why Dogs are the Go-to Emotional Support Animals as Invalid.
Oct 6 2020, 17:32
jasonbcox closed T1051: Emotional Support Animals related Laws You Should Know About as Invalid.
Oct 6 2020, 17:31
jasonbcox closed T1055: Burr Grinder & Blade Grinder: Differences and Which to Choose as Invalid.
Oct 6 2020, 17:29
jasonbcox closed T1069: Đâu là liệu trình trẻ hóa da tốt nhất tại thẩm mỹ viện Xuân Hương? as Invalid.
Oct 6 2020, 17:28
jasonbcox closed T992: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Oct 6 2020, 17:25
jasonbcox requested review of D7787: [buildbot] Introduce an ignore list for known flaky errors.
Oct 6 2020, 17:19
jasonbcox closed D7784: Ensure the source repo in the cache is in a clean state before building.
Oct 6 2020, 16:06
jasonbcox committed rABCWEBa756d858c84d: Ensure the source repo in the cache is in a clean state before building (authored by jasonbcox).
Ensure the source repo in the cache is in a clean state before building
Oct 6 2020, 16:05
jasonbcox closed D7785: Apply cherry-pick before cmake.
Oct 6 2020, 16:05
jasonbcox committed rABCWEBb94b4268192a: Apply cherry-pick before cmake (authored by jasonbcox).
Apply cherry-pick before cmake
Oct 6 2020, 16:05
jasonbcox requested review of D7785: Apply cherry-pick before cmake.
Oct 6 2020, 15:59
jasonbcox requested review of D7784: Ensure the source repo in the cache is in a clean state before building.
Oct 6 2020, 15:14
jasonbcox closed D7774: Cleanup copy-pasted comment.
Oct 6 2020, 05:41
jasonbcox committed rABC1175f57283d5: Cleanup copy-pasted comment (authored by jasonbcox).
Cleanup copy-pasted comment
Oct 6 2020, 05:41
jasonbcox closed D7773: [CI] Set default git user and email during setup.
Oct 6 2020, 05:40
jasonbcox committed rABC63d110c7b254: [CI] Set default git user and email during setup (authored by jasonbcox).
[CI] Set default git user and email during setup
Oct 6 2020, 05:40
jasonbcox requested review of D7774: Cleanup copy-pasted comment.
Oct 6 2020, 01:15

Oct 5 2020

jasonbcox requested review of D7773: [CI] Set default git user and email during setup.
Oct 5 2020, 23:45
jasonbcox closed D7770: Do not cache HTML of pages that are expected to change.
Oct 5 2020, 21:07
jasonbcox committed rABCWEBe26427bae4e4: Do not cache HTML of pages that are expected to change (authored by jasonbcox).
Do not cache HTML of pages that are expected to change
Oct 5 2020, 21:07
jasonbcox closed D7772: Fix 0.22.3 manpages not appearing in the doc index.
Oct 5 2020, 21:05
jasonbcox committed rABCWEBce1e353fd0bf: Fix 0.22.3 manpages not appearing in the doc index (authored by jasonbcox).
Fix 0.22.3 manpages not appearing in the doc index
Oct 5 2020, 21:05
jasonbcox requested review of D7772: Fix 0.22.3 manpages not appearing in the doc index.
Oct 5 2020, 19:08
jasonbcox accepted D7771: [CMAKE] Fix version in the man2html template.
Oct 5 2020, 18:54
jasonbcox updated the summary of D7770: Do not cache HTML of pages that are expected to change.
Oct 5 2020, 17:40
jasonbcox requested review of D7770: Do not cache HTML of pages that are expected to change.
Oct 5 2020, 17:39

Oct 2 2020

jasonbcox accepted D7747: [backport#16578] Do not pass in command line arguments to QApplication.
Oct 2 2020, 18:53
jasonbcox accepted D7746: [backport#16554] test: only include and use OpenSSL where it's actually needed (BIP70).
Oct 2 2020, 18:52
jasonbcox requested changes to D7748: [backport#10899] [test] Qt: Use _putenv_s instead of setenv on Windows builds.

Unless something changed, I think the feedback from D3225 is still valid.

Oct 2 2020, 18:22
jasonbcox requested changes to D7747: [backport#16578] Do not pass in command line arguments to QApplication.

The summary describes some steps that aren't included in the test plan.

Oct 2 2020, 18:20
jasonbcox requested changes to D7746: [backport#16554] test: only include and use OpenSSL where it's actually needed (BIP70).

You need to enable/disable BIP70 in the test plan.

Oct 2 2020, 18:16
jasonbcox closed D7729: Revert recent coin selection changes.
Oct 2 2020, 02:03
jasonbcox added a reverting change for D7691: Merge #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs: rABC85f266319f58: Revert recent coin selection changes.
Oct 2 2020, 02:03
jasonbcox added a reverting change for D7674: Enable BnB coin selection for preset inputs and subtract fee from outputs: rABC85f266319f58: Revert recent coin selection changes.
Oct 2 2020, 02:03
jasonbcox added a reverting change for rABC28efd9a54daa: Enable BnB coin selection for preset inputs and subtract fee from outputs: rABC85f266319f58: Revert recent coin selection changes.
Oct 2 2020, 02:03
jasonbcox added a reverting change for rABC78322dfdfa3c: Merge #17568: wallet: fix when sufficient preset inputs and…: rABC85f266319f58: Revert recent coin selection changes.
Oct 2 2020, 02:03
jasonbcox committed rABC85f266319f58: Revert recent coin selection changes (authored by jasonbcox).
Revert recent coin selection changes
Oct 2 2020, 02:03
jasonbcox requested review of D7729: Revert recent coin selection changes.
Oct 2 2020, 00:18
jasonbcox added a reverting change for D7674: Enable BnB coin selection for preset inputs and subtract fee from outputs: D7729: Revert recent coin selection changes.
Oct 2 2020, 00:18
jasonbcox added a reverting change for D7691: Merge #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs: D7729: Revert recent coin selection changes.
Oct 2 2020, 00:18
jasonbcox added a reverting change for rABC28efd9a54daa: Enable BnB coin selection for preset inputs and subtract fee from outputs: D7729: Revert recent coin selection changes.
Oct 2 2020, 00:18
jasonbcox added a reverting change for rABC78322dfdfa3c: Merge #17568: wallet: fix when sufficient preset inputs and…: D7729: Revert recent coin selection changes.
Oct 2 2020, 00:18

Oct 1 2020

jasonbcox added a comment to D7726: [gitian-builder] By default, cleanup the target after use.

Upstream PR: https://github.com/devrandom/gitian-builder/pull/234

Oct 1 2020, 23:54
jasonbcox accepted D7728: [backport#17677] Activate watchonly wallet behavior for LegacySPKM only.
Oct 1 2020, 23:51
jasonbcox closed D7726: [gitian-builder] By default, cleanup the target after use.
Oct 1 2020, 23:47
jasonbcox committed rABCbe81abd457c5: [gitian-builder] By default, cleanup the target after use (authored by jasonbcox).
[gitian-builder] By default, cleanup the target after use
Oct 1 2020, 23:47
jasonbcox requested review of D7726: [gitian-builder] By default, cleanup the target after use.
Oct 1 2020, 21:48
jasonbcox planned changes to D7725: [CI] Do not wait too long for build logs to flush.
Oct 1 2020, 21:17
jasonbcox accepted D7719: [CMAKE] Fix version mismatch during crosscompilation due to pkg-config.
Oct 1 2020, 20:44
jasonbcox requested review of D7725: [CI] Do not wait too long for build logs to flush.
Oct 1 2020, 20:36
jasonbcox requested review of D7725: [CI] Do not wait too long for build logs to flush.
Oct 1 2020, 20:00
jasonbcox planned changes to D7725: [CI] Do not wait too long for build logs to flush.
Oct 1 2020, 20:00
jasonbcox closed D7723: Fix clang-tidy error.
Oct 1 2020, 17:48
jasonbcox committed rABC8d492105b489: Fix clang-tidy error (authored by jasonbcox).
Fix clang-tidy error
Oct 1 2020, 17:47
jasonbcox requested review of D7723: Fix clang-tidy error.
Oct 1 2020, 17:16
jasonbcox closed D7717: Fix shadowing of bin Python keyword.
Oct 1 2020, 17:13
jasonbcox committed rABCbee6c23a30e6: Fix shadowing of bin Python keyword (authored by jasonbcox).
Fix shadowing of bin Python keyword
Oct 1 2020, 17:13
jasonbcox requested review of D7717: Fix shadowing of bin Python keyword.
Oct 1 2020, 16:27
jasonbcox accepted D7694: [backport#17518] refactor, wallet: Nuke coincontrol circular dependency.
Oct 1 2020, 03:10
jasonbcox accepted D7695: [backport#16766] wallet: Make IsTrusted scan parents recursively.

Rest looks good

Oct 1 2020, 02:05
jasonbcox accepted D7693: [backport#17648] doc: rename wallet-tool references to bitcoin-wallet.
Oct 1 2020, 01:52
jasonbcox requested changes to D7695: [backport#16766] wallet: Make IsTrusted scan parents recursively.
Oct 1 2020, 01:44
jasonbcox closed D7696: Remove erroneous checks in wallet_balance test.
Oct 1 2020, 01:35
jasonbcox committed rABC19ef8d7b391c: Remove erroneous checks in wallet_balance test (authored by jasonbcox).
Remove erroneous checks in wallet_balance test
Oct 1 2020, 01:35
jasonbcox requested review of D7696: Remove erroneous checks in wallet_balance test.
Oct 1 2020, 00:57

Sep 30 2020

jasonbcox accepted D7690: [backport#17237 2/2] wallet: LearnRelatedScripts only if KeepDestination.
Sep 30 2020, 23:26
jasonbcox accepted D7689: [backport#17237 1/2] wallet: Lock address type in ReserveDestination.
Sep 30 2020, 23:25
jasonbcox closed D7691: Merge #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs.
Sep 30 2020, 22:35
jasonbcox committed rABC78322dfdfa3c: Merge #17568: wallet: fix when sufficient preset inputs and… (authored by fanquake <fanquake@gmail.com>).
Merge #17568: wallet: fix when sufficient preset inputs and…
Sep 30 2020, 22:35
jasonbcox closed D7688: Merge #16293: test: Make test cases separate functions.
Sep 30 2020, 22:31
jasonbcox committed rABCd54de8344d7a: Merge #16293: test: Make test cases separate functions (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #16293: test: Make test cases separate functions
Sep 30 2020, 22:31
jasonbcox requested changes to D7689: [backport#17237 1/2] wallet: Lock address type in ReserveDestination.

See build failure

Sep 30 2020, 22:12
jasonbcox requested review of D7691: Merge #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs.
Sep 30 2020, 22:07
jasonbcox updated the diff for D7688: Merge #16293: test: Make test cases separate functions.

Fixed according to feedback

Sep 30 2020, 22:02