Page MenuHomePhabricator
Feed Advanced Search

Nov 8 2020

deadalnix requested changes to D8316: tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such.

What about test/functional/mempool_package_onemore.py ?

Nov 8 2020, 14:55
deadalnix closed D8315: Simplify progress reprort for the UTXO DB upgrade.
Nov 8 2020, 14:12
deadalnix committed rABCfb09258947f4: Simplify progress reprort for the UTXO DB upgrade (authored by deadalnix).
Simplify progress reprort for the UTXO DB upgrade
Nov 8 2020, 14:12
deadalnix closed D8318: Fix constant style in txdb.h.
Nov 8 2020, 14:11
deadalnix committed rABCc6955487eaa0: Fix constant style in txdb.h (authored by deadalnix).
Fix constant style in txdb.h
Nov 8 2020, 14:11
deadalnix updated the summary of D8319: Add routine to upgrade the block tree db to index block size.
Nov 8 2020, 01:43
deadalnix updated the diff for D8319: Add routine to upgrade the block tree db to index block size.

Errors on invalid DB version.

Nov 8 2020, 01:42
deadalnix updated the test plan for D8319: Add routine to upgrade the block tree db to index block size.
Nov 8 2020, 01:34
deadalnix updated the test plan for D8319: Add routine to upgrade the block tree db to index block size.
Nov 8 2020, 01:34
deadalnix requested review of D8319: Add routine to upgrade the block tree db to index block size.
Nov 8 2020, 01:33
deadalnix requested review of D8318: Fix constant style in txdb.h.
Nov 8 2020, 01:00

Nov 7 2020

deadalnix closed D8314: Make id const in CCoinsViewDB::Upgrade.
Nov 7 2020, 17:37
deadalnix committed rABCa2f61718adf3: Make id const in CCoinsViewDB::Upgrade (authored by deadalnix).
Make id const in CCoinsViewDB::Upgrade
Nov 7 2020, 17:37
deadalnix requested review of D8315: Simplify progress reprort for the UTXO DB upgrade.
Nov 7 2020, 16:02
deadalnix requested review of D8314: Make id const in CCoinsViewDB::Upgrade.
Nov 7 2020, 14:25

Nov 6 2020

deadalnix accepted D8313: Re-introduce older 0.22.x releases in the past releases section.
Nov 6 2020, 23:00
deadalnix accepted D8308: test: add unit test for non-standard bare multisig txs.
Nov 6 2020, 21:09
deadalnix requested changes to D8307: util: Update tinyformat to upstream.

There are a bunch of changes in there that are not as per univalue.

Nov 6 2020, 21:08
deadalnix committed rABCe05246e8b0b0: Support the BCHN chain. (authored by deadalnix).
Support the BCHN chain.
Nov 6 2020, 17:54
deadalnix accepted D8278: fuzz: Pass down MAKEJOBS to test_runner.
Nov 6 2020, 15:57

Nov 5 2020

deadalnix closed D6981: Implement Grasberg DAA.
Nov 5 2020, 17:44
deadalnix committed rABC963c8c171c77: Implement Grasberg DAA (authored by deadalnix).
Implement Grasberg DAA
Nov 5 2020, 17:44
deadalnix updated the diff for D6981: Implement Grasberg DAA.

Rebase and fix typos

Nov 5 2020, 16:21
deadalnix accepted D8279: test/fuzz: add a seed corpus generation option to the test_runner.
Nov 5 2020, 15:56
deadalnix accepted D8283: test: Properly deserialize integers in little-endian.
Nov 5 2020, 15:56
deadalnix requested changes to D8278: fuzz: Pass down MAKEJOBS to test_runner.

This is busted

Nov 5 2020, 15:55
deadalnix accepted D8273: test: Set -use_value_profile=1 when merging fuzz inputs.
Nov 5 2020, 15:55
deadalnix accepted D8277: fuzz: Run in parallel.
Nov 5 2020, 15:54
deadalnix accepted D8282: Use correct C++11 header for std::swap().
Nov 5 2020, 15:53

Nov 4 2020

deadalnix accepted D8265: [SECP256K1] Prevent arithmetic on NULL pointer if the scratch space is too small.
Nov 4 2020, 16:31

Nov 3 2020

deadalnix accepted D8249: tests: Add fuzzing harness for serialization/deserialization of floating-points and integrals.
Nov 3 2020, 13:30
deadalnix accepted D8240: Minor refactoring to remove implied m_addr_relay_peer..
Nov 3 2020, 03:20

Oct 31 2020

deadalnix requested changes to D8203: [backport#16400] refactor: Rewrite AcceptToMemoryPoolWorker() using smaller parts.
Oct 31 2020, 15:35

Oct 30 2020

deadalnix accepted D8202: [SECP256K1] Return NULL early in context_preallocated_create if flags invalid.
Oct 30 2020, 22:29

Oct 29 2020

deadalnix accepted D8182: [logging] Don't log REJECT code when transaction is rejected.
Oct 29 2020, 18:24
deadalnix accepted D8157: [SECP256K1] Make autotools check for all the used openssl functions.
Oct 29 2020, 18:22
deadalnix accepted D8183: [validation] Remove REJECT code from CValidationState.
Oct 29 2020, 18:21
deadalnix accepted D8184: [validation] Fix REJECT message comments.
Oct 29 2020, 18:20
deadalnix added a comment to D8165: [docs] use CashAddr throughout sendmany help.

Is there a reason yo use testnet addresses rather than mainnet ones?

Oct 29 2020, 02:01
deadalnix accepted D8165: [docs] use CashAddr throughout sendmany help.
Oct 29 2020, 02:00
deadalnix requested changes to D8157: [SECP256K1] Make autotools check for all the used openssl functions.

This seems busted.

Oct 29 2020, 01:00
deadalnix accepted D8158: [CMAKE] Add an installation target for the fuzzer executables.
Oct 29 2020, 00:38
deadalnix accepted D8164: [backport#12077] [Docs] Correct `sendmany` curl example.
Oct 29 2020, 00:36

Oct 28 2020

deadalnix accepted D8148: gui: Add shortcuts for tab tools.
Oct 28 2020, 13:53
deadalnix accepted D8149: tests: Add fuzzing harnesses for functions parsing scripts, numbers, JSON and HD keypaths (bip32).
Oct 28 2020, 13:53
deadalnix accepted D8155: util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests..
Oct 28 2020, 13:45
deadalnix accepted D8156: tests: Add fuzzing harnesses for various Base{32,58,64} and hex related functions.
Oct 28 2020, 13:45
deadalnix accepted D8153: Add bounds checks before base58 decoding.
Oct 28 2020, 13:44
deadalnix accepted D8151: tests: Add fuzzing harness for CheckBlock(...) and other CBlock related functions.
Oct 28 2020, 13:44
deadalnix accepted D8154: util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests..
Oct 28 2020, 13:34

Oct 27 2020

deadalnix accepted D8139: fuzz: Bump timeout in test_runner to accomodate for slow arm64 CPUs.
Oct 27 2020, 16:07
deadalnix accepted D8140: tests: Add fuzzing harness for various CTx{In,Out} related functions.
Oct 27 2020, 16:07
deadalnix accepted D8138: fuzz: Log output even if fuzzer failed.
Oct 27 2020, 14:16
deadalnix accepted D8137: [CMAKE] Link the fuzzer test_runner.py when building a fuzz target.
Oct 27 2020, 14:14
deadalnix closed D8124: rpc: Auto-format RPCResult.
Oct 27 2020, 12:53
deadalnix committed rABC119798507329: rpc: Auto-format RPCResult (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Auto-format RPCResult
Oct 27 2020, 12:53

Oct 26 2020

deadalnix accepted D8122: Show addresses for "SendToSelf" transactions.
Oct 26 2020, 22:59
deadalnix updated the diff for D8124: rpc: Auto-format RPCResult.

Address comments and update the diff in the test plan.

Oct 26 2020, 22:52
deadalnix updated the test plan for D8124: rpc: Auto-format RPCResult.
Oct 26 2020, 22:52
deadalnix accepted D8127: Error out if jq is not installed when fetching docs.
Oct 26 2020, 17:26
deadalnix accepted D8126: Gracefully degrade when no releases are detected.
Oct 26 2020, 17:25
deadalnix accepted D8125: Move a release note that belongs in the 0.22.6 release.
Oct 26 2020, 17:14
deadalnix closed D8123: rpc: Move OuterType enum to header.
Oct 26 2020, 15:38
deadalnix committed rABC36af7ba9105c: rpc: Move OuterType enum to header (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Move OuterType enum to header
Oct 26 2020, 15:38
deadalnix requested review of D8124: rpc: Auto-format RPCResult.
Oct 26 2020, 15:20
deadalnix requested review of D8123: rpc: Move OuterType enum to header.
Oct 26 2020, 15:18
deadalnix accepted D8120: build: Fix #include sys/poll.h to just poll.h (without sys/).
Oct 26 2020, 13:09
deadalnix accepted D8110: feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic.
Oct 26 2020, 13:09
deadalnix requested changes to D8122: Show addresses for "SendToSelf" transactions.
Oct 26 2020, 13:08
deadalnix accepted D8121: fix name of bench executable.
Oct 26 2020, 13:07
deadalnix closed D8116: Output a descriptor in createmultisig and addmultisigaddress.
Oct 26 2020, 13:07
deadalnix committed rABC01749e021025: Output a descriptor in createmultisig and addmultisigaddress (authored by Andrew Chow <achow101-github@achow101.com>).
Output a descriptor in createmultisig and addmultisigaddress
Oct 26 2020, 13:07
deadalnix accepted D8119: util: Simplify path argument for CBlockTreeDB ctor.
Oct 26 2020, 13:02
deadalnix closed D8117: Use BlockHash in CUpdatedBlock.
Oct 26 2020, 13:01
deadalnix committed rABC8693e1998b7c: Use BlockHash in CUpdatedBlock (authored by deadalnix).
Use BlockHash in CUpdatedBlock
Oct 26 2020, 13:01

Oct 25 2020

deadalnix closed D8115: wallet/refactor: refer to CWallet immutably when possible.
Oct 25 2020, 22:34
deadalnix committed rABCfceefb59cf19: wallet/refactor: refer to CWallet immutably when possible (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
wallet/refactor: refer to CWallet immutably when possible
Oct 25 2020, 22:34
deadalnix requested changes to D8110: feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic.
In D8110#189913, @PiRK wrote:

CFeeRate is already explicit, in Bitcoin ABC:
https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/src/feerate.h$31
It is initialized with CFeeRate()
https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/src/wallet/rpcwallet.cpp$2737
which is initialized with Amount() : amount(0) {}

Oct 25 2020, 22:33
deadalnix requested review of D8117: Use BlockHash in CUpdatedBlock.
Oct 25 2020, 19:06
deadalnix requested review of D8116: Output a descriptor in createmultisig and addmultisigaddress.
Oct 25 2020, 18:43
deadalnix requested changes to D8110: feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic.
Oct 25 2020, 17:01
deadalnix accepted D8108: add newline after -stdin*.
Oct 25 2020, 17:01
deadalnix accepted D8107: cli: add -stdinwalletpassphrase for (slightly more) secure CLI.
Oct 25 2020, 17:01
deadalnix accepted D8106: add stdin helpers for password input support.
Oct 25 2020, 17:00
deadalnix added a comment to D8110: feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic.

What about https://github.com/bitcoin/bitcoin/pull/16507/commits/6a51f7951716d6d6fc0f9b56028f3a0dd02b61c8 ?

Oct 25 2020, 16:54
deadalnix requested review of D8115: wallet/refactor: refer to CWallet immutably when possible.
Oct 25 2020, 16:50
deadalnix closed D8114: Replace GetSigningProvider with GetSolvingProvider.
Oct 25 2020, 15:40
deadalnix committed rABC206346fce4db: Replace GetSigningProvider with GetSolvingProvider (authored by Andrew Chow <achow101-github@achow101.com>).
Replace GetSigningProvider with GetSolvingProvider
Oct 25 2020, 15:40
deadalnix requested review of D8114: Replace GetSigningProvider with GetSolvingProvider.
Oct 25 2020, 15:29
deadalnix accepted D8105: remove redundant strprintf and add missing sentence in doc.
Oct 25 2020, 15:28
deadalnix requested changes to D8106: add stdin helpers for password input support.
Oct 25 2020, 15:26
deadalnix requested changes to D8107: cli: add -stdinwalletpassphrase for (slightly more) secure CLI.

Add a link to the commit.

Oct 25 2020, 15:24
deadalnix requested changes to D8108: add newline after -stdin*.

Add link tot he commit.

Oct 25 2020, 15:24
deadalnix accepted D8109: rpc: fix -rpcclienttimeout 0 option.
Oct 25 2020, 15:22
deadalnix requested changes to D8111: modify p2p_feefilter test to catch rounding error.

See D8110

Oct 25 2020, 15:21
deadalnix requested changes to D8110: feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic.

Please merge the test and the code change together instead of in two diffs.

Oct 25 2020, 15:21
deadalnix accepted D8112: clarify RPC rawtransaction documentation.
Oct 25 2020, 15:19
deadalnix accepted D8113: doc: Clarify sendrawtransaction::maxfeerate==0 help.
Oct 25 2020, 15:18
deadalnix closed D8102: Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan.
Oct 25 2020, 15:18
deadalnix committed rABC67435e511aa3: Move direct calls to MessageSign into new SignMessage functions in CWallet and… (authored by Andrew Chow <achow101-github@achow101.com>).
Move direct calls to MessageSign into new SignMessage functions in CWallet and…
Oct 25 2020, 15:17