- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 26 2022
Nov 25 2022
Nov 24 2022
Nov 22 2022
Nov 21 2022
Nov 18 2022
Nov 17 2022
Responding to review feedback, content jumping has been addressed. Instead of conditionally rendering the single and multi address inputs, they have been placed in a div with a fixed min-height. Oon click the max-height of the single / multi address input is reduced to 0.
Responding to review feedback
Nov 16 2022
After some consideration, the visual navigation aid has been moved below the Cashtab logo.
Responding to review feedback. Navigation aid has been added above the Cashtab logo, and the active NavItem is highlighted.
Nov 15 2022
Nov 10 2022
Nov 8 2022
Nov 7 2022
Updated styling and added the same changes to extension.
To keep it clean I am going to abandon this diff and begin the process of pushing it up stacked as mentioned in the review.
Nov 4 2022
Updated extension
Nov 3 2022
Nov 2 2022
Responding to review feedback, optionalLocale is now defaultLocale, and is defined as 'en', if navigator.language is available, locale is set by the browser.
Nov 1 2022
Responding to review feedback, removed unused currency import in chronik.test.js and updated diff details to reflect this change.
Responding to review feedback, removed onWheel from inputProps in SendToken.js which was left in by mistake in last push, added comments to explain why target.blur() is used in this case instead of event.preventDefault().
Responding to review feedback. Because toLocaleString does not work on a string, the initial unformattedTokenBalance must be converted back to a number in order to be formatted as a localeString. As far as I can tell, using new BigNumber(unformattedTokenBalance).toLocalteString(optionalLocale, {minimumFractionDigits: tokenBalance}) has no effect which was the catalyst for the creation of this new function originally. The workaround is, as stated, do the initial conversion of unformattedTokenBalance to a BigNumber, get the appropriate amount of decimal places with toFixed(tokenDecimal), and in the next step, convert that string into a number which maintains the decimals from the previous step, and finally setting that to localeString with the minimumFractionDigits option set to tokenDecimal. I tried to find a more elegant way to do this, but this has been my best attempt today. Additionally, with consideration to the new optionalLocale parameter, checks have been added along with fallback values in case the optionalLocale is not provided to the function.
Responding to review feedback.
Responding to review feedback, comment has been added to indicate parameter types, and unit test has been added per feedback.
Oct 31 2022
responding to review feedback
Responding to review feedback + added extra type checking to formatTokenBalance.
Responding to review feedback.
Responding to review feedback, formatTokenBalance returns a string, and Number has been replaced with BigNumber. A comment has been added to the diff to indicate the formatTokenBalance is passed unformattedBalance as a BigNumber.
Per review feedback: a blur effect is placed on the balance on toggle to avoid content jumping, changeCashtabSettings is passed to HideBalanceSwitch as a prop instead of initialized within the component.