Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jan 19 2023

sdulfari closed D13004: [avalanche] Improve test coverage of availability scoring.
Jan 19 2023, 17:38
sdulfari committed rABC9643639f3700: [avalanche] Improve test coverage of availability scoring (authored by sdulfari).
[avalanche] Improve test coverage of availability scoring
Jan 19 2023, 17:38
sdulfari closed D13003: [avalanche] Move statistics constants into their own header.
Jan 19 2023, 17:38
sdulfari committed rABCadb6f0f7476b: [avalanche] Move statistics constants into their own header (authored by sdulfari).
[avalanche] Move statistics constants into their own header
Jan 19 2023, 17:38
sdulfari closed D13002: [avalanche] Using C++17 structured bindings to make unit tests more readable.
Jan 19 2023, 17:07
sdulfari committed rABC280c07aa1c02: [avalanche] Using C++17 structured bindings to make unit tests more readable (authored by sdulfari).
[avalanche] Using C++17 structured bindings to make unit tests more readable
Jan 19 2023, 17:07
sdulfari closed D13001: [avalanche] Make unit test cases const.
Jan 19 2023, 17:03
sdulfari committed rABC04567cb58980: [avalanche] Make unit test cases const (authored by sdulfari).
[avalanche] Make unit test cases const
Jan 19 2023, 17:03
sdulfari closed D13000: Fix getpeerinfo help text reference to availability score.
Jan 19 2023, 17:02
sdulfari committed rABC6073f66a7b06: Fix getpeerinfo help text reference to availability score (authored by sdulfari).
Fix getpeerinfo help text reference to availability score
Jan 19 2023, 17:02

Jan 18 2023

sdulfari requested review of D13004: [avalanche] Improve test coverage of availability scoring.
Jan 18 2023, 22:25
sdulfari requested review of D13003: [avalanche] Move statistics constants into their own header.
Jan 18 2023, 22:12
sdulfari requested review of D13002: [avalanche] Using C++17 structured bindings to make unit tests more readable.
Jan 18 2023, 22:03
sdulfari updated the diff for D13001: [avalanche] Make unit test cases const.

Add some missing const

Jan 18 2023, 21:48
sdulfari requested review of D13001: [avalanche] Make unit test cases const.
Jan 18 2023, 21:36
sdulfari requested review of D13000: Fix getpeerinfo help text reference to availability score.
Jan 18 2023, 19:12
sdulfari requested changes to D12998: [avalanche] Leverage AnyVoteItem to have a single VoteItemUpdate object.
Jan 18 2023, 17:49
sdulfari accepted D12997: [avalanche] Use the clear() method where applicable in the processor tests.
Jan 18 2023, 17:32
sdulfari accepted D12996: Move the overloaded template to its own header/namespace.
Jan 18 2023, 17:32
sdulfari accepted D12995: [avalanche] Make the finalization tip pointer const.
Jan 18 2023, 17:31
sdulfari added inline comments to D12999: [avalanche] Sync proofs when functional tests call sync_all.
Jan 18 2023, 17:30
sdulfari requested review of D12999: [avalanche] Sync proofs when functional tests call sync_all.
Jan 18 2023, 17:27
sdulfari requested review of D12987: Move block finalization out of ConnectTip.
Jan 18 2023, 00:42

Jan 17 2023

sdulfari accepted D12986: [avalanche] Merge the block and proof vote records into a single data structure.
Jan 17 2023, 21:26
sdulfari closed D12984: Access miner fund destinations by reference in getblocktemplate.
Jan 17 2023, 19:33
sdulfari committed rABCa331108f3941: Access miner fund destinations by reference in getblocktemplate (authored by sdulfari).
Access miner fund destinations by reference in getblocktemplate
Jan 17 2023, 19:33
sdulfari closed D12985: Make blockReward const when checking miner fund.
Jan 17 2023, 19:33
sdulfari committed rABC2f179cc23642: Make blockReward const when checking miner fund (authored by sdulfari).
Make blockReward const when checking miner fund
Jan 17 2023, 19:33
sdulfari accepted D12983: [avalanche] Don't hold cs_main when adding a block to reconcile.
Jan 17 2023, 19:30
sdulfari requested changes to D12983: [avalanche] Don't hold cs_main when adding a block to reconcile.

patch looks good otherwise

Jan 17 2023, 18:14
sdulfari requested review of D12985: Make blockReward const when checking miner fund.
Jan 17 2023, 18:08
sdulfari requested review of D12984: Access miner fund destinations by reference in getblocktemplate.
Jan 17 2023, 18:03

Jan 16 2023

sdulfari accepted D12980: [avalanche] Create a generic vote map that can have any kind of item being voted on.
Jan 16 2023, 21:56
sdulfari requested changes to D12983: [avalanche] Don't hold cs_main when adding a block to reconcile.
Jan 16 2023, 21:33

Jan 12 2023

sdulfari closed D12973: Add miner fund regression test around Wellington activation.
Jan 12 2023, 17:38
sdulfari committed rABC7c2a1f89d2ed: Add miner fund regression test around Wellington activation (authored by sdulfari).
Add miner fund regression test around Wellington activation
Jan 12 2023, 17:38

Jan 11 2023

sdulfari requested review of D12973: Add miner fund regression test around Wellington activation.
Jan 11 2023, 21:50
sdulfari closed D12970: Cleanup unused nodes in abc_mining_basic.py.
Jan 11 2023, 16:41
sdulfari committed rABCb071759ef844: Cleanup unused nodes in abc_mining_basic.py (authored by sdulfari).
Cleanup unused nodes in abc_mining_basic.py
Jan 11 2023, 16:41

Jan 10 2023

sdulfari closed D12965: [doc] Add notes on how to activate bash completion for locally built binaries.
Jan 10 2023, 21:06
sdulfari committed rABC74545aae946b: [doc] Add notes on how to activate bash completion for locally built binaries (authored by sdulfari).
[doc] Add notes on how to activate bash completion for locally built binaries
Jan 10 2023, 21:06
sdulfari requested review of D12970: Cleanup unused nodes in abc_mining_basic.py.
Jan 10 2023, 21:05
sdulfari accepted D12969: [avalanche] Vote on transactions.
Jan 10 2023, 17:42
sdulfari requested changes to D12969: [avalanche] Vote on transactions.
Jan 10 2023, 17:02

Jan 9 2023

sdulfari requested review of D12965: [doc] Add notes on how to activate bash completion for locally built binaries.
Jan 9 2023, 23:34
sdulfari accepted D12960: [secp256k1] ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs.
Jan 9 2023, 16:37

Jan 6 2023

sdulfari accepted D12961: [secp256k1] Update macOS image for CI.
Jan 6 2023, 18:02
sdulfari requested changes to D12960: [secp256k1] ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs.
Jan 6 2023, 18:00
sdulfari accepted D12957: [secp256k1] Update the CI docker to Debian Bullseye.
Jan 6 2023, 17:48
sdulfari accepted D12953: miner: bug fix? update for ancestor inclusion using modified fees, not base.
Jan 6 2023, 17:45
sdulfari abandoned D11961: [avalanche] Make a low dust threshold the default for functional tests.
Jan 6 2023, 00:14

Jan 5 2023

sdulfari accepted D12955: refactor, miner: Delete call to UpdatePackagesForAdded at beginning of addPackageTxs.
Jan 5 2023, 22:06
sdulfari accepted D12954: refactor: remove duplicate code from BlockAssembler.
Jan 5 2023, 22:04
sdulfari requested changes to D12953: miner: bug fix? update for ancestor inclusion using modified fees, not base.
Jan 5 2023, 22:03
sdulfari closed D12952: [avalanche] Add logging when a block is parked due to conflict with avalanche finalized blocks.
Jan 5 2023, 19:00
sdulfari committed rABC71f04545b8c2: [avalanche] Add logging when a block is parked due to conflict with avalanche… (authored by sdulfari).
[avalanche] Add logging when a block is parked due to conflict with avalanche…
Jan 5 2023, 19:00
sdulfari requested review of D12952: [avalanche] Add logging when a block is parked due to conflict with avalanche finalized blocks.
Jan 5 2023, 18:15
sdulfari accepted D12951: policy: Remove unused locktime flags.
Jan 5 2023, 18:00
sdulfari accepted D12949: wallet: Actually treat (un)confirmed txs as (un)confirmed.
Jan 5 2023, 17:38
sdulfari accepted D12950: Remove unused MTP from ContextualCheckTransaction.
Jan 5 2023, 17:28
sdulfari accepted D12947: Fix a -Wreturn-type warning with GCC.
Jan 5 2023, 17:27

Jan 4 2023

sdulfari requested changes to D12947: Fix a -Wreturn-type warning with GCC.

Although we don't expect this code to execute, it should at least appear sane if it did.

Jan 4 2023, 21:28

Jan 1 2023

sdulfari closed D12944: [avalanche] Improve test coverage of existing parking behavior.
Jan 1 2023, 23:31
sdulfari committed rABCfc44fd909ab4: [avalanche] Improve test coverage of existing parking behavior (authored by sdulfari).
[avalanche] Improve test coverage of existing parking behavior
Jan 1 2023, 23:31

Dec 31 2022

sdulfari updated the diff for D12944: [avalanche] Improve test coverage of existing parking behavior.

Pull 1 block case out of the loop and other fixes from feedback

Dec 31 2022, 19:12

Dec 30 2022

sdulfari closed D12943: [avalanche] Add test coverage for parking against avalanche finalized chaintip.
Dec 30 2022, 23:40
sdulfari committed rABC4981f77bb694: [avalanche] Add test coverage for parking against avalanche finalized chaintip (authored by sdulfari).
[avalanche] Add test coverage for parking against avalanche finalized chaintip
Dec 30 2022, 23:40

Dec 29 2022

sdulfari requested review of D12944: [avalanche] Improve test coverage of existing parking behavior.
Dec 29 2022, 21:35
sdulfari requested review of D12943: [avalanche] Add test coverage for parking against avalanche finalized chaintip.
Dec 29 2022, 21:26
sdulfari accepted D12941: [avalanche] Add the local proof verification status details to getavalancheinfo.
Dec 29 2022, 21:11
sdulfari accepted D12942: Bump version to 0.26.10.
Dec 29 2022, 05:07

Dec 14 2022

sdulfari accepted D12897: [backport#19379] tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...).
Dec 14 2022, 23:25
sdulfari closed D12896: [avalanche] Cleanup unnecessary timeout values in block voting test.
Dec 14 2022, 20:42
sdulfari committed rABC3a2eaa578f58: [avalanche] Cleanup unnecessary timeout values in block voting test (authored by sdulfari).
[avalanche] Cleanup unnecessary timeout values in block voting test
Dec 14 2022, 20:42
sdulfari closed D12893: [doc] Add suggestions in functional test documentation for improving debugging iteration speed.
Dec 14 2022, 20:41
sdulfari committed rABCe1303a1f82cf: [doc] Add suggestions in functional test documentation for improving debugging… (authored by sdulfari).
[doc] Add suggestions in functional test documentation for improving debugging…
Dec 14 2022, 20:41
sdulfari closed D12892: [doc] Fix incorrect argument syntax for --timeout-factor.
Dec 14 2022, 20:41
sdulfari committed rABC606c0c4345d1: [doc] Fix incorrect argument syntax for --timeout-factor (authored by sdulfari).
[doc] Fix incorrect argument syntax for --timeout-factor
Dec 14 2022, 20:41
sdulfari accepted D12873: Remove the txHashes structure from the mempool.
Dec 14 2022, 20:17
sdulfari requested review of D12896: [avalanche] Cleanup unnecessary timeout values in block voting test.
Dec 14 2022, 19:40
sdulfari accepted D12895: [website] There might be no relative link in the release notes.
Dec 14 2022, 19:31
sdulfari abandoned D12890: Add sane timeout in tests when waiting for parked blocks.

TIL you can set timeout-factor on the command line. Inspired some improvement to the docs: D12893

Dec 14 2022, 19:15
sdulfari requested review of D12893: [doc] Add suggestions in functional test documentation for improving debugging iteration speed.
Dec 14 2022, 19:14
sdulfari requested review of D12892: [doc] Fix incorrect argument syntax for --timeout-factor.
Dec 14 2022, 19:07
sdulfari requested review of D12890: Add sane timeout in tests when waiting for parked blocks.
Dec 14 2022, 17:41
sdulfari closed D12886: [avalanche] Optimize block parking.
Dec 14 2022, 16:44
sdulfari committed rABC3074dd676c26: [avalanche] Optimize block parking (authored by sdulfari).
[avalanche] Optimize block parking
Dec 14 2022, 16:44
sdulfari closed D12885: [avalanche] Clear finalization when manually switching chaintips.
Dec 14 2022, 16:43
sdulfari committed rABCcfaf55feb04f: [avalanche] Clear finalization when manually switching chaintips (authored by sdulfari).
[avalanche] Clear finalization when manually switching chaintips
Dec 14 2022, 16:43

Dec 13 2022

sdulfari published D12886: [avalanche] Optimize block parking for review.
Dec 13 2022, 23:05
sdulfari published D12885: [avalanche] Clear finalization when manually switching chaintips for review.
Dec 13 2022, 22:53
sdulfari closed D12875: [avalanche] Actually finalize block in voting functional test.
Dec 13 2022, 17:01
sdulfari committed rABCbf4a9cfa2e30: [avalanche] Actually finalize block in voting functional test (authored by sdulfari).
[avalanche] Actually finalize block in voting functional test
Dec 13 2022, 17:01

Dec 12 2022

sdulfari updated the diff for D12875: [avalanche] Actually finalize block in voting functional test.

Remove unused import

Dec 12 2022, 22:03
sdulfari requested review of D12875: [avalanche] Actually finalize block in voting functional test.
Dec 12 2022, 22:02

Dec 8 2022

sdulfari accepted D12826: Fix automated timings updates.
Dec 8 2022, 17:27
sdulfari accepted D12797: ci: ubsan report_error_type=1 and add suppressions.
Dec 8 2022, 17:19

Dec 7 2022

sdulfari accepted D12799: refactor: Remove implicit-integer-sign-change suppressions in validation.cpp.
Dec 7 2022, 19:21
sdulfari accepted D12798: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback.
Dec 7 2022, 19:15
sdulfari requested changes to D12797: ci: ubsan report_error_type=1 and add suppressions.

back to you

Dec 7 2022, 19:13
First
Prev
Next