Page MenuHomePhabricator
Feed Advanced Search

Jul 3 2023

emack committed rABC17c003c4d228: [Cashtab][Alias] Implement getAliasDetails (authored by emack).
[Cashtab][Alias] Implement getAliasDetails
Jul 3 2023, 14:35
emack requested review of D14198: [Apps][Examples] Sending XECs.
Jul 3 2023, 14:27
emack updated the diff for D14189: [Cashtab][Alias] Implement getAliasesForAddress.

updated getAliasesforAddress to throw error if address endpoint returns an error response
updated error handling unit test accordingly

Jul 3 2023, 02:01
emack updated the diff for D14191: [Cashtab][Alias] Implement getAliasDetails.

rebase

Jul 3 2023, 01:51
emack updated the diff for D14191: [Cashtab][Alias] Implement getAliasDetails.
  • updated getAliasDetails to throw error if alias endpoint returns an error response
  • updated error handling unit tests accordingly
Jul 3 2023, 01:48
emack closed D14186: [Cashtab][Alias] Deprecate alias history refresh in handleUpdateWallet.
Jul 3 2023, 00:18
emack committed rABC420431d0ef4f: [Cashtab][Alias] Deprecate alias history refresh in handleUpdateWallet (authored by emack).
[Cashtab][Alias] Deprecate alias history refresh in handleUpdateWallet
Jul 3 2023, 00:18

Jul 2 2023

emack added inline comments to D14186: [Cashtab][Alias] Deprecate alias history refresh in handleUpdateWallet.
Jul 2 2023, 16:15
emack committed rABC36f0fb5bdcbf: [Apps][Examples] Create wallet (authored by emack).
[Apps][Examples] Create wallet
Jul 2 2023, 15:07
emack closed D14165: [Apps][Examples] Create wallet.
Jul 2 2023, 15:07
emack updated the diff for D14186: [Cashtab][Alias] Deprecate alias history refresh in handleUpdateWallet.

Updated unit test to use the updated isValidStoredWallet validation function from D14190

Jul 2 2023, 15:00
emack closed D14190: [Cashtab] Improve isValidStoredWallet validation.
Jul 2 2023, 14:02
emack committed rABC890a4217c28f: [Cashtab] Improve isValidStoredWallet validation (authored by emack).
[Cashtab] Improve isValidStoredWallet validation
Jul 2 2023, 14:02
emack closed D14193: [alias-server] Error response handling patch.
Jul 2 2023, 13:49
emack committed rABC366a96823508: [alias-server] Error response handling patch (authored by emack).
[alias-server] Error response handling patch
Jul 2 2023, 13:49
emack updated the diff for D14190: [Cashtab] Improve isValidStoredWallet validation.

rebase

Jul 2 2023, 13:44
teamcity awarded D14190: [Cashtab] Improve isValidStoredWallet validation a Piece of Eight token.
Jul 2 2023, 13:30
emack added a comment to D14190: [Cashtab] Improve isValidStoredWallet validation.

@bot cashtab-tests

Jul 2 2023, 13:29
emack added a comment to D14190: [Cashtab] Improve isValidStoredWallet validation.

mb a rebase issue?

Jul 2 2023, 13:22
emack closed D14192: [Cashtab] Updating processChronikWsMsg unit test.
Jul 2 2023, 13:16
emack committed rABC52c9b5557640: [Cashtab] Updating processChronikWsMsg unit test (authored by emack).
[Cashtab] Updating processChronikWsMsg unit test
Jul 2 2023, 13:16
teamcity awarded D14190: [Cashtab] Improve isValidStoredWallet validation a Haypence token.
Jul 2 2023, 12:58
emack planned changes to D14189: [Cashtab][Alias] Implement getAliasesForAddress.
Jul 2 2023, 09:17
emack updated the diff for D14189: [Cashtab][Alias] Implement getAliasesForAddress.

fixed typos

Jul 2 2023, 09:17
emack planned changes to D14191: [Cashtab][Alias] Implement getAliasDetails.

Will update response handling once D14193 is propagated to alias.etokens.cash.

Jul 2 2023, 09:09
emack updated the diff for D14191: [Cashtab][Alias] Implement getAliasDetails.

updated comments

Jul 2 2023, 09:08
emack requested review of D14193: [alias-server] Error response handling patch.
Jul 2 2023, 09:02
emack added inline comments to D14191: [Cashtab][Alias] Implement getAliasDetails.
Jul 2 2023, 07:35
emack requested review of D14192: [Cashtab] Updating processChronikWsMsg unit test.
Jul 2 2023, 05:39
emack updated the diff for D14190: [Cashtab] Improve isValidStoredWallet validation.

Updated unit tests

Jul 2 2023, 05:20
emack updated the diff for D14165: [Apps][Examples] Create wallet.

updated unit tests

Jul 2 2023, 05:08
emack closed D14166: [Apps][Examples] Get eToken Info.
Jul 2 2023, 04:46
emack committed rABC263ae88127b0: [Apps][Examples] Get eToken Info (authored by emack).
[Apps][Examples] Get eToken Info
Jul 2 2023, 04:46
emack committed rABC5e76d4421a08: [Apps][Examples] Get Utxos from address (authored by emack).
[Apps][Examples] Get Utxos from address
Jul 2 2023, 04:11
emack closed D14170: [Apps][Examples] Get Utxos from address.
Jul 2 2023, 04:11
emack closed D14184: [Cashtab][Alias] Deprecate alias specific BlockConnected websocket events.
Jul 2 2023, 03:59
emack committed rABCcf1d050ef655: [Cashtab][Alias] Deprecate alias specific BlockConnected websocket events (authored by emack).
[Cashtab][Alias] Deprecate alias specific BlockConnected websocket events
Jul 2 2023, 03:59
emack closed D14183: [Apps][Examples] Remove chronik url input arg from getDetailsFromTxid.
Jul 2 2023, 03:33
emack committed rABC70a4d39068f7: [Apps][Examples] Remove chronik url input arg from getDetailsFromTxid (authored by emack).
[Apps][Examples] Remove chronik url input arg from getDetailsFromTxid
Jul 2 2023, 03:33
emack closed D14182: [Apps][Examples] Remove chronik url input arg from getTxHistoryFromAddress.
Jul 2 2023, 03:22
emack committed rABC9ebe6d0e8f93: [Apps][Examples] Remove chronik url input arg from getTxHistoryFromAddress (authored by emack).
[Apps][Examples] Remove chronik url input arg from getTxHistoryFromAddress
Jul 2 2023, 03:22
emack updated the diff for D14165: [Apps][Examples] Create wallet.

Upgraded ecashaddrjs

Jul 2 2023, 03:20
emack requested review of D14191: [Cashtab][Alias] Implement getAliasDetails.
Jul 2 2023, 03:12
emack added inline comments to D14186: [Cashtab][Alias] Deprecate alias history refresh in handleUpdateWallet.
Jul 2 2023, 01:57
emack requested review of D14190: [Cashtab] Improve isValidStoredWallet validation.
Jul 2 2023, 01:53
emack updated the diff for D14184: [Cashtab][Alias] Deprecate alias specific BlockConnected websocket events.

Updated chronik websocket tests to specifically differentiate state between AddedToMempool and BlockConnected events

Jul 2 2023, 01:28
emack abandoned D14185: [Cashtab][Alias] Deprecate getAliasServerState.
Jul 2 2023, 00:46
emack updated the diff for D14189: [Cashtab][Alias] Implement getAliasesForAddress.

globalized the fetch() mock override, fixed linting and unit test issues

Jul 2 2023, 00:40
emack planned changes to D14189: [Cashtab][Alias] Implement getAliasesForAddress.
Jul 2 2023, 00:31
emack requested review of D14189: [Cashtab][Alias] Implement getAliasesForAddress.
Jul 2 2023, 00:28

Jul 1 2023

emack requested review of D14185: [Cashtab][Alias] Deprecate getAliasServerState.
Jul 1 2023, 23:01
emack requested review of D14183: [Apps][Examples] Remove chronik url input arg from getDetailsFromTxid.
Jul 1 2023, 22:57
emack requested review of D14182: [Apps][Examples] Remove chronik url input arg from getTxHistoryFromAddress.
Jul 1 2023, 22:57
emack requested review of D14166: [Apps][Examples] Get eToken Info.

We'll be using this in many scripts, so it should be kept in its own file. e.g. create a config.js and export this here

Jul 1 2023, 22:55
emack requested review of D14170: [Apps][Examples] Get Utxos from address.

We'll be using this in many scripts, so it should be kept in its own file. e.g. create a config.js and export this here

Jul 1 2023, 22:54
emack requested review of D14186: [Cashtab][Alias] Deprecate alias history refresh in handleUpdateWallet.
Jul 1 2023, 15:33
emack requested review of D14185: [Cashtab][Alias] Deprecate getAliasServerState.
Jul 1 2023, 12:20
emack requested review of D14184: [Cashtab][Alias] Deprecate alias specific BlockConnected websocket events.
Jul 1 2023, 09:58
emack requested review of D14183: [Apps][Examples] Remove chronik url input arg from getDetailsFromTxid.
Jul 1 2023, 08:42
emack requested review of D14182: [Apps][Examples] Remove chronik url input arg from getTxHistoryFromAddress.
Jul 1 2023, 08:37
emack updated the test plan for D14166: [Apps][Examples] Get eToken Info.
Jul 1 2023, 08:32
emack updated the test plan for D14166: [Apps][Examples] Get eToken Info.
Jul 1 2023, 08:31
emack updated the test plan for D14170: [Apps][Examples] Get Utxos from address.
Jul 1 2023, 08:31
emack updated the diff for D14166: [Apps][Examples] Get eToken Info.

removed chronik url from input args

Jul 1 2023, 08:31
emack updated the diff for D14170: [Apps][Examples] Get Utxos from address.

removed chronik url from input args

Jul 1 2023, 08:25
emack updated the diff for D14165: [Apps][Examples] Create wallet.

updated comments

Jul 1 2023, 08:18
emack added inline comments to D14165: [Apps][Examples] Create wallet.
Jul 1 2023, 02:46
emack updated the diff for D14165: [Apps][Examples] Create wallet.

resolved merge conflicts in package-lock.json

Jul 1 2023, 02:45
emack updated the diff for D14165: [Apps][Examples] Create wallet.

added contextual comments

Jul 1 2023, 02:42
emack updated the diff for D14170: [Apps][Examples] Get Utxos from address.

updated address decoding call, new unit test for an address with no utxos and added contextual comments

Jul 1 2023, 02:20
emack added a comment to D14166: [Apps][Examples] Get eToken Info.

TIL chronik does this...I've been using chronik.tx(tokenId)
Is there a difference in the response?

Jul 1 2023, 01:39
emack updated the diff for D14166: [Apps][Examples] Get eToken Info.

updated chronik mock and package.json

Jul 1 2023, 01:37

Jun 30 2023

emack requested review of D14170: [Apps][Examples] Get Utxos from address.
Jun 30 2023, 15:31
emack closed D14164: [Apps][Examples] getTxHistoryFromAddress.
Jun 30 2023, 14:19
emack committed rABC8d8b4ca5a26d: [Apps][Examples] getTxHistoryFromAddress (authored by emack).
[Apps][Examples] getTxHistoryFromAddress
Jun 30 2023, 14:19
emack requested review of D14166: [Apps][Examples] Get eToken Info.
Jun 30 2023, 14:15
emack requested review of D14165: [Apps][Examples] Create wallet.
Jun 30 2023, 13:32
emack requested review of D14164: [Apps][Examples] getTxHistoryFromAddress.
Jun 30 2023, 11:59
emack abandoned D14146: [Apps][Examples] addressToHash160.

Not worth an individual diff + unit tests on a library, will use directly in txhistory/utxo retrieval examples

Jun 30 2023, 02:35

Jun 29 2023

emack added inline comments to D14146: [Apps][Examples] addressToHash160.
Jun 29 2023, 12:13
emack planned changes to D14146: [Apps][Examples] addressToHash160.
Jun 29 2023, 07:32
emack updated the diff for D14146: [Apps][Examples] addressToHash160.

wrapping ecashaddr.decode call

Jun 29 2023, 07:29
emack planned changes to D14146: [Apps][Examples] addressToHash160.
Jun 29 2023, 07:11
emack updated the diff for D14146: [Apps][Examples] addressToHash160.

switching to assert.rejects() for exception validation

Jun 29 2023, 07:04
emack planned changes to D14146: [Apps][Examples] addressToHash160.
Jun 29 2023, 00:10
emack added a comment to D14146: [Apps][Examples] addressToHash160.

Looking into why the tests passes locally but phab is complaining about a validation error which is what the unit tests were expecting...

Jun 29 2023, 00:09
emack closed D14144: [Cashtab] Improve cashtabCacheKeys validation logic.
Jun 29 2023, 00:07
emack committed rABCa9f7a4333f8d: [Cashtab] Improve cashtabCacheKeys validation logic (authored by emack).
[Cashtab] Improve cashtabCacheKeys validation logic
Jun 29 2023, 00:07
emack updated the diff for D14146: [Apps][Examples] addressToHash160.

Simplified ecashaddrjs usage and updated readme

Jun 29 2023, 00:04

Jun 28 2023

emack planned changes to D14146: [Apps][Examples] addressToHash160.
Jun 28 2023, 14:54
emack updated the diff for D14146: [Apps][Examples] addressToHash160.

updated error handling

Jun 28 2023, 14:52
emack planned changes to D14146: [Apps][Examples] addressToHash160.
Jun 28 2023, 14:39
emack requested review of D14146: [Apps][Examples] addressToHash160.
Jun 28 2023, 14:35
emack requested review of D14144: [Cashtab] Improve cashtabCacheKeys validation logic.
Jun 28 2023, 12:18
emack closed D14100: [Apps] [Examples] Initial mocha framework and getDetailsFromTxid example.
Jun 28 2023, 11:48
emack committed rABC1ceb096d1a1c: [Apps] [Examples] Initial mocha framework and getDetailsFromTxid example (authored by emack).
[Apps] [Examples] Initial mocha framework and getDetailsFromTxid example
Jun 28 2023, 11:48
emack abandoned D14122: [Cashtab] Move caching config out of Ticker.

The defaultCashtabCache structure is there to support the migration of legacy wallets and ensure they have the right cache attributes.
Will throw up a separate diff to address the antipattern in feedback.

Jun 28 2023, 11:48

Jun 27 2023

emack added inline comments to D14130: [alias-server] Add new database function to lookup registered aliases by address.
Jun 27 2023, 08:05
emack updated the diff for D14100: [Apps] [Examples] Initial mocha framework and getDetailsFromTxid example.
  • updated test file to align with naming convention
  • added new test to ensure chronik errors are being thrown
Jun 27 2023, 06:13

Jun 26 2023

emack closed D14116: [Cashtab] Move parseAddressForParams out of Ticker.js.
Jun 26 2023, 15:15