ok now this version has the latest rev of D14526 installed.

Update dust error, bump ecash-coinselect to latest version in parallel diff

better dust error

Add support for hex strings as script input, remove chronik references, add validation for script types

Nice case of silently breaking stuff

@emack Your questions are valid, and the missing dependency is indeed an issue: the test plan won't work without it.
Please request changes when you have such remarks: comments with no state change are more to ask a general question about the diff in a non-blocking way but also it makes it harder to spot for dev that the diff needs his attention.

Can we get rid of the references to chronik everywhere ? The fact that the utxo format matches chronik is convenient but doesn't mean the lib can't be used with another backend. In fact it's not a dependency of this lib.

rebase

rebase

rebase

undo function renaming

reverting arabic

using locale alphabet for symbol

Accepted with minor nit

Minor commenting nit

• Added warning about not tracking pending aliases for other wallets as part of the registration confirmation modal if the user is specifying a separate address for the alias
• Cleared inputs upon registration broadcast
• Fixed a silent bug where refreshAliases() was being constantly triggered in a loop - have moved it into its own useEffect() now with just hasPendingAliases as a dependency
• Responding to other feedback as below:

Upcoming stack

It's actually more complicated to implement because a Cashtab user can register aliases for an address that is not their own address.

To be split up into smaller diffs -- retiring this as proof of concept.

rebase

rename write_compact_size -> compact_size, as it is not writing anything anywhere, and arg nsize in compact_size_nbytes for consistency

Let's not do it all at once: start with the lib overhaul, incrementally, then use it in cashtab.

remove linter warning

• New refreshAliases() function added to useWallet that calls the /address endpoint to retrieve both registered and pending aliases for the active wallet
• Latest aliases are stored in useWallet's state variable latestAliases, which are then used by Alias.js to populate the registered and pending alias dropdowns
• Interval created in useWallet that calls refreshAliases() to refresh registered and pending aliases
• useEffect() dependencies adjusted in Alias.js so that a refresh is triggered upon alias registration (balance change) and new aliases detected
• No longer using localStorage to keep track of pending aliases
• Per earlier feedback, no longer using websocket listener on 'BlockConnected' events as that may not be a one to one correlation to a successful registration

Improve code commenting

Remove dead code now that coinselect throws errors instead of mysteriously returning undefined for inputs and outputs

reverting unrelated snapshot changes from package-lock.json patch, add script unit test to ecash-coinselect

package-lock.json was corrupted somehow during uninstall/reinstall of local ecash-coinsect vs npm hosted one

Fix local install dependency in package-lock.json from local testing, remove p2sh comments

Refactor and implement ecash-coinselect

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41238 for the next 60 minutes.