Page MenuHomePhabricator
Feed Advanced Search

Mar 20 2024

Fabien published D15686: [avalanche] Allow for yes-voting several winners for review.
Mar 20 2024, 09:09
Fabien published D15685: [avalanche] Prepare the data structure to hold several staking reward winners for review.
Mar 20 2024, 09:09

Mar 19 2024

Fabien accepted D15740: validationcaches: Use size_t for sizes.
Mar 19 2024, 19:52
Fabien accepted D15666: Fix DNS seed dump flushing.
Mar 19 2024, 19:51
Fabien accepted D15738: validationcaches: Add and use ValidationCacheSizes.
Mar 19 2024, 14:53
Fabien closed D15739: [cmake] Explicitely exclude the CI build directory from the source package.
Mar 19 2024, 13:43
Fabien committed rABC03464465658a: [cmake] Explicitely exclude the CI build directory from the source package (authored by Fabien).
[cmake] Explicitely exclude the CI build directory from the source package
Mar 19 2024, 13:43
teamcity awarded D15739: [cmake] Explicitely exclude the CI build directory from the source package a Doubloon token.
Mar 19 2024, 13:38
Fabien added a comment to D15739: [cmake] Explicitely exclude the CI build directory from the source package.

@bot guix-osx

Mar 19 2024, 13:38
teamcity awarded D15739: [cmake] Explicitely exclude the CI build directory from the source package a Piece of Eight token.
Mar 19 2024, 13:33
Fabien added a comment to D15739: [cmake] Explicitely exclude the CI build directory from the source package.

@bot guix-osx

Mar 19 2024, 13:33
teamcity awarded D15739: [cmake] Explicitely exclude the CI build directory from the source package a Haypence token.
Mar 19 2024, 13:29
Fabien added a comment to D15739: [cmake] Explicitely exclude the CI build directory from the source package.

@bot guix-osx

Mar 19 2024, 13:29
Fabien requested changes to D15738: validationcaches: Add and use ValidationCacheSizes.

tests are failing

Mar 19 2024, 13:28
Fabien accepted D15738: validationcaches: Add and use ValidationCacheSizes.
Mar 19 2024, 13:21
Fabien accepted D15737: cuckoocache: Check for uint32 overflow in setup_bytes.
Mar 19 2024, 13:17
Fabien accepted D15736: validationcaches: Abolish arbitrary limit.
Mar 19 2024, 13:16
Fabien accepted D15735: cuckoocache: Return approximate memory size.
Mar 19 2024, 13:16
Fabien accepted D15734: tests: Reduce calls to InitS*Cache().
Mar 19 2024, 13:12
Fabien requested review of D15739: [cmake] Explicitely exclude the CI build directory from the source package.
Mar 19 2024, 13:08
Fabien accepted D15733: [test] remove unneeded InitScriptExecutionCache.
Mar 19 2024, 12:30
Fabien closed D15730: [chronik] Make chronik_serve bind once to the same ip.
Mar 19 2024, 08:13
Fabien committed rABCa8e8f277059d: [chronik] Make chronik_serve bind once to the same ip (authored by Fabien).
[chronik] Make chronik_serve bind once to the same ip
Mar 19 2024, 08:13
Fabien added a comment to D15730: [chronik] Make chronik_serve bind once to the same ip.
In D15730#355246, @PiRK wrote:

Otherwise LGTM, except for the confusing summary.

Mar 19 2024, 08:12
Fabien updated the summary of D15730: [chronik] Make chronik_serve bind once to the same ip.
Mar 19 2024, 08:12

Mar 18 2024

teamcity awarded D15730: [chronik] Make chronik_serve bind once to the same ip a Haypence token.
Mar 18 2024, 20:31
Fabien added a comment to D15730: [chronik] Make chronik_serve bind once to the same ip.

@bot build-linux-arm build-linux-aarch64

Mar 18 2024, 20:31
Fabien retitled D15730: [chronik] Make chronik_serve bind once to the same ip from [chronik] Make chornik_serve bind once to the same ip to [chronik] Make chronik_serve bind once to the same ip.
Mar 18 2024, 20:30
Fabien accepted D15727: [e.cash] Add a motivating intro to the Developers page.
Mar 18 2024, 20:30
Fabien requested review of D15730: [chronik] Make chronik_serve bind once to the same ip.
Mar 18 2024, 20:23
Fabien added inline comments to D15727: [e.cash] Add a motivating intro to the Developers page.
Mar 18 2024, 19:34
Fabien added a comment to D15727: [e.cash] Add a motivating intro to the Developers page.

@bot preview-e.cash

Mar 18 2024, 19:20
Fabien accepted D15726: [Cashtab] Bump extension version for in-node chronik-client.
Mar 18 2024, 19:20
Fabien closed D15725: Bump version to 0.28.12.
Mar 18 2024, 18:03
Fabien committed rABCad0c1b7d0032: Bump version to 0.28.12 (authored by Fabien).
Bump version to 0.28.12
Mar 18 2024, 18:03
Fabien requested review of D15725: Bump version to 0.28.12.
Mar 18 2024, 15:34
Fabien accepted D15724: Move {Load,Dump}Mempool to kernel namespace.
Mar 18 2024, 14:42
Fabien accepted D15723: Move DEFAULT_PERSIST_MEMPOOL out of libbitcoinkernel.
Mar 18 2024, 14:38
Fabien accepted D15722: LoadMempool: Pass in load_path, stop using gArgs.
Mar 18 2024, 14:36
Fabien accepted D15721: test/fuzz: Invoke LoadMempool via Chainstate.
Mar 18 2024, 14:31
Fabien accepted D15720: Move FopenFn to fsbridge namespace.
Mar 18 2024, 14:30
Fabien accepted D15719: mempool: Use NodeClock+friends for LoadMempool.
Mar 18 2024, 14:26
Fabien accepted D15718: Rename m_is_loaded -> m_load_tried.
Mar 18 2024, 14:24
Fabien accepted D15717: DumpMempool: Pass in dump_path, stop using gArgs.
Mar 18 2024, 14:21
Fabien accepted D15716: DumpMempool: Use std::chrono instead of weird int64_t arthmetics.
Mar 18 2024, 14:13
Fabien accepted D15715: test/mempool_persist: Test manual savemempool when -persistmempool=0.
Mar 18 2024, 14:10
Fabien accepted D15713: fuzz: Rework strong and weak net enum fuzzing.
Mar 18 2024, 09:55

Mar 15 2024

Fabien accepted D15709: [electrum] fix error when cached password is forwarded to subwidget.
Mar 15 2024, 14:25
Fabien accepted D15708: [electrum] prefill the delegator key in the delegation editor when possible.
Mar 15 2024, 12:44
Fabien accepted D15699: fuzz: Add fuzzing harness for LoadMempool(...) and DumpMempool(...).
Mar 15 2024, 12:41
Fabien closed D15707: [chronik] Prevent potential port collision in chronik_serve.
Mar 15 2024, 10:19
Fabien committed rABCadc17694f15b: [chronik] Prevent potential port collision in chronik_serve (authored by Fabien).
[chronik] Prevent potential port collision in chronik_serve
Mar 15 2024, 10:19
Fabien closed D15706: [chronik] Don't ever use mainnet on tests.
Mar 15 2024, 10:19
Fabien committed rABCd2f3d9d702f7: [chronik] Don't ever use mainnet on tests (authored by Fabien).
[chronik] Don't ever use mainnet on tests
Mar 15 2024, 10:18
Fabien closed D15705: Make combine_logs.py executable.
Mar 15 2024, 09:08
Fabien committed rABC58874ac3c27d: Make combine_logs.py executable (authored by Fabien).
Make combine_logs.py executable
Mar 15 2024, 09:08
Fabien requested review of D15707: [chronik] Prevent potential port collision in chronik_serve.
Mar 15 2024, 09:08
Fabien requested review of D15706: [chronik] Don't ever use mainnet on tests.
Mar 15 2024, 09:02
Fabien requested review of D15705: Make combine_logs.py executable.
Mar 15 2024, 08:29

Mar 14 2024

Fabien closed D15702: [chronik] Fix a race in chronik_ws.
Mar 14 2024, 19:15
Fabien committed rABC9542adf854a2: [chronik] Fix a race in chronik_ws (authored by Fabien).
[chronik] Fix a race in chronik_ws
Mar 14 2024, 19:15
Fabien requested review of D15702: [chronik] Fix a race in chronik_ws.
Mar 14 2024, 18:54
Fabien closed D15698: Use GetConflictTx() where possible.
Mar 14 2024, 15:12
Fabien committed rABC66fcceb38a33: Use GetConflictTx() where possible (authored by Fabien).
Use GetConflictTx() where possible
Mar 14 2024, 15:12
Fabien accepted D15696: rpc: Add EnsureArgsman helper.
Mar 14 2024, 14:25
Fabien requested changes to D15696: rpc: Add EnsureArgsman helper.

You're missing rpc/avalanche.cpp

Mar 14 2024, 13:02
Fabien accepted D15695: rpc: Move mempool RPCs to new file.

I trust this is correct

Mar 14 2024, 13:00
Fabien requested review of D15698: Use GetConflictTx() where possible.
Mar 14 2024, 12:55

Mar 13 2024

Fabien accepted D15688: test: add functional test for `-maxtipage` parameter.
Mar 13 2024, 08:34
Fabien added a comment to D15688: test: add functional test for `-maxtipage` parameter.
In D15688#354247, @PiRK wrote:
Mar 13 2024, 08:34
Fabien added inline comments to D15688: test: add functional test for `-maxtipage` parameter.
Mar 13 2024, 06:05

Mar 12 2024

Fabien accepted D15682: [gui] stop migrating QSettings from BitcoinABC 0.14.6 or Bitcoin Core.
Mar 12 2024, 10:28
Fabien accepted D14993: Extend bilingual_str support for tinyformat.
Mar 12 2024, 10:26
Fabien closed D15674: [CI] Add CI configuration for the GUIX builds.
Mar 12 2024, 08:57
Fabien committed rABCb5497111c120: [CI] Add CI configuration for the GUIX builds (authored by Fabien).
[CI] Add CI configuration for the GUIX builds
Mar 12 2024, 08:57
Fabien accepted D15668: [chronik-client] Support for confirmedTxs and unconfirmedTxs in script.
Mar 12 2024, 08:55
Fabien requested changes to D14993: Extend bilingual_str support for tinyformat.
Mar 12 2024, 08:45
Fabien added a comment to D15674: [CI] Add CI configuration for the GUIX builds.

I tried reviewing one of these guix diffs but got an error about not having the required deps (and running the script wiped my build/ dir and also all node_modules.

What do I need to install to run these commands?

Mar 12 2024, 08:36

Mar 11 2024

Fabien requested review of D15674: [CI] Add CI configuration for the GUIX builds.
Mar 11 2024, 15:27

Mar 9 2024

Fabien accepted D15664: [chronik-client] Add line breaks to README changelog.
Mar 9 2024, 08:12
Fabien requested changes to D15666: Fix DNS seed dump flushing.
Mar 9 2024, 08:12
Fabien accepted D15661: [token-server] Add Dockerfile for CI deployments.
Mar 9 2024, 08:09

Mar 8 2024

Fabien added inline comments to D15665: [Chronik] Add Docusaurus documentation.
Mar 8 2024, 20:32
Fabien requested changes to D15661: [token-server] Add Dockerfile for CI deployments.
Mar 8 2024, 20:29
Fabien closed D15654: [guix] Create a print the SHA256SUMS file.
Mar 8 2024, 16:21
Fabien committed rABC3d8909f8154b: [guix] Create a print the SHA256SUMS file (authored by Fabien).
[guix] Create a print the SHA256SUMS file
Mar 8 2024, 16:21
Fabien requested changes to D15661: [token-server] Add Dockerfile for CI deployments.
Mar 8 2024, 16:19
Fabien requested review of D15654: [guix] Create a print the SHA256SUMS file.
Mar 8 2024, 10:40
Fabien accepted D15642: [guix] build the the source package only once.
Mar 8 2024, 08:59

Mar 7 2024

Fabien closed D15651: [cmake] Fix git short length.
Mar 7 2024, 16:57
Fabien committed rABC71c3d41fe595: [cmake] Fix git short length (authored by Fabien).
[cmake] Fix git short length
Mar 7 2024, 16:57
Fabien retitled D15651: [cmake] Fix git short length from [guix] Fix git short length to [cmake] Fix git short length.
Mar 7 2024, 16:56
Fabien updated the diff for D15651: [cmake] Fix git short length.

Remove the guix-build where it's useless

Mar 7 2024, 16:55
Fabien requested review of D15651: [cmake] Fix git short length.
Mar 7 2024, 16:45
Fabien closed D15650: [guix] Fix source package.
Mar 7 2024, 16:36
Fabien committed rABC84e65ddd3223: [guix] Fix source package (authored by Fabien).
[guix] Fix source package
Mar 7 2024, 16:36
Fabien requested review of D15650: [guix] Fix source package.
Mar 7 2024, 15:45
Fabien closed D15649: [guix] Remove unused geniso override.
Mar 7 2024, 15:04
Fabien committed rABC1aa7171bd787: [guix] Remove unused geniso override (authored by Fabien).
[guix] Remove unused geniso override
Mar 7 2024, 15:04
Fabien closed D15648: [guix] Deduplicate the tar options and sort the source package.
Mar 7 2024, 12:05