Page MenuHomePhabricator
Feed Advanced Search

Mar 30 2024

PiRK committed rABC9d6dc4d896f4: refactor: use chainman instead of chainParams for DeploymentActive* (authored by PiRK).
refactor: use chainman instead of chainParams for DeploymentActive*
Mar 30 2024, 17:23
PiRK committed rABC1b7ae36ae758: Move ::nMaxTipAge into ChainstateManager (authored by MacroFake <falke.marco@gmail.com>).
Move ::nMaxTipAge into ChainstateManager
Mar 30 2024, 17:23
PiRK closed D15807: get config via chainstatemanager when possible (4/n).
Mar 30 2024, 17:23
PiRK committed rABC424d0fc3f6c1: get config via chainstatemanager when possible (5/5) (authored by PiRK).
get config via chainstatemanager when possible (5/5)
Mar 30 2024, 17:23
PiRK closed D15808: get config via chainstatemanager when possible (5/5).
Mar 30 2024, 17:23
PiRK committed rABC625015f9d64e: get config via chainstatemanager when possible (4/n) (authored by PiRK).
get config via chainstatemanager when possible (4/n)
Mar 30 2024, 17:23
PiRK closed D15802: make checkpoints_tests work with the same Config as the rest of the validation code.
Mar 30 2024, 17:23
PiRK committed rABCe4521cbbe266: make checkpoints_tests work with the same Config as the rest of the validation… (authored by PiRK).
make checkpoints_tests work with the same Config as the rest of the validation…
Mar 30 2024, 17:23
PiRK requested review of D15812: Move ::hashAssumeValid into ChainstateManager.
Mar 30 2024, 10:16
PiRK added inline comments to D15813: Move ::nMinimumChainWork into ChainstateManager.
Mar 30 2024, 09:22
PiRK updated the test plan for D15812: Move ::hashAssumeValid into ChainstateManager.
Mar 30 2024, 09:16
PiRK updated the diff for D15802: make checkpoints_tests work with the same Config as the rest of the validation code.

address feedback

Mar 30 2024, 09:14

Mar 29 2024

teamcity awarded D15812: Move ::hashAssumeValid into ChainstateManager a Haypence token.
Mar 29 2024, 15:43
PiRK requested review of D15815: Move ::fCheckBlockIndex into ChainstateManager.
Mar 29 2024, 14:56
PiRK requested review of D15814: Move ::fCheckpointsEnabled into ChainstateManager.
Mar 29 2024, 14:54
PiRK requested review of D15813: Move ::nMinimumChainWork into ChainstateManager.
Mar 29 2024, 14:52
PiRK requested review of D15812: Move ::hashAssumeValid into ChainstateManager.
Mar 29 2024, 14:49
PiRK requested review of D15811: Move ::nMaxTipAge into ChainstateManager.
Mar 29 2024, 14:47
PiRK updated the diff for D15809: refactor: use chainman instead of chainParams for DeploymentActive*.

remove unused args in lambda

Mar 29 2024, 08:59
PiRK planned changes to D15809: refactor: use chainman instead of chainParams for DeploymentActive*.

fix clang tidy warning

Mar 29 2024, 08:56
PiRK updated the summary of D15809: refactor: use chainman instead of chainParams for DeploymentActive*.
Mar 29 2024, 08:55
PiRK requested review of D15809: refactor: use chainman instead of chainParams for DeploymentActive*.
Mar 29 2024, 08:45
teamcity awarded D15808: get config via chainstatemanager when possible (5/5) a Haypence token.
Mar 29 2024, 08:37
PiRK added a comment to D15808: get config via chainstatemanager when possible (5/5).

@bot build-chronik

Mar 29 2024, 08:37
PiRK requested review of D15808: get config via chainstatemanager when possible (5/5).
Mar 29 2024, 08:23
PiRK requested review of D15807: get config via chainstatemanager when possible (4/n).
Mar 29 2024, 07:58
PiRK updated the diff for D15802: make checkpoints_tests work with the same Config as the rest of the validation code.

the config needs to be a global, or else we get a nullptr deref when the fixture is destructed.

Mar 29 2024, 07:25

Mar 28 2024

teamcity awarded D15802: make checkpoints_tests work with the same Config as the rest of the validation code a Haypence token.
Mar 28 2024, 22:33
PiRK added a comment to D15802: make checkpoints_tests work with the same Config as the rest of the validation code.

@bot build-tsan

Mar 28 2024, 22:33
PiRK requested review of D15802: make checkpoints_tests work with the same Config as the rest of the validation code.
Mar 28 2024, 19:30
PiRK closed D15799: fix chronikbridge_tests.
Mar 28 2024, 14:39
PiRK committed rABCf9248cd296c8: fix chronikbridge_tests (authored by PiRK).
fix chronikbridge_tests
Mar 28 2024, 14:39
PiRK updated the diff for D15799: fix chronikbridge_tests.

rebase

Mar 28 2024, 14:12
teamcity awarded D15799: fix chronikbridge_tests a Piece of Eight token.
Mar 28 2024, 14:10
PiRK added a comment to D15799: fix chronikbridge_tests.

@bot build-chronik

Mar 28 2024, 14:10
PiRK published D15799: fix chronikbridge_tests for review.
Mar 28 2024, 13:53
teamcity awarded D15799: fix chronikbridge_tests a Haypence token.
Mar 28 2024, 13:53
PiRK closed D15798: get config via chainstatemanager when possible (3/n).
Mar 28 2024, 13:02
PiRK committed rABCc8068cf3662a: get config via chainstatemanager when possible (3/n) (authored by PiRK).
get config via chainstatemanager when possible (3/n)
Mar 28 2024, 13:02
PiRK closed D15797: get config via chainstatemanager when possible (2/n).
Mar 28 2024, 13:02
PiRK committed rABC665bf5b1ec44: get config via chainstatemanager when possible (2/n) (authored by PiRK).
get config via chainstatemanager when possible (2/n)
Mar 28 2024, 13:02
PiRK closed D15796: get config via chainstatemanager when possible (1/n).
Mar 28 2024, 13:02
PiRK committed rABCbd69d55d4624: get config via chainstatemanager when possible (1/n) (authored by PiRK).
get config via chainstatemanager when possible (1/n)
Mar 28 2024, 13:02
PiRK closed D15795: refactor: move *index constants out of validation.
Mar 28 2024, 13:02
PiRK committed rABC7ecc35dd5443: refactor: move *index constants out of validation (authored by fanquake <fanquake@gmail.com>).
refactor: move *index constants out of validation
Mar 28 2024, 13:02
PiRK accepted D15793: [CI] Make sure to upload the artifacts upon failure.
Mar 28 2024, 11:50
PiRK requested review of D15798: get config via chainstatemanager when possible (3/n).
Mar 28 2024, 09:39
PiRK requested review of D15797: get config via chainstatemanager when possible (2/n).
Mar 28 2024, 09:38
PiRK updated the summary of D15796: get config via chainstatemanager when possible (1/n).
Mar 28 2024, 08:49
PiRK requested review of D15796: get config via chainstatemanager when possible (1/n).
Mar 28 2024, 08:39
PiRK requested review of D15795: refactor: move *index constants out of validation.
Mar 28 2024, 07:56

Mar 27 2024

PiRK closed D15792: refactor: add kernel/cs_main.*.
Mar 27 2024, 15:52
PiRK committed rABCfac25bdef1a4: refactor: add kernel/cs_main.* (authored by fanquake <fanquake@gmail.com>).
refactor: add kernel/cs_main.*
Mar 27 2024, 15:52
PiRK closed D15789: remove coinbase spend tracking in CTxMemPoolEntry.
Mar 27 2024, 15:52
PiRK closed D15790: Move CTxMemPoolEntry class to its own module and inline class's function.
Mar 27 2024, 15:52
PiRK committed rABC1ce42143fd2c: Move CTxMemPoolEntry class to its own module and inline class's function (authored by PiRK).
Move CTxMemPoolEntry class to its own module and inline class's function
Mar 27 2024, 15:52
PiRK committed rABC5f461d35eff6: remove coinbase spend tracking in CTxMemPoolEntry (authored by PiRK).
remove coinbase spend tracking in CTxMemPoolEntry
Mar 27 2024, 15:52
PiRK closed D15788: cleanup more unused code after removal of chained-tx logic (TestLockPointValidity).
Mar 27 2024, 15:52
PiRK committed rABC6b9dd55f580a: cleanup more unused code after removal of chained-tx logic… (authored by PiRK).
cleanup more unused code after removal of chained-tx logic…
Mar 27 2024, 15:52
PiRK updated the diff for D15792: refactor: add kernel/cs_main.*.

found another candidate (see D8525)

Mar 27 2024, 14:33
PiRK updated the summary of D15792: refactor: add kernel/cs_main.*.
Mar 27 2024, 14:27
PiRK requested review of D15792: refactor: add kernel/cs_main.*.
Mar 27 2024, 14:21
PiRK added inline comments to D15790: Move CTxMemPoolEntry class to its own module and inline class's function.
Mar 27 2024, 14:19
PiRK published D15790: Move CTxMemPoolEntry class to its own module and inline class's function for review.
Mar 27 2024, 11:12
teamcity awarded D15790: Move CTxMemPoolEntry class to its own module and inline class's function a Haypence token.
Mar 27 2024, 11:12
PiRK retitled D15789: remove coinbase spend tracking in CTxMemPoolEntry from emove coinbase spend tracking in CTxMemPoolEntry to remove coinbase spend tracking in CTxMemPoolEntry.
Mar 27 2024, 10:00
PiRK published D15789: remove coinbase spend tracking in CTxMemPoolEntry for review.
Mar 27 2024, 09:59
PiRK retitled D15788: cleanup more unused code after removal of chained-tx logic (TestLockPointValidity) from cleanup more unused code after removal of chained-tx logic to cleanup more unused code after removal of chained-tx logic (TestLockPointValidity).
Mar 27 2024, 09:27
PiRK updated the summary of D15788: cleanup more unused code after removal of chained-tx logic (TestLockPointValidity).
Mar 27 2024, 09:24
PiRK requested review of D15788: cleanup more unused code after removal of chained-tx logic (TestLockPointValidity).
Mar 27 2024, 09:18
PiRK accepted D15786: Move DisconnectedBlockTransactions to its own file.
Mar 27 2024, 07:35

Mar 26 2024

PiRK closed D15756: Remove ::dustRelayFee global.
Mar 26 2024, 17:00
PiRK committed rABC5c5d6168a00d: Remove ::dustRelayFee global (authored by MacroFake <falke.marco@gmail.com>).
Remove ::dustRelayFee global
Mar 26 2024, 17:00
PiRK added inline comments to D15786: Move DisconnectedBlockTransactions to its own file.
Mar 26 2024, 16:05
PiRK accepted D15785: [mempool] Make DisconnectedBlockTransactions responsible for removing txs from the mempool after a block is connected.
Mar 26 2024, 15:46
PiRK updated the summary of D15756: Remove ::dustRelayFee global.
Mar 26 2024, 15:30
PiRK published D15756: Remove ::dustRelayFee global for review.
Mar 26 2024, 15:30
PiRK closed D15778: remove ::fAcceptDatacarrier global.
Mar 26 2024, 14:18
PiRK committed rABCfcf58d6bd71c: remove ::fAcceptDatacarrier global (authored by PiRK).
remove ::fAcceptDatacarrier global
Mar 26 2024, 14:18
PiRK accepted D15781: [avalanche] Reject blocks that contains txs conflicting with finalized txs.
Mar 26 2024, 14:17
PiRK updated the summary of D15778: remove ::fAcceptDatacarrier global.
Mar 26 2024, 10:18
PiRK updated the diff for D15778: remove ::fAcceptDatacarrier global.

remove the ArgsManager shortcut, the parsing of arguments is now only needed in one place

Mar 26 2024, 08:10
PiRK closed D15780: fix includes in standard.{h|cpp}.
Mar 26 2024, 07:51
PiRK committed rABC4b15b2af0406: fix includes in standard.{h|cpp} (authored by PiRK).
fix includes in standard.{h|cpp}
Mar 26 2024, 07:51

Mar 25 2024

PiRK planned changes to D15778: remove ::fAcceptDatacarrier global.

the system.h changes are no longer required, the args inspection code can be moved to mempool_options.h

Mar 25 2024, 16:24
PiRK updated the diff for D15778: remove ::fAcceptDatacarrier global.

revert most avalanche changes, wrap IsStandard for the purpose of checking a proof's validity

Mar 25 2024, 15:42
PiRK updated the summary of D15780: fix includes in standard.{h|cpp}.
Mar 25 2024, 14:42
PiRK accepted D15779: [avalanche] Check the node can mine a finalized tx.
Mar 25 2024, 14:41
PiRK updated the diff for D15780: fix includes in standard.{h|cpp}.

don't remove the uint256.h include (uint160 needed for templates) and don't confuse uint256 with sha256

Mar 25 2024, 14:40
PiRK updated the diff for D15778: remove ::fAcceptDatacarrier global.

MakeProcessor takes argsman as a parameter, no need to access it via the global gArgs

Mar 25 2024, 14:30
PiRK updated the diff for D15778: remove ::fAcceptDatacarrier global.

rebase onto D15780

Mar 25 2024, 14:25
PiRK requested review of D15780: fix includes in standard.{h|cpp}.
Mar 25 2024, 14:23
PiRK closed D15777: Remove ::GetVirtualTransactionSize() alias.
Mar 25 2024, 13:45
PiRK closed D15757: Remove ::fIsBareMultisigStd global.
Mar 25 2024, 13:45
PiRK committed rABCfb43a8161191: Remove ::fIsBareMultisigStd global (authored by MacroFake <falke.marco@gmail.com>).
Remove ::fIsBareMultisigStd global
Mar 25 2024, 13:45
PiRK committed rABC6341c2a89327: Remove ::GetVirtualTransactionSize() alias (authored by MacroFake <falke.marco@gmail.com>).
Remove ::GetVirtualTransactionSize() alias
Mar 25 2024, 13:45
PiRK closed D15755: Remove ::IsStandardTx(tx, reason) alias.
Mar 25 2024, 13:45
PiRK closed D15754: test: Remove unused cs_main.
Mar 25 2024, 13:44
PiRK committed rABC2692dad01c14: Remove ::IsStandardTx(tx, reason) alias (authored by MacroFake <falke.marco@gmail.com>).
Remove ::IsStandardTx(tx, reason) alias
Mar 25 2024, 13:44
PiRK committed rABC9bbe839c31b7: test: Remove unused cs_main (authored by MacroFake <falke.marco@gmail.com>).
test: Remove unused cs_main
Mar 25 2024, 13:44