Page MenuHomePhabricator
Feed Advanced Search

May 16 2024

PiRK closed D16154: refactor: Move fs.* to util/fs.*.
May 16 2024, 08:30
PiRK committed rABC83169f5396a0: refactor: Move fs.* to util/fs.* (authored by PiRK).
refactor: Move fs.* to util/fs.*
May 16 2024, 08:30
PiRK closed D16153: Add missing includes in assumptions.h and chainstate.cpp.
May 16 2024, 08:30
PiRK committed rABCc7e566a3fa1c: Add missing includes in assumptions.h and chainstate.cpp (authored by TheCharlatan <seb.kung@gmail.com>).
Add missing includes in assumptions.h and chainstate.cpp
May 16 2024, 08:30
teamcity awarded D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods a Haypence token.
May 16 2024, 07:57

May 15 2024

PiRK accepted D16168: Add a checkpoint after the May 15 2024 upgrade.
May 15 2024, 14:57
PiRK requested review of D16162: coins: add Sync() method to allow flush without cacheCoins drop.
May 15 2024, 12:05
PiRK requested review of D16161: test: refactor: clarify the coins simulation.
May 15 2024, 12:02
PiRK accepted D16160: [Cashtab] Show exact XEC amount sent or received in XEC tx history if user clicks tx.
May 15 2024, 06:21
PiRK accepted D16159: [Cashtab] Bump extension version to update published version to latest master.
May 15 2024, 06:19

May 14 2024

PiRK added inline comments to D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.
May 14 2024, 13:32
PiRK requested review of D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.
May 14 2024, 13:26
PiRK requested review of D16155: Move random test util code from setup_common to random.
May 14 2024, 13:24
PiRK updated the summary of D16154: refactor: Move fs.* to util/fs.*.
May 14 2024, 11:01
PiRK requested review of D16154: refactor: Move fs.* to util/fs.*.
May 14 2024, 11:01
PiRK requested review of D16153: Add missing includes in assumptions.h and chainstate.cpp.
May 14 2024, 10:59
PiRK closed D16152: misc fixes for file syncing.
May 14 2024, 10:41
PiRK committed rABCf16a9739fdd4: misc fixes for file syncing (authored by PiRK).
misc fixes for file syncing
May 14 2024, 10:41
PiRK closed D16151: refactor: Extract util/fs_helpers from util/system.
May 14 2024, 10:41
PiRK closed D16150: refactor: Move error() from util/system.h to logging.h.
May 14 2024, 10:41
PiRK committed rABC0d0aa0ec5fa8: refactor: Extract util/fs_helpers from util/system (authored by Ben Woosley <ben.woosley@gmail.com>).
refactor: Extract util/fs_helpers from util/system
May 14 2024, 10:41
PiRK committed rABC5d2f0941ddff: refactor: Move error() from util/system.h to logging.h (authored by Ben Woosley <ben.woosley@gmail.com>).
refactor: Move error() from util/system.h to logging.h
May 14 2024, 10:41
PiRK closed D16149: refactor: Extract util/exception from util/system.
May 14 2024, 10:41
PiRK committed rABCffcb9d86e747: refactor: Extract util/exception from util/system (authored by Ben Woosley <ben.woosley@gmail.com>).
refactor: Extract util/exception from util/system
May 14 2024, 10:41
teamcity awarded D16152: misc fixes for file syncing a Haypence token.
May 14 2024, 08:12
PiRK updated the test plan for D16152: misc fixes for file syncing.
May 14 2024, 07:53
PiRK updated the summary of D16152: misc fixes for file syncing.
May 14 2024, 07:52
PiRK requested review of D16152: misc fixes for file syncing.
May 14 2024, 07:51

May 13 2024

PiRK closed D16146: refactor: Drop no longer used `swap` member functions.
May 13 2024, 16:48
PiRK closed D16148: clang-tidy: Fix modernize-use-default-member-init in `CScriptCheck`.
May 13 2024, 16:48
PiRK closed D16147: test: Default initialize `should_freeze` to `true`.
May 13 2024, 16:48
PiRK committed rABC7a6f1e8c111d: clang-tidy: Fix modernize-use-default-member-init in `CScriptCheck` (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
clang-tidy: Fix modernize-use-default-member-init in `CScriptCheck`
May 13 2024, 16:48
PiRK committed rABC47fe5d39de37: refactor: Drop no longer used `swap` member functions (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Drop no longer used `swap` member functions
May 13 2024, 16:48
PiRK committed rABC8bdd266333c9: test: Default initialize `should_freeze` to `true` (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
test: Default initialize `should_freeze` to `true`
May 13 2024, 16:48
PiRK closed D16145: refactor: Use move semantics in `CCheckQueue::Loop`.
May 13 2024, 16:48
PiRK closed D16144: refactor: Use move semantics in `CCheckQueue::Add`.
May 13 2024, 16:48
PiRK committed rABCdc6291bb0c0f: refactor: Use move semantics in `CCheckQueue::Add` (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Use move semantics in `CCheckQueue::Add`
May 13 2024, 16:48
PiRK committed rABC600ecb007d3a: refactor: Use move semantics in `CCheckQueue::Loop` (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Use move semantics in `CCheckQueue::Loop`
May 13 2024, 16:48
PiRK closed D16143: refactor: Avoid CScriptCheck::swap.
May 13 2024, 16:48
PiRK committed rABCb3e09635eb70: refactor: Avoid CScriptCheck::swap (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Avoid CScriptCheck::swap
May 13 2024, 16:48
PiRK requested review of D16151: refactor: Extract util/fs_helpers from util/system.
May 13 2024, 16:46
PiRK requested review of D16150: refactor: Move error() from util/system.h to logging.h.
May 13 2024, 16:42
PiRK requested review of D16149: refactor: Extract util/exception from util/system.
May 13 2024, 16:40
teamcity awarded D16145: refactor: Use move semantics in `CCheckQueue::Loop` a Haypence token.
May 13 2024, 13:59
teamcity awarded D16144: refactor: Use move semantics in `CCheckQueue::Add` a Haypence token.
May 13 2024, 13:48
PiRK requested review of D16148: clang-tidy: Fix modernize-use-default-member-init in `CScriptCheck`.
May 13 2024, 06:56
PiRK requested review of D16147: test: Default initialize `should_freeze` to `true`.
May 13 2024, 06:55
PiRK requested review of D16146: refactor: Drop no longer used `swap` member functions.
May 13 2024, 06:53
PiRK requested review of D16145: refactor: Use move semantics in `CCheckQueue::Loop`.
May 13 2024, 06:52
PiRK requested review of D16144: refactor: Use move semantics in `CCheckQueue::Add`.
May 13 2024, 06:50
PiRK requested review of D16143: refactor: Avoid CScriptCheck::swap.
May 13 2024, 06:49
PiRK closed D16124: Split non/kernel chainparams.
May 13 2024, 05:47
PiRK committed rABC6807143b114f: Split non/kernel chainparams (authored by PiRK).
Split non/kernel chainparams
May 13 2024, 05:47

May 9 2024

PiRK accepted D16137: [nsis] Fix build error due to images not found.
May 9 2024, 09:54
PiRK accepted D16136: [e.cash] Improve upgrade version wording.
May 9 2024, 09:48

May 7 2024

PiRK closed D16117: get config via ChainstateManager when it is reachable.
May 7 2024, 10:44
PiRK committed rABC21770c4bb1b0: get config via ChainstateManager when it is reachable (authored by PiRK).
get config via ChainstateManager when it is reachable
May 7 2024, 10:44
PiRK requested review of D16124: Split non/kernel chainparams.
May 7 2024, 10:43

May 6 2024

PiRK closed D16114: Decouple ChainParams from ArgsManager, add factory functions.
May 6 2024, 14:14
PiRK committed rABCfe7f869a3c96: Decouple ChainParams from ArgsManager, add factory functions (authored by PiRK).
Decouple ChainParams from ArgsManager, add factory functions
May 6 2024, 14:14
PiRK closed D16108: move DummyConfig to test/util/setup_common.h.
May 6 2024, 14:14
PiRK committed rABC7eb1a738fe5d: move DummyConfig to test/util/setup_common.h (authored by PiRK).
move DummyConfig to test/util/setup_common.h
May 6 2024, 14:14
PiRK closed D16116: [chronik] get consensus params via chainman.
May 6 2024, 14:13
PiRK committed rABCfdaa22f51a9b: [chronik] get consensus params via chainman (authored by PiRK).
[chronik] get consensus params via chainman
May 6 2024, 14:13
PiRK updated the diff for D16117: get config via ChainstateManager when it is reachable.

fix transaction_tests by using a ChainTestingSetup in the test that needs consensus params

May 6 2024, 13:54
PiRK updated the diff for D16116: [chronik] get consensus params via chainman.

add an Assert(node.chainman) to ensure the chainman is not nullptr, as the ChronikBridge code heavily depends on that.
Note that in the current state of the codebase this is already done in init.cpp before calling chronik::Start(config, node, fReindexChronik), but it doesn't hurt to check again for all case where ChronikBridge is instantiated directly (unit tests)

May 6 2024, 13:48
PiRK planned changes to D16117: get config via ChainstateManager when it is reachable.
May 6 2024, 13:37
PiRK updated the diff for D16114: Decouple ChainParams from ArgsManager, add factory functions.

fix accidental :wq, convert a gArgs into args

May 6 2024, 13:13
PiRK added inline comments to D16114: Decouple ChainParams from ArgsManager, add factory functions.
May 6 2024, 13:08
PiRK added inline comments to D16116: [chronik] get consensus params via chainman.
May 6 2024, 13:07
PiRK requested review of D16117: get config via ChainstateManager when it is reachable.
May 6 2024, 13:06
PiRK requested review of D16116: [chronik] get consensus params via chainman.
May 6 2024, 12:27
PiRK closed D16104: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`.
May 6 2024, 11:54
PiRK committed rABC22f5560fd2f6: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()` (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`
May 6 2024, 11:54
PiRK closed D16102: prune: scan and unlink already pruned block files on startup.
May 6 2024, 11:54
PiRK committed rABC7b4e342de013: prune: scan and unlink already pruned block files on startup (authored by Andrew Toth <andrewstoth@gmail.com>).
prune: scan and unlink already pruned block files on startup
May 6 2024, 11:54
PiRK updated the diff for D16104: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`.

fix doxygen comment for lock_points (remove duplicated part of a sentence from the coins_view doxygen comment from the previous function)

May 6 2024, 09:43
PiRK updated the diff for D16114: Decouple ChainParams from ArgsManager, add factory functions.

make chainparams const in fuzzer, add bitcoin-fuzzers to test plan

May 6 2024, 09:37
PiRK accepted D16115: [guix] Better SHA256SUMS format.
May 6 2024, 09:32
teamcity awarded D16104: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()` a Haypence token.
May 6 2024, 08:01
PiRK requested review of D16114: Decouple ChainParams from ArgsManager, add factory functions.
May 6 2024, 07:46

May 3 2024

PiRK updated the summary of D16108: move DummyConfig to test/util/setup_common.h.
May 3 2024, 16:28
PiRK requested review of D16108: move DummyConfig to test/util/setup_common.h.
May 3 2024, 16:26
PiRK accepted D16103: [chronik-client] Add noban permission to cut p2p delays in the websocket test.
May 3 2024, 13:58
PiRK updated the diff for D16104: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`.

remove unneeded max_input_height computation in CalculateLockPointsAtTip

May 3 2024, 13:58
PiRK planned changes to D16104: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`.

i think i need to remove some unused code

May 3 2024, 13:54
PiRK updated the diff for D16104: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`.

use tx.GetId()

May 3 2024, 13:50
PiRK published D16104: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()` for review.
May 3 2024, 13:45
PiRK updated the diff for D16102: prune: scan and unlink already pruned block files on startup.

better variable name

May 3 2024, 12:42
PiRK updated the diff for D16102: prune: scan and unlink already pruned block files on startup.

nit: make file permission and shebang conistent with other functional tests

May 3 2024, 09:36
PiRK closed D16101: Bump version to 0.29.4.
May 3 2024, 09:33
PiRK committed rABC335598bb616c: Bump version to 0.29.4 (authored by PiRK).
Bump version to 0.29.4
May 3 2024, 09:33
PiRK requested review of D16102: prune: scan and unlink already pruned block files on startup.
May 3 2024, 09:32
PiRK requested review of D16101: Bump version to 0.29.4.
May 3 2024, 08:46
PiRK closed D16093: refactor, txdb: Use DBParams struct in CBlockTreeDB.
May 3 2024, 08:34
PiRK closed D16094: refactor, validation: Add ChainstateManagerOpts db options.
May 3 2024, 08:34
PiRK committed rABCef56c603f71c: refactor, validation: Add ChainstateManagerOpts db options (authored by Ryan Ofsky <ryan@ofsky.org>).
refactor, validation: Add ChainstateManagerOpts db options
May 3 2024, 08:34
PiRK committed rABC1cf4a86ce123: refactor, txdb: Use DBParams struct in CBlockTreeDB (authored by Ryan Ofsky <ryan@ofsky.org>).
refactor, txdb: Use DBParams struct in CBlockTreeDB
May 3 2024, 08:34
PiRK closed D16092: refactor, txdb: Add CoinsViewOptions struct.
May 3 2024, 08:34
PiRK closed D16091: refactor, dbwrapper: Add DBParams and DBOptions structs.
May 3 2024, 08:34