Page MenuHomePhabricator
Feed Advanced Search

May 22 2024

PiRK added inline comments to D16203: add missing includes and remove unneeded ones.
May 22 2024, 15:06
PiRK requested review of D16203: add missing includes and remove unneeded ones.
May 22 2024, 15:03
PiRK added a comment to D16202: move-only: Extract common/args and common/config.cpp from util/system.

Fixing the includes in args.h and system.h makes these missing includes (mostly logging.h) necessary. I can add them in a previous diff to limit this diff to args.h and system.h

May 22 2024, 14:40
PiRK closed D16201: util, refactor: Drop explicit conversion to fs::path.
May 22 2024, 14:29
PiRK committed rABCe83d4c55116c: util, refactor: Drop explicit conversion to fs::path (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
util, refactor: Drop explicit conversion to fs::path
May 22 2024, 14:29
PiRK closed D16200: util, refactor: Use GetPathArg to read "-rpccookiefile" value.
May 22 2024, 14:29
PiRK committed rABC488cdcd7aa94: util, refactor: Use GetPathArg to read "-rpccookiefile" value (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
util, refactor: Use GetPathArg to read "-rpccookiefile" value
May 22 2024, 14:29
PiRK added inline comments to D16202: move-only: Extract common/args and common/config.cpp from util/system.
May 22 2024, 14:22
PiRK added a comment to D16178: Use PoolAllocator for CCoinsMap.

Same benchmark with the data on a SSD disk:

May 22 2024, 14:18
PiRK updated the diff for D16202: move-only: Extract common/args and common/config.cpp from util/system.

nit: alphabetical sorting in CMakeLists.txt

May 22 2024, 11:53
PiRK requested review of D16202: move-only: Extract common/args and common/config.cpp from util/system.
May 22 2024, 11:46
PiRK closed D16199: util, refactor: Use GetPathArg to read "-conf" value.
May 22 2024, 08:26
PiRK committed rABCb57de34fea69: util, refactor: Use GetPathArg to read "-conf" value (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
util, refactor: Use GetPathArg to read "-conf" value
May 22 2024, 08:26
PiRK requested review of D16201: util, refactor: Drop explicit conversion to fs::path.
May 22 2024, 07:13
PiRK requested review of D16200: util, refactor: Use GetPathArg to read "-rpccookiefile" value.
May 22 2024, 07:12
teamcity awarded D16199: util, refactor: Use GetPathArg to read "-conf" value a Haypence token.
May 22 2024, 07:05
PiRK added a comment to D16199: util, refactor: Use GetPathArg to read "-conf" value.

@bot build-win64

May 22 2024, 07:05
PiRK requested review of D16199: util, refactor: Use GetPathArg to read "-conf" value.
May 22 2024, 07:05
PiRK closed D16193: util: make GetDataDir read-only & create datadir only in bitcoind and bitcoin-qt.
May 22 2024, 05:49
PiRK closed D16195: refactor: Stop using gArgs global in system.cpp.
May 22 2024, 05:49
PiRK committed rABC946cd1a1f86a: refactor: Stop using gArgs global in system.cpp (authored by Ryan Ofsky <ryan@ofsky.org>).
refactor: Stop using gArgs global in system.cpp
May 22 2024, 05:49
PiRK committed rABCf8f02358c908: util: make GetDataDir read-only & create datadir only in bitcoind and bitcoin-qt (authored by willcl-ark <will@256k1.dev>).
util: make GetDataDir read-only & create datadir only in bitcoind and bitcoin-qt
May 22 2024, 05:49
PiRK closed D16192: gui: Prompt to reset settings when settings.json cannot be read.
May 22 2024, 05:48
PiRK committed rABC62f6ad9702ad: gui: Prompt to reset settings when settings.json cannot be read (authored by Russell Yanofsky <russ@yanofsky.org>).
gui: Prompt to reset settings when settings.json cannot be read
May 22 2024, 05:48
PiRK accepted D16198: Don't use a PeerManager for the net group limit test.
May 22 2024, 05:47

May 21 2024

PiRK requested review of D16195: refactor: Stop using gArgs global in system.cpp.
May 21 2024, 15:16
PiRK updated the diff for D16193: util: make GetDataDir read-only & create datadir only in bitcoind and bitcoin-qt.

review

May 21 2024, 15:08
PiRK closed D16185: refactor, BlockManager: Replace fastprune from arg with options.
May 21 2024, 15:00
PiRK closed D16187: refactor, blockstorage: Replace stopafterblockimport arg.
May 21 2024, 15:00
PiRK closed D16186: refactor, blockstorage: Replace blocksdir arg.
May 21 2024, 15:00
PiRK committed rABCff2bb4ba3632: refactor, blockstorage: Replace stopafterblockimport arg (authored by TheCharlatan <seb.kung@gmail.com>).
refactor, blockstorage: Replace stopafterblockimport arg
May 21 2024, 15:00
PiRK committed rABCd00ef4479e3c: refactor, blockstorage: Replace blocksdir arg (authored by TheCharlatan <seb.kung@gmail.com>).
refactor, blockstorage: Replace blocksdir arg
May 21 2024, 15:00
PiRK committed rABC4ebf2abf6302: refactor, BlockManager: Replace fastprune from arg with options (authored by PiRK).
refactor, BlockManager: Replace fastprune from arg with options
May 21 2024, 15:00
PiRK closed D16184: refactor: Move functions to BlockManager methods.
May 21 2024, 15:00
PiRK closed D16183: zmq: Pass lambda to zmq's ZMQPublishRawBlockNotifier.
May 21 2024, 15:00
PiRK committed rABC99f7dd2d8b85: refactor: Move functions to BlockManager methods (authored by TheCharlatan <seb.kung@gmail.com>).
refactor: Move functions to BlockManager methods
May 21 2024, 15:00
PiRK committed rABCe84814fc26e1: zmq: Pass lambda to zmq's ZMQPublishRawBlockNotifier (authored by TheCharlatan <seb.kung@gmail.com>).
zmq: Pass lambda to zmq's ZMQPublishRawBlockNotifier
May 21 2024, 15:00
PiRK closed D16182: refactor: Declare g_zmq_notification_interface as unique_ptr.
May 21 2024, 15:00
PiRK committed rABC1b5e4c74d4d5: refactor: Declare g_zmq_notification_interface as unique_ptr (authored by TheCharlatan <seb.kung@gmail.com>).
refactor: Declare g_zmq_notification_interface as unique_ptr
May 21 2024, 15:00
PiRK accepted D16194: [chronik] Wait for the correct tip finalization in chronik_ws_ordering.
May 21 2024, 14:38
PiRK accepted D16191: Consistently delete nodes at the end of the net tests.
May 21 2024, 14:36
PiRK requested review of D16193: util: make GetDataDir read-only & create datadir only in bitcoind and bitcoin-qt.
May 21 2024, 14:15
PiRK requested review of D16192: gui: Prompt to reset settings when settings.json cannot be read.
May 21 2024, 14:09
PiRK added inline comments to D16184: refactor: Move functions to BlockManager methods.
May 21 2024, 09:43
PiRK updated the diff for D16184: refactor: Move functions to BlockManager methods.

move GetFirstStoredBlock as well (core#25016), remove leftover TODO

May 21 2024, 09:41
PiRK closed D16189: fix check-crates target.
May 21 2024, 09:26
PiRK committed rABC3db48ecde096: fix check-crates target (authored by PiRK).
fix check-crates target
May 21 2024, 09:26
PiRK updated the diff for D16184: refactor: Move functions to BlockManager methods.

rebase (check-crates should be fixed by D16189)

May 21 2024, 07:27
PiRK added a comment to D16182: refactor: Declare g_zmq_notification_interface as unique_ptr.

mq

May 21 2024, 07:20
teamcity awarded D16189: fix check-crates target a Haypence token.
May 21 2024, 07:01
PiRK added a comment to D16189: fix check-crates target.

@bot build-chronik

May 21 2024, 07:01
PiRK requested review of D16189: fix check-crates target.
May 21 2024, 07:00
PiRK added a comment to D16134: [chronik-client]+[alias-server]+[examples] Use local dep instead of npm.

@bot build-chronik

May 21 2024, 06:23
PiRK accepted D16181: [avalanche] Improve logging on staking reward.
May 21 2024, 06:06

May 20 2024

PiRK closed D16178: Use PoolAllocator for CCoinsMap.
May 20 2024, 15:46
PiRK closed D16177: Call ReallocateCache() on each Flush().
May 20 2024, 15:46
PiRK committed rABC4bf7aca6146c: Use PoolAllocator for CCoinsMap (authored by Martin Leitner-Ankerl <martin.ankerl@gmail.com>).
Use PoolAllocator for CCoinsMap
May 20 2024, 15:46
PiRK committed rABC4b916c68bdc2: Call ReallocateCache() on each Flush() (authored by Martin Leitner-Ankerl <martin.ankerl@gmail.com>).
Call ReallocateCache() on each Flush()
May 20 2024, 15:46
PiRK closed D16175: Add pool based memory resource & allocator.
May 20 2024, 15:46
PiRK closed D16176: Calculate memory usage correctly for unordered_maps that use PoolAllocator.
May 20 2024, 15:46
PiRK committed rABC574f749bd839: Calculate memory usage correctly for unordered_maps that use PoolAllocator (authored by Martin Leitner-Ankerl <martin.ankerl@gmail.com>).
Calculate memory usage correctly for unordered_maps that use PoolAllocator
May 20 2024, 15:46
PiRK committed rABCf93eddc5bfa5: Add pool based memory resource & allocator (authored by Martin Leitner-Ankerl <martin.ankerl@gmail.com>).
Add pool based memory resource & allocator
May 20 2024, 15:46
PiRK closed D16174: Add simulation-based CCoinsViewCache fuzzer.
May 20 2024, 15:46
PiRK committed rABCda80299db64c: Add simulation-based CCoinsViewCache fuzzer (authored by Pieter Wuille <pieter@wuille.net>).
Add simulation-based CCoinsViewCache fuzzer
May 20 2024, 15:46
PiRK requested review of D16187: refactor, blockstorage: Replace stopafterblockimport arg.
May 20 2024, 09:53
PiRK requested review of D16186: refactor, blockstorage: Replace blocksdir arg.
May 20 2024, 09:51
PiRK requested review of D16185: refactor, BlockManager: Replace fastprune from arg with options.
May 20 2024, 09:49
PiRK requested review of D16184: refactor: Move functions to BlockManager methods.
May 20 2024, 09:47
PiRK requested review of D16183: zmq: Pass lambda to zmq's ZMQPublishRawBlockNotifier.
May 20 2024, 09:45
PiRK requested review of D16182: refactor: Declare g_zmq_notification_interface as unique_ptr.
May 20 2024, 09:43

May 17 2024

PiRK updated the summary of D16176: Calculate memory usage correctly for unordered_maps that use PoolAllocator.
May 17 2024, 17:41
PiRK updated the summary of D16178: Use PoolAllocator for CCoinsMap.
May 17 2024, 17:35
PiRK updated the summary of D16178: Use PoolAllocator for CCoinsMap.
May 17 2024, 17:33
PiRK published D16178: Use PoolAllocator for CCoinsMap for review.
May 17 2024, 17:30
PiRK published D16177: Call ReallocateCache() on each Flush() for review.
May 17 2024, 17:29
PiRK published D16176: Calculate memory usage correctly for unordered_maps that use PoolAllocator for review.
May 17 2024, 17:29
PiRK published D16175: Add pool based memory resource & allocator for review.
May 17 2024, 17:28
PiRK closed D16180: util: improve streams.h:FindByte() performance.
May 17 2024, 13:54
PiRK committed rABC3e657f8f3c1d: util: improve streams.h:FindByte() performance (authored by Larry Ruane <larryruane@gmail.com>).
util: improve streams.h:FindByte() performance
May 17 2024, 13:54
PiRK closed D16179: [bench] add streams findbyte.
May 17 2024, 13:54
PiRK committed rABCa2c47d769cc1: [bench] add streams findbyte (authored by gzhao408 <gzhao408@berkeley.edu>).
[bench] add streams findbyte
May 17 2024, 13:54
PiRK updated the diff for D16174: Add simulation-based CCoinsViewCache fuzzer.

fix comment layouts

May 17 2024, 10:25
PiRK updated the summary of D16180: util: improve streams.h:FindByte() performance.
May 17 2024, 08:36
PiRK requested review of D16180: util: improve streams.h:FindByte() performance.
May 17 2024, 08:26
PiRK requested review of D16179: [bench] add streams findbyte.
May 17 2024, 08:23

May 16 2024

teamcity awarded D16178: Use PoolAllocator for CCoinsMap a Haypence token.
May 16 2024, 14:41
teamcity awarded D16176: Calculate memory usage correctly for unordered_maps that use PoolAllocator a Haypence token.
May 16 2024, 14:41
PiRK requested review of D16174: Add simulation-based CCoinsViewCache fuzzer.
May 16 2024, 12:25
PiRK closed D16162: coins: add Sync() method to allow flush without cacheCoins drop.
May 16 2024, 11:57
PiRK committed rABCd80b4c6190eb: coins: add Sync() method to allow flush without cacheCoins drop (authored by James O'Beirne <james.obeirne@gmail.com>).
coins: add Sync() method to allow flush without cacheCoins drop
May 16 2024, 11:57
PiRK closed D16161: test: refactor: clarify the coins simulation.
May 16 2024, 11:57
PiRK closed D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.
May 16 2024, 11:57
PiRK committed rABC9006f52c6661: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods (authored by PiRK).
test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods
May 16 2024, 11:57
PiRK committed rABC44b0c160029a: test: refactor: clarify the coins simulation (authored by James O'Beirne <james.obeirne@gmail.com>).
test: refactor: clarify the coins simulation
May 16 2024, 11:57
PiRK closed D16155: Move random test util code from setup_common to random.
May 16 2024, 11:57
PiRK committed rABC4d970e2fdeef: Move random test util code from setup_common to random (authored by PiRK).
Move random test util code from setup_common to random
May 16 2024, 11:57
PiRK accepted D16173: Replace May 15, 2024 activation with Nov 15.
May 16 2024, 10:06
teamcity awarded D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods a Piece of Eight token.
May 16 2024, 08:45
PiRK added a comment to D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.

@bot build-linux32 build-linux-arm

May 16 2024, 08:45
PiRK updated the diff for D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.

test keeping 56 bytes CScript but adjusting COINS_SIZE to use the same value as Core

May 16 2024, 08:44