Page MenuHomePhabricator
Feed All Stories

Jul 15 2024

PiRK updated the diff for D16465: Seeder: Verify that nodes are on the correct chain.

add tests

Jul 15 2024, 13:09
Fabien added inline comments to D16465: Seeder: Verify that nodes are on the correct chain.
Jul 15 2024, 10:27
PiRK planned changes to D16465: Seeder: Verify that nodes are on the correct chain.

This one should be relatively easy to test (but hopefully without having to add a dependency to the main unit test framework like the source material does)

Jul 15 2024, 10:02
PiRK updated the diff for D16465: Seeder: Verify that nodes are on the correct chain.

doc layout

Jul 15 2024, 10:01
PiRK updated the diff for D16465: Seeder: Verify that nodes are on the correct chain.

improve comment, set range_check=false when calling ReadCompactSize to prevent the function from throwing if the net message is intentionnaly bad, don't duplicate MAX_HEADERS_RESULTS but include it via net_processing.h.

Jul 15 2024, 09:59
PiRK added inline comments to D16466: Seeder: Fix getaddr interval to actually query address lists once a day.
Jul 15 2024, 09:21
Fabien requested changes to D16466: Seeder: Fix getaddr interval to actually query address lists once a day.
Jul 15 2024, 08:59
Fabien requested changes to D16465: Seeder: Verify that nodes are on the correct chain.

You should add tests as you go

Jul 15 2024, 08:36
Fabien added a comment to D16462: [Cashtab] Copy amounts on clikc.

@assasin-k7 So now we have a title, and an idea of what you're trying to achieve.

Jul 15 2024, 07:57
Fabien abandoned D16464: [Cashtab] copu amounts on Click.
Jul 15 2024, 07:50
Fabien commandeered D16464: [Cashtab] copu amounts on Click.
Jul 15 2024, 07:50
teamcity updated the summary of D16466: Seeder: Fix getaddr interval to actually query address lists once a day.
Jul 15 2024, 07:46
PiRK requested review of D16466: Seeder: Fix getaddr interval to actually query address lists once a day.
Jul 15 2024, 07:46
PiRK added inline comments to D16465: Seeder: Verify that nodes are on the correct chain.
Jul 15 2024, 07:42
teamcity updated the summary of D16465: Seeder: Verify that nodes are on the correct chain.
Jul 15 2024, 07:39
PiRK requested review of D16465: Seeder: Verify that nodes are on the correct chain.
Jul 15 2024, 07:39
assasin-k7 requested review of D16464: [Cashtab] copu amounts on Click.
Jul 15 2024, 06:20
emack requested changes to D16462: [Cashtab] Copy amounts on clikc.

The actual change itself is not as described, you're merely fixing a typo - then title it as such.
You need to fix the linting errors before pushing. Do an arc lint locally.
Test plan needs to be something the reviewer can follow easily easily e.g.

  1. npm test
  2. click here, check blah...
Jul 15 2024, 05:14
assasin-k7 abandoned D16463: [Cashtab] Copy amounts on click.
Jul 15 2024, 04:06
assasin-k7 abandoned D16460: [Cashtab].
Jul 15 2024, 03:59
assasin-k7 requested review of D16463: [Cashtab] Copy amounts on click.
Jul 15 2024, 02:01
assasin-k7 requested review of D16462: [Cashtab] Copy amounts on clikc.
Jul 15 2024, 01:52

Jul 14 2024

teamcity triaged T3604: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Jul 14 2024, 22:29
abc-bot committed rABC7cb82183c82a: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Jul 14 2024, 21:19
abc-bot committed rABC7a54d5acb5b9: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Jul 14 2024, 21:09
bytesofman closed D16461: [Cashtab] Special handling for tx inputs that are required and do not require wallet signature.
Jul 14 2024, 12:47
bytesofman committed rABC65b1ea928880: [Cashtab] Special handling for tx inputs that are required and do not require… (authored by bytesofman).
[Cashtab] Special handling for tx inputs that are required and do not require…
Jul 14 2024, 12:47

Jul 13 2024

emack accepted D16461: [Cashtab] Special handling for tx inputs that are required and do not require wallet signature.
Jul 13 2024, 07:15
emack closed D16459: [Cashtab] Update paywall article link.
Jul 13 2024, 07:02
emack committed rABC0f69d70a11ba: [Cashtab] Update paywall article link (authored by emack).
[Cashtab] Update paywall article link
Jul 13 2024, 07:02
emack added inline comments to D16459: [Cashtab] Update paywall article link.
Jul 13 2024, 06:58
emack updated the diff for D16459: [Cashtab] Update paywall article link.

Version bump

Jul 13 2024, 06:57

Jul 12 2024

bytesofman published D16461: [Cashtab] Special handling for tx inputs that are required and do not require wallet signature for review.
Jul 12 2024, 21:20
bytesofman accepted D16459: [Cashtab] Update paywall article link.
Jul 12 2024, 19:42
Fabien requested changes to D16460: [Cashtab].

This has no title.
This has no rationale.
This has no test plan.
This is failing the linters.

Jul 12 2024, 18:26
assasin-k7 requested review of D16460: [Cashtab].
Jul 12 2024, 18:05
roqqit closed D16454: [avalanche] Fix bytes received tracking for avalanche messages.
Jul 12 2024, 15:54
roqqit committed rABC9065327743ae: [avalanche] Fix bytes received tracking for avalanche messages (authored by roqqit).
[avalanche] Fix bytes received tracking for avalanche messages
Jul 12 2024, 15:54
emack published D16459: [Cashtab] Update paywall article link for review.
Jul 12 2024, 14:44
PiRK closed D16457: net_processing: move avalanche related args to PeerManager::Options.
Jul 12 2024, 14:30
PiRK committed rABC020c3c10290b: net_processing: move avalanche related args to PeerManager::Options (authored by PiRK).
net_processing: move avalanche related args to PeerManager::Options
Jul 12 2024, 14:30
PiRK closed D16456: net processing: clamp PeerManager::Options user input.
Jul 12 2024, 14:30
PiRK committed rABC83352fab4390: net processing: clamp PeerManager::Options user input (authored by stickies-v <stickies-v@protonmail.com>).
net processing: clamp PeerManager::Options user input
Jul 12 2024, 14:30
Fabien closed D16458: bugfix, Change up submitpackage results to return results for all transactions.
Jul 12 2024, 12:29
Fabien committed rABCf3ea6de5679d: bugfix, Change up submitpackage results to return results for all transactions (authored by Fabien).
bugfix, Change up submitpackage results to return results for all transactions
Jul 12 2024, 12:29
Fabien accepted D16456: net processing: clamp PeerManager::Options user input.
Jul 12 2024, 11:46
PiRK updated the summary of D16456: net processing: clamp PeerManager::Options user input.
Jul 12 2024, 11:43
PiRK updated the summary of D16456: net processing: clamp PeerManager::Options user input.
Jul 12 2024, 11:43
PiRK updated the summary of D16456: net processing: clamp PeerManager::Options user input.
Jul 12 2024, 11:43
Fabien updated the diff for D16458: bugfix, Change up submitpackage results to return results for all transactions.

Fix var name

Jul 12 2024, 11:43
PiRK accepted D16458: bugfix, Change up submitpackage results to return results for all transactions.
Jul 12 2024, 11:41
Fabien accepted D16457: net_processing: move avalanche related args to PeerManager::Options.
Jul 12 2024, 11:36
teamcity updated the summary of D16458: bugfix, Change up submitpackage results to return results for all transactions.
Jul 12 2024, 11:12
Fabien requested review of D16458: bugfix, Change up submitpackage results to return results for all transactions.
Jul 12 2024, 11:12
PiRK retitled D16457: net_processing: move avalanche related args to PeerManager::Options from net_processing: move related args to PeerManager::Options to net_processing: move avalanche related args to PeerManager::Options.
Jul 12 2024, 10:57
PiRK requested review of D16457: net_processing: move avalanche related args to PeerManager::Options.
Jul 12 2024, 10:56
PiRK closed D16455: net processing, refactor: Decouple PeerManager from gArgs.
Jul 12 2024, 10:28
PiRK committed rABCcdd9740bd3c3: net processing, refactor: Decouple PeerManager from gArgs (authored by dergoegge <n.goeggi@gmail.com>).
net processing, refactor: Decouple PeerManager from gArgs
Jul 12 2024, 10:28
PiRK requested review of D16456: net processing: clamp PeerManager::Options user input.
Jul 12 2024, 10:04
Fabien closed D16447: validation: fix coins disappearing mid-package evaluation.
Jul 12 2024, 09:55
Fabien committed rABC8de49c3ef86a: validation: fix coins disappearing mid-package evaluation (authored by Miles Liu <miles@bung.cc>).
validation: fix coins disappearing mid-package evaluation
Jul 12 2024, 09:55
PiRK accepted D16447: validation: fix coins disappearing mid-package evaluation.
Jul 12 2024, 09:40
Fabien updated the diff for D16447: validation: fix coins disappearing mid-package evaluation.

Remove debug leftover

Jul 12 2024, 09:35
PiRK updated the summary of D16455: net processing, refactor: Decouple PeerManager from gArgs.
Jul 12 2024, 09:35
Fabien accepted D16455: net processing, refactor: Decouple PeerManager from gArgs.
Jul 12 2024, 09:34
PiRK requested changes to D16447: validation: fix coins disappearing mid-package evaluation.
Jul 12 2024, 09:31
Fabien accepted D16454: [avalanche] Fix bytes received tracking for avalanche messages.
Jul 12 2024, 09:17
Fabien updated the diff for D16447: validation: fix coins disappearing mid-package evaluation.

Actually backport PR27127

Jul 12 2024, 09:16
teamcity updated the summary of D16455: net processing, refactor: Decouple PeerManager from gArgs.
Jul 12 2024, 08:57
PiRK requested review of D16455: net processing, refactor: Decouple PeerManager from gArgs.
Jul 12 2024, 08:57
Fabien closed D16443: test: use MiniWallet for mining_prioritisetransaction.py.
Jul 12 2024, 08:56
Fabien committed rABC8a5202b62d2d: test: use MiniWallet for mining_prioritisetransaction.py (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: use MiniWallet for mining_prioritisetransaction.py
Jul 12 2024, 08:56
Fabien closed D16444: rpc: Return coinbase flag in scantxoutset.
Jul 12 2024, 08:54
Fabien committed rABC8354ecf06296: rpc: Return coinbase flag in scantxoutset (authored by MacroFake <falke.marco@gmail.com>).
rpc: Return coinbase flag in scantxoutset
Jul 12 2024, 08:54
Fabien closed D16445: Bump version to 0.29.9.
Jul 12 2024, 08:54
Fabien committed rABC89b4eae1ecbd: Bump version to 0.29.9 (authored by Fabien).
Bump version to 0.29.9
Jul 12 2024, 08:53
Unknown Object (User) added a comment to D10035: walletdb: track database file use as m_refcount within BerkeleyDatabase.
Jul 12 2024, 08:36

Jul 11 2024

bytesofman closed D16449: [CONTRIBUTING] pin version for eslint.
Jul 11 2024, 23:59
bytesofman committed rABCec00831bed41: [CONTRIBUTING] pin version for eslint (authored by bytesofman).
[CONTRIBUTING] pin version for eslint
Jul 11 2024, 23:59
roqqit accepted D16449: [CONTRIBUTING] pin version for eslint.
Jul 11 2024, 23:02
roqqit requested review of D16454: [avalanche] Fix bytes received tracking for avalanche messages.
Jul 11 2024, 23:00
bytesofman requested changes to D16452: Fixed file permissions for mocks.js.
  • All files in Cashtab are like this, so putting up a diff that fixes it in just one place is not improving the codebase
  • Please describe a rationale for the change
Jul 11 2024, 21:12
bytesofman requested changes to D16453: [Cashtab].
  • The diff has no title
  • The diff has no summary, it's not clear what you are trying to do
  • The diff cannot be locally tested because it is not based on master
Jul 11 2024, 21:04
bytesofman added a comment to D16453: [Cashtab].

this commit is not against master so I am not able to test it locally using arc patch

Jul 11 2024, 21:02
assasin-k7 requested review of D16453: [Cashtab].
Jul 11 2024, 20:42
assasin-k7 requested review of D16452: Fixed file permissions for mocks.js.
Jul 11 2024, 20:13
bytesofman published D16449: [CONTRIBUTING] pin version for eslint for review.
Jul 11 2024, 19:00
Fabien abandoned D16446: Test Commit.
Jul 11 2024, 18:20
Fabien commandeered D16446: Test Commit.
Jul 11 2024, 18:20
PiRK accepted D16444: rpc: Return coinbase flag in scantxoutset.
Jul 11 2024, 15:53
PiRK accepted D16443: test: use MiniWallet for mining_prioritisetransaction.py.
Jul 11 2024, 15:51
teamcity updated the summary of D16447: validation: fix coins disappearing mid-package evaluation.
Jul 11 2024, 15:39
Fabien requested review of D16447: validation: fix coins disappearing mid-package evaluation.
Jul 11 2024, 15:38
tobias_ruck closed D16442: [Chronik] Add `get_block_header` to FFI.
Jul 11 2024, 15:38
tobias_ruck committed rABCa4e47f611a90: [Chronik] Add `get_block_header` to FFI (authored by tobias_ruck).
[Chronik] Add `get_block_header` to FFI
Jul 11 2024, 15:38
Fabien requested changes to D16446: Test Commit.

Please don't submit this kind of commit to reviewers. You tested your workflow twice already, now your next diff should be an actual useful code change.

Jul 11 2024, 15:35
PiRK accepted D16445: Bump version to 0.29.9.
Jul 11 2024, 15:35
PiRK accepted D16442: [Chronik] Add `get_block_header` to FFI.

OK, that looks like something I can use.

Jul 11 2024, 15:34
Fabien updated the summary of D16444: rpc: Return coinbase flag in scantxoutset.
Jul 11 2024, 14:59
Fabien updated the diff for D16444: rpc: Return coinbase flag in scantxoutset.

Add a release note

Jul 11 2024, 14:59