add tests
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jul 15 2024
This one should be relatively easy to test (but hopefully without having to add a dependency to the main unit test framework like the source material does)
doc layout
improve comment, set range_check=false when calling ReadCompactSize to prevent the function from throwing if the net message is intentionnaly bad, don't duplicate MAX_HEADERS_RESULTS but include it via net_processing.h.
You should add tests as you go
@assasin-k7 So now we have a title, and an idea of what you're trying to achieve.
The actual change itself is not as described, you're merely fixing a typo - then title it as such.
You need to fix the linting errors before pushing. Do an arc lint locally.
Test plan needs to be something the reviewer can follow easily easily e.g.
- npm test
- click here, check blah...
Jul 14 2024
Jul 13 2024
Version bump
Jul 12 2024
This has no title.
This has no rationale.
This has no test plan.
This is failing the linters.
Fix var name
Remove debug leftover
Actually backport PR27127
Jul 11 2024
- All files in Cashtab are like this, so putting up a diff that fixes it in just one place is not improving the codebase
- Please describe a rationale for the change
- The diff has no title
- The diff has no summary, it's not clear what you are trying to do
- The diff cannot be locally tested because it is not based on master
this commit is not against master so I am not able to test it locally using arc patch
Please don't submit this kind of commit to reviewers. You tested your workflow twice already, now your next diff should be an actual useful code change.
OK, that looks like something I can use.
Add a release note