add test for tip header too
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jul 11 2024
Jul 11 2024
remove unnecessary bridge
bytesofman committed rABC0e6afdf73577: [Cashtab] Replace 546 magic number with dust const (authored by bytesofman).
[Cashtab] Replace 546 magic number with dust const
[e.cash] Modify ViaWallet
Jul 10 2024
Jul 10 2024
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41367 for the next 60 minutes.
teamcity awarded D16441: [e.cash] Modify ViaWallet a Haypence token.
@bot preview-e.cash
Fabien committed rABC465fb65ae28f: validation: return more helpful results for reconsiderable fee failures and… (authored by Fabien).
validation: return more helpful results for reconsiderable fee failures and…
tobias_ruck committed rABC0fec8554ffe1: [Mitra] Add Intcode integer format (authored by tobias_ruck).
[Mitra] Add Intcode integer format
bytesofman committed rABC2537cd1d3835: [Cashtab] Only add inputs to a tx if you need them (authored by bytesofman).
[Cashtab] Only add inputs to a tx if you need them
teamcity triaged T3603: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
bytesofman committed rABC3fe72d4b1ede: [Cashtab] Update comment and TODO in sendXec function (authored by bytesofman).
[Cashtab] Update comment and TODO in sendXec function
trigger a diff build
teamcity awarded D6571: [WIP] Test commit, don't review a Love token.
teamcity awarded D16437: [Cashtab] Update comment and TODO in sendXec function a Haypence token.
@bot cashtab-tests
rebase, apply suggestions, fix json compilation errors
Jul 9 2024
Jul 9 2024
tobias_ruck committed rABC06d187868df1: [Chronik] Plugins: Load plugins based on plugins.toml in datadir (authored by tobias_ruck).
[Chronik] Plugins: Load plugins based on plugins.toml in datadir
note: tests are passing locally, CI failure does not seem related to this diff. Unable to parse issue from log
rebase
tobias_ruck requested review of D16219: [Chronik] Plugins: Load plugins based on plugins.toml in datadir.
bytesofman committed rABCaf9c90e6aad6: [Cashtab] Build all targetOutputs with script instead of address key (authored by bytesofman).
[Cashtab] Build all targetOutputs with script instead of address key
Fabien committed rABC656b42a2b667: [CI] Update the sha256 sum for the nodejs setup script (authored by Fabien).
[CI] Update the sha256 sum for the nodejs setup script
Fabien committed rABC5678070f1821: upnp: add compatibility for miniupnpc 2.2.8 (authored by Cory Fields <cory-nospam-@coryfields.com>).
upnp: add compatibility for miniupnpc 2.2.8
Fabien committed rABCc7154d408c6a: mempool: disallow txns under min relay fee, even in packages (authored by Fabien).
mempool: disallow txns under min relay fee, even in packages
bytesofman published D16427: [Cashtab] Build all targetOutputs with script instead of address key for review.
teamcity triaged T3602: Build Bitcoin-ABC / Master / Build without CLI is broken. as Unbreak Now! priority.
bytesofman committed rABCe5f55cf103b4: [ecash-lib] Support address key in target outputs (authored by bytesofman).
[ecash-lib] Support address key in target outputs
README patch per recommendation
add test case for Script.fromAddress use as leftover (change) output
Can you add a test case that uses Script.fromAddress for the change output as well ?
Otherwise the code LGTM
teamcity updated the summary of D16433: mempool: disallow txns under min relay fee, even in packages.
Fabien committed rABCb81cd4c29fd7: test: Run mempool_packages.py with MiniWallet (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
test: Run mempool_packages.py with MiniWallet
Fabien committed rABC05ef30bbc89d: test: Move tx creation to create_self_transfer_multi (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: Move tx creation to create_self_transfer_multi
Jul 8 2024
Jul 8 2024
Cleanup unused proofCount
In D16428#371852, @Fabien wrote:OK I get a better sense of what API you're trying to build then. I think creating the new type is the wrong approach because it makes the API inconsistent from the callsite perspective. You can specify any output as an TxBuilderAddress but the change output has to be a Script ? It is simpler imo to require the callsite to use Script.fromAddress() every time it uses an address: it's explicit and consistent because you will do that for the change output as well. It avoids the issue "address vs script as a key but not both" also which makes the code more robust by design.
What do you think ?
do not support new TxOutputAddress type, instead require Script.fromAddress() at callsite