Page MenuHomePhabricator
Feed All Stories

Aug 27 2024

PiRK added inline comments to D16683: [explorer] Remove extra spaces around 's'.
Aug 27 2024, 13:12
PiRK updated the diff for D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.

properly handle point at infinity

Aug 27 2024, 09:25
PiRK updated the diff for D16681: [electrum] properly handle point at infinity and point not on curve.

properly hand point at infinity (not an error)

Aug 27 2024, 09:03
PiRK planned changes to D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.
Aug 27 2024, 08:29
PiRK added inline comments to D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.
Aug 27 2024, 08:29
PiRK planned changes to D16681: [electrum] properly handle point at infinity and point not on curve.

point at infinity shouldn't be an error on the ECC side, this needs some more work

Aug 27 2024, 08:28
PiRK updated the diff for D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.

rebase

Aug 27 2024, 07:06
PiRK updated the diff for D16681: [electrum] properly handle point at infinity and point not on curve.

rebase

Aug 27 2024, 07:05
PiRK updated the diff for D16676: [electrum] refactor private key class to better abstract ecdsa library usage.

rebase

Aug 27 2024, 07:05
PiRK updated the diff for D16678: [electrum] fix the max value for the ephemeral exponent.

rebase

Aug 27 2024, 07:03
PiRK updated the diff for D16677: [electrum] move .encrypt method to ECPubkey class.

rebase

Aug 27 2024, 07:03
PiRK updated the diff for D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.

replace the magic 32 number with a constant

Aug 27 2024, 06:55
PiRK added inline comments to D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.
Aug 27 2024, 06:54
PiRK updated the diff for D16665: [electrum] use python's standard library `secrets` for randrange.

rebase

Aug 27 2024, 06:26
PiRK updated the summary of D16678: [electrum] fix the max value for the ephemeral exponent.
Aug 27 2024, 06:21
johnkuney updated the diff for D16683: [explorer] Remove extra spaces around 's'.

fix spacing

Aug 27 2024, 03:57
johnkuney planned changes to D16683: [explorer] Remove extra spaces around 's'.
Aug 27 2024, 03:49
johnkuney requested review of D16683: [explorer] Remove extra spaces around 's'.
Aug 27 2024, 03:48

Aug 26 2024

Kronkmeister updated the diff for D16679: [e.cash] Add button and bip70 label to wallets page.

Removing bip-70 label change. Will be added later with a user-facing label like "BitPay support"
or "Payment Protocol". Retaining the wallet guide button at the top of the page.

Aug 26 2024, 23:47
Kronkmeister added a comment to D16679: [e.cash] Add button and bip70 label to wallets page.

The user-level idea is to make them see which of those wallets support BitPay invoices. It is officially titled as "Payment Protocol", we could also add "Bitpay support" in that sense.

Aug 26 2024, 23:35
bytesofman accepted D16677: [electrum] move .encrypt method to ECPubkey class.

TIL this feature

Aug 26 2024, 23:27
bytesofman requested changes to D16679: [e.cash] Add button and bip70 label to wallets page.
Aug 26 2024, 23:21
bytesofman added inline comments to D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.
Aug 26 2024, 23:18
teamcity added a comment to D16679: [e.cash] Add button and bip70 label to wallets page.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41952 for the next 60 minutes.

Aug 26 2024, 23:14
teamcity awarded D16679: [e.cash] Add button and bip70 label to wallets page a Haypence token.
Aug 26 2024, 23:13
bytesofman added a comment to D16679: [e.cash] Add button and bip70 label to wallets page.

@bot preview-e.cash

Aug 26 2024, 23:13
tobias_ruck added a comment to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.

Not sure what you’re asking there

Aug 26 2024, 21:48
bytesofman added inline comments to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
Aug 26 2024, 21:39
bytesofman added a comment to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.

Not sure what you’re asking there

Aug 26 2024, 21:39
tobias_ruck added inline comments to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
Aug 26 2024, 21:20
tobias_ruck added a comment to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.

update using a dataclass

could you summarize what this does and why this became preferable? I can see the organization change, is it just easier to read and maintain as a class?

Aug 26 2024, 21:11
bytesofman requested changes to D16665: [electrum] use python's standard library `secrets` for randrange.

not able to arc patch this as not rebased after landing of its parent

Aug 26 2024, 21:10
bytesofman accepted D16678: [electrum] fix the max value for the ephemeral exponent.
Aug 26 2024, 21:08
Kronkmeister updated the diff for D16679: [e.cash] Add button and bip70 label to wallets page.

Fix typo: Changing "checkout" to "check out".

Aug 26 2024, 19:44
bytesofman accepted D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.

update using a dataclass

Aug 26 2024, 19:31
PiRK closed D16663: [electrum] fix fiat price cache not being created if it does not already exist.
Aug 26 2024, 19:01
PiRK committed rABCdddc4d139dce: [electrum] fix fiat price cache not being created if it does not already exist (authored by PiRK).
[electrum] fix fiat price cache not being created if it does not already exist
Aug 26 2024, 19:01
PiRK closed D16669: [electrum] fix the btchip-python dependency for pip > 24.1.
Aug 26 2024, 18:59
PiRK committed rABC2e0146732b59: [electrum] bump mnemonic dependency to >=0.21 (authored by PiRK).
[electrum] bump mnemonic dependency to >=0.21
Aug 26 2024, 18:59
PiRK closed D16664: [electrum] bump mnemonic dependency to >=0.21.
Aug 26 2024, 18:59
PiRK committed rABCfae9d4597a5c: [electrum] fix the btchip-python dependency for pip > 24.1 (authored by PiRK).
[electrum] fix the btchip-python dependency for pip > 24.1
Aug 26 2024, 18:59
PiRK closed D16667: [electrum] update dockerfiles to unbreak the release build.
Aug 26 2024, 18:59
PiRK committed rABCf35fef42cb80: [electrum] update dockerfiles to unbreak the release build (authored by PiRK).
[electrum] update dockerfiles to unbreak the release build
Aug 26 2024, 18:59
bytesofman accepted D16663: [electrum] fix fiat price cache not being created if it does not already exist.
Aug 26 2024, 18:28
PiRK updated the summary of D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.
Aug 26 2024, 15:17
PiRK requested review of D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.
Aug 26 2024, 15:16
PiRK requested review of D16681: [electrum] properly handle point at infinity and point not on curve.
Aug 26 2024, 15:08
PiRK updated the diff for D16676: [electrum] refactor private key class to better abstract ecdsa library usage.

fix fusion.py

Aug 26 2024, 11:55
PiRK planned changes to D16676: [electrum] refactor private key class to better abstract ecdsa library usage.

this silently breaks fusion

Aug 26 2024, 11:42
PiRK updated the diff for D16665: [electrum] use python's standard library `secrets` for randrange.

and more... hopefully that's all of them

Aug 26 2024, 09:01
PiRK updated the diff for D16665: [electrum] use python's standard library `secrets` for randrange.

and another one

Aug 26 2024, 08:45
PiRK updated the diff for D16665: [electrum] use python's standard library `secrets` for randrange.

i missed one

Aug 26 2024, 08:35
PiRK published D16676: [electrum] refactor private key class to better abstract ecdsa library usage for review.
Aug 26 2024, 06:43
PiRK added inline comments to D16679: [e.cash] Add button and bip70 label to wallets page.
Aug 26 2024, 06:41

Aug 25 2024

abc-bot committed rABC9c84e16aef67: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Aug 25 2024, 21:19
abc-bot committed rABC3421ff8c26f5: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Aug 25 2024, 21:09
abc-bot committed rABCa3eb0ccd05d7: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Aug 25 2024, 20:38

Aug 24 2024

celemtine added a comment to rABC057a7344afeb: [linter doc] Specify prettier version to install globally.

Good suggestion to specify the Prettier version. This will help prevent issues with inconsistent formatting across different setups. Ensuring everyone uses the same version half body sexdoll is key.

Aug 24 2024, 07:30
Kronkmeister published D16679: [e.cash] Add button and bip70 label to wallets page for review.
Aug 24 2024, 00:15

Aug 23 2024

bytesofman closed D16680: [token-server] Reduce faucet reward.
Aug 23 2024, 21:44
bytesofman committed rABCc6a9804d6730: [token-server] Reduce faucet reward (authored by bytesofman).
[token-server] Reduce faucet reward
Aug 23 2024, 21:44
johnkuney accepted D16680: [token-server] Reduce faucet reward.
Aug 23 2024, 21:42
bytesofman published D16680: [token-server] Reduce faucet reward for review.
Aug 23 2024, 21:41
PiRK requested review of D16678: [electrum] fix the max value for the ephemeral exponent.
Aug 23 2024, 19:50
PiRK added inline comments to D16677: [electrum] move .encrypt method to ECPubkey class.
Aug 23 2024, 19:22
PiRK updated the summary of D16677: [electrum] move .encrypt method to ECPubkey class.
Aug 23 2024, 19:19
PiRK requested review of D16677: [electrum] move .encrypt method to ECPubkey class.
Aug 23 2024, 19:16
roqqit accepted D16664: [electrum] bump mnemonic dependency to >=0.21.
Aug 23 2024, 15:34
roqqit accepted D16669: [electrum] fix the btchip-python dependency for pip > 24.1.
Aug 23 2024, 15:33
roqqit accepted D16667: [electrum] update dockerfiles to unbreak the release build.
Aug 23 2024, 15:30
PiRK updated the summary of D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.
Aug 23 2024, 11:55
PiRK updated the summary of D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.
Aug 23 2024, 11:52
PiRK requested review of D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.
Aug 23 2024, 11:52
sirphiremobile updated sirphiremobile.
Aug 23 2024, 05:29

Aug 22 2024

tobias_ruck closed D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Aug 22 2024, 19:57
tobias_ruck committed rABC1544301342f0: [Chronik] Rename `group` in `PluginOutput` to `groups` (authored by tobias_ruck).
[Chronik] Rename `group` in `PluginOutput` to `groups`
Aug 22 2024, 19:57
PiRK accepted D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Aug 22 2024, 19:49
tobias_ruck updated the diff for D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.

rebase to fix build

Aug 22 2024, 17:02
tobias_ruck updated the diff for D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.

fix hopefully the last test

Aug 22 2024, 16:25
PiRK added a comment to D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Build build-chronik-plugins failed with exit code 1

It is mysterious. I don't see any explcit error except for that one.

Aug 22 2024, 16:00
teamcity added a comment to D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Aug 22 2024, 15:34
roqqit closed D16668: [avalanche] Add stake contender inv type.
Aug 22 2024, 15:33
roqqit committed rABCf93c6792c0cf: [avalanche] Add stake contender inv type (authored by roqqit).
[avalanche] Add stake contender inv type
Aug 22 2024, 15:33
tobias_ruck updated the diff for D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.

fix other tests

Aug 22 2024, 15:18
teamcity added a comment to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
Aug 22 2024, 14:28
teamcity added a comment to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
Aug 22 2024, 14:17
teamcity added a comment to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
Aug 22 2024, 14:16
PiRK closed D16571: [chronik] Add a struct to compute a block merkle tree.
Aug 22 2024, 14:06
PiRK committed rABC2e8e8b9f174b: [chronik] Add a struct to compute a block merkle tree (authored by PiRK).
[chronik] Add a struct to compute a block merkle tree
Aug 22 2024, 14:06
teamcity added a comment to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
Aug 22 2024, 14:03
teamcity added a comment to D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Aug 22 2024, 13:56
teamcity added a comment to D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Aug 22 2024, 13:41
teamcity added a comment to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
Aug 22 2024, 13:12
tobias_ruck updated the diff for D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.

fix groups for the error case

Aug 22 2024, 13:08
teamcity added a comment to D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Aug 22 2024, 12:59
tobias_ruck updated the diff for D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.

move agora.py into ecash-agora (so it becomes part of the npm package), rebase to fix tests, update + fix comments

Aug 22 2024, 12:58
teamcity added a comment to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
Aug 22 2024, 12:54
tobias_ruck updated the diff for D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.

fix tests in context.rs

Aug 22 2024, 12:53
teamcity added a comment to D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
Aug 22 2024, 12:45
teamcity added a comment to D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Aug 22 2024, 12:31