rebase
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Aug 30 2024
Aug 30 2024
PiRK updated the diff for D16681: [electrum] properly handle point at infinity and point not on curve.
PiRK updated the diff for D16676: [electrum] refactor private key class to better abstract ecdsa library usage.
replace a few 32's with PRIVATE_KEY_BYTECOUNT, clarify legacy use for arbitrary size secret
PiRK added inline comments to D16676: [electrum] refactor private key class to better abstract ecdsa library usage.
PiRK added a comment to D16681: [electrum] properly handle point at infinity and point not on curve.
In D16681#378434, @bytesofman wrote:still not able to arc patch this one, which could mean we see issues when it is landed. may want to wait until this is next off the rank.
did points at infinity or not on curve not being properly handled impact app performance? why was this not handled before this diff?
Aug 29 2024
Aug 29 2024
would be nice if both of these images took up 100% of the tile width -- but that is already not happening with the current images. This is an improvement.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41990 for the next 60 minutes.
teamcity awarded D16693: [e.cash] Swap color cashtab logos a Haypence token.
@bot preview-e.cash
roqqit requested review of D16695: [avalanche] Add a cache for avalanche voting results of stake contenders.
roqqit committed rABC7aafd2f1c1e7: [avalanche] Make buildRandomProof use a random payout script (authored by roqqit).
[avalanche] Make buildRandomProof use a random payout script
bytesofman requested changes to D16676: [electrum] refactor private key class to better abstract ecdsa library usage.
confirmed my different signatures were from not having built libsecp
PiRK added a comment to D16676: [electrum] refactor private key class to better abstract ecdsa library usage.
In D16676#378433, @bytesofman wrote:I can't get the test plan to pass but I'm also not sure it's really an issue.
still not able to arc patch this one, which could mean we see issues when it is landed. may want to wait until this is next off the rank.
bytesofman added a comment to D16676: [electrum] refactor private key class to better abstract ecdsa library usage.
I can't get the test plan to pass but I'm also not sure it's really an issue.
bytesofman committed rABC41d216ffd9fd: [alias-server] Migrate to in-node chronik-client (authored by bytesofman).
[alias-server] Migrate to in-node chronik-client
rebase
PiRK updated the diff for D16681: [electrum] properly handle point at infinity and point not on curve.
rebase
PiRK updated the diff for D16676: [electrum] refactor private key class to better abstract ecdsa library usage.
rebase
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Like token.
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Mountain of Wealth token.
PiRK added a comment to D16681: [electrum] properly handle point at infinity and point not on curve.
I'm not sure exactly what is going on. I will try to rebase all these diffs onto D16687 when I get it sorted out. Hopefully it will fix the situation. I could just rebase everything onto master after I land any diff in the stack, but that would be tedious and noisy in the phabricator logs for a stack of 10+ commits.
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Doubloon token.
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Piece of Eight token.
Aug 28 2024
Aug 28 2024
bytesofman requested changes to D16681: [electrum] properly handle point at infinity and point not on curve.
like D16676, I'm not able to arc patch this diff. Looks like there is an issue with the parent / child revisions in the stack.
johnkuney committed rABCa3125926c643: [explorer] Remove extra spaces around 's' (authored by johnkuney).
[explorer] Remove extra spaces around 's'
Works for me 👍🏻
good call thanks, had to add the closing ) in each one as well
fix spacing issue and avoid extra formatting
PiRK committed rABCc58302608fc6: tests: fix formatting of itemid in p2p_inv_download (authored by PiRK).
tests: fix formatting of itemid in p2p_inv_download
I forgot that this needs D16687 to be sorted out first
I forgot that this needs D16687 to be sorted out first
Build Bitcoin ABC Diffs / Diff Testing (electrum-tests) failed.
Build Bitcoin ABC Diffs / Diff Testing (electrum-tests) failed.
remove dead/commented code (the todo is done in a couple of commits, and is not critical)
Build Bitcoin ABC Diffs / Diff Testing (electrum-tests) failed.
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Haypence token.
tobias_ruck committed rABC4df038a7cffb: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers (authored by tobias_ruck).
[ecash-agora] Add `agora.py` plugin to index ONESHOT offers
restore coercing secret_exponent to int (see D14490)
teamcity updated the summary of D16685: [electrum] grind ecdsa low R signature when using libsecp256k1.
rebase
PiRK updated the diff for D16681: [electrum] properly handle point at infinity and point not on curve.
use GENERATOR and POINT_AT_INFINITY constants. These need to be placed after the ECPubkey class is defined.
PiRK committed rABCe890009510c5: [electrum] fix the max value for the ephemeral exponent (authored by PiRK).
[electrum] fix the max value for the ephemeral exponent
PiRK committed rABC98cf2c8bda6a: [electrum] move .encrypt method to ECPubkey class (authored by PiRK).
[electrum] move .encrypt method to ECPubkey class
PiRK committed rABC1c69a840da62: [electrum] don't use ecdsa for basic bytes <-> int conversion (authored by PiRK).
[electrum] don't use ecdsa for basic bytes <-> int conversion
PiRK committed rABC98564823c35f: [electrum] use python's standard library `secrets` for randrange (authored by SomberNight <somber.night@protonmail.com>).
[electrum] use python's standard library `secrets` for randrange
Aug 27 2024
Aug 27 2024
tobias_ruck updated the diff for D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
rebase on master
teamcity triaged T3621: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Kronkmeister committed rABCfa1fa0ba9184: [e.cash] Add button and bip70 label to wallets page (authored by Kronkmeister).
[e.cash] Add button and bip70 label to wallets page
Added BIP-70 label back and improved copy on wallets page as suggested.
bytesofman added a comment to D16676: [electrum] refactor private key class to better abstract ecdsa library usage.
I see this has been rebased but I am running into the same issue, arc patch 16676 fails with a cherry pick error
yeah this is the only way I can get it to work, but it tabs everything below it over
fix extra space
actually this is still causing the space after the 's' looks like
Use the constants GENERATOR and POINT_AT_INFINITY rather than functions.
PiRK planned changes to D16681: [electrum] properly handle point at infinity and point not on curve.
formatting
adjust -