Page MenuHomePhabricator
Feed Advanced Search

Aug 28 2024

PiRK closed D16688: tests: fix formatting of itemid in p2p_inv_download.
Aug 28 2024, 17:53
PiRK committed rABCc58302608fc6: tests: fix formatting of itemid in p2p_inv_download (authored by PiRK).
tests: fix formatting of itemid in p2p_inv_download
Aug 28 2024, 17:53
PiRK planned changes to D16690: [electrum] use libsecp256k1 for signature conversions.

I forgot that this needs D16687 to be sorted out first

Aug 28 2024, 14:39
PiRK planned changes to D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.

I forgot that this needs D16687 to be sorted out first

Aug 28 2024, 14:38
PiRK requested review of D16690: [electrum] use libsecp256k1 for signature conversions.
Aug 28 2024, 14:36
PiRK updated the diff for D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.

remove dead/commented code (the todo is done in a couple of commits, and is not critical)

Aug 28 2024, 14:30
PiRK requested review of D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.
Aug 28 2024, 14:24
PiRK updated the summary of D16688: tests: fix formatting of itemid in p2p_inv_download.
Aug 28 2024, 09:12
PiRK requested review of D16688: tests: fix formatting of itemid in p2p_inv_download.
Aug 28 2024, 09:11
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Haypence token.
Aug 28 2024, 08:45
PiRK updated the summary of D16686: [electrum] deduplicate the ECPrivkey.sign code.
Aug 28 2024, 07:26
PiRK requested review of D16686: [electrum] deduplicate the ECPrivkey.sign code.
Aug 28 2024, 07:24
PiRK updated the diff for D16685: [electrum] grind ecdsa low R signature when using libsecp256k1.

restore coercing secret_exponent to int (see D14490)

Aug 28 2024, 07:15
PiRK requested review of D16685: [electrum] grind ecdsa low R signature when using libsecp256k1.
Aug 28 2024, 07:09
PiRK updated the summary of D16684: [electrum] also use libsecp256k1 for point addition.
Aug 28 2024, 07:03
PiRK requested review of D16684: [electrum] also use libsecp256k1 for point addition.
Aug 28 2024, 07:02
PiRK updated the diff for D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.

rebase

Aug 28 2024, 06:58
PiRK updated the diff for D16681: [electrum] properly handle point at infinity and point not on curve.

use GENERATOR and POINT_AT_INFINITY constants. These need to be placed after the ECPubkey class is defined.

Aug 28 2024, 06:36
PiRK closed D16678: [electrum] fix the max value for the ephemeral exponent.
Aug 28 2024, 06:26
PiRK committed rABCe890009510c5: [electrum] fix the max value for the ephemeral exponent (authored by PiRK).
[electrum] fix the max value for the ephemeral exponent
Aug 28 2024, 06:26
PiRK closed D16677: [electrum] move .encrypt method to ECPubkey class.
Aug 28 2024, 06:26
PiRK closed D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.
Aug 28 2024, 06:26
PiRK committed rABC98cf2c8bda6a: [electrum] move .encrypt method to ECPubkey class (authored by PiRK).
[electrum] move .encrypt method to ECPubkey class
Aug 28 2024, 06:26
PiRK committed rABC1c69a840da62: [electrum] don't use ecdsa for basic bytes <-> int conversion (authored by PiRK).
[electrum] don't use ecdsa for basic bytes <-> int conversion
Aug 28 2024, 06:26
PiRK closed D16665: [electrum] use python's standard library `secrets` for randrange.
Aug 28 2024, 06:26
PiRK committed rABC98564823c35f: [electrum] use python's standard library `secrets` for randrange (authored by SomberNight <somber.night@protonmail.com>).
[electrum] use python's standard library `secrets` for randrange
Aug 28 2024, 06:26

Aug 27 2024

PiRK accepted D16683: [explorer] Remove extra spaces around 's'.
Aug 27 2024, 15:47
PiRK planned changes to D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.

Use the constants GENERATOR and POINT_AT_INFINITY rather than functions.

Aug 27 2024, 15:45
PiRK planned changes to D16681: [electrum] properly handle point at infinity and point not on curve.
Aug 27 2024, 15:44
PiRK added inline comments to D16683: [explorer] Remove extra spaces around 's'.
Aug 27 2024, 13:12
PiRK updated the diff for D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.

properly handle point at infinity

Aug 27 2024, 09:25
PiRK updated the diff for D16681: [electrum] properly handle point at infinity and point not on curve.

properly hand point at infinity (not an error)

Aug 27 2024, 09:03
PiRK planned changes to D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.
Aug 27 2024, 08:29
PiRK added inline comments to D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.
Aug 27 2024, 08:29
PiRK planned changes to D16681: [electrum] properly handle point at infinity and point not on curve.

point at infinity shouldn't be an error on the ECC side, this needs some more work

Aug 27 2024, 08:28
PiRK updated the diff for D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.

rebase

Aug 27 2024, 07:06
PiRK updated the diff for D16681: [electrum] properly handle point at infinity and point not on curve.

rebase

Aug 27 2024, 07:05
PiRK updated the diff for D16676: [electrum] refactor private key class to better abstract ecdsa library usage.

rebase

Aug 27 2024, 07:05
PiRK updated the diff for D16678: [electrum] fix the max value for the ephemeral exponent.

rebase

Aug 27 2024, 07:03
PiRK updated the diff for D16677: [electrum] move .encrypt method to ECPubkey class.

rebase

Aug 27 2024, 07:03
PiRK updated the diff for D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.

replace the magic 32 number with a constant

Aug 27 2024, 06:55
PiRK added inline comments to D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.
Aug 27 2024, 06:54
PiRK updated the diff for D16665: [electrum] use python's standard library `secrets` for randrange.

rebase

Aug 27 2024, 06:26
PiRK updated the summary of D16678: [electrum] fix the max value for the ephemeral exponent.
Aug 27 2024, 06:21

Aug 26 2024

PiRK closed D16663: [electrum] fix fiat price cache not being created if it does not already exist.
Aug 26 2024, 19:01
PiRK committed rABCdddc4d139dce: [electrum] fix fiat price cache not being created if it does not already exist (authored by PiRK).
[electrum] fix fiat price cache not being created if it does not already exist
Aug 26 2024, 19:01
PiRK closed D16669: [electrum] fix the btchip-python dependency for pip > 24.1.
Aug 26 2024, 18:59
PiRK committed rABC2e0146732b59: [electrum] bump mnemonic dependency to >=0.21 (authored by PiRK).
[electrum] bump mnemonic dependency to >=0.21
Aug 26 2024, 18:59
PiRK closed D16664: [electrum] bump mnemonic dependency to >=0.21.
Aug 26 2024, 18:59
PiRK committed rABCfae9d4597a5c: [electrum] fix the btchip-python dependency for pip > 24.1 (authored by PiRK).
[electrum] fix the btchip-python dependency for pip > 24.1
Aug 26 2024, 18:59
PiRK closed D16667: [electrum] update dockerfiles to unbreak the release build.
Aug 26 2024, 18:59
PiRK committed rABCf35fef42cb80: [electrum] update dockerfiles to unbreak the release build (authored by PiRK).
[electrum] update dockerfiles to unbreak the release build
Aug 26 2024, 18:59
PiRK updated the summary of D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.
Aug 26 2024, 15:17
PiRK requested review of D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.
Aug 26 2024, 15:16
PiRK requested review of D16681: [electrum] properly handle point at infinity and point not on curve.
Aug 26 2024, 15:08
PiRK updated the diff for D16676: [electrum] refactor private key class to better abstract ecdsa library usage.

fix fusion.py

Aug 26 2024, 11:55
PiRK planned changes to D16676: [electrum] refactor private key class to better abstract ecdsa library usage.

this silently breaks fusion

Aug 26 2024, 11:42
PiRK updated the diff for D16665: [electrum] use python's standard library `secrets` for randrange.

and more... hopefully that's all of them

Aug 26 2024, 09:01
PiRK updated the diff for D16665: [electrum] use python's standard library `secrets` for randrange.

and another one

Aug 26 2024, 08:45
PiRK updated the diff for D16665: [electrum] use python's standard library `secrets` for randrange.

i missed one

Aug 26 2024, 08:35
PiRK published D16676: [electrum] refactor private key class to better abstract ecdsa library usage for review.
Aug 26 2024, 06:43
PiRK added inline comments to D16679: [e.cash] Add button and bip70 label to wallets page.
Aug 26 2024, 06:41

Aug 23 2024

PiRK requested review of D16678: [electrum] fix the max value for the ephemeral exponent.
Aug 23 2024, 19:50
PiRK added inline comments to D16677: [electrum] move .encrypt method to ECPubkey class.
Aug 23 2024, 19:22
PiRK updated the summary of D16677: [electrum] move .encrypt method to ECPubkey class.
Aug 23 2024, 19:19
PiRK requested review of D16677: [electrum] move .encrypt method to ECPubkey class.
Aug 23 2024, 19:16
PiRK updated the summary of D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.
Aug 23 2024, 11:55
PiRK updated the summary of D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.
Aug 23 2024, 11:52
PiRK requested review of D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.
Aug 23 2024, 11:52

Aug 22 2024

PiRK accepted D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Aug 22 2024, 19:49
PiRK added a comment to D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Build build-chronik-plugins failed with exit code 1

It is mysterious. I don't see any explcit error except for that one.

Aug 22 2024, 16:00
PiRK closed D16571: [chronik] Add a struct to compute a block merkle tree.
Aug 22 2024, 14:06
PiRK committed rABC2e8e8b9f174b: [chronik] Add a struct to compute a block merkle tree (authored by PiRK).
[chronik] Add a struct to compute a block merkle tree
Aug 22 2024, 14:06
PiRK accepted D16673: [ecash-lib] Fix fee estimation for signatories that depend on tx outputs.
Aug 22 2024, 12:05
PiRK updated the diff for D16571: [chronik] Add a struct to compute a block merkle tree.

use a verb in the function name, as per suggestion

Aug 22 2024, 10:36

Aug 21 2024

PiRK accepted D16670: [explorer] Remove trailing commma in linter file.
Aug 21 2024, 18:27
PiRK added inline comments to D16571: [chronik] Add a struct to compute a block merkle tree.
Aug 21 2024, 18:12
PiRK updated the diff for D16571: [chronik] Add a struct to compute a block merkle tree.

I missed one

Aug 21 2024, 18:11
PiRK updated the diff for D16571: [chronik] Add a struct to compute a block merkle tree.

review items

Aug 21 2024, 18:08
PiRK accepted D16666: [explorer] Support multi-token transactions.

We figured out my issue for running the explorer, I wasn't running cargo run in the right folder.
The result looks good, each UTXO shows the correct token now.

Aug 21 2024, 14:40
PiRK added a comment to D16666: [explorer] Support multi-token transactions.

The code looks good as far as I can tell, but I'm having trouble running the test plan to check the result.

Aug 21 2024, 13:02
PiRK accepted D16668: [avalanche] Add stake contender inv type.

with a nit in the test

Aug 21 2024, 12:53
PiRK updated the test plan for D16669: [electrum] fix the btchip-python dependency for pip > 24.1.
Aug 21 2024, 08:46
PiRK updated the summary of D16669: [electrum] fix the btchip-python dependency for pip > 24.1.
Aug 21 2024, 08:45
PiRK added inline comments to D16665: [electrum] use python's standard library `secrets` for randrange.
Aug 21 2024, 08:36
PiRK updated the summary of D16664: [electrum] bump mnemonic dependency to >=0.21.
Aug 21 2024, 08:34
PiRK requested review of D16669: [electrum] fix the btchip-python dependency for pip > 24.1.
Aug 21 2024, 08:33

Aug 20 2024

PiRK published D16665: [electrum] use python's standard library `secrets` for randrange for review.
Aug 20 2024, 16:34
PiRK published D16664: [electrum] bump mnemonic dependency to >=0.21 for review.
Aug 20 2024, 16:32
PiRK requested review of D16667: [electrum] update dockerfiles to unbreak the release build.
Aug 20 2024, 16:16
PiRK accepted D16662: [explorer] Format askama HTML templates using djlint instead of prettier.

OK. It requires python >= 3.8, which is fine. I added a suggestion about an alternative way to pass the input data to stdin, your pick.

Aug 20 2024, 14:35
PiRK updated the test plan for D16663: [electrum] fix fiat price cache not being created if it does not already exist.
Aug 20 2024, 09:44
PiRK added inline comments to D16663: [electrum] fix fiat price cache not being created if it does not already exist.
Aug 20 2024, 09:42
PiRK requested review of D16663: [electrum] fix fiat price cache not being created if it does not already exist.
Aug 20 2024, 09:40
PiRK added a comment to D16662: [explorer] Format askama HTML templates using djlint instead of prettier.

I tried adding a .prettierignore file to web/explorer with a explorer-server/templates line, but it does not seem to have any effect, prettier still messes up the html files in this directory. So not sure how to what I suggested.

Aug 20 2024, 08:12
PiRK added a comment to D16662: [explorer] Format askama HTML templates using djlint instead of prettier.

I agree that it looks a lot more readable like this, and everything looks good to me. I'm just wondering whether applying markdown formatting to html files makes sense in the first place. Does it add anything useful vs just disabling prettier altogether for this project?

Aug 20 2024, 07:58

Aug 19 2024

PiRK added inline comments to D16571: [chronik] Add a struct to compute a block merkle tree.
Aug 19 2024, 11:19
PiRK updated the diff for D16571: [chronik] Add a struct to compute a block merkle tree.

rebase on latest master

Aug 19 2024, 11:13
PiRK updated the diff for D16571: [chronik] Add a struct to compute a block merkle tree.

use Sha256d instead of [u8; 32] everywhere and use integer arithmetic in branch_length

Aug 19 2024, 10:52
PiRK accepted D16650: [avalanche] Reject transactions that conflict with a finalized one.

Looks good.
As discussed above, there is some ambiguity about TX_AVALANCHE_RECONSIDERABLE currently only being used for non-finalized conflicting txs (tx added to the TxConflicting pool). The pool will need to be renamed if/when we start adding other type of transactions to it, but that can be done if/when needed.

Aug 19 2024, 07:33