fix BE_name_from_config to always return a valid explorer so we don't show an empty combobox in the settings
Feed Advanced Search
Oct 10 2024
Oct 10 2024
PiRK requested review of D16881: Improve performance of p2p inv to send queues.
PiRK requested review of D16883: [electrum] rename migrate_data.py to update.py and fix module docstring.
PiRK updated the test plan for D16875: [electrum] update block explorers.
PiRK updated the diff for D16881: Improve performance of p2p inv to send queues.
no need to recompute INVENTORY_BROADCAST_MAX_PER_MB * config.GetMaxBlockSize() / 1000000 for each iteration of the loop
PiRK requested review of D16881: Improve performance of p2p inv to send queues.
Oct 9 2024
Oct 9 2024
PiRK added a comment to D16875: [electrum] update block explorers.
not a blocker, but mb worth noting
if you
- set explorer to bitcoinabc
- close electrum
- arc patch this diff
- ./electrum-abc
then check out preferences
looks like "no" explorer is selected. However, if you click to see txs in the explorer, it does use explorer.e.cash
if you do the same but with "ViaWallet", it works and also appears as selected in preferences
PiRK requested review of D16875: [electrum] update block explorers.
Oct 8 2024
Oct 8 2024
PiRK committed rABC2fdbd11f292d: [chronik] remove outdated comment for enable_lokad_id_index (authored by PiRK).
[chronik] remove outdated comment for enable_lokad_id_index
PiRK requested review of D16866: [chronik] remove outdated comment for enable_lokad_id_index.
Oct 7 2024
Oct 7 2024
Oct 4 2024
Oct 4 2024
Unrelated to the diff: in the second screenshot there seems to be an issue with the BTC price
in the summary of the diff, did you mean "if we do not get a token" ? Otherwise looks good
Oct 3 2024
Oct 3 2024
Oct 2 2024
Oct 2 2024
PiRK committed rABC597ca78e92c1: [electrum] move-only: move helper functions to avoid libsecp dependency (authored by PiRK).
[electrum] move-only: move helper functions to avoid libsecp dependency
Oct 1 2024
Oct 1 2024
PiRK added inline comments to D16833: [electrum] move-only: move helper functions to avoid libsecp dependency.
PiRK updated the summary of D16833: [electrum] move-only: move helper functions to avoid libsecp dependency.
PiRK requested review of D16833: [electrum] move-only: move helper functions to avoid libsecp dependency.
PiRK accepted D16831: Lint everything.
Looks good. I don't understand the CI failure, though, please check that it is unrelated.
Sep 30 2024
Sep 30 2024
$ date -ud @1747310400 jeu. 15 mai 2025 12:00:00 UTC
[iguana] make some includes explicit
PiRK updated the diff for D16822: [iguana] make some includes explicit.
make sure script_error.h is included directly in the .cpp
PiRK requested review of D16822: [iguana] make some includes explicit.
PiRK committed rABCfdf861d63cd3: p2p: Don't self-advertise during VERSION processing (authored by Gleb Naumenko <naumenko.gs@gmail.com>).
p2p: Don't self-advertise during VERSION processing
PiRK committed rABC9206721dbb4f: refactor: Pass reference to last header, not pointer (authored by MacroFake <falke.marco@gmail.com>).
refactor: Pass reference to last header, not pointer
PiRK committed rABCf3f9586e12b3: addrman: Use system time instead of adjusted network time (authored by MarcoFalke <falke.marco@gmail.com>).
addrman: Use system time instead of adjusted network time
Sep 27 2024
Sep 27 2024
PiRK requested review of D16818: p2p: Don't self-advertise during VERSION processing.
PiRK requested review of D16817: refactor: Pass reference to last header, not pointer.
PiRK added inline comments to D16816: addrman: Use system time instead of adjusted network time.
PiRK requested review of D16816: addrman: Use system time instead of adjusted network time.
Put this on hold for now, it makes things more complicated. If perf does turn out to be an issue in production we can reconsider doing this.
Sep 25 2024
Sep 25 2024
PiRK updated the diff for D16806: [chronik] pass only required block hashes to merkle tree cache.
please the compiler warnings
It is not clear to me why on these two the return statement can be omitted but not on the previous lines (93 and 96, 121 and 115)
PiRK updated the summary of D16806: [chronik] pass only required block hashes to merkle tree cache.
PiRK published D16806: [chronik] pass only required block hashes to merkle tree cache for review.
Sep 23 2024
Sep 23 2024
[chronik] better use the merkle tree cache
PiRK updated the summary of D16800: [chronik] better use the merkle tree cache.
PiRK added a comment to D16800: [chronik] better use the merkle tree cache.
diff --git a/chronik/chronik-indexer/src/query/blocks.rs b/chronik/chronik-indexer/src/query/blocks.rs index 01e658e2fd..f130f2e7f3 100644 --- a/chronik/chronik-indexer/src/query/blocks.rs +++ b/chronik/chronik-indexer/src/query/blocks.rs @@ -33,6 +33,7 @@ use crate::{ OutputsSpent, TxTokenData, }, }; +use std::time::{Duration, Instant};
PiRK requested review of D16800: [chronik] better use the merkle tree cache.
PiRK committed rABC160dafd5d1ba: p2p: Ensure transaction announcements are only queued for fully connected peers (authored by dergoegge <n.goeggi@gmail.com>).
p2p: Ensure transaction announcements are only queued for fully connected peers
PiRK committed rABCda9e51779f9e: net: Avoid SetTxRelay for feeler connections (authored by MacroFake <falke.marco@gmail.com>).
net: Avoid SetTxRelay for feeler connections
PiRK committed rABC184f9a2329c3: net: Set relay in version msg to peers with relay permission (authored by MacroFake <falke.marco@gmail.com>).
net: Set relay in version msg to peers with relay permission
PiRK committed rABCb14242616146: refactor: Introduce PeerManagerImpl::RejectIncomingTxs (authored by MacroFake <falke.marco@gmail.com>).
refactor: Introduce PeerManagerImpl::RejectIncomingTxs
Sep 20 2024
Sep 20 2024
PiRK requested review of D16797: net: Avoid SetTxRelay for feeler connections.
PiRK requested review of D16796: net: Set relay in version msg to peers with relay permission.
PiRK requested review of D16795: refactor: Introduce PeerManagerImpl::RejectIncomingTxs.
Sep 19 2024
Sep 19 2024
PiRK committed rABC0a75b25cc085: [chronik] add an optional checkpoint_height query parameters to the block… (authored by PiRK).
[chronik] add an optional checkpoint_height query parameters to the block…
PiRK committed rABCdd52be11d685: [net processing] Handle IsContinuationOfLowWorkHeadersSync return value… (authored by dergoegge <n.goeggi@gmail.com>).
[net processing] Handle IsContinuationOfLowWorkHeadersSync return value…
PiRK updated the diff for D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.
feedback
Sep 18 2024
Sep 18 2024
Sep 17 2024
Sep 17 2024
PiRK updated the diff for D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.
fix compiler warning
PiRK updated the diff for D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.
more refactoring
PiRK added inline comments to D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.
PiRK updated the diff for D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.
feedback
PiRK added inline comments to D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.
PiRK committed rABCd13de02951a6: [test framework] add a python implementation for merkle trees (authored by PiRK).
[test framework] add a python implementation for merkle trees
PiRK added inline comments to D16757: [avalanche] Vote on conflicting txs.
Sep 16 2024
Sep 16 2024
PiRK requested review of D16756: [test framework] add a python implementation for merkle trees.
PiRK updated the diff for D16756: [test framework] add a python implementation for merkle trees.
fix assertion for index vs len(hashes), and also assert that len(hashes) is strictly larger than 0
PiRK added inline comments to D16756: [test framework] add a python implementation for merkle trees.
PiRK added inline comments to D16756: [test framework] add a python implementation for merkle trees.
Sep 13 2024
Sep 13 2024
PiRK updated the diff for D16756: [test framework] add a python implementation for merkle trees.
move hex_to_be_bytes to util.py and remove unused be_bytes_to_hex
PiRK planned changes to D16756: [test framework] add a python implementation for merkle trees.
let's move hex_to_be_bytes to util.py
PiRK requested review of D16756: [test framework] add a python implementation for merkle trees.
Sep 12 2024
Sep 12 2024
PiRK added a comment to D16730: Return the RTT parameters in the block template.
lgtm with two nits
Sep 11 2024
Sep 11 2024