remove fixme comment (now fixed)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Nov 18 2024
Nov 18 2024
PiRK updated the diff for D17139: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation.
PiRK published D17139: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation for review.
PiRK committed rABC56db8a817f1c: Use std::string_view throughout util strencodings/string (authored by Pieter Wuille <pieter@wuille.net>).
Use std::string_view throughout util strencodings/string
PiRK committed rABC2ce28a323c56: scripted-diff: Rename ValidAsCString to ContainsNoNUL (authored by PiRK).
scripted-diff: Rename ValidAsCString to ContainsNoNUL
PiRK committed rABC6d85d6304400: Make DecodeBase{32,64} take string_view arguments (authored by Pieter Wuille <pieter@wuille.net>).
Make DecodeBase{32,64} take string_view arguments
PiRK committed rABC5dc47a349314: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth (authored by Pieter Wuille <pieter@wuille.net>).
modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth
PiRK committed rABCdad4fd9df468: Make strencodings functions use string_view (authored by Pieter Wuille <pieter@wuille.net>).
Make strencodings functions use string_view
PiRK committed rABC10326d3320e1: util: Introduce ToIntegral<T>(const std::string&) for locale independent… (authored by practicalswift <practicalswift@users.noreply.github.com>).
util: Introduce ToIntegral<T>(const std::string&) for locale independent…
PiRK updated the diff for D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.
fix var shadowing and move comment to the related line of code
Fabien requested changes to D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.
PiRK updated the diff for D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.
rebase
PiRK updated the diff for D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).
comment nits
When you add a new feature like this you need to also add a test for the new feature so you demonstrate that it works as expected.
You can look at the functional tests in test/functional/chronik_*.py for test examples, and most likely you can extend one of the existing test instead of creating a new one.
PiRK committed rABCadc9c8e45a53: net: use Sock::WaitMany() instead of CConnman::SocketEvents() (authored by Vasil Dimov <vd@FreeBSD.org>).
net: use Sock::WaitMany() instead of CConnman::SocketEvents()
PiRK committed rABCf0f41147f028: net: also wait for exceptional events in Sock::Wait() (authored by Vasil Dimov <vd@FreeBSD.org>).
net: also wait for exceptional events in Sock::Wait()
PiRK committed rABC9f4a3fa6a70c: net: introduce Sock::WaitMany() (authored by Vasil Dimov <vd@FreeBSD.org>).
net: introduce Sock::WaitMany()
net: use Sock in CNode
PiRK committed rABC7e5ca9440c2f: refactor: wrap accept() and extend usage of Sock (authored by Vasil Dimov <vd@FreeBSD.org>).
refactor: wrap accept() and extend usage of Sock
PiRK committed rABC5bea016076f0: fuzz: Add fuzzing harness for Socks5(...) (authored by practicalswift <practicalswift@users.noreply.github.com>).
fuzz: Add fuzzing harness for Socks5(...)
Nov 17 2024
Nov 17 2024
[Automated] Update seeds
[Automated] Update chainparams
[Automated] Update timing.json
renamed variable from x to block
bytesofman committed rABC92e37d388268: [Cashtab] Convert OrderBook component to ts as prep for adding websocket support (authored by bytesofman).
[Cashtab] Convert OrderBook component to ts as prep for adding websocket support
Nov 16 2024
Nov 16 2024
In D17149#389136, @teamcity wrote:
That failure seems unrelated to this diff. I can rebase later and investigate the failure separately.
teamcity triaged T3679: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
bytesofman committed rABCcff88b5382e6: [Cashtab] Show NFT offer on token page (authored by bytesofman).
[Cashtab] Show NFT offer on token page
bytesofman committed rABCc4b245224f2c: [Cashtab] More ts implementation as prep for wallet upgrade (authored by bytesofman).
[Cashtab] More ts implementation as prep for wallet upgrade
bytesofman added inline comments to D17140: [Cashtab] More ts implementation as prep for wallet upgrade.
bytesofman updated the diff for D17140: [Cashtab] More ts implementation as prep for wallet upgrade.
rebase, remove not-needed dep, back out unrelated change to alias query function, fix comment
teamcity added a comment to D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
rebase
rebase
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
rebase
PiRK updated the diff for D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.
rebase
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
teamcity added a comment to D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
fix clang-tidy
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Note that I squashed these 3 commits because they kept touching the same lines. The intermediate states in-between commits was not very interesting to have in the git history.
teamcity updated the summary of D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.
PiRK updated the diff for D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).
it didn't complain but fix it anyway
Nov 15 2024
Nov 15 2024