Feed All Stories
Nov 20 2024
Nov 20 2024
roqqit committed rABCd74a3bd8a0e8: [avalanche] Do not modify the chaintip in stake contender test (authored by roqqit).
[avalanche] Do not modify the chaintip in stake contender test
hazzarust updated the summary of D17167: [chronik] updated dependencies - Cargo.lock.
hazzarust retitled D17167: [chronik] updated dependencies - Cargo.lock from updated dependencies - cargo.lock to updated dependencies - Cargo.lock.
[arclint] Fix arc lint for Cashtab
bytesofman added inline comments to D17169: [arclint] Fix arc lint for Cashtab.
bytesofman committed rABC7d2e784926a3: [ecash-herald] Patch bug in tracking per-token agora volume (authored by bytesofman).
[ecash-herald] Patch bug in tracking per-token agora volume
Fabien added inline comments to D17169: [arclint] Fix arc lint for Cashtab.
bytesofman published D17169: [arclint] Fix arc lint for Cashtab for review.
hazzarust retitled D17167: [chronik] updated dependencies - Cargo.lock from updating dependencies - cargo.lock to updated dependencies - cargo.lock.
hazzarust updated the summary of D17167: [chronik] updated dependencies - Cargo.lock.
hazzarust retitled D17167: [chronik] updated dependencies - Cargo.lock from cargo.lock to updating dependencies - cargo.lock.
hazzarust updated the diff for D17167: [chronik] updated dependencies - Cargo.lock.
Renamed title and updated test name
teamcity awarded D17167: [chronik] updated dependencies - Cargo.lock a Haypence token.
tobias_ruck added a comment to D17167: [chronik] updated dependencies - Cargo.lock.
@bot build-chronik-plugins
tobias_ruck requested changes to D17167: [chronik] updated dependencies - Cargo.lock.
the title is wrong (the file was already there) and the test plan too (missing -)
hazzarust requested review of D17167: [chronik] updated dependencies - Cargo.lock.
Fabien committed rABC7805d72b0caa: [chronik-docs] Fix a wrong link in the websocket documentation (authored by Fabien).
[chronik-docs] Fix a wrong link in the websocket documentation
hazzarust committed rABC8f49415dbac4: [CHRONIK] add is_final to tx struct in util.rs (authored by ninafo80).
[CHRONIK] add is_final to tx struct in util.rs
Fabien requested review of D17166: [chronik-docs] Fix a wrong link in the websocket documentation.
[CI] Fix previews
Nov 19 2024
Nov 19 2024
hazzarust updated the diff for D17155: [CHRONIK] add is_final to tx struct in util.rs.
squashed 2 commits into 1 and updated
hazzarust updated the diff for D17155: [CHRONIK] add is_final to tx struct in util.rs.
Changed comments and code in proto and chronik_avalanche.py
bytesofman published D17164: [ecash-herald] Patch bug in tracking per-token agora volume for review.
tobias_ruck requested changes to D17155: [CHRONIK] add is_final to tx struct in util.rs.
hazzarust updated the diff for D17155: [CHRONIK] add is_final to tx struct in util.rs.
Made changes as revised - added tests
hazzarust added a comment to D17155: [CHRONIK] add is_final to tx struct in util.rs.
hazzarust updated the diff for D17155: [CHRONIK] add is_final to tx struct in util.rs.
Added tests post revision comments
teamcity awarded D17163: [avalanche] Do not modify the chaintip in stake contender test a Piece of Eight token.
roqqit added a comment to D17163: [avalanche] Do not modify the chaintip in stake contender test.
@bot build-tsan
roqqit updated the diff for D17163: [avalanche] Do not modify the chaintip in stake contender test.
Better approach
roqqit retitled D17163: [avalanche] Do not modify the chaintip in stake contender test from [avalanche] Add missing lock in stake contenders test to [avalanche] Do not modify the chaintip in stake contender test.
Fabien requested changes to D17163: [avalanche] Do not modify the chaintip in stake contender test.
teamcity awarded D17163: [avalanche] Do not modify the chaintip in stake contender test a Haypence token.
roqqit added a comment to D17163: [avalanche] Do not modify the chaintip in stake contender test.
@bot build-tsan
roqqit requested review of D17163: [avalanche] Do not modify the chaintip in stake contender test.
PiRK committed rABCa91e6a41e27b: util: optimize HexStr (authored by Martin Leitner-Ankerl <martin.ankerl@gmail.com>).
util: optimize HexStr
PiRK committed rABC94d6cf737131: Rework receive buffer pushback (authored by Pieter Wuille <pieter@wuille.net>).
Rework receive buffer pushback
Okay fair enough
Fabien requested review of D17162: [CI] Fix previews.
teamcity added a comment to D17143: [cashtab] Hide balance button style edits.
Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) failed.
teamcity awarded D17143: [cashtab] Hide balance button style edits a Haypence token.
Fabien added a comment to D17143: [cashtab] Hide balance button style edits.
@bot preview-cashtab
bytesofman requested changes to D17143: [cashtab] Hide balance button style edits.
This does look better but for whatever reason it seems to really slow down the behavior of the app. Scrolling locks up. I can see why the dynamic behavior of the header seemed like a major issue while doing this redesign.
bytesofman published D17154: [Cashtab] Convert Token, validation, and other deps to ts for review.
teamcity triaged T3680: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Mengerian committed rABC6653ee9ba241: [e.cash] Remove tagline about Avalanche (authored by Mengerian).
[e.cash] Remove tagline about Avalanche
johnkuney updated the diff for D17143: [cashtab] Hide balance button style edits.
add version patch
johnkuney added a comment to D17143: [cashtab] Hide balance button style edits.
Cool, yeah I agree with those UI points as well
johnkuney retitled D17143: [cashtab] Hide balance button style edits from [cashtab] Header style edits to [cashtab] Hide balance button style edits .
johnkuney updated the diff for D17143: [cashtab] Hide balance button style edits.
remove out of scope elements
Nov 18 2024
Nov 18 2024
Sintayew4 awarded D17159: util: optimize HexStr a Mountain of Wealth token.
Mengerian requested review of D17161: [e.cash] Remove tagline about Avalanche.
bytesofman requested changes to D17143: [cashtab] Hide balance button style edits.
I think the nav headers make the header too tall in this diff, e.g.
[avalanche] Add stake contender polling
roqqit committed rABC59076f7b8f83: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test (authored by roqqit).
[avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test
Nov 18 2024, 21:46 · Restricted Project
roqqit committed rABCea1205ddb23a: [avalanche] Return pending stake contender status when there is no local… (authored by roqqit).
[avalanche] Return pending stake contender status when there is no local…
PiRK updated the summary of D17159: util: optimize HexStr.
PiRK abandoned D17139: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation.
squashed with D17138
PiRK updated the diff for D17138: Rework receive buffer pushback.
squash with tests
PiRK committed rABC17760e91d644: Handle invalid hex encoding in ParseHex (authored by MarcoFalke <6399679+MarcoFalke@users.noreply.github.com>).
Handle invalid hex encoding in ParseHex
PiRK committed rABC000b0266e7e8: util: Add ParseHex<std::byte>() helper (authored by MarcoFalke <falke.marco@gmail.com>).
util: Add ParseHex<std::byte>() helper
PiRK committed rABCabfd248f0a4b: refactor: Take Span in SetSeed (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Take Span in SetSeed
Fabien requested changes to D17139: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation.
See comment in D17138
Fabien requested changes to D17138: Rework receive buffer pushback.
Can you please squash D17139 ? I don't think it makes sense to have the bugfix and the test be separate diffs.
roqqit updated the diff for D17144: [avalanche] Return pending stake contender status when there is no local staking rewards computed.
Added back an invalid case. It is incomplete since the local winner does not actually trigger an ACCEPT vote, but this should make it more obvious where that test is heading.
roqqit requested review of D17160: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test.
johnkuney published D17143: [cashtab] Hide balance button style edits for review.
teamcity updated the summary of D17159: util: optimize HexStr.