lgtm (if the bitcoin-chainstate / kernel build does not fail)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Thu, Mar 20
Thu, Mar 20
teamcity added a comment to D17836: [avalanche] Improve lock annotations for AvalancheFinalizeBlock.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
PiRK added inline comments to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
PiRK added inline comments to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
PiRK added inline comments to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
This whole diff is a test on how Grok v3 can helpful to do semi-automated changes on a large amount of code.
It worked quite well, I just had to revert a few changes msg_avaproofs.serialize and msg_avaproofsreq.serialize, which imo were not trivial enough to justify removing the intermadiate var and all the comments to make it a one-liner.
back-off unrelated changes
Fabien updated the diff for D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Fix another lock issue (cs_main => cs_peermanager)
Switch to my branch and commit again.
this diff was created on the master branch, which makes it difficult to rebase onto the latest master
Wed, Mar 19
Wed, Mar 19
teamcity added a comment to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Fabien committed rABCd0d90118ccea: [avalanche] Add to the recently finalized items filter at callsite (authored by Fabien).
[avalanche] Add to the recently finalized items filter at callsite
Fabien updated the diff for D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Fix mempool lock
roqqit requested changes to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
back to you
This looks a bit odd to move it to the callsite but since it is moving in the right direction with regards to the processor FIXME, it is probably a small step in the right direction.
teamcity added a comment to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Fabien committed rABC9b7827b53bdd: Bump the log crawling timeout after node restart in rpc_setban.py (authored by Fabien).
Bump the log crawling timeout after node restart in rpc_setban.py
Fabien requested review of D17830: Bump the log crawling timeout after node restart in rpc_setban.py.
Fabien requested review of D17829: [avalanche] Add to the recently finalized items filter at callsite.
Completed the above modifications
teamcity triaged T3772: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
- If we are switching from px to rem, switch; remove all the px comments, mb keep one to show what the base-level px is
- do not use calc. if some ratios seem unreadable, create a variable for them and use the variable
- remove all unused variables
bytesofman committed rABC0ba12c26bb6d: [install readme] Add deps needed to build with chronik and plugins (authored by bytesofman).
[install readme] Add deps needed to build with chronik and plugins
bytesofman updated the diff for D17826: [install readme] Add deps needed to build with chronik and plugins.
back out the pythonpath stuff, add dep
bytesofman updated the diff for D17826: [install readme] Add deps needed to build with chronik and plugins.
debian python note
bytesofman published D17826: [install readme] Add deps needed to build with chronik and plugins for review.
bytesofman committed rABCb50acc96032b: [Cashtab] Patch bug in rendering of managed NFTs (authored by bytesofman).
[Cashtab] Patch bug in rendering of managed NFTs
PiRK committed rABCe5e31cf6c69a: [electrum] bump the version to 5.4.1 and add release notes (authored by PiRK).
[electrum] bump the version to 5.4.1 and add release notes
[electrum] No python 3.12 syntax
[electrum] Pin version of shamir-mnemonic
PiRK committed rABC79a912688729: [electrum] fix pyopenssl version (authored by Jonas Lundqvist <jonas@gannon.se>).
[electrum] fix pyopenssl version
[CI] Fix the chronik-plugins docker image
PiRK committed rABCa370271feb5e: [electrum] include metadata for slip10 for the windows and osx releases (authored by PiRK).
[electrum] include metadata for slip10 for the windows and osx releases
PiRK published D17819: [electrum] include metadata for slip10 for the windows and osx releases for review.
bytesofman added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
In D17815#406034, @bytesofman wrote:would be a good change and help to get some of the css more standardized in Cashtab
Tue, Mar 18
Tue, Mar 18
would be a good change and help to get some of the css more standardized in Cashtab
bytesofman committed rABCcdbb66df256c: [chronik-client] Patch failoverProxy to recognize another type of server failure (authored by bytesofman).
[chronik-client] Patch failoverProxy to recognize another type of server failure
bytesofman updated the diff for D17814: [chronik-client] Patch failoverProxy to recognize another type of server failure.
better comments
Fabien committed rABC88dc412d3367: [avalanche] Improve performance of inventory filtering (authored by Fabien).
[avalanche] Improve performance of inventory filtering
roqqit committed rABCf7b0bdf7c762: [electrum] Fix typo in trezor firmware warning text (authored by roqqit).
[electrum] Fix typo in trezor firmware warning text
mention which devices have a custom Trezor firmware
reflow release note
[Cashtab] Introduce CSS variables to make styling easier