Fixed according to feedback
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mar 4 2019
Mar 4 2019
jasonbcox updated the diff for D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.
Cleanup nSmartFeeSliderPosition settings
Rebase
jasonbcox committed rABC8a165551eff6: Added functional test for estimatefee RPC (authored by jasonbcox).
Added functional test for estimatefee RPC
Rebase + added separating line between imports
Done: D2641
Still need to rebase this diff.
Herald added a reviewer for D2641: Removed unused confirmation target dropdown from the UI: Restricted Project.
Mar 2 2019
Mar 2 2019
jasonbcox committed rABCed234bd3bb18: Fix undefined behavior in rpc/server.cpp (authored by jasonbcox).
Fix undefined behavior in rpc/server.cpp
jasonbcox committed rABCf9c866be05a6: Fix a bug in ibd.sh where multiple args provided to the script would not be… (authored by jasonbcox).
Fix a bug in ibd.sh where multiple args provided to the script would not be…
Herald added a reviewer for D2637: Fix a bug in ibd.sh where multiple args provided to the script would not be parsed correctly: Restricted Project.
Mar 1 2019
Mar 1 2019
jasonbcox accepted D2612: Updated ibd.sh script to take bitcoind options and then pass them directly to the bitcoind call..
I will update the TeamCity config to the following once this is landed:
- Existing IBD will have -disablewallet added to ensure the config behavior remains the same
- A new IBD setting will be added with -disablewallet -assumevalid=0 -checkpoints=0
Fix unnecessary copy
Added new test timing
jasonbcox added inline comments to D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.
jasonbcox committed rABC7839640916c5: Avoid NULL pointer dereference when _walletModel is NULL (which is valid) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Avoid NULL pointer dereference when _walletModel is NULL (which is valid)
jasonbcox committed rABC9bae8c8bf6f1: Use two boolean literals instead of re-using variable (authored by practicalswift <practicalswift@users.noreply.github.com>).
Use two boolean literals instead of re-using variable
jasonbcox committed rABCc99e09a9a9db: Remove duplicate uriParts.size() > 0 check (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove duplicate uriParts.size() > 0 check
jasonbcox committed rABC9dd6ff0deb2d: Remove redundant NULL checks after new (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant NULL checks after new
jasonbcox committed rABC32f04379b4e5: Remove redundant check (!ecc is always true) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant check (!ecc is always true)
Feb 28 2019
Feb 28 2019
Feb 27 2019
Feb 27 2019
jasonbcox updated the test plan for D2625: Avoid NULL pointer dereference when _walletModel is NULL (which is valid).
jasonbcox updated the test plan for D2625: Avoid NULL pointer dereference when _walletModel is NULL (which is valid).
Herald added a reviewer for D2625: Avoid NULL pointer dereference when _walletModel is NULL (which is valid): Restricted Project.
Herald added a reviewer for D2624: Use two boolean literals instead of re-using variable: Restricted Project.
Herald added a reviewer for D2621: Remove redundant check (!ecc is always true): Restricted Project.
jasonbcox renamed T524: Improve IBD script to support arbitrary params from Write a continuous IBD script to Improve IBD script to support arbitrary params.
Moving this off of the review queue until the dependencies are finished.
jasonbcox requested changes to D2168: [qa] [move only] Move threading helpers to be top level functions..
Likely needs rebasing.
jasonbcox requested changes to D2586: [avalanche] Reject votes that fromnodes which already are in the quorum..
jasonbcox updated the summary of D2604: Enable automatic detection of undefined names in Python tests scripts.
jasonbcox updated the summary of D2604: Enable automatic detection of undefined names in Python tests scripts.
jasonbcox updated the summary of D2604: Enable automatic detection of undefined names in Python tests scripts.
Feb 26 2019
Feb 26 2019
jasonbcox added inline comments to D2606: Refactor ProcessGetData in anticipation of avoiding cs_main for ABC.
Herald added a reviewer for D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands: Restricted Project.
jasonbcox requested changes to D2612: Updated ibd.sh script to take bitcoind options and then pass them directly to the bitcoind call..
Testplan should indicate that the params passed in were verified in logs or otherwise
jasonbcox added inline comments to D2606: Refactor ProcessGetData in anticipation of avoiding cs_main for ABC.
jasonbcox requested changes to D2606: Refactor ProcessGetData in anticipation of avoiding cs_main for ABC.
Rebase to depend on D2614
Herald added a reviewer for D2614: Remove unused param from txmempool::estimateFee: Restricted Project.
jasonbcox added inline comments to D2608: Require no cs_main lock for ProcessNewBlock/ActivateBestChain.
Feb 25 2019
Feb 25 2019
jasonbcox updated the diff for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Rebase
jasonbcox committed rABCf10ed0743aa1: Revert "Cleanup unused confirm target in GetMinimumFee()" (authored by jasonbcox).
Revert "Cleanup unused confirm target in GetMinimumFee()"
This script already exists, for the most part: contrib/teamcity/ibd.sh Update it so that we can pass in -assumevalid=0 -checkpoints=0
Herald added a reviewer for D2601: Revert "Cleanup unused confirm target in GetMinimumFee()": Restricted Project.