nakihito retitled D4439: Allow Seeder to handle receiving HEADER messages from Allow Seeder to handle receiving NOTFOUND and HEADER messages to Allow Seeder to handle receiving HEADER messages.

Nov 14 2019, 04:25

teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 04:25

nakihito planned changes to D4439: Allow Seeder to handle receiving HEADER messages.

Nov 14 2019, 04:24

nakihito updated the diff for D4439: Allow Seeder to handle receiving HEADER messages.

Rebase, split test into two different tests, removed NOTFOUND message functionality because it is not necessary, added differentiating logic for an empty HEADERS message and a non-empty HEADERS message. Also added some more constants.

Nov 14 2019, 04:24

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 04:21

nakihito planned changes to D4436: Add unit tests for CSeederNode::ProcessMessage().

Nov 14 2019, 04:21

nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Changed static_cast into a functional cast.

Nov 14 2019, 04:21

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 04:07

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 03:58

nakihito planned changes to D4436: Add unit tests for CSeederNode::ProcessMessage().

Nov 14 2019, 03:58

nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Split tests into smaller parts and added more constants.

Nov 14 2019, 03:58

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 03:20

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 03:11

nakihito planned changes to D4418: Add simple unit tests for parse_name().

Nov 14 2019, 03:11

nakihito updated the diff for D4418: Add simple unit tests for parse_name().

Broken tests into smaller parts, made names more explicit, added more constants.

Nov 14 2019, 03:11

teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing passed.

Nov 14 2019, 02:33

deadalnix committed rABC2ca660ddcf75: Various nits in cuckoocache.h (authored by deadalnix).

Various nits in cuckoocache.h

Nov 14 2019, 02:18

deadalnix closed D4440: Various nits in cuckoocache.h.

Nov 14 2019, 02:18

teamcity added a comment to D4300: Integrate gArgs and chainparams into the Seeder.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 01:52

nakihito requested review of D4300: Integrate gArgs and chainparams into the Seeder.

Nov 14 2019, 01:44

teamcity added a comment to D4300: Integrate gArgs and chainparams into the Seeder.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 01:43

nakihito planned changes to D4300: Integrate gArgs and chainparams into the Seeder.

Nov 14 2019, 01:43

nakihito updated the diff for D4300: Integrate gArgs and chainparams into the Seeder.

Came up with a better solution for the return value of ParseCommandLine(). Changed handling of -testnet option to mirror bitcoin-cli.cpp.

Nov 14 2019, 01:43

nakihito planned changes to D4300: Integrate gArgs and chainparams into the Seeder.

Nov 14 2019, 01:10

nakihito planned changes to D4418: Add simple unit tests for parse_name().

Nov 14 2019, 00:56

nakihito planned changes to D4436: Add unit tests for CSeederNode::ProcessMessage().

Nov 14 2019, 00:52

jasonbcox accepted D4440: Various nits in cuckoocache.h.

Nov 14 2019, 00:33

jasonbcox retitled D4440: Various nits in cuckoocache.h from Various nits un cuckoocache.h to Various nits in cuckoocache.h.

Nov 14 2019, 00:32

Nov 13 2019

teamcity added a comment to D4440: Various nits in cuckoocache.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 23:16

teamcity added a comment to D4440: Various nits in cuckoocache.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 23:11

teamcity added a comment to D4440: Various nits in cuckoocache.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 23:06

deadalnix updated the diff for D4440: Various nits in cuckoocache.h.

Add fogoten brace

Nov 13 2019, 23:06

teamcity added a comment to D4440: Various nits in cuckoocache.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 23:02

deadalnix created D4440: Various nits in cuckoocache.h.

Nov 13 2019, 23:01

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 21:58

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 21:49

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 21:43

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 21:34

teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 21:05

teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 20:56

nakihito planned changes to D4439: Allow Seeder to handle receiving HEADER messages.

Nov 13 2019, 20:56

nakihito created D4439: Allow Seeder to handle receiving HEADER messages.

Nov 13 2019, 20:56

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 20:03

teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing started.

Nov 13 2019, 19:57

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 19:54

nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Cleaned up TestCSeederNode and rebase.

Nov 13 2019, 19:53

teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing failed.

Nov 13 2019, 19:50

nakihito requested review of D4418: Add simple unit tests for parse_name().

Nov 13 2019, 19:49

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 19:49

teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing started.

Nov 13 2019, 19:46

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 19:40

teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) failed.

Nov 13 2019, 19:39

teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) started.

Nov 13 2019, 19:38

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Nov 13 2019, 19:19

Harbormaster failed remote builds in B8095: Diff 14106 for D4418: Add simple unit tests for parse_name()!

Nov 13 2019, 19:19

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 19:14

nakihito planned changes to D4418: Add simple unit tests for parse_name().

Nov 13 2019, 19:13

nakihito updated the diff for D4418: Add simple unit tests for parse_name().

Removed code creating the DNS message header because it is unnecessary for these tests. Renamed various functions/variables. Also added some more comments.

Nov 13 2019, 19:13

nakihito requested review of D4300: Integrate gArgs and chainparams into the Seeder.

Nov 13 2019, 18:11

nakihito requested review of D4417: Add a separate executable for seeder tests.

Nov 13 2019, 18:05

nakihito updated the test plan for D4417: Add a separate executable for seeder tests.

Nov 13 2019, 18:05

teamcity added a comment to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 14:51

teamcity added a comment to D4438: [CMAKE] Use a stripped binary to build the dist and DMG for OSX.

Build Bitcoin-ABC / Diffs / Diff Testing passed.