Page MenuHomePhabricator
Feed Advanced Search

Nov 3 2023

emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

I must have missed something here

Nov 3 2023, 23:57
emack closed D14713: [Cashtab][Alias] Check Alias function.
Nov 3 2023, 14:55
emack committed rABC6954c1d261ed: [Cashtab][Alias] Check Alias function (authored by emack).
[Cashtab][Alias] Check Alias function
Nov 3 2023, 14:55
emack updated the diff for D14713: [Cashtab][Alias] Check Alias function.

Rebase to master

Nov 3 2023, 14:32
emack closed D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.
Nov 3 2023, 14:13
emack committed rABC86052e98a0fb: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal (authored by emack).
[Cashtab][Alias] Increase pending warning emphasis on confirmation modal
Nov 3 2023, 14:13
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

Updated processChronikWsMsg() to refresh pricing every 90 blocks rather than every block

Nov 3 2023, 07:19
emack updated the diff for D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.

Updated UI as follows

Nov 3 2023, 00:11

Nov 2 2023

emack closed D14719: [Cashtab] Seed warning confirmation check.
Nov 2 2023, 22:04
emack committed rABC7d6047f1d2a8: [Cashtab] Seed warning confirmation check (authored by emack).
[Cashtab] Seed warning confirmation check
Nov 2 2023, 22:04
emack requested review of D14713: [Cashtab][Alias] Check Alias function.

You should do an API call on each block and store the value locally, obviously a lookup for each keystroke is the wrong design.

this is a good idea but imo should be it's own diff. not necessarily related to just this UI change, easy enough to add into this UI -- but does require some new logic.

Nov 2 2023, 21:59
emack updated the test plan for D14728: [Cashtab][Alias] Sync pricing on new blocks.
Nov 2 2023, 14:31
emack requested review of D14728: [Cashtab][Alias] Sync pricing on new blocks.
Nov 2 2023, 14:31
emack updated the test plan for D14719: [Cashtab] Seed warning confirmation check.
Nov 2 2023, 03:57
emack updated the diff for D14719: [Cashtab] Seed warning confirmation check.

Updated checkbox logic to toggle between showing and hiding the seed phrase in addition to the updated static warning message.

Nov 2 2023, 03:56
emack updated the diff for D14713: [Cashtab][Alias] Check Alias function.

Updated UI per feedback.

Nov 2 2023, 03:13
emack updated the summary of D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.
Nov 2 2023, 02:02
emack requested review of D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.
Nov 2 2023, 02:01

Nov 1 2023

emack closed D14611: [Cashtab][Alias] Pending Aliases.
Nov 1 2023, 22:49
emack committed rABC8e4b8d528fd7: [Cashtab][Alias] Pending Aliases (authored by emack).
[Cashtab][Alias] Pending Aliases
Nov 1 2023, 22:49
emack updated subscribers of D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Nov 1 2023, 07:12
emack updated the diff for D14708: [Cashtab][Swap] Add swap component with SideShift integration.

Setting the IFP address as the settlement address.

Nov 1 2023, 07:10
emack requested review of D14719: [Cashtab] Seed warning confirmation check.
Nov 1 2023, 06:58
emack changed the visibility for D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Nov 1 2023, 03:46
emack updated the summary of D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Nov 1 2023, 01:15
emack updated the diff for D14708: [Cashtab][Swap] Add swap component with SideShift integration.

Added isValidSideshiftObj() along with unit tests to validation.js to check that the instantiated sideshift object contains the expected APIs. If not valid, an error is displayed in place of the button in Swap.js. This can be verified by malforming the sidieshift library url in /public/index.html header.

Nov 1 2023, 01:14
emack added a comment to D14713: [Cashtab][Alias] Check Alias function.

Rejigged UI for reference:

Nov 1 2023, 00:22
emack updated the diff for D14713: [Cashtab][Alias] Check Alias function.

Re-arranged UI per feedback, updated label for active wallet registration checkbox.

Nov 1 2023, 00:21

Oct 31 2023

emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

Improved pending array filter and variable names.

Oct 31 2023, 23:46
emack updated the summary of D14713: [Cashtab][Alias] Check Alias function.
Oct 31 2023, 13:54
emack requested review of D14713: [Cashtab][Alias] Check Alias function.
Oct 31 2023, 13:52
emack abandoned D14666: [Cashtab][Alias] Alias lookup facility.

Will re-use the existing registration field with a check button as a separate diff.

Oct 31 2023, 13:31
emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

Added pendingAliasCounter to tally count of certain aliases within the pending array for the current address.

Oct 31 2023, 13:22
emack planned changes to D14611: [Cashtab][Alias] Pending Aliases.
Oct 31 2023, 13:05
emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

Added conditional substring to the pending alias warning which indicates number of pending registrations for this wallet address.

Oct 31 2023, 13:01
emack updated the diff for D14708: [Cashtab][Swap] Add swap component with SideShift integration.

Updated test snapshot for Home

Oct 31 2023, 06:54
emack planned changes to D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Oct 31 2023, 06:50
emack changed the visibility for D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Oct 31 2023, 06:47
emack requested review of D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Oct 31 2023, 06:47
emack abandoned D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 31 2023, 06:47
emack planned changes to D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 31 2023, 02:55

Oct 29 2023

emack retitled D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC) from [Cashtab][Swap] Sideshift integration (POC) to [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 29 2023, 01:28
emack updated the diff for D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).

Updated the Swap component to be a central portal for all Swap widgets rather than SideShift specific. It now houses both ChangeNow and SideShift.

Oct 29 2023, 01:18
emack retitled D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC) from [Cashtab][Swap] Sideshift integration (POC) to [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 29 2023, 01:18

Oct 28 2023

emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 23:56
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 23:39
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 23:39
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 14:04
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 14:00
emack requested review of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 13:57
emack added a comment to D14269: [Chronik-client] - Cycle through backup instances on outage.

On a separate note, I've also carried out localized usage of this diff in /apps/examples and it tested fine.
i.e.

  1. Refreshed the dist folder within /modules/chronik-client repo via npm run build
  2. Go into /apps/examples and removed current client npm uninstall chronik-client
  3. Installed this diff via npm i ../../modules/chronik-client
  4. Go into /apps/examples/getDetailsFromTxid.js, import the client via the relative path above and instantiated ChronikClient constructor with an array of 1 mispelt url (simulated outage) and 1 correctly spelt url
  5. Executed the example via npm run getDetailsFromTxid <txid> and it should cycle past the 1st url and connects successfully on the 2nd url to return the transaction details.
Oct 28 2023, 09:06
emack added inline comments to D14269: [Chronik-client] - Cycle through backup instances on outage.
Oct 28 2023, 08:01
emack updated the diff for D14269: [Chronik-client] - Cycle through backup instances on outage.

Responding to feedback

Oct 28 2023, 08:00
emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

Full onchain pending alias check is now implemented in the post-registration-button-click logic (preparePreviewModal), which renders an additional sentence in the registration confirmation modal, depending on whether pending.length is > 0. The local pending check per keystroke is now removed due to low value.

Oct 28 2023, 05:11

Oct 27 2023

emack planned changes to D14611: [Cashtab][Alias] Pending Aliases.
Oct 27 2023, 21:37
emack requested review of D14666: [Cashtab][Alias] Alias lookup facility.

Why do you have a search button if you're having the lookup at every key stroke ?

Pending the pending discussion in D14611 before evaluating whether this search is redundant.

Oct 27 2023, 14:14
emack added a comment to D14666: [Cashtab][Alias] Alias lookup facility.

Why do you have a search button if you're having the lookup at every key stroke ?

Oct 27 2023, 11:43
emack requested review of D14611: [Cashtab][Alias] Pending Aliases.
Oct 27 2023, 11:39
emack planned changes to D14666: [Cashtab][Alias] Alias lookup facility.
Oct 27 2023, 11:29
emack added a comment to D14666: [Cashtab][Alias] Alias lookup facility.
Oct 27 2023, 09:58

Oct 26 2023

emack updated the diff for D14666: [Cashtab][Alias] Alias lookup facility.
  • Initialized aliasLookupName in formData
  • Using the newest pending prop in the /alias endpoint to distinguish between unregistered or pending confirmation aliases
  • Screenshots below:
Oct 26 2023, 23:27
emack added inline comments to D14269: [Chronik-client] - Cycle through backup instances on outage.
Oct 26 2023, 22:00
emack updated the diff for D14269: [Chronik-client] - Cycle through backup instances on outage.

Responding to feedback. Note: the XPI url was unstable recently and started breaking the test suite. Replaced all instances of this with the working XEC version in test.ts.

Oct 26 2023, 22:00

Oct 25 2023

emack accepted D14683: [alias-server] Return pending registrations for a specified alias.
Oct 25 2023, 21:57
emack planned changes to D14611: [Cashtab][Alias] Pending Aliases.

Pending D14683

Oct 25 2023, 05:43
emack accepted D14681: [examples] Update dependencies.
Oct 25 2023, 02:03
emack added a comment to D14578: [Cashtab] Deprecate airdrops.

quick note - if you end up going through with this you'll need to remove this button from SendToken.js as well

image.png (129×448 px, 11 KB)

Oct 25 2023, 02:02
emack accepted D14682: [mock-chronik-client] Update dependencies.
Oct 25 2023, 01:57
emack requested changes to D14683: [alias-server] Return pending registrations for a specified alias.

Worth noting this would be implemented at the point of pressing the register button and not when the user is inputting the alias name with each keystroke being parsed for validity. I can add it as a conditional text render in the registration confirmation modal (preparePreviewModal).

Oct 25 2023, 01:53

Oct 24 2023

emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

The alias registration input field now detects whether an input (without needing to click Register Alias) already has a pending tx for this wallet and renders a non-blocking warning.

Oct 24 2023, 11:32

Oct 23 2023

teamcity awarded D14666: [Cashtab][Alias] Alias lookup facility a Haypence token.
Oct 23 2023, 13:21
emack updated the test plan for D14611: [Cashtab][Alias] Pending Aliases.
Oct 23 2023, 12:12

Oct 22 2023

emack requested review of D14666: [Cashtab][Alias] Alias lookup facility.
Oct 22 2023, 11:23

Oct 17 2023

emack requested review of D14611: [Cashtab][Alias] Pending Aliases.
Oct 17 2023, 11:18
emack closed D14610: [Cashtab[Alias] Clear registration input after broadcast.
Oct 17 2023, 07:01
emack committed rABC9b065e2383aa: [Cashtab[Alias] Clear registration input after broadcast (authored by emack).
[Cashtab[Alias] Clear registration input after broadcast
Oct 17 2023, 07:01

Oct 16 2023

emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

Rebased to master after state var cleanup

Oct 16 2023, 11:22
emack updated the diff for D14610: [Cashtab[Alias] Clear registration input after broadcast.

Rebased to master after state var cleanup

Oct 16 2023, 10:50
emack closed D14624: [Cashtab][Ailas] Remove aliasToRegister and aliasLength state vars.
Oct 16 2023, 10:39
emack committed rABC8ea867c5bdca: [Cashtab][Ailas] Remove aliasToRegister and aliasLength state vars (authored by emack).
[Cashtab][Ailas] Remove aliasToRegister and aliasLength state vars
Oct 16 2023, 10:39

Oct 15 2023

emack added a comment to D14611: [Cashtab][Alias] Pending Aliases.

Pls note the state var cleanup is via D14624.

Oct 15 2023, 01:47
emack added a comment to D14611: [Cashtab][Alias] Pending Aliases.

Does a page refresh trigger an alias server call ?

Yes it does. The useEffect() within Alias.js that has a dependency on [wallet.name] triggers it upon refresh of the page. So this serves as another, more common mitigation path.

Oct 15 2023, 01:44
emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

Updated interval default value and initialization logic.

Oct 15 2023, 01:44

Oct 14 2023

emack updated the diff for D14624: [Cashtab][Ailas] Remove aliasToRegister and aliasLength state vars.

Rebase to master

Oct 14 2023, 12:17
emack closed D14638: [Cashtab][Alias] Remove redundant node error translation in handleAliasRegistrationError.
Oct 14 2023, 12:12
emack committed rABC38455aff4a7f: [Cashtab][Alias] Remove redundant node error translation in… (authored by emack).
[Cashtab][Alias] Remove redundant node error translation in…
Oct 14 2023, 12:11

Oct 13 2023

emack updated the test plan for D14638: [Cashtab][Alias] Remove redundant node error translation in handleAliasRegistrationError.
Oct 13 2023, 09:51
emack added a comment to D14638: [Cashtab][Alias] Remove redundant node error translation in handleAliasRegistrationError.

There was no test for this ?

Oct 13 2023, 09:51
emack added a comment to D14638: [Cashtab][Alias] Remove redundant node error translation in handleAliasRegistrationError.

image.png (524×522 px, 89 KB)

Oct 13 2023, 05:12
teamcity awarded D14638: [Cashtab][Alias] Remove redundant node error translation in handleAliasRegistrationError a Haypence token.
Oct 13 2023, 05:09
emack added a comment to D14638: [Cashtab][Alias] Remove redundant node error translation in handleAliasRegistrationError.

@bot build-cashtab

Oct 13 2023, 05:09
emack requested review of D14638: [Cashtab][Alias] Remove redundant node error translation in handleAliasRegistrationError.
Oct 13 2023, 04:59
emack accepted D14636: [herald] Update dependencies.
Oct 13 2023, 03:23
emack accepted D14637: [Cashtab] Update dependencies.
Oct 13 2023, 03:20
emack accepted D14635: [alias-server] Run npm audit fix to patch dependency issue.
Oct 13 2023, 03:14
emack added a comment to D14607: [chronik-client] Support connection to in-node chronik.

Also worth considering whether to use D14269 as a baseline since that refactors ~60% of chronik-client

Oct 13 2023, 03:11
emack updated the diff for D14624: [Cashtab][Ailas] Remove aliasToRegister and aliasLength state vars.

Updated snapshot @generated tag

Oct 13 2023, 03:08
emack updated the diff for D14624: [Cashtab][Ailas] Remove aliasToRegister and aliasLength state vars.

Added aliasLength as a local var

Oct 13 2023, 03:06

Oct 12 2023

emack requested review of D14624: [Cashtab][Ailas] Remove aliasToRegister and aliasLength state vars.
Oct 12 2023, 09:55

Oct 11 2023

emack updated the diff for D14624: [Cashtab][Ailas] Remove aliasToRegister and aliasLength state vars.

Using getAliasByteSize in place of formData.aliasName.length.

Oct 11 2023, 12:22