Rebase to master and correcting expect() statement

See https://reviews.bitcoinabc.org/D15079#change-FQ7xkm8tTewN for new approach to testing localForage interactions for feedback

In D15042#337747, @bytesofman wrote:

Tested all ok in chrome however I feel like the usage of chrome APIs in this diff is the start of permanently locking the extension into the chrome ecosystem and any future plans to port this over to firefox, brave...etc will require significant refactor. Double checking here that this is the intention?

The use of extensionizer to run chrome APIs means we could (in theory) still extend to other browsers supported by extensionizer -- is the chrome param used directly anywhere?

There would still be more work to do + testing to make sure everything works in another browser, but we aren't really adding more chrome APIs here, really we are getting rid of one.

will check on the window killing situation.

A few extra refreshes seem to be happening which then confuses cashtab into momentarily thinking this is an empty wallet

Tested all ok in chrome however I feel like the usage of chrome APIs in this diff is the start of permanently locking the extension into the chrome ecosystem and any future plans to port this over to firefox, brave...etc will require significant refactor. Double checking here that this is the intention?

Will land this once I coordinate the tweet release with the comms team.

Removed snapshot in alignment with recent change in snapshot testing philosphy. Test plan reflects integration testing coverage.

rebase

• rebased/merged to D14990 (landed earlier today) where the extension app.js is removed altogether and extension specific logic is conditionally executed based on env var
• dropped the lingering commit via interactive rebase that was causing the unit test error
• removed redundant previousWallet checks

rebase to master

In D15000#336782, @bytesofman wrote:

If the way wallet switching is done in Configure.js is not portable, mb this needs to be fixed first.

Removed withWalletPresent and will now redirect to the default wallet screen i.e. onboarding/wallet creation

In D15025#337181, @Fabien wrote:

maybe you need to rebase ?

In D15025#337157, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: Improved Cashtab transaction broadcasting function sendXec: Sending below dust threshold ======
Error: expect(received).rejects.toThrow(expected)

Expected substring: "Transaction must send more than dust threshold of 546 satoshis"
Received message:   "Transaction output amount must be at least the dust threshold of 546 satoshis"

As discussed on tg, quite the complexity in squeezing html markup into a state var and somehow make React render it in html and not a string.

Switched alias availability color from vomit green to eCash blue in order to align with the Cashtab's color scheme

Moved the clearTimeout call to the end of useEffect() when the component unmounts

In D14885#334392, @bytesofman wrote:

Still useful to know there are pending registrations though. The user still gets a popup msg / warning in this case on trying to register?

Deprecating check alias in another diff

In D14885#334256, @emack wrote:

In D14885#334242, @Fabien wrote:

That's smart, but what is the point of the check button then ? Can it be removed ?

Yea the Check button can be removed as this is a more elegant solution. I'll update this diff to also render a UI message when the alias is available for consistency.
I'll deprecate the check button in a separate diff.

Adding the generated tag back into snapshot

In D14885#334242, @Fabien wrote:

That's smart, but what is the point of the check button then ? Can it be removed ?

In D14728#333005, @Fabien wrote:

wait for a new block to be found and observe the "New block found, refreshing alias prices" message in console

I think this message has been removed ?

Updated for pricing array length 0 check, diff summary and test plan.

Updated array length checks, error message and price element index.

Per tg chat, disabling alias registration if the pricing array from API has more than one entry. I've kept the Alias component itself still accessible as the user should still be able to check their purchased aliases, which is separate from pricing matters.

Removed debug logs

Updated nit

Removed aliasFee state far and updated component to access directly from the aliasPrices object

Added real time localized pricing displays per alias input, improved not null checks, added default value for aliasPAram in queryAliasServer args.
LocalString formatting applied to pricing since it's likely to eventually be a large number in prod.

Backing out extension changes

Alias.js now pulls aliasPrices as a context variable and triggers a regresh if none exist.

• parentAffiliatedId set to the official ABC account from Antony
• Reverted settleAddress back to undefined otherwise the Receiving Address field will not be displayed in the widget. Whoever is managing the ABC account can just execute monthly withdrawals from the official account to the IFP address.

In D14728#331163, @Fabien wrote:

Any block height related optimization will incur an API call to get the latest blockheight as a minimum.

Not with websockets ?