The above CI failure is unrelated (likely fixed by backporting https://github.com/bitcoin/bitcoin/pull/21814)

still checking some stuff (g_avalanche pointer dereferencing safety)

self review notes

no need to pass avalanche to ChainstateManager::ActivateSnapshot, it is passed to the chainstate after it is initialized

No, actually that CI failure related to locks is already fixed. It is just a CI job that finished after I already updated the diff and removed the offending code.

looks like i need more mutexes

@bot build-tsan

@bot build-tsan

Same unit test failing as in the previous run. And also p2p_compactblocks.py now seems flaky (same failure here and in D16233)

@bot build-tsan

it failed why I reviewed. It seems unrelated, but I have never seen this error before so better rerun the tests

This would not print out messages for blocks that are never finalized because another block with the same height is found within a few seconds of the first and the second block ends up being finalized less than 10s after the first one is connected. Not sure if we want to see these messages, and if we do whether this should be handled in this diff or in a follow-up

undo accidental comment change, rebase on D16212 (add as a dependency)

include string in notifications_interface, now that the include is no longer done in a parent diff

include util/translation.h rather than <string>, and only if necessary (use forward declarations of bilingual_str when possible)

@bot build-win64

It is not related to this diff.
The first message in websocket.ts (line 336) seems to have timed out, and after that all tests fail because they receive the previous message (everything is shifted by 1 message).

Looking into the test failure

rebase on D16203 (removes include changes that are not directly related)