use more flexible approach that allows dependencies to have dependencies
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Sat, Dec 28
In D17402#395972, @Fabien wrote:Do you know where you want to go with this change ? I mean the end filters.
Do you know where you want to go with this change ? I mean the end filters.
we need more stablecoins. cashtab already supports token features
cashtab should not do this. really the contact list is too much already.
no
too much for cashtab. i don't think cashtab should be as "permanent" as poweruser wallet like electrum.
Fri, Dec 27
@bot ecash-lib-integration-tests
In D17398#395903, @teamcity wrote:Tail of the build log:
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s ----------------------------|---------|----------|---------|---------|------------------------------ All files | 28.33 | 26.4 | 28.35 | 44.85 | ecash-lib | 0 | 0 | 0 | 0 | eslint.config.js | 0 | 0 | 0 | 0 | ecash-lib/dist/ffi | 0 | 0 | 0 | 0 | ecash_lib_wasm_browser.js | 0 | 0 | 0 | 0 | 3-336 ecash_lib_wasm_nodejs.js | 0 | 0 | 0 | 0 | 1-264 ecash-lib/src | 35.84 | 28.6 | 39.24 | 68.05 | consts.ts | 0 | 100 | 100 | 0 | 6-8 ecc.ts | 30.76 | 83.33 | 22.22 | 57.14 | 23-31 hash.ts | 47.05 | 83.33 | 44.44 | 88.88 | 14 index.ts | 0 | 0 | 0 | 0 | indexBrowser.ts | 0 | 0 | 0 | 0 | indexNodeJs.ts | 0 | 0 | 0 | 0 | initBrowser.ts | 0 | 100 | 0 | 0 | 11-13 initNodeJs.ts | 53.84 | 100 | 66.66 | 85.71 | 12 op.ts | 20.13 | 23.33 | 36.36 | 39.47 | ...4,107,109,117-122,133-161 opcode.ts | 50.2 | 83.33 | 100 | 100 | 1 script.ts | 28.97 | 20.58 | 31.03 | 51.78 | ...1-122,133,143,153,175-186 sigHashType.ts | 40 | 25 | 46.15 | 78.94 | 26-38 tx.ts | 47.25 | 45.23 | 47.61 | 87.23 | 110,114,123-125,144 txBuilder.ts | 40.64 | 32.69 | 54.54 | 80.21 | ...1,154,173-178,183,253-257 unsignedTx.ts | 25.27 | 16 | 30.76 | 46.15 | ...9,312,320,326-329,345,357 ecash-lib/src/address | 11.35 | 15.15 | 5.12 | 22.41 | address.ts | 10.95 | 11.36 | 3.22 | 21.05 | ...3,239-240,255-256,266-344 legacyaddr.ts | 12.04 | 22.72 | 12.5 | 25 | 15-19,23-38,70-111,124-128 ecash-lib/src/ffi | 28.26 | 15.94 | 16.98 | 28.98 | ecash_lib_wasm_browser.js | 0 | 0 | 0 | 0 | 3-336 ecash_lib_wasm_nodejs.js | 61.9 | 55 | 39.13 | 62.75 | ...1,197-215,237,250-251,255 ecash-lib/src/io | 30.45 | 41 | 38.7 | 58.77 | bytes.ts | 3.77 | 62.5 | 6.66 | 7.4 | 13-64 hex.ts | 41.55 | 50 | 44.44 | 82.35 | 41-45,50,58 int.ts | 0 | 0 | 0 | 0 | str.ts | 46.15 | 83.33 | 40 | 85.71 | 15 varsize.ts | 16.32 | 21.05 | 40 | 32 | 14-24,40-47 writer.ts | 0 | 0 | 0 | 0 | writerbytes.ts | 42.37 | 40.62 | 53.33 | 83.33 | 33,43,53,63,79 writerlength.ts | 53.33 | 83.33 | 53.84 | 100 | 1 ecash-lib/src/test | 44.93 | 36.23 | 47.05 | 86.84 | testRunner.ts | 44.93 | 36.23 | 47.05 | 86.84 | 73-75,87-89,112,123,166,203 ecash-lib/src/token | 31.48 | 28.44 | 28.57 | 60.11 | alp.ts | 42.5 | 53.12 | 43.47 | 82.92 | 110-123,142 common.ts | 54.54 | 83.33 | 100 | 100 | 1 empp.ts | 52.17 | 60 | 57.14 | 91.66 | 12 slp.ts | 14.76 | 7.35 | 4 | 28.2 | ...7,174-178,185-197,201-211 ----------------------------|---------|----------|---------|---------|------------------------------ ##teamcity[blockOpened name='Code Coverage Summary'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='796'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='2809'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='239'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='905'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='129'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='455'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='776'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='1730'] ##teamcity[blockClosed name='Code Coverage Summary'] mv: cannot stat 'test_results/ecash-lib-integration-tests-junit.xml': No such file or directory Build ecash-lib-integration-tests failed with exit code 1
@bot ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests
@bot ecash-agora-tests
chronik-client is a dev dep of ecash-lib, add for ecash-agora-tests
@bot ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests
rebase (removing alias-server-tests)
move doc, add return type, remove obsolete types from the doc
@bot ecash-agora-integration-tests
@bot alias-server-tests ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests
lint
correct order of ecash-lib and chronik-client since ecash-lib takes chronik-client as a dev dependency, make sure deps are built for js-mocha-integration-tests builds
CI says it's not working
You should move the doc as well
@bot alias-server-tests ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests
not really a chronik task
In D17405#395729, @teamcity wrote:The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Thu, Dec 26
Much better logic. I am not totally sure if my implementation here is the right approach (parsing dependencies, making new BuildConfigurations for each one, adding to steps), though I was able to get it to work locally.
lint
Simplifying by removing dependencies.yml and its custom methods, instead creating script steps for the dependencies, parsing these before building
comment clarifying strange typescript/styled-components interaction