Page MenuHomePhabricator
Feed All Stories

Sat, Dec 28

bytesofman updated the diff for D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

use more flexible approach that allows dependencies to have dependencies

Sat, Dec 28, 22:26
bytesofman requested review of D17414: [e.cash] Add XECX to use ecash page.
Sat, Dec 28, 22:01
bytesofman added a comment to D17402: [Cashtab] Allow user to sort Agora offers by offer count.

Do you know where you want to go with this change ? I mean the end filters.

Sat, Dec 28, 21:54
Fabien added a comment to D17402: [Cashtab] Allow user to sort Agora offers by offer count.

Do you know where you want to go with this change ? I mean the end filters.

Sat, Dec 28, 21:07
Fabien requested changes to D17407: [Cashtab + doc] Parse XECX rewards.
Sat, Dec 28, 20:59
Fabien requested changes to D17414: [e.cash] Add XECX to use ecash page.
Sat, Dec 28, 20:46
bytesofman closed D17411: [Cashtab] Move function only used on Send screen to helpers dir for Send screen.
Sat, Dec 28, 14:59
bytesofman committed rABCee625b89b9ca: [Cashtab] Move function only used on Send screen to helpers dir for Send screen (authored by bytesofman).
[Cashtab] Move function only used on Send screen to helpers dir for Send screen
Sat, Dec 28, 14:59
Fabien accepted D17411: [Cashtab] Move function only used on Send screen to helpers dir for Send screen.
Sat, Dec 28, 13:02
bytesofman closed D17413: [monorepo] Use a locally installed prettier version.
Sat, Dec 28, 12:15
bytesofman committed rABC1f2f44cf81c3: [monorepo] Use a locally installed prettier version (authored by bytesofman).
[monorepo] Use a locally installed prettier version
Sat, Dec 28, 12:15
Fabien added inline comments to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Sat, Dec 28, 09:32
Fabien requested changes to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Sat, Dec 28, 09:14
Fabien accepted D17413: [monorepo] Use a locally installed prettier version.
Sat, Dec 28, 09:09
bytesofman published D17414: [e.cash] Add XECX to use ecash page for review.
Sat, Dec 28, 04:15
bytesofman closed T1690: Add support for stablecoin as Wontfix.

we need more stablecoins. cashtab already supports token features

Sat, Dec 28, 00:47 · Restricted Project
bytesofman closed T1716: Support exporting all data as Wontfix.

cashtab should not do this. really the contact list is too much already.

Sat, Dec 28, 00:46 · Restricted Project
bytesofman closed T1715: Transaction history should be kept in local storage as Resolved.

no

Sat, Dec 28, 00:44 · Restricted Project
bytesofman closed T1714: Custom comments in transaction history as Wontfix.

too much for cashtab. i don't think cashtab should be as "permanent" as poweruser wallet like electrum.

Sat, Dec 28, 00:44 · Restricted Project

Fri, Dec 27

bytesofman published D17413: [monorepo] Use a locally installed prettier version for review.
Fri, Dec 27, 22:13
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Like token.
Fri, Dec 27, 21:16
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

@bot ecash-lib-integration-tests

Fri, Dec 27, 21:16
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

Tail of the build log:

File                        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s            
----------------------------|---------|----------|---------|---------|------------------------------
All files                   |   28.33 |     26.4 |   28.35 |   44.85 |                              
 ecash-lib                  |       0 |        0 |       0 |       0 |                              
  eslint.config.js          |       0 |        0 |       0 |       0 |                              
 ecash-lib/dist/ffi         |       0 |        0 |       0 |       0 |                              
  ecash_lib_wasm_browser.js |       0 |        0 |       0 |       0 | 3-336                        
  ecash_lib_wasm_nodejs.js  |       0 |        0 |       0 |       0 | 1-264                        
 ecash-lib/src              |   35.84 |     28.6 |   39.24 |   68.05 |                              
  consts.ts                 |       0 |      100 |     100 |       0 | 6-8                          
  ecc.ts                    |   30.76 |    83.33 |   22.22 |   57.14 | 23-31                        
  hash.ts                   |   47.05 |    83.33 |   44.44 |   88.88 | 14                           
  index.ts                  |       0 |        0 |       0 |       0 |                              
  indexBrowser.ts           |       0 |        0 |       0 |       0 |                              
  indexNodeJs.ts            |       0 |        0 |       0 |       0 |                              
  initBrowser.ts            |       0 |      100 |       0 |       0 | 11-13                        
  initNodeJs.ts             |   53.84 |      100 |   66.66 |   85.71 | 12                           
  op.ts                     |   20.13 |    23.33 |   36.36 |   39.47 | ...4,107,109,117-122,133-161 
  opcode.ts                 |    50.2 |    83.33 |     100 |     100 | 1                            
  script.ts                 |   28.97 |    20.58 |   31.03 |   51.78 | ...1-122,133,143,153,175-186 
  sigHashType.ts            |      40 |       25 |   46.15 |   78.94 | 26-38                        
  tx.ts                     |   47.25 |    45.23 |   47.61 |   87.23 | 110,114,123-125,144          
  txBuilder.ts              |   40.64 |    32.69 |   54.54 |   80.21 | ...1,154,173-178,183,253-257 
  unsignedTx.ts             |   25.27 |       16 |   30.76 |   46.15 | ...9,312,320,326-329,345,357 
 ecash-lib/src/address      |   11.35 |    15.15 |    5.12 |   22.41 |                              
  address.ts                |   10.95 |    11.36 |    3.22 |   21.05 | ...3,239-240,255-256,266-344 
  legacyaddr.ts             |   12.04 |    22.72 |    12.5 |      25 | 15-19,23-38,70-111,124-128   
 ecash-lib/src/ffi          |   28.26 |    15.94 |   16.98 |   28.98 |                              
  ecash_lib_wasm_browser.js |       0 |        0 |       0 |       0 | 3-336                        
  ecash_lib_wasm_nodejs.js  |    61.9 |       55 |   39.13 |   62.75 | ...1,197-215,237,250-251,255 
 ecash-lib/src/io           |   30.45 |       41 |    38.7 |   58.77 |                              
  bytes.ts                  |    3.77 |     62.5 |    6.66 |     7.4 | 13-64                        
  hex.ts                    |   41.55 |       50 |   44.44 |   82.35 | 41-45,50,58                  
  int.ts                    |       0 |        0 |       0 |       0 |                              
  str.ts                    |   46.15 |    83.33 |      40 |   85.71 | 15                           
  varsize.ts                |   16.32 |    21.05 |      40 |      32 | 14-24,40-47                  
  writer.ts                 |       0 |        0 |       0 |       0 |                              
  writerbytes.ts            |   42.37 |    40.62 |   53.33 |   83.33 | 33,43,53,63,79               
  writerlength.ts           |   53.33 |    83.33 |   53.84 |     100 | 1                            
 ecash-lib/src/test         |   44.93 |    36.23 |   47.05 |   86.84 |                              
  testRunner.ts             |   44.93 |    36.23 |   47.05 |   86.84 | 73-75,87-89,112,123,166,203  
 ecash-lib/src/token        |   31.48 |    28.44 |   28.57 |   60.11 |                              
  alp.ts                    |    42.5 |    53.12 |   43.47 |   82.92 | 110-123,142                  
  common.ts                 |   54.54 |    83.33 |     100 |     100 | 1                            
  empp.ts                   |   52.17 |       60 |   57.14 |   91.66 | 12                           
  slp.ts                    |   14.76 |     7.35 |       4 |    28.2 | ...7,174-178,185-197,201-211 
----------------------------|---------|----------|---------|---------|------------------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='796']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='2809']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='239']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='905']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='129']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='455']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='776']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='1730']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/ecash-lib-integration-tests-junit.xml': No such file or directory
Build ecash-lib-integration-tests failed with exit code 1
Fri, Dec 27, 21:15
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Fri, Dec 27, 21:09
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Love token.
Fri, Dec 27, 21:01
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

@bot ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests

Fri, Dec 27, 21:01
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Like token.
Fri, Dec 27, 20:20
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

@bot ecash-agora-tests

Fri, Dec 27, 20:20
bytesofman updated the diff for D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

chronik-client is a dev dep of ecash-lib, add for ecash-agora-tests

Fri, Dec 27, 20:20
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Fri, Dec 27, 18:21
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Love token.
Fri, Dec 27, 17:59
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

@bot ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests

Fri, Dec 27, 17:59
bytesofman updated the test plan for D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Fri, Dec 27, 17:59
bytesofman updated the diff for D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

rebase (removing alias-server-tests)

Fri, Dec 27, 17:57
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Fri, Dec 27, 17:49
bytesofman closed D17405: [alias-server] Remove alias-server from the monorepo.
Fri, Dec 27, 17:47
bytesofman committed rABC166784aa02b4: [alias-server] Remove alias-server from the monorepo (authored by bytesofman).
[alias-server] Remove alias-server from the monorepo
Fri, Dec 27, 17:47
bytesofman updated the diff for D17411: [Cashtab] Move function only used on Send screen to helpers dir for Send screen.

move doc, add return type, remove obsolete types from the doc

Fri, Dec 27, 17:46
bytesofman closed D17409: [Cashtab] Convert Configure to ts.
Fri, Dec 27, 17:44
bytesofman committed rABCde20df89a8f3: [Cashtab] Convert Configure to ts (authored by bytesofman).
[Cashtab] Convert Configure to ts
Fri, Dec 27, 17:44
bytesofman closed D17410: [Cashtab] Convert contacts screen to ts.
Fri, Dec 27, 17:43
bytesofman committed rABCb8e11b1cfd55: [Cashtab] Convert contacts screen to ts (authored by bytesofman).
[Cashtab] Convert contacts screen to ts
Fri, Dec 27, 17:43
bytesofman closed D17408: [Cashtab] Remove unused imports from test file.
Fri, Dec 27, 17:43
bytesofman committed rABC1e3e2b1513d5: [Cashtab] Remove unused imports from test file (authored by bytesofman).
[Cashtab] Remove unused imports from test file
Fri, Dec 27, 17:43
bytesofman closed D17406: [Cashtab] Minor ts conversion.
Fri, Dec 27, 17:42
bytesofman committed rABC6e25ce1dfa47: [Cashtab] Minor ts conversion (authored by bytesofman).
[Cashtab] Minor ts conversion
Fri, Dec 27, 17:42
bytesofman closed D17404: [Cashtab] Convert App screen and deps to ts.
Fri, Dec 27, 17:41
bytesofman committed rABCedca57c3683c: [Cashtab] Convert App screen and deps to ts (authored by bytesofman).
[Cashtab] Convert App screen and deps to ts
Fri, Dec 27, 17:41
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Like token.
Fri, Dec 27, 17:40
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

@bot ecash-agora-integration-tests

Fri, Dec 27, 17:40
bytesofman closed D17401: [Cashtab] Convert some common components to ts.
Fri, Dec 27, 17:39
bytesofman committed rABC602ebcdf598a: [Cashtab] Convert some common components to ts (authored by bytesofman).
[Cashtab] Convert some common components to ts
Fri, Dec 27, 17:39
bytesofman closed D17400: [Cashtab] Convert BackupWallet screen to ts.
Fri, Dec 27, 17:37
bytesofman committed rABCa3cb3bd23735: [Cashtab] Convert BackupWallet screen to ts (authored by bytesofman).
[Cashtab] Convert BackupWallet screen to ts
Fri, Dec 27, 17:37
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Fri, Dec 27, 17:37
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Mountain of Wealth token.
Fri, Dec 27, 17:36
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

@bot alias-server-tests ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests

Fri, Dec 27, 17:36
bytesofman updated the diff for D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

lint

Fri, Dec 27, 17:36
bytesofman updated the diff for D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

correct order of ecash-lib and chronik-client since ecash-lib takes chronik-client as a dev dependency, make sure deps are built for js-mocha-integration-tests builds

Fri, Dec 27, 17:36
Fabien closed D17397: depends: xcb-proto 1.15.2.
Fri, Dec 27, 17:19
Fabien committed rABCd627305b3ddb: depends: xcb-proto 1.15.2 (authored by Fabien).
depends: xcb-proto 1.15.2
Fri, Dec 27, 17:19
PiRK accepted D17397: depends: xcb-proto 1.15.2.
Fri, Dec 27, 16:04
Fabien requested changes to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

CI says it's not working

Fri, Dec 27, 15:40
Fabien requested changes to D17411: [Cashtab] Move function only used on Send screen to helpers dir for Send screen.

You should move the doc as well

Fri, Dec 27, 15:39
Fabien accepted D17410: [Cashtab] Convert contacts screen to ts.
Fri, Dec 27, 15:37
Fabien accepted D17409: [Cashtab] Convert Configure to ts.
Fri, Dec 27, 15:36
Fabien accepted D17408: [Cashtab] Remove unused imports from test file.
Fri, Dec 27, 15:35
Fabien accepted D17406: [Cashtab] Minor ts conversion.
Fri, Dec 27, 15:33
Fabien accepted D17405: [alias-server] Remove alias-server from the monorepo.
Fri, Dec 27, 15:33
Fabien accepted D17404: [Cashtab] Convert App screen and deps to ts.
Fri, Dec 27, 15:32
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Fri, Dec 27, 15:32
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Fri, Dec 27, 15:30
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Fri, Dec 27, 15:30
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Fri, Dec 27, 15:28
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Fri, Dec 27, 15:27
Fabien accepted D17401: [Cashtab] Convert some common components to ts.
Fri, Dec 27, 15:26
Fabien accepted D17400: [Cashtab] Convert BackupWallet screen to ts.
Fri, Dec 27, 15:25
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Fri, Dec 27, 15:23
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Doubloon token.
Fri, Dec 27, 15:22
Fabien added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

@bot alias-server-tests ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests

Fri, Dec 27, 15:22
bytesofman published D17411: [Cashtab] Move function only used on Send screen to helpers dir for Send screen for review.
Fri, Dec 27, 13:41
bytesofman published D17410: [Cashtab] Convert contacts screen to ts for review.
Fri, Dec 27, 13:36
bytesofman published D17409: [Cashtab] Convert Configure to ts for review.
Fri, Dec 27, 13:36
bytesofman published D17408: [Cashtab] Remove unused imports from test file for review.
Fri, Dec 27, 13:01
bytesofman published D17407: [Cashtab + doc] Parse XECX rewards for review.
Fri, Dec 27, 13:00
bytesofman closed T1713: Paginated transaction history as Invalid.

not really a chronik task

Fri, Dec 27, 00:56 · Restricted Project
bytesofman published D17406: [Cashtab] Minor ts conversion for review.
Fri, Dec 27, 00:41
bytesofman published D17405: [alias-server] Remove alias-server from the monorepo for review.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fri, Dec 27, 00:11
bytesofman published D17404: [Cashtab] Convert App screen and deps to ts for review.
Fri, Dec 27, 00:10

Thu, Dec 26

bytesofman closed D17399: [Cashtab] Remove legacy aliases implementation.
Thu, Dec 26, 23:15
bytesofman committed rABC1f7871d420dd: [Cashtab] Remove legacy aliases implementation (authored by bytesofman).
[Cashtab] Remove legacy aliases implementation
Thu, Dec 26, 23:15
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

Much better logic. I am not totally sure if my implementation here is the right approach (parsing dependencies, making new BuildConfigurations for each one, adding to steps), though I was able to get it to work locally.

Thu, Dec 26, 23:11
bytesofman updated the diff for D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

lint

Thu, Dec 26, 23:09
bytesofman updated the diff for D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

Simplifying by removing dependencies.yml and its custom methods, instead creating script steps for the dependencies, parsing these before building

Thu, Dec 26, 23:08
bytesofman published D17402: [Cashtab] Allow user to sort Agora offers by offer count for review.
Thu, Dec 26, 22:26
bytesofman added inline comments to D17401: [Cashtab] Convert some common components to ts.
Thu, Dec 26, 22:23
bytesofman updated the diff for D17401: [Cashtab] Convert some common components to ts.

comment clarifying strange typescript/styled-components interaction

Thu, Dec 26, 22:23
bytesofman added inline comments to D17400: [Cashtab] Convert BackupWallet screen to ts.
Thu, Dec 26, 22:18
Fabien added inline comments to D17401: [Cashtab] Convert some common components to ts.
Thu, Dec 26, 21:52
Fabien accepted D17399: [Cashtab] Remove legacy aliases implementation.
Thu, Dec 26, 21:48