Page MenuHomePhabricator
Feed All Stories

Thu, Dec 26

Fabien added a comment to D17399: [Cashtab] Remove legacy aliases implementation.

What about the alias server ?

imo this also needs to go. I do not think we should implement aliases if it is not on a spec that a chronik plugin can index.

I could remove it in this diff as well. Was planning to do it separately as it has its own CI-related impacts.

Thu, Dec 26, 21:46
Fabien added inline comments to D17400: [Cashtab] Convert BackupWallet screen to ts.
Thu, Dec 26, 21:45
bytesofman added a comment to D17399: [Cashtab] Remove legacy aliases implementation.

What about the alias server ?

Thu, Dec 26, 21:42
Fabien added a comment to D17399: [Cashtab] Remove legacy aliases implementation.

What about the alias server ?

Thu, Dec 26, 21:40
Fabien requested changes to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

I like the top level API, but this can be simplified a bit. See suggestions.

Thu, Dec 26, 21:30
bytesofman published D17401: [Cashtab] Convert some common components to ts for review.
Thu, Dec 26, 18:43
bytesofman published D17399: [Cashtab] Remove legacy aliases implementation for review.
Thu, Dec 26, 18:33
bytesofman published D17400: [Cashtab] Convert BackupWallet screen to ts for review.
Thu, Dec 26, 18:21
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

Tail of the build log:

> mock-chronik-client@2.1.1 build
> tsc

/work/apps/alias-server /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecash-script /work/modules/ecashaddrjs /work/abc-ci-builds/alias-server-tests
npm warn deprecated har-validator@5.1.5: this library is no longer supported
npm warn deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm warn deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.

added 612 packages, and audited 616 packages in 6s

94 packages are looking for funding
  run `npm fund` for details

15 vulnerabilities (3 low, 7 moderate, 5 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
CI not configured to test build.

> alias-server@1.0.0 test
> mocha --reporter mocha-junit-reporter --reporter-options mochaFile=test_results/alias-server-junit.xml --reporter-options testsuitesTitle=Alias Server Unit Tests --reporter-options rootSuiteTitle=Alias Server

Connected successfully to MongoDB server
Error in function updateServerState. MongoServerError: interrupted at shutdown
    at Connection.sendCommand (/work/apps/alias-server/node_modules/mongodb/lib/cmap/connection.js:290:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Connection.command (/work/apps/alias-server/node_modules/mongodb/lib/cmap/connection.js:317:26)
    at async Server.command (/work/apps/alias-server/node_modules/mongodb/lib/sdam/server.js:167:29)
    at async UpdateOneOperation.executeCommand (/work/apps/alias-server/node_modules/mongodb/lib/operations/command.js:73:16)
    at async UpdateOneOperation.execute (/work/apps/alias-server/node_modules/mongodb/lib/operations/update.js:55:21)
    at async UpdateOneOperation.execute (/work/apps/alias-server/node_modules/mongodb/lib/operations/update.js:69:21)
    at async tryOperation (/work/apps/alias-server/node_modules/mongodb/lib/operations/execute_operation.js:199:20)
    at async executeOperation (/work/apps/alias-server/node_modules/mongodb/lib/operations/execute_operation.js:69:16)
    at async Collection.updateOne (/work/apps/alias-server/node_modules/mongodb/lib/collection.js:204:16)
    at async Object.updateServerState (/work/apps/alias-server/src/db.js:28:92)
    at async initializeDb (/work/apps/alias-server/src/db.js:21:26)
    at async Context.<anonymous> (/work/apps/alias-server/test/app.test.js:35:18) {
  errorResponse: {
    ok: 0,
    errmsg: 'interrupted at shutdown',
    code: 11600,
    codeName: 'InterruptedAtShutdown'
  },
  ok: 0,
  code: 11600,
  codeName: 'InterruptedAtShutdown',
  [Symbol(errorLabels)]: Set(1) { 'ResetPool' }
}
Initialized serverState on app startup
Configured connection to database ecashAliases
Connected successfully to MongoDB server
Initialized serverState on app startup
Configured connection to database ecashAliases
Build alias-server-tests timed out after 3600.0s
Thu, Dec 26, 17:29
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Piece of Eight token.
Thu, Dec 26, 17:28
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

@bot alias-server-tests

Thu, Dec 26, 17:28
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Thu, Dec 26, 17:06
bytesofman published D17398: [CI] Improve handling of JS dependencies in build-configurations CI for review.
Thu, Dec 26, 16:51
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Haypence token.
Thu, Dec 26, 16:04
teamcity awarded D17397: depends: xcb-proto 1.15.2 a Haypence token.
Thu, Dec 26, 15:17
Fabien added a comment to D17397: depends: xcb-proto 1.15.2.

@bot guix-linux

Thu, Dec 26, 15:17
teamcity updated the summary of D17397: depends: xcb-proto 1.15.2.
Thu, Dec 26, 15:13
Fabien requested review of D17397: depends: xcb-proto 1.15.2.
Thu, Dec 26, 15:13
teamcity awarded D17396: [chronik] Upgrade karyon_jsonrpc library to 0.2.0 a Haypence token.
Thu, Dec 26, 14:11
Fabien added a comment to D17396: [chronik] Upgrade karyon_jsonrpc library to 0.2.0.

@bot guix-linux guix-win guix-osx

Thu, Dec 26, 14:11
teamcity added a comment to D17396: [chronik] Upgrade karyon_jsonrpc library to 0.2.0.
Thu, Dec 26, 14:07
teamcity added a comment to D17396: [chronik] Upgrade karyon_jsonrpc library to 0.2.0.
Thu, Dec 26, 13:59
Fabien requested review of D17396: [chronik] Upgrade karyon_jsonrpc library to 0.2.0.
Thu, Dec 26, 13:59
bytesofman added inline comments to D17394: [Cashtab] Convert Etokens screen to ts.
Thu, Dec 26, 13:47
bytesofman updated the diff for D17394: [Cashtab] Convert Etokens screen to ts.

use same type check bail-out throughout component

Thu, Dec 26, 13:46
Fabien closed D17392: Wait for remote proof messages in functional tests.
Thu, Dec 26, 10:16
Fabien committed rABCd64d5e3aa9fd: Wait for remote proof messages in functional tests (authored by Fabien).
Wait for remote proof messages in functional tests
Thu, Dec 26, 10:15
Fabien closed D17390: Improve Indices on pruned nodes via prune blockers.
Thu, Dec 26, 10:05
Fabien committed rABC3d14146b567c: Improve Indices on pruned nodes via prune blockers (authored by Fabien).
Improve Indices on pruned nodes via prune blockers
Thu, Dec 26, 10:05
Fabien added a comment to D17392: Wait for remote proof messages in functional tests.

This CI issue appeared with a Teamcity update and has been reported to JetBrains. It causes random failure to fetch the sources which is super annoying

Thu, Dec 26, 09:49
teamcity added a comment to D17392: Wait for remote proof messages in functional tests.
Thu, Dec 26, 09:48

Wed, Dec 25

PiRK accepted D17392: Wait for remote proof messages in functional tests.
Wed, Dec 25, 22:32
bytesofman closed D17395: [Cashtab] Link to Cashtab token page instead of explorer for NFTs in a collection.
Wed, Dec 25, 00:43
bytesofman committed rABC760983110925: [Cashtab] Link to Cashtab token page instead of explorer for NFTs in a… (authored by bytesofman).
[Cashtab] Link to Cashtab token page instead of explorer for NFTs in a…
Wed, Dec 25, 00:43
emack accepted D17395: [Cashtab] Link to Cashtab token page instead of explorer for NFTs in a collection.
Wed, Dec 25, 00:03
emack requested changes to D17394: [Cashtab] Convert Etokens screen to ts.
Wed, Dec 25, 00:01

Tue, Dec 24

PiRK accepted D17390: Improve Indices on pruned nodes via prune blockers.
Tue, Dec 24, 16:28
bytesofman published D17395: [Cashtab] Link to Cashtab token page instead of explorer for NFTs in a collection for review.
Tue, Dec 24, 14:51
bytesofman published D17394: [Cashtab] Convert Etokens screen to ts for review.
Tue, Dec 24, 14:46
bytesofman closed D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat.
Tue, Dec 24, 01:20
bytesofman committed rABC1aca7699cbc4: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat (authored by bytesofman).
[Cashtab] Add toggle switch to show Agora prices in XEC or fiat
Tue, Dec 24, 01:20
bytesofman added inline comments to D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat.
Tue, Dec 24, 01:16
emack accepted D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat.
Tue, Dec 24, 01:09
teamcity awarded D17393: [build-configurations.yml] Clean up dependency management a Piece of Eight token.
Tue, Dec 24, 00:13
teamcity awarded D17393: [build-configurations.yml] Clean up dependency management a Haypence token.
Tue, Dec 24, 00:05

Mon, Dec 23

Fabien updated the diff for D17392: Wait for remote proof messages in functional tests.

Revert accidental newline

Mon, Dec 23, 22:21
teamcity added a comment to D17392: Wait for remote proof messages in functional tests.
Mon, Dec 23, 22:06
Fabien requested review of D17392: Wait for remote proof messages in functional tests.
Mon, Dec 23, 22:06
Fabien updated the diff for D17390: Improve Indices on pruned nodes via prune blockers.

Bump the syncing timeout

Mon, Dec 23, 18:13
teamcity added a comment to D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 17:56
Fabien updated the diff for D17390: Improve Indices on pruned nodes via prune blockers.

Add core#25123

Mon, Dec 23, 17:38
Fabien updated the summary of D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 17:37
Fabien planned changes to D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 17:32
teamcity added a comment to D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 16:31
Fabien updated the diff for D17390: Improve Indices on pruned nodes via prune blockers.

Bump the coinstatindex syncing timeout

Mon, Dec 23, 16:09
Fabien closed D17387: Fix a race in abc_p2p_avalanche_remote_proofs.py.
Mon, Dec 23, 15:53
Fabien committed rABC504a0b703be6: Fix a race in abc_p2p_avalanche_remote_proofs.py (authored by Fabien).
Fix a race in abc_p2p_avalanche_remote_proofs.py
Mon, Dec 23, 15:53
Fabien closed D17389: init: disallow reindex-chainstate when pruning.
Mon, Dec 23, 15:53
Fabien committed rABC541bfc8db064: init: disallow reindex-chainstate when pruning (authored by Martin Zumsande <mzumsande@gmail.com>).
init: disallow reindex-chainstate when pruning
Mon, Dec 23, 15:53
Fabien closed D17388: test: check for invalid `-prune` parameters.
Mon, Dec 23, 15:53
Fabien committed rABC65eec8ee3f69: test: check for invalid `-prune` parameters (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: check for invalid `-prune` parameters
Mon, Dec 23, 15:52
Fabien planned changes to D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 15:47
PiRK accepted D17389: init: disallow reindex-chainstate when pruning.
Mon, Dec 23, 15:42
PiRK accepted D17388: test: check for invalid `-prune` parameters.
Mon, Dec 23, 15:39
bytesofman added a comment to D17328: [token-server] Bump free xec from 42 to 88.

haven't forgotten about this btw but waiting for a good time to pull the trigger.

Mon, Dec 23, 15:11
bytesofman updated the test plan for D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat.
Mon, Dec 23, 14:45
bytesofman published D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat for review.
Mon, Dec 23, 14:39
bytesofman accepted D17387: Fix a race in abc_p2p_avalanche_remote_proofs.py.
Mon, Dec 23, 11:59
teamcity added a comment to D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 11:10
teamcity updated the summary of D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 10:58
Fabien requested review of D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 10:58
teamcity updated the summary of D17389: init: disallow reindex-chainstate when pruning.
Mon, Dec 23, 10:26
Fabien requested review of D17389: init: disallow reindex-chainstate when pruning.
Mon, Dec 23, 10:26
teamcity updated the summary of D17388: test: check for invalid `-prune` parameters.
Mon, Dec 23, 10:19
Fabien requested review of D17388: test: check for invalid `-prune` parameters.
Mon, Dec 23, 10:19
Fabien requested review of D17387: Fix a race in abc_p2p_avalanche_remote_proofs.py.
Mon, Dec 23, 09:56
bytesofman closed D17386: [Cashtab] Upgrade BigNumber.js.
Mon, Dec 23, 03:58
bytesofman committed rABC2ea7234ba560: [Cashtab] Upgrade BigNumber.js (authored by bytesofman).
[Cashtab] Upgrade BigNumber.js
Mon, Dec 23, 03:58
bytesofman closed D17385: [Cashtab] Improve portability of getFormattedFiatPrice.
Mon, Dec 23, 03:53
bytesofman committed rABCa2e7986400fe: [Cashtab] Improve portability of getFormattedFiatPrice (authored by bytesofman).
[Cashtab] Improve portability of getFormattedFiatPrice
Mon, Dec 23, 03:53
emack accepted D17385: [Cashtab] Improve portability of getFormattedFiatPrice.
Mon, Dec 23, 01:44
emack accepted D17386: [Cashtab] Upgrade BigNumber.js.
Mon, Dec 23, 01:41
bytesofman published D17386: [Cashtab] Upgrade BigNumber.js for review.
Mon, Dec 23, 00:20

Sun, Dec 22

abc-bot committed rABCf725b03574f7: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Sun, Dec 22, 22:15
abc-bot committed rABC42e27bb0e83c: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Sun, Dec 22, 22:11
abc-bot committed rABC57366efa22cb: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Sun, Dec 22, 21:38
bytesofman added a comment to D17384: [CI] Update dockerfiles that build-wasm to include bitcoinsuite-chronik-client.

confirmed this did patch the Cashtab CI issue

Sun, Dec 22, 21:14
bytesofman closed D17384: [CI] Update dockerfiles that build-wasm to include bitcoinsuite-chronik-client.
Sun, Dec 22, 21:07
bytesofman committed rABC99031b560307: [CI] Update dockerfiles that build-wasm to include bitcoinsuite-chronik-client (authored by bytesofman).
[CI] Update dockerfiles that build-wasm to include bitcoinsuite-chronik-client
Sun, Dec 22, 21:07
bytesofman added a comment to D17384: [CI] Update dockerfiles that build-wasm to include bitcoinsuite-chronik-client.

Maybe we shouldn't use workspace for this?

Sun, Dec 22, 21:06
Fabien accepted D17384: [CI] Update dockerfiles that build-wasm to include bitcoinsuite-chronik-client.

Maybe we shouldn't use workspace for this?

Sun, Dec 22, 20:33
bytesofman published D17385: [Cashtab] Improve portability of getFormattedFiatPrice for review.
Sun, Dec 22, 17:17
bytesofman published D17384: [CI] Update dockerfiles that build-wasm to include bitcoinsuite-chronik-client for review.
Sun, Dec 22, 11:58
bytesofman closed D17383: [Cashtab] Use user modal confirmation settings for minting tokens.
Sun, Dec 22, 11:40
bytesofman committed rABC9fa101265182: [Cashtab] Use user modal confirmation settings for minting tokens (authored by bytesofman).
[Cashtab] Use user modal confirmation settings for minting tokens
Sun, Dec 22, 11:39
bytesofman added inline comments to D17383: [Cashtab] Use user modal confirmation settings for minting tokens.
Sun, Dec 22, 11:39
emack accepted D17383: [Cashtab] Use user modal confirmation settings for minting tokens.
Sun, Dec 22, 09:46
bytesofman published D17383: [Cashtab] Use user modal confirmation settings for minting tokens for review.
Sun, Dec 22, 00:31

Sat, Dec 21

Fabien closed D17382: test: Avoid intermittent block download timeout in p2p_ibd_stalling.
Sat, Dec 21, 14:43
Fabien committed rABC5396e280be4c: test: Avoid intermittent block download timeout in p2p_ibd_stalling (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
test: Avoid intermittent block download timeout in p2p_ibd_stalling
Sat, Dec 21, 14:43