Page MenuHomePhabricator
Feed All Stories

Jan 3 2025

bytesofman updated the diff for D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.

tslint patch

Jan 3 2025, 02:11
johnkuney committed rABC3b6dd3e26a3e: [e.cash] Add Swapspace widget (authored by johnkuney).
[e.cash] Add Swapspace widget
Jan 3 2025, 00:55
johnkuney closed D17439: [e.cash] Add Swapspace widget.
Jan 3 2025, 00:55

Jan 2 2025

teamcity added a comment to D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Jan 2 2025, 23:36
bytesofman retitled D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string from [Cashtab] [bugfix] genesis supply validation for ALP tokens in create token form to [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Jan 2 2025, 23:34
bytesofman updated the diff for D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.

make sure input fields that take amounts larger than JS max safe number are actually string fields

Jan 2 2025, 23:31
bytesofman added inline comments to D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Jan 2 2025, 23:30
emack requested changes to D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Jan 2 2025, 22:34
majcosta abandoned D12891: Streamline contributor instructions for Rust stuff.
Jan 2 2025, 22:01
bytesofman accepted D17439: [e.cash] Add Swapspace widget.

looks much better

Jan 2 2025, 21:20
teamcity added a comment to D17439: [e.cash] Add Swapspace widget.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41535 for the next 60 minutes.

Jan 2 2025, 21:18
teamcity awarded D17439: [e.cash] Add Swapspace widget a Doubloon token.
Jan 2 2025, 21:17
bytesofman added a comment to D17439: [e.cash] Add Swapspace widget.

@bot preview-e.cash

Jan 2 2025, 21:17
bytesofman retitled D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string from [Cashtab] Patch genesis supply validation for ALP tokens in create token form to [Cashtab] [bugfix] genesis supply validation for ALP tokens in create token form.
Jan 2 2025, 21:08
johnkuney added a comment to D17439: [e.cash] Add Swapspace widget.

Okay how about this? fyi those styles on swapspace are what they have in their instructions for the widget

Jan 2 2025, 21:07
johnkuney updated the diff for D17439: [e.cash] Add Swapspace widget.

dont show side by side, copy edit

Jan 2 2025, 21:05
bytesofman accepted D17458: [cashtab] Don't display token type (SLP, ALP, etc.) in tx history.

a screenshot of "before" and "after" example can also help with this kind of diff review

Jan 2 2025, 20:48
bytesofman published D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string for review.
Jan 2 2025, 20:33
Fabien updated the diff for D17458: [cashtab] Don't display token type (SLP, ALP, etc.) in tx history.

Fix the linter

Jan 2 2025, 20:15
teamcity added a comment to D17458: [cashtab] Don't display token type (SLP, ALP, etc.) in tx history.
Jan 2 2025, 20:08
Fabien requested review of D17458: [cashtab] Don't display token type (SLP, ALP, etc.) in tx history.
Jan 2 2025, 20:03
teamcity closed T3716: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Jan 2 2025, 18:17
teamcity triaged T3716: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Jan 2 2025, 17:58
bytesofman closed D17457: [Cashtab] Prevent creation of unacceptable agora offers.
Jan 2 2025, 17:56
bytesofman committed rABC4bb8240bd8d5: [Cashtab] Prevent creation of unacceptable agora offers (authored by bytesofman).
[Cashtab] Prevent creation of unacceptable agora offers
Jan 2 2025, 17:56
bytesofman closed D17448: [Cashtab] Implement exhaustive parsing of tx notifications.
Jan 2 2025, 17:48
bytesofman committed rABCa8765b3de5d5: [Cashtab] Implement exhaustive parsing of tx notifications (authored by bytesofman).
[Cashtab] Implement exhaustive parsing of tx notifications
Jan 2 2025, 17:48
Fabien accepted D17457: [Cashtab] Prevent creation of unacceptable agora offers.
Jan 2 2025, 17:44
Fabien accepted D17448: [Cashtab] Implement exhaustive parsing of tx notifications.
Jan 2 2025, 17:41
bytesofman published D17457: [Cashtab] Prevent creation of unacceptable agora offers for review.
Jan 2 2025, 17:30
bytesofman updated the diff for D17448: [Cashtab] Implement exhaustive parsing of tx notifications.

less confusing variable names

Jan 2 2025, 16:41
bytesofman updated the diff for D17448: [Cashtab] Implement exhaustive parsing of tx notifications.

split out the addr parse and preview logic, set up for easier rendering of contacts in notifications

Jan 2 2025, 16:35
bytesofman closed D17455: [Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to sellers.
Jan 2 2025, 16:19
bytesofman committed rABC5f27e3d2661a: [Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to… (authored by bytesofman).
[Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to…
Jan 2 2025, 16:18
Fabien accepted D17455: [Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to sellers.
Jan 2 2025, 15:44
Fabien added a comment to D17455: [Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to sellers.

It is (probably) possible to get the impact of this on the visual component by confirming expected width of the depth bars.

Why would you do that ? Just test that the value is not accounted in the depth computation. Anyway it's really a nit

Jan 2 2025, 15:42
bytesofman updated the summary of D17455: [Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to sellers.
Jan 2 2025, 15:31
bytesofman updated the diff for D17455: [Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to sellers.

continue before any analytic logic

Jan 2 2025, 15:30
bytesofman added inline comments to D17455: [Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to sellers.
Jan 2 2025, 15:30
bytesofman closed D17453: [Cashtab] Highlight your own offers in agora orderbook.
Jan 2 2025, 15:19
bytesofman committed rABCe90d67768707: [Cashtab] Highlight your own offers in agora orderbook (authored by bytesofman).
[Cashtab] Highlight your own offers in agora orderbook
Jan 2 2025, 15:19
Fabien closed D17454: [cashtab] Link to the token page from the tx history.
Jan 2 2025, 15:12
Fabien committed rABCac0032725cb3: [cashtab] Link to the token page from the tx history (authored by Fabien).
[cashtab] Link to the token page from the tx history
Jan 2 2025, 15:12
Fabien closed D17451: [cashtab] Always show 2 decimals for amounts < 1k XEC.
Jan 2 2025, 15:11
Fabien committed rABC37545e85844f: [cashtab] Always show 2 decimals for amounts < 1k XEC (authored by Fabien).
[cashtab] Always show 2 decimals for amounts < 1k XEC
Jan 2 2025, 15:11
Fabien closed D17456: [cashtab] Fix the unit tests verbosity.
Jan 2 2025, 15:10
Fabien committed rABC58f250b0e5a4: [cashtab] Fix the unit tests verbosity (authored by Fabien).
[cashtab] Fix the unit tests verbosity
Jan 2 2025, 15:10
Fabien requested changes to D17455: [Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to sellers.
Jan 2 2025, 15:10
bytesofman accepted D17451: [cashtab] Always show 2 decimals for amounts < 1k XEC.
Jan 2 2025, 15:08
bytesofman accepted D17456: [cashtab] Fix the unit tests verbosity.

finally lmao

Jan 2 2025, 15:00
bytesofman accepted D17454: [cashtab] Link to the token page from the tx history.
Jan 2 2025, 14:59
Fabien requested review of D17456: [cashtab] Fix the unit tests verbosity.
Jan 2 2025, 14:57
bytesofman published D17455: [Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to sellers for review.
Jan 2 2025, 14:57
Fabien requested changes to D17448: [Cashtab] Implement exhaustive parsing of tx notifications.
Jan 2 2025, 14:22
Fabien closed D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.
Jan 2 2025, 14:16
Fabien committed rABCd6b7b6d517ad: [cashtab] Remove the avalanche finalized message/icon in the tx history… (authored by Fabien).
[cashtab] Remove the avalanche finalized message/icon in the tx history…
Jan 2 2025, 14:16
Fabien accepted D17453: [Cashtab] Highlight your own offers in agora orderbook.
Jan 2 2025, 14:16
bytesofman added a comment to D17453: [Cashtab] Highlight your own offers in agora orderbook.

I want to propose an alternative approach here: add a X to the right of yours listing that is a shortcut for the cancel action.
This is similar to what is done on most exchanges. It's still fine to highlight if you want to, but might not be necessary

Jan 2 2025, 14:12
bytesofman accepted D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.
Jan 2 2025, 14:10
Fabien added a comment to D17453: [Cashtab] Highlight your own offers in agora orderbook.

I want to propose an alternative approach here: add a X to the right of yours listing that is a shortcut for the cancel action.
This is similar to what is done on most exchanges. It's still fine to highlight if you want to, but might not be necessary

Jan 2 2025, 14:10
Fabien updated the diff for D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.

Keep the buttons on the right

Jan 2 2025, 14:02
teamcity added a comment to D17454: [cashtab] Link to the token page from the tx history.

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.178.130.230:41158 for the next 60 minutes.

Jan 2 2025, 14:02
teamcity awarded D17454: [cashtab] Link to the token page from the tx history a Haypence token.
Jan 2 2025, 13:58
bytesofman added a comment to D17454: [cashtab] Link to the token page from the tx history.

@bot preview-cashtab

Jan 2 2025, 13:58
Fabien requested review of D17454: [cashtab] Link to the token page from the tx history.
Jan 2 2025, 13:57
bytesofman published D17453: [Cashtab] Highlight your own offers in agora orderbook for review.
Jan 2 2025, 13:55
Fabien updated the summary of D17451: [cashtab] Always show 2 decimals for amounts < 1k XEC.
Jan 2 2025, 13:49
Fabien updated the diff for D17451: [cashtab] Always show 2 decimals for amounts < 1k XEC.

Don't change the mock, but reuse the existing ones to add a test case.
Bump the version

Jan 2 2025, 13:48
Fabien updated the diff for D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.

Rebase

Jan 2 2025, 13:46
Fabien updated the diff for D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.

Bump version

Jan 2 2025, 13:29
bytesofman published D17448: [Cashtab] Implement exhaustive parsing of tx notifications for review.

image.png (366×682 px, 508 KB)

Jan 2 2025, 13:24
Fabien closed D17452: [cashtab] Fix misplaced comments.
Jan 2 2025, 13:23
Fabien committed rABC2018e84576e4: [cashtab] Fix misplaced comments (authored by Fabien).
[cashtab] Fix misplaced comments
Jan 2 2025, 13:23
bytesofman accepted D17452: [cashtab] Fix misplaced comments.
Jan 2 2025, 13:22
bytesofman requested changes to D17451: [cashtab] Always show 2 decimals for amounts < 1k XEC.

I think the change is good but should implement by adding a new mock tx and test instead of changing the values of an existing mock.

Jan 2 2025, 13:22
Fabien requested review of D17452: [cashtab] Fix misplaced comments.
Jan 2 2025, 12:15
Fabien requested review of D17451: [cashtab] Always show 2 decimals for amounts < 1k XEC.
Jan 2 2025, 10:35
emack accepted D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.
Jan 2 2025, 10:33
Fabien requested review of D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.
Jan 2 2025, 09:55

Jan 1 2025

bytesofman closed D17446: [Cashtab] Remove artifact CashtabSettings type from formatting.
Jan 1 2025, 15:18
bytesofman committed rABCd5e2de595f89: [Cashtab] Remove artifact CashtabSettings type from formatting (authored by bytesofman).
[Cashtab] Remove artifact CashtabSettings type from formatting
Jan 1 2025, 15:18
bytesofman closed D17447: [Cashtab] More refinements to spot price presentation in agora.
Jan 1 2025, 14:36
bytesofman committed rABCf9f40e88249b: [Cashtab] More refinements to spot price presentation in agora (authored by bytesofman).
[Cashtab] More refinements to spot price presentation in agora
Jan 1 2025, 14:36
bytesofman added inline comments to D17447: [Cashtab] More refinements to spot price presentation in agora.
Jan 1 2025, 14:31
Fabien accepted D17447: [Cashtab] More refinements to spot price presentation in agora.
Jan 1 2025, 14:24
Fabien accepted D17446: [Cashtab] Remove artifact CashtabSettings type from formatting.
Jan 1 2025, 14:07
Fabien closed D17445: [cashtab] Don't open agora offers on a new tab.
Jan 1 2025, 14:07
Fabien committed rABCd72d9d5b7883: [cashtab] Don't open agora offers on a new tab (authored by Fabien).
[cashtab] Don't open agora offers on a new tab
Jan 1 2025, 14:07
bytesofman published D17447: [Cashtab] More refinements to spot price presentation in agora for review.
Jan 1 2025, 13:33
bytesofman published D17446: [Cashtab] Remove artifact CashtabSettings type from formatting for review.
Jan 1 2025, 13:05
bytesofman accepted D17445: [cashtab] Don't open agora offers on a new tab.
Jan 1 2025, 13:05
emack accepted D17445: [cashtab] Don't open agora offers on a new tab.

@bytesofman - as a side note, current versions of major browsers are all automatically assuming rel="noopener noreferrer" when opening links in a new window.

Jan 1 2025, 10:20
Fabien updated the summary of D17445: [cashtab] Don't open agora offers on a new tab.
Jan 1 2025, 08:19
Fabien requested review of D17445: [cashtab] Don't open agora offers on a new tab.
Jan 1 2025, 08:17
bytesofman closed D17444: [e.cash] Add clarificatio to XECX link page.
Jan 1 2025, 01:57
bytesofman committed rABC76fdd96fd56f: [e.cash] Add clarificatio to XECX link page (authored by bytesofman).
[e.cash] Add clarificatio to XECX link page
Jan 1 2025, 01:57
emack accepted D17444: [e.cash] Add clarificatio to XECX link page.
Jan 1 2025, 01:48
bytesofman published D17444: [e.cash] Add clarificatio to XECX link page for review.
Jan 1 2025, 01:02
bytesofman closed D17438: [Cashtab] Allow typed input for agora quantity selection.
Jan 1 2025, 00:52
bytesofman committed rABC2b6af5403027: [Cashtab] Allow typed input for agora quantity selection (authored by bytesofman).
[Cashtab] Allow typed input for agora quantity selection
Jan 1 2025, 00:52