Page MenuHomePhabricator
Feed All Stories

Jan 7 2025

PiRK added a comment to D17476: [explorer] Show as much token tx information as possible when the genesis info is missing.

@bot build-explorer

Jan 7 2025, 07:46
PiRK requested changes to D17470: [explorer] Don't fail to render invalid token txs with non existing token id.
Jan 7 2025, 07:24
bytesofman closed D17482: [ecash-herald, Cashtab, explorer] chronik back to native1.
Jan 7 2025, 05:00
bytesofman committed rABC6a03426ab8b4: [ecash-herald, Cashtab, explorer] chronik back to native1 (authored by bytesofman).
[ecash-herald, Cashtab, explorer] chronik back to native1
Jan 7 2025, 05:00
emack accepted D17482: [ecash-herald, Cashtab, explorer] chronik back to native1.
Jan 7 2025, 04:53
bytesofman published D17482: [ecash-herald, Cashtab, explorer] chronik back to native1 for review.
Jan 7 2025, 04:50
Kronkmeister added a comment to D17466: [Cashtab] Prevent agora buys of offers above spot.

If it is for newbies, I would suggest to say "market rate" instead of "spot" because that's trader talk. Or maybe spot price at least. Also I would add "Recommended to chose cheaper offers instead".

Jan 7 2025, 03:51
bytesofman published D17481: [Cashtab] Improve notification styles for review.
Jan 7 2025, 03:48

Jan 6 2025

bytesofman closed D17480: [ecash-herald] Move to agora-indexed chronik.
Jan 6 2025, 23:40
bytesofman committed rABC5cde2317ae9d: [ecash-herald] Move to agora-indexed chronik (authored by bytesofman).
[ecash-herald] Move to agora-indexed chronik
Jan 6 2025, 23:39
teamcity added a comment to D17479: [avalanche] Add a way to get pollable contenders from contender cache.
Jan 6 2025, 23:36
roqqit updated the diff for D17479: [avalanche] Add a way to get pollable contenders from contender cache.

Move static_assert to processor.h in order to avoid circular dependency

Jan 6 2025, 23:36
johnkuney accepted D17480: [ecash-herald] Move to agora-indexed chronik.
Jan 6 2025, 23:30
bytesofman published D17480: [ecash-herald] Move to agora-indexed chronik for review.
Jan 6 2025, 23:27
bytesofman closed D17473: [Cashtab] Improve notification styling.
Jan 6 2025, 23:08
bytesofman committed rABC9719e5c28501: [Cashtab] Improve notification styling (authored by bytesofman).
[Cashtab] Improve notification styling
Jan 6 2025, 23:08
teamcity added a comment to D17479: [avalanche] Add a way to get pollable contenders from contender cache.
Jan 6 2025, 23:07
roqqit requested review of D17479: [avalanche] Add a way to get pollable contenders from contender cache.
Jan 6 2025, 22:57
Fabien closed D17474: [explorer] Use the whole tree as context, use locked versions.
Jan 6 2025, 22:02
Fabien committed rABCc351d0731299: [explorer] Use the whole tree as context, use locked versions (authored by Fabien).
[explorer] Use the whole tree as context, use locked versions
Jan 6 2025, 22:02
bytesofman accepted D17474: [explorer] Use the whole tree as context, use locked versions.
Jan 6 2025, 22:00
bytesofman closed D17478: [explorer] working chronik patch.
Jan 6 2025, 21:59
bytesofman committed rABC75b369a2c49c: [explorer] working chronik patch (authored by bytesofman).
[explorer] working chronik patch
Jan 6 2025, 21:59
Fabien accepted D17478: [explorer] working chronik patch.
Jan 6 2025, 21:59
bytesofman published D17478: [explorer] working chronik patch for review.
Jan 6 2025, 21:58
roqqit closed D17475: [avalanche] Make ComputeProofRewardRank const.
Jan 6 2025, 21:49
roqqit committed rABC576d79f82e1a: [avalanche] Make ComputeProofRewardRank const (authored by roqqit).
[avalanche] Make ComputeProofRewardRank const
Jan 6 2025, 21:49
bytesofman closed D17477: [Cashtab] Swap chronik instances for patch.
Jan 6 2025, 21:41
bytesofman committed rABCe1c01c735dc2: [Cashtab] Swap chronik instances for patch (authored by bytesofman).
[Cashtab] Swap chronik instances for patch
Jan 6 2025, 21:41
Fabien accepted D17477: [Cashtab] Swap chronik instances for patch.
Jan 6 2025, 21:35
bytesofman published D17477: [Cashtab] Swap chronik instances for patch for review.
Jan 6 2025, 21:34
Fabien accepted D17473: [Cashtab] Improve notification styling.
Jan 6 2025, 20:09
teamcity added a comment to D17476: [explorer] Show as much token tx information as possible when the genesis info is missing.
Jan 6 2025, 19:44
Fabien requested review of D17476: [explorer] Show as much token tx information as possible when the genesis info is missing.
Jan 6 2025, 19:40
Fabien accepted D17475: [avalanche] Make ComputeProofRewardRank const.
Jan 6 2025, 19:23
roqqit requested review of D17475: [avalanche] Make ComputeProofRewardRank const.
Jan 6 2025, 18:54
teamcity added a comment to D17470: [explorer] Don't fail to render invalid token txs with non existing token id.

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://54.39.19.73:41647 for the next 60 minutes.

Jan 6 2025, 15:14
teamcity awarded D17470: [explorer] Don't fail to render invalid token txs with non existing token id a Piece of Eight token.
Jan 6 2025, 15:12
Fabien added a comment to D17470: [explorer] Don't fail to render invalid token txs with non existing token id.

@bot preview-explorer

Jan 6 2025, 15:12
Fabien updated the summary of D17470: [explorer] Don't fail to render invalid token txs with non existing token id.
Jan 6 2025, 15:12
Fabien updated the diff for D17470: [explorer] Don't fail to render invalid token txs with non existing token id.

Rebase on D17474 for the preview

Jan 6 2025, 15:09
Fabien requested review of D17474: [explorer] Use the whole tree as context, use locked versions.
Jan 6 2025, 15:09
bytesofman published D17473: [Cashtab] Improve notification styling for review.
Jan 6 2025, 14:40
Fabien closed D17469: Add the cargo build dir "target/" to the gitignore.
Jan 6 2025, 12:15
Fabien committed rABCd7ce21a13d15: Add the cargo build dir "target/" to the gitignore (authored by Fabien).
Add the cargo build dir "target/" to the gitignore
Jan 6 2025, 12:15
teamcity added a comment to D17470: [explorer] Don't fail to render invalid token txs with non existing token id.
Jan 6 2025, 11:56
teamcity awarded D17470: [explorer] Don't fail to render invalid token txs with non existing token id a Haypence token.
Jan 6 2025, 11:55
Fabien added a comment to D17470: [explorer] Don't fail to render invalid token txs with non existing token id.

@bot preview-explorer

Jan 6 2025, 11:55
Fabien updated the test plan for D17470: [explorer] Don't fail to render invalid token txs with non existing token id.
Jan 6 2025, 11:36
Fabien retitled D17470: [explorer] Don't fail to render invalid token txs with non existing token id from [explorer] Don't fail to render invalid token txs with missing genesis to [explorer] Don't fail to render invalid token txs with non existing token id.
Jan 6 2025, 11:35
Fabien updated the diff for D17470: [explorer] Don't fail to render invalid token txs with non existing token id.

Handle the block page as well

Jan 6 2025, 11:35
PiRK accepted D17469: Add the cargo build dir "target/" to the gitignore.
Jan 6 2025, 11:00
Fabien planned changes to D17470: [explorer] Don't fail to render invalid token txs with non existing token id.
Jan 6 2025, 10:02
Fabien requested review of D17470: [explorer] Don't fail to render invalid token txs with non existing token id.
Jan 6 2025, 09:51
Fabien requested review of D17469: Add the cargo build dir "target/" to the gitignore.
Jan 6 2025, 09:49
Fabien requested changes to D17468: [Cashtab] Bring back noisy test logs if not in CI.

There is no point degrading the experience of all users because you need a special case for your debugging workflow.
If you want to do get a more verbose output for debugging, either comment this (you're changing the code for your debug anyway) or maybe better, create a new test script like 'test-debug' that doesn't have this --silent flag. So that npm run test is clean and npm run test-debug is verbose

Jan 6 2025, 08:46
emack accepted D17468: [Cashtab] Bring back noisy test logs if not in CI.
Jan 6 2025, 08:28
bytesofman published D17468: [Cashtab] Bring back noisy test logs if not in CI for review.
Jan 6 2025, 03:55
bytesofman closed D17466: [Cashtab] Prevent agora buys of offers above spot.
Jan 6 2025, 03:50
bytesofman committed rABC2249c7452dc0: [Cashtab] Prevent agora buys of offers above spot (authored by bytesofman).
[Cashtab] Prevent agora buys of offers above spot
Jan 6 2025, 03:50
emack accepted D17466: [Cashtab] Prevent agora buys of offers above spot.
Jan 6 2025, 03:46
bytesofman requested review of D17466: [Cashtab] Prevent agora buys of offers above spot.
Jan 6 2025, 02:59
emack requested changes to D17466: [Cashtab] Prevent agora buys of offers above spot.
Jan 6 2025, 01:48

Jan 5 2025

bytesofman published D17466: [Cashtab] Prevent agora buys of offers above spot for review.
Jan 5 2025, 23:53
abc-bot committed rABC1e3ce7396a5a: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Jan 5 2025, 22:17
abc-bot committed rABC494f7141c4d6: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Jan 5 2025, 22:13
abc-bot committed rABCaa559f67de9d: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Jan 5 2025, 21:38
teamcity added a comment to D17464: [ecash-lib] attach ecc and hashes to globalThis.
Jan 5 2025, 05:40
bytesofman added a comment to D17464: [ecash-lib] attach ecc and hashes to globalThis.

mb it was actually working at rc-16 but this one is simpler anyway. got better at ensuring the proper version was being tested iterating through various other attempts.

Jan 5 2025, 05:40
teamcity added a comment to D17464: [ecash-lib] attach ecc and hashes to globalThis.
Jan 5 2025, 05:36
bytesofman updated the diff for D17464: [ecash-lib] attach ecc and hashes to globalThis.

simplify, use function instead of Proxy

Jan 5 2025, 05:36

Jan 4 2025

bytesofman planned changes to D17464: [ecash-lib] attach ecc and hashes to globalThis.

never mind. once I

Jan 4 2025, 23:34
bytesofman added a comment to D17464: [ecash-lib] attach ecc and hashes to globalThis.

This one seems to be working

Jan 4 2025, 23:19
bytesofman updated the diff for D17464: [ecash-lib] attach ecc and hashes to globalThis.

use a Proxy to get Ecc to work with existing syntax across dependency levels

Jan 4 2025, 23:13
bytesofman added a comment to D17464: [ecash-lib] attach ecc and hashes to globalThis.

note that rc4 does still "work" with

Jan 4 2025, 14:15
tobias_ruck requested changes to D17464: [ecash-lib] attach ecc and hashes to globalThis.
Jan 4 2025, 14:14
bytesofman added a comment to D17464: [ecash-lib] attach ecc and hashes to globalThis.

this (may) only work sometimes. Running into tests that passed last night fail this morning ... can't get them to work now... cache issue? mistake in setup and versions installed last night? not sure. tough to test as the problem only occurs in npm-installed versions

Jan 4 2025, 14:07
bytesofman published D17464: [ecash-lib] attach ecc and hashes to globalThis for review.
Jan 4 2025, 05:31
bytesofman closed D17463: [ecash-lib] [bugfix] patch version number.
Jan 4 2025, 00:25
bytesofman committed rABC26bacf0d4516: [ecash-lib] [bugfix] patch version number (authored by bytesofman).
[ecash-lib] [bugfix] patch version number
Jan 4 2025, 00:25
Fabien accepted D17463: [ecash-lib] [bugfix] patch version number.
Jan 4 2025, 00:22

Jan 3 2025

bytesofman added a comment to D17463: [ecash-lib] [bugfix] patch version number.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #89207, branch 'refs/tags/phabricator/diff/51949'
Triggered 2025-01-03 22:32:06 by 'Phabricator Staging (phabricator-staging)'
Started 2025-01-03 22:37:37 on agent 'buildagent7'
Finished 2025-01-03 22:37:37 with status FAILURE 'Unable to collect changes'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): 'N/A' (checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/880964 
TeamCity server version is 2024.12 (build 174331), server timezone: GMT (UTC)

[22:32:06]E: bt15 (5m:30s)
[22:32:06]i: TeamCity server version is 2024.12 (build 174331)
[22:32:06] : Finalize build settings
[22:32:06] : Collecting changes in 2 VCS roots
[22:32:06] :	 [Collecting changes in 2 VCS roots] VCS Root details
[22:32:06] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[22:32:06] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[22:32:06]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (running for 5m:30s)
[22:32:06]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure' (running for 5m:30s)
[22:32:06]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper14313791672650669746.sh ls-remote origin
[22:32:06]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper16734715470406059090.sh ls-remote origin
[22:32:06]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[22:32:06]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': kex_exchange_identification: read: Connection reset by peer
[22:32:06]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Connection reset by 51.161.87.173 port 2221
[22:32:06]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': fatal: Could not read from remote repository.
[22:32:06]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': 
[22:32:06]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Please make sure you have the correct access rights
[22:32:06]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': and the repository exists.
[22:32:07]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] Detecting changes in VCS root 'abc-infrastructure' (used in 'Bitcoin-ABC Infra Checkout', 'Extract Electrum ABC from ABC' and 5 other configurations)
[22:32:07]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] Will collect changes for 'abc-infrastructure' starting from revision 8bd105f8a65e40e3b0942b63bba4a735b877f2da
[22:32:07] : Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout
[22:32:07] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Upper limit revision: 8bd105f8a65e40e3b0942b63bba4a735b877f2da
[22:32:07]i:	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] MaxModId = 77176
[22:32:07] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Computed revision: 8bd105f8a65e40e3b0942b63bba4a735b877f2da
[22:37:37] : The build is removed from the queue to be prepared for the start
[22:37:37]E: Failed to collect changes, error: git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper14313791672650669746.sh ls-remote origin command failed.
exit code: 128
stderr: kex_exchange_identification: read: Connection reset by peer
Connection reset by 51.161.87.173 port 2221
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists., VCS root: "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[22:37:37]E: Failed to collect changes, error: git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper14313791672650669746.sh ls-remote origin command failed.
exit code: 128
stderr: kex_exchange_identification: read: Connection reset by peer
Connection reset by 51.161.87.173 port 2221
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists., VCS root: "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[22:37:37] : Build finished
Jan 3 2025, 22:38
teamcity added a comment to D17463: [ecash-lib] [bugfix] patch version number.
Jan 3 2025, 22:37
bytesofman published D17463: [ecash-lib] [bugfix] patch version number for review.
Jan 3 2025, 22:32
bytesofman closed D17461: [ecash-lib] Patch for nodejs tx building.
Jan 3 2025, 22:23
bytesofman committed rABC8909966d4893: [ecash-lib] Patch for nodejs tx building (authored by bytesofman).
[ecash-lib] Patch for nodejs tx building
Jan 3 2025, 22:23
tobias_ruck accepted D17461: [ecash-lib] Patch for nodejs tx building.
Jan 3 2025, 22:03
bytesofman published D17461: [ecash-lib] Patch for nodejs tx building for review.
Jan 3 2025, 21:57
Fabien closed D17460: [test_framework] Better debug output during port collision.
Jan 3 2025, 17:21
Fabien committed rABC92c2193e60e6: [test_framework] Better debug output during port collision (authored by Fabien).
[test_framework] Better debug output during port collision
Jan 3 2025, 17:21
PiRK accepted D17460: [test_framework] Better debug output during port collision.
Jan 3 2025, 14:28
Fabien requested review of D17460: [test_framework] Better debug output during port collision.
Jan 3 2025, 09:46
Fabien closed D17458: [cashtab] Don't display token type (SLP, ALP, etc.) in tx history.
Jan 3 2025, 08:01
Fabien committed rABC9ae51c3751aa: [cashtab] Don't display token type (SLP, ALP, etc.) in tx history (authored by Fabien).
[cashtab] Don't display token type (SLP, ALP, etc.) in tx history
Jan 3 2025, 08:01
bytesofman closed D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Jan 3 2025, 06:01
bytesofman committed rABCf3221e53549b: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create… (authored by bytesofman).
[Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create…
Jan 3 2025, 06:01
emack accepted D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Jan 3 2025, 05:57
bytesofman updated the diff for D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.

tslint again

Jan 3 2025, 04:34
emack requested changes to D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.

Remove SlpDecimals import in Inputs.tsx to get the build working

Jan 3 2025, 03:00
teamcity added a comment to D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Jan 3 2025, 02:17