Page MenuHomePhabricator
Feed All Stories

Jan 31 2025

teamcity triaged T3731: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Jan 31 2025, 12:20
tobias_ruck closed D17612: [ecash-lib] Add mnemonic functionality.
Jan 31 2025, 12:03
tobias_ruck committed rABCe8c7c10070f5: [ecash-lib] Add mnemonic functionality (authored by tobias_ruck).
[ecash-lib] Add mnemonic functionality
Jan 31 2025, 12:03
tobias_ruck closed D17610: [ecash-lib] Add `pbkdf2`.
Jan 31 2025, 12:00
tobias_ruck committed rABC01abe1438cf6: [ecash-lib] Add `pbkdf2` (authored by tobias_ruck).
[ecash-lib] Add `pbkdf2`
Jan 31 2025, 12:00
Fabien updated the diff for D17618: [avalanche] Track the finalized txs total sigchecks.

Remove unnecessary header

Jan 31 2025, 09:57
teamcity added a comment to D17618: [avalanche] Track the finalized txs total sigchecks.
Jan 31 2025, 09:46
Fabien requested review of D17618: [avalanche] Track the finalized txs total sigchecks.
Jan 31 2025, 09:38
Fabien requested review of D17617: [avalanche] Track the total size of finalized txs.
Jan 31 2025, 09:36
Fabien closed D17613: [avalanche] Fix flaky abc_p2p_getavaaddr.py test.
Jan 31 2025, 08:10
Fabien committed rABCafcb4a91d3bc: [avalanche] Fix flaky abc_p2p_getavaaddr.py test (authored by Fabien).
[avalanche] Fix flaky abc_p2p_getavaaddr.py test
Jan 31 2025, 08:10
PiRK accepted D17613: [avalanche] Fix flaky abc_p2p_getavaaddr.py test.
Jan 31 2025, 07:20

Jan 30 2025

bytesofman accepted D17614: [ecash-lib] Add `HdNode` for HD wallets.
Jan 30 2025, 23:23
bytesofman accepted D17612: [ecash-lib] Add mnemonic functionality.
Jan 30 2025, 22:43
tobias_ruck updated the diff for D17614: [ecash-lib] Add `HdNode` for HD wallets.

add =, rebase

Jan 30 2025, 22:43
bytesofman accepted D17610: [ecash-lib] Add `pbkdf2`.
Jan 30 2025, 22:41
tobias_ruck added a comment to D17614: [ecash-lib] Add `HdNode` for HD wallets.

Could you give a few sentences about the approach used here and how it differs from the legacy lib?

Jan 30 2025, 22:39
tobias_ruck updated the diff for D17612: [ecash-lib] Add mnemonic functionality.

use more consts

Jan 30 2025, 22:32
tobias_ruck added inline comments to D17612: [ecash-lib] Add mnemonic functionality.
Jan 30 2025, 22:20
tobias_ruck added a comment to D17612: [ecash-lib] Add mnemonic functionality.

very nice to have this in our own lib but we do lose the empirical validation of the bip39 lib, i.e. this has been used for years in wallets without any known issues in "truly random" seed generation.

Jan 30 2025, 22:17
tobias_ruck requested review of D17610: [ecash-lib] Add `pbkdf2`.
Jan 30 2025, 22:09
Fabien accepted D17611: [chronik] return empty transaction history for an unknown scripthash.
Jan 30 2025, 20:50
Fabien requested changes to D17607: [avalanche] Poll for stake contenders.
Jan 30 2025, 20:45
Fabien updated the diff for D17613: [avalanche] Fix flaky abc_p2p_getavaaddr.py test.

Make sure the proofs all exist

Jan 30 2025, 20:39
Fabien retitled D17611: [chronik] return empty transaction history for an unknown scripthash from [chronik] return empty transcation history for an unknown scripthash to [chronik] return empty transaction history for an unknown scripthash.
Jan 30 2025, 20:37
roqqit closed D17616: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when getting stake contender status.
Jan 30 2025, 19:38
roqqit committed rABCfd85bce1ebe4: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when… (authored by roqqit).
[avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when…
Jan 30 2025, 19:38
Fabien requested changes to D17615: [avalanche] Add stake contender to AnyVoteItem.
Jan 30 2025, 18:59
bytesofman requested changes to D17610: [ecash-lib] Add `pbkdf2`.
Jan 30 2025, 18:37
teamcity closed T3730: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Jan 30 2025, 18:35
bytesofman requested changes to D17614: [ecash-lib] Add `HdNode` for HD wallets.

Similar question as with D17612

Jan 30 2025, 18:16
PiRK accepted D17616: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when getting stake contender status.
Jan 30 2025, 18:15
PiRK planned changes to D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.

the failure seems unrelated, this diff shouldn't affect chronik_plugins, but i'll investigate just to be sure

Jan 30 2025, 18:13
Mengerian committed rABCa932cfb2f187: [e.cash] Replace Pay2Stay logo (authored by Mengerian).
[e.cash] Replace Pay2Stay logo
Jan 30 2025, 18:11
Mengerian closed D17606: [e.cash] Replace Pay2Stay logo.
Jan 30 2025, 18:11
bytesofman requested changes to D17612: [ecash-lib] Add mnemonic functionality.

very nice to have this in our own lib but we do lose the empirical validation of the bip39 lib, i.e. this has been used for years in wallets without any known issues in "truly random" seed generation.

Jan 30 2025, 17:59
roqqit requested review of D17616: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when getting stake contender status.
Jan 30 2025, 17:11
roqqit published D17607: [avalanche] Poll for stake contenders for review.
Jan 30 2025, 17:04
roqqit requested review of D17615: [avalanche] Add stake contender to AnyVoteItem.
Jan 30 2025, 16:59
tobias_ruck published D17614: [ecash-lib] Add `HdNode` for HD wallets for review.
Jan 30 2025, 16:05
teamcity added a comment to D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.
Jan 30 2025, 15:02
PiRK published D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method for review.
Jan 30 2025, 14:53
PiRK requested changes to D17613: [avalanche] Fix flaky abc_p2p_getavaaddr.py test.

The getavalanchepeerinfo errors probably because a proof is not yet registered when it is called.

Jan 30 2025, 14:52
teamcity added a comment to D17613: [avalanche] Fix flaky abc_p2p_getavaaddr.py test.
Jan 30 2025, 13:46
Fabien requested review of D17613: [avalanche] Fix flaky abc_p2p_getavaaddr.py test.
Jan 30 2025, 13:37
tobias_ruck requested review of D17612: [ecash-lib] Add mnemonic functionality.
Jan 30 2025, 13:34
PiRK requested review of D17611: [chronik] return empty transaction history for an unknown scripthash.
Jan 30 2025, 13:02
teamcity triaged T3730: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Jan 30 2025, 10:12
tobias_ruck published D17610: [ecash-lib] Add `pbkdf2` for review.
Jan 30 2025, 09:43
tobias_ruck closed D17609: [ecash-lib] Add SHA512 support, hashers and `Hmac`.
Jan 30 2025, 09:43
tobias_ruck committed rABC37bb5ed18b08: [ecash-lib] Add SHA512 support, hashers and `Hmac` (authored by tobias_ruck).
[ecash-lib] Add SHA512 support, hashers and `Hmac`
Jan 30 2025, 09:43
Fabien closed D17600: [doc] Rename some spec file to remove the activation date.
Jan 30 2025, 08:10
Fabien committed rABC8379d6a7bf1a: [doc] Rename some spec file to remove the activation date (authored by Fabien).
[doc] Rename some spec file to remove the activation date
Jan 30 2025, 08:10
bytesofman closed D17608: [Cashtab] Support buying agora offers above spot, within reason.
Jan 30 2025, 05:57
bytesofman committed rABC76ae72c209be: [Cashtab] Support buying agora offers above spot, within reason (authored by bytesofman).
[Cashtab] Support buying agora offers above spot, within reason
Jan 30 2025, 05:57
emack accepted D17608: [Cashtab] Support buying agora offers above spot, within reason.
Jan 30 2025, 05:56
bytesofman accepted D17609: [ecash-lib] Add SHA512 support, hashers and `Hmac`.

not necessarily related to the diff -- why is it better to keep all of these hash functions in webassembly? afaik we are the only cryptocurrency doing this.

Jan 30 2025, 04:06
tobias_ruck requested review of D17609: [ecash-lib] Add SHA512 support, hashers and `Hmac`.
Jan 30 2025, 03:47
bytesofman published D17608: [Cashtab] Support buying agora offers above spot, within reason for review.
Jan 30 2025, 00:34
bytesofman accepted D17606: [e.cash] Replace Pay2Stay logo.

is a higher resolution image available? it does look a little grainier than the last one, but not bad.

Jan 30 2025, 00:31
teamcity added a comment to D17606: [e.cash] Replace Pay2Stay logo.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41897 for the next 60 minutes.

Jan 30 2025, 00:26
teamcity awarded D17606: [e.cash] Replace Pay2Stay logo a Haypence token.
Jan 30 2025, 00:24
bytesofman added a comment to D17606: [e.cash] Replace Pay2Stay logo.

@bot preview-e.cash

Jan 30 2025, 00:24

Jan 29 2025

Mengerian added a reviewer for D17606: [e.cash] Replace Pay2Stay logo: tobias_ruck.
Jan 29 2025, 23:11
Mengerian requested review of D17606: [e.cash] Replace Pay2Stay logo.
Jan 29 2025, 23:10
Mengerian accepted D17600: [doc] Rename some spec file to remove the activation date.
Jan 29 2025, 22:35
roqqit closed D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.
Jan 29 2025, 20:38
roqqit committed rABC1d9e9cd37db2: [avalanche] Check that avalanche invalidated items no longer poll in the… (authored by roqqit).
[avalanche] Check that avalanche invalidated items no longer poll in the…
Jan 29 2025, 20:38
Fabien accepted D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.
Jan 29 2025, 19:58
roqqit updated the diff for D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.

Add comments to make it more clear that the test is checking the item is not being polled for

Jan 29 2025, 17:26
roqqit committed rABCfe50cfef5517: [doc] Cleanup trailing whitespaces (authored by roqqit).
[doc] Cleanup trailing whitespaces
Jan 29 2025, 17:18
roqqit closed D17602: [doc] Cleanup trailing whitespaces.
Jan 29 2025, 17:18
PiRK committed rABCb4ca4a8c259c: [chronik] make -chronikelectrumbind require -chronikscripthashindex (authored by PiRK).
[chronik] make -chronikelectrumbind require -chronikscripthashindex
Jan 29 2025, 12:09
PiRK closed D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.
Jan 29 2025, 12:09
Fabien added inline comments to D17600: [doc] Rename some spec file to remove the activation date.
Jan 29 2025, 09:51
Fabien updated the diff for D17600: [doc] Rename some spec file to remove the activation date.

Revert link update in the ecashaddrjs README

Jan 29 2025, 09:50

Jan 28 2025

Mengerian added inline comments to D17600: [doc] Rename some spec file to remove the activation date.
Jan 28 2025, 19:23
teamcity closed T3729: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Resolved.
Jan 28 2025, 16:31
Fabien committed rABCb6929f58a136: [cmake] Fix check-crates (authored by Fabien).
[cmake] Fix check-crates
Jan 28 2025, 16:18
Fabien closed D17604: [cmake] Fix check-crates.
Jan 28 2025, 16:18
PiRK accepted D17604: [cmake] Fix check-crates.
Jan 28 2025, 15:53
teamcity awarded D17604: [cmake] Fix check-crates a Haypence token.
Jan 28 2025, 15:47
Fabien added a comment to D17604: [cmake] Fix check-crates.

@bot build-chronik

Jan 28 2025, 15:47
Fabien requested review of D17604: [cmake] Fix check-crates.
Jan 28 2025, 15:47
teamcity triaged T3729: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Unbreak Now! priority.
Jan 28 2025, 14:26
Fabien closed D17603: Bump version to 0.30.10.
Jan 28 2025, 14:14
Fabien committed rABC98280cb3c2b8: Bump version to 0.30.10 (authored by Fabien).
Bump version to 0.30.10
Jan 28 2025, 14:14
PiRK updated the diff for D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.

fix test_init_errors (now chronikelectrumbind must be explicitely specified)

Jan 28 2025, 14:05
PiRK planned changes to D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.
Jan 28 2025, 14:02
teamcity added a comment to D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.
Jan 28 2025, 13:30
teamcity added a comment to D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.
Jan 28 2025, 13:26
PiRK updated the diff for D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.

fix functional tests

Jan 28 2025, 13:04
bytesofman accepted D17603: Bump version to 0.30.10.
Jan 28 2025, 12:38
Fabien requested review of D17603: Bump version to 0.30.10.
Jan 28 2025, 11:59
PiRK accepted D17602: [doc] Cleanup trailing whitespaces.
Jan 28 2025, 11:54
Fabien closed D17601: [chronik] Fix check-crates.
Jan 28 2025, 08:19
Fabien committed rABCe1a3a8f1fd34: [chronik] Fix check-crates (authored by Fabien).
[chronik] Fix check-crates
Jan 28 2025, 08:19
PiRK accepted D17601: [chronik] Fix check-crates.
Jan 28 2025, 08:15
PiRK requested changes to D17602: [doc] Cleanup trailing whitespaces.

One more to be removed

Jan 28 2025, 07:45

Jan 27 2025

roqqit updated the diff for D17602: [doc] Cleanup trailing whitespaces.

Remove erroneous image file change

Jan 27 2025, 22:11