Page MenuHomePhabricator
Feed Advanced Search

Jul 29 2025

PiRK accepted D18421: [chronik] Fix -Wmissing-field-initializers in chronikbridge_tests.cpp.
Jul 29 2025, 13:19

Jul 28 2025

PiRK accepted D18420: [avalanche][chronik] Bridge the isAvalancheFinalizedPreconsensus method and use it for the tx is_final status.
Jul 28 2025, 12:28
PiRK accepted D18419: [avalanche] Rename isAvalancheFinalized to isAvalancheFinalizedPreConsensus.
Jul 28 2025, 12:22

Jul 25 2025

PiRK accepted D18416: [avalanche] Disconnect from the updated block tip handler before destructing the processor.
Jul 25 2025, 14:57
PiRK accepted D18414: [avalanche] Release the locking requirements in AvalancheFinalizeBlock.
Jul 25 2025, 09:36
PiRK accepted D18407: [avalanche] Properly clean up the finalized transactions from the ancestor of the finalized block.
Jul 25 2025, 09:34

Jul 24 2025

PiRK accepted D18411: [avalanche] Add preconsensus validation callbacks.
Jul 24 2025, 14:33
PiRK accepted D18412: [website] Build the container on bullseye.
Jul 24 2025, 12:39
PiRK requested changes to D18407: [avalanche] Properly clean up the finalized transactions from the ancestor of the finalized block.
Jul 24 2025, 11:53
PiRK added inline comments to D18407: [avalanche] Properly clean up the finalized transactions from the ancestor of the finalized block.
Jul 24 2025, 09:53
PiRK accepted D18406: [avalanche] Enable mining finalized transactions.

looks good, except for the comment nits

Jul 24 2025, 07:58
PiRK added inline comments to D18406: [avalanche] Enable mining finalized transactions.
Jul 24 2025, 07:55

Jul 23 2025

PiRK accepted D18408: Bump version to 0.31.9.
Jul 23 2025, 15:55

Jul 21 2025

PiRK committed rABCa0603cd3e2f0: [electrum] update servers list (authored by PiRK).
[electrum] update servers list
Jul 21 2025, 12:26
PiRK closed D18388: [electrum] update servers list.
Jul 21 2025, 12:26
PiRK accepted D18392: [build] Use case insensitive checks for the allowed Windows libraries.
Jul 21 2025, 12:14
PiRK requested review of D18388: [electrum] update servers list.
Jul 21 2025, 07:50

Jul 17 2025

PiRK accepted D18377: [avalanche] Only mine the finalized txs.
Jul 17 2025, 09:14

Jul 16 2025

PiRK closed D18368: net: Give seednodes time before falling back to fixed seeds.
Jul 16 2025, 13:53
PiRK committed rABC7d0a42894a24: net: Give seednodes time before falling back to fixed seeds (authored by Martin Zumsande <mzumsande@gmail.com>).
net: Give seednodes time before falling back to fixed seeds
Jul 16 2025, 13:53
PiRK closed D18367: net_processing: remove mapRelay, relay txs from m_most_recent_block.
Jul 16 2025, 13:50
PiRK committed rABC733f231e8393: net_processing: remove mapRelay, relay txs from m_most_recent_block (authored by Anthony Towns <aj@erisian.com.au>).
net_processing: remove mapRelay, relay txs from m_most_recent_block
Jul 16 2025, 13:50
PiRK closed D18366: test: Add test to check tx in the last block can be downloaded.
Jul 16 2025, 13:50
PiRK committed rABC525f2f663b8e: test: Add test to check tx in the last block can be downloaded (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
test: Add test to check tx in the last block can be downloaded
Jul 16 2025, 13:50
PiRK closed D18365: util: Use steady clock instead of system clock to measure durations.
Jul 16 2025, 13:50
PiRK committed rABC5c08c9f9716a: util: Use steady clock instead of system clock to measure durations (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
util: Use steady clock instead of system clock to measure durations
Jul 16 2025, 13:50
PiRK accepted D18374: [tests] Readability refactors for miner_tests.
Jul 16 2025, 13:48
PiRK accepted D18369: [avalanche] Add the remaining contextual transaction checks to the tx finalization process.
Jul 16 2025, 13:44

Jul 15 2025

PiRK added inline comments to D18367: net_processing: remove mapRelay, relay txs from m_most_recent_block.
Jul 15 2025, 15:56
PiRK updated the diff for D18367: net_processing: remove mapRelay, relay txs from m_most_recent_block.

add a reorg test
The transaction is put back in the mempool so it should be available for request

Jul 15 2025, 15:48
PiRK updated the diff for D18368: net: Give seednodes time before falling back to fixed seeds.

move the comment inside the else if scope and rephrase it accordingly. Remove blank line

Jul 15 2025, 15:23
PiRK requested review of D18368: net: Give seednodes time before falling back to fixed seeds.
Jul 15 2025, 13:53
PiRK closed D18364: Pass MSG_MORE flag when sending non-final network messages.
Jul 15 2025, 13:34
PiRK committed rABCace0ea44f60d: Pass MSG_MORE flag when sending non-final network messages (authored by Matt Whitlock <bitcoin@mattwhitlock.name>).
Pass MSG_MORE flag when sending non-final network messages
Jul 15 2025, 13:34
PiRK accepted D18363: Move ContextualCheckTransactionForCurrentBlock to tx_verify.h/cpp.
Jul 15 2025, 12:58
PiRK added inline comments to D18367: net_processing: remove mapRelay, relay txs from m_most_recent_block.
Jul 15 2025, 12:56
PiRK updated the diff for D18367: net_processing: remove mapRelay, relay txs from m_most_recent_block.

lint: sort imports

Jul 15 2025, 12:55
PiRK requested review of D18367: net_processing: remove mapRelay, relay txs from m_most_recent_block.
Jul 15 2025, 12:53
PiRK requested review of D18366: test: Add test to check tx in the last block can be downloaded.
Jul 15 2025, 12:13
PiRK requested review of D18365: util: Use steady clock instead of system clock to measure durations.
Jul 15 2025, 11:44
PiRK added inline comments to D18364: Pass MSG_MORE flag when sending non-final network messages.
Jul 15 2025, 10:54
PiRK requested review of D18364: Pass MSG_MORE flag when sending non-final network messages.
Jul 15 2025, 10:50
PiRK accepted D18361: [Cashtab] Convert Config tests to ts.
Jul 15 2025, 07:43

Jul 12 2025

PiRK closed D18136: depends: Qt 5.15.16.
Jul 12 2025, 06:48
PiRK committed rABCa7202a569465: depends: Qt 5.15.16 (authored by fanquake <fanquake@gmail.com>).
depends: Qt 5.15.16
Jul 12 2025, 06:48

Jul 11 2025

PiRK published D18136: depends: Qt 5.15.16 for review.
Jul 11 2025, 11:50
teamcity awarded D18136: depends: Qt 5.15.16 a Piece of Eight token.
Jul 11 2025, 09:27
PiRK accepted D18353: [Cashtab] Convert JS common components to ts.
Jul 11 2025, 07:29

Jul 10 2025

PiRK accepted D18352: [Cashtab] Convert Extension.js to ts.
Jul 10 2025, 15:07
PiRK closed D18345: [electrum] fix the transaction dialog for Qt6.
Jul 10 2025, 10:23
PiRK committed rABC1a929605f51e: [electrum] fix the transaction dialog for Qt6 (authored by PiRK).
[electrum] fix the transaction dialog for Qt6
Jul 10 2025, 10:23
PiRK closed D18344: [electrum] add a copy_to_clipboard util function.
Jul 10 2025, 10:23
PiRK committed rABC9d5a6f042e4d: [electrum] add a copy_to_clipboard util function (authored by PiRK).
[electrum] add a copy_to_clipboard util function
Jul 10 2025, 10:23
PiRK accepted D18351: Add a release note for the known determinism bug on windows release.
Jul 10 2025, 09:26
PiRK accepted D18346: [Cashtab] Convert mock file to ts.
Jul 10 2025, 06:41
PiRK accepted D18347: [avalanche] Fix wrong local proof status when a replacement one is received over p2p.
Jul 10 2025, 06:39
PiRK updated the diff for D18344: [electrum] add a copy_to_clipboard util function.

consistency: used named params only when the text argument is omitted. When we copy selected text from a QTextEdit we don't want to pass a confusing text="" param

Jul 10 2025, 06:33

Jul 9 2025

PiRK added a comment to D18345: [electrum] fix the transaction dialog for Qt6.

I seearched for setShortcut and QKeySequence and found no other occurence of the + operator being used (except for the string constructor which still works, QKeySequence("Shift+Ctrl+P"))

Jul 9 2025, 09:21
PiRK requested review of D18345: [electrum] fix the transaction dialog for Qt6.
Jul 9 2025, 09:18
PiRK updated the test plan for D18344: [electrum] add a copy_to_clipboard util function.
Jul 9 2025, 09:13
PiRK requested review of D18344: [electrum] add a copy_to_clipboard util function.
Jul 9 2025, 09:12
PiRK closed D18339: [electrum] scripted-diff: use some Qt6 enums.
Jul 9 2025, 07:52
PiRK committed rABC3430fbdf2349: [electrum] scripted-diff: use some Qt6 enums (authored by PiRK).
[electrum] scripted-diff: use some Qt6 enums
Jul 9 2025, 07:52
PiRK closed D18338: [electrum] hw plugins: include a copy of pinmatrix.py from python-trezor, remove qt4 code.
Jul 9 2025, 07:52
PiRK committed rABCfae78f27107b: [electrum] hw plugins: include a copy of pinmatrix.py from python-trezor… (authored by SomberNight <somber.night@protonmail.com>).
[electrum] hw plugins: include a copy of pinmatrix.py from python-trezor…
Jul 9 2025, 07:52

Jul 8 2025

PiRK updated the diff for D18339: [electrum] scripted-diff: use some Qt6 enums.

remove commented dead code

Jul 8 2025, 14:06
PiRK updated the diff for D18338: [electrum] hw plugins: include a copy of pinmatrix.py from python-trezor, remove qt4 code.

mention the SatoshiLabs copyright and LGPL3 license in COPYING

Jul 8 2025, 14:02
PiRK updated the summary of D18338: [electrum] hw plugins: include a copy of pinmatrix.py from python-trezor, remove qt4 code.
Jul 8 2025, 13:50
PiRK updated the diff for D18339: [electrum] scripted-diff: use some Qt6 enums.

don't forget AlignRight

Jul 8 2025, 13:49
PiRK updated the summary of D18339: [electrum] scripted-diff: use some Qt6 enums.
Jul 8 2025, 13:45
PiRK requested review of D18339: [electrum] scripted-diff: use some Qt6 enums.
Jul 8 2025, 13:45
PiRK requested review of D18338: [electrum] hw plugins: include a copy of pinmatrix.py from python-trezor, remove qt4 code.
Jul 8 2025, 13:23
PiRK committed rABC011b0b6915aa: [electrum] refactor: move Send tab to its own module (authored by PiRK).
[electrum] refactor: move Send tab to its own module
Jul 8 2025, 12:08
PiRK closed D18324: [electrum] refactor: move Send tab to its own module.
Jul 8 2025, 12:08
PiRK closed D18335: [electrum] simplify and inline InvoiceList.chkVisible.
Jul 8 2025, 12:08
PiRK committed rABCacbd2ec2eaca: [electrum] simplify and inline InvoiceList.chkVisible (authored by PiRK).
[electrum] simplify and inline InvoiceList.chkVisible
Jul 8 2025, 12:08
PiRK committed rABCde6aaf9412a4: test: Avoid intermittent errors in feture_index_prune.py (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
test: Avoid intermittent errors in feture_index_prune.py
Jul 8 2025, 10:19
PiRK closed D18337: test: Avoid intermittent errors in feture_index_prune.py.
Jul 8 2025, 10:19
PiRK updated the summary of D18337: test: Avoid intermittent errors in feture_index_prune.py.
Jul 8 2025, 07:27
PiRK requested review of D18337: test: Avoid intermittent errors in feture_index_prune.py.
Jul 8 2025, 07:27

Jul 7 2025

PiRK added inline comments to D18324: [electrum] refactor: move Send tab to its own module.
Jul 7 2025, 15:21
PiRK updated the diff for D18324: [electrum] refactor: move Send tab to its own module.
  • rebase on the recent stack of small refactorings that help disentangle a bit more the main_window and it's child widgets
  • revert most changes in invoice_list.py: we can decouple this module in another diff, for now we still need to access the main_window for some things
  • don't access send_tab from invoice_list, because invoice_list is a subwidget of the tab. Add signals and let the Send tab connect to the signal
  • fix a bunch of lines that were broken by this refactor (self.* -> self.send_tab.*...) and test them (payment requests, contacts...)
Jul 7 2025, 15:15
PiRK closed D18334: [electrum] Remove shortcut reference to Contacts in main_window.
Jul 7 2025, 15:10
PiRK committed rABCdb5750d7f296: [electrum] Remove shortcut reference to Contacts in main_window (authored by PiRK).
[electrum] Remove shortcut reference to Contacts in main_window
Jul 7 2025, 15:10
PiRK added a comment to D18335: [electrum] simplify and inline InvoiceList.chkVisible.

Note that I needed a small patch to test this to bypass a SSL cert expiration check, as this bip70 server does currently not have a fresh certificate.

Jul 7 2025, 15:09
PiRK requested review of D18335: [electrum] simplify and inline InvoiceList.chkVisible.
Jul 7 2025, 15:07
PiRK requested review of D18334: [electrum] Remove shortcut reference to Contacts in main_window.
Jul 7 2025, 13:34
PiRK planned changes to D18324: [electrum] refactor: move Send tab to its own module.
Jul 7 2025, 12:01
PiRK accepted D18301: [chronik] Electrum: make the documentation public.
Jul 7 2025, 12:00
PiRK updated the diff for D18324: [electrum] refactor: move Send tab to its own module.

rebase, move a few methods that access history_list back to main_window so that the SendTab does not need to know the history_list API

Jul 7 2025, 11:55
PiRK closed D18331: [electrum] fix update of amounts when changing unit.
Jul 7 2025, 11:38
PiRK committed rABC06282c4db8de: [electrum] fix update of amounts when changing unit (authored by PiRK).
[electrum] fix update of amounts when changing unit
Jul 7 2025, 11:38
PiRK closed D18330: [electrum] fix fee unit in Preferences > Fee > Custom Fee Rate.
Jul 7 2025, 09:04
PiRK committed rABC2649c671c6a0: [electrum] fix fee unit in Preferences > Fee > Custom Fee Rate (authored by PiRK).
[electrum] fix fee unit in Preferences > Fee > Custom Fee Rate
Jul 7 2025, 09:04
PiRK closed D18329: [electrum] remove shortcut reference to InvoiceStore in MainWindow.
Jul 7 2025, 09:04
PiRK committed rABC2537fea019c4: [electrum] remove shortcut reference to InvoiceStore in MainWindow (authored by PiRK).
[electrum] remove shortcut reference to InvoiceStore in MainWindow
Jul 7 2025, 09:04
PiRK updated the diff for D18331: [electrum] fix update of amounts when changing unit.

remove unused docstring

Jul 7 2025, 08:54
PiRK updated the diff for D18331: [electrum] fix update of amounts when changing unit.

don't add unused args to update_status and update_tabs, use lambda function to ignore argument in the signal connection

Jul 7 2025, 08:53

Jul 5 2025

PiRK planned changes to D18324: [electrum] refactor: move Send tab to its own module.

actually this does not completely address the feedback on the send_tab being accessed from history_list

Jul 5 2025, 14:25
PiRK added inline comments to D18324: [electrum] refactor: move Send tab to its own module.
Jul 5 2025, 14:22