Page MenuHomePhabricator
Feed Advanced Search

Wed, Nov 5

teamcity awarded D18878: [validation] Add detailed txin/txout information for script error messages a Haypence token.
Wed, Nov 5, 15:52
PiRK added a comment to D18878: [validation] Add detailed txin/txout information for script error messages.

@bot build-chronik chronik-client-integration-tests

Wed, Nov 5, 15:52
PiRK updated the diff for D18880: [validation] merge all ConnectBlock debug logging code paths.

rebase

Wed, Nov 5, 15:49
PiRK updated the diff for D18879: [validation] include all logged information in BlockValidationState.

rebase

Wed, Nov 5, 15:49
PiRK updated the diff for D18878: [validation] Add detailed txin/txout information for script error messages.

update also chronik functional and unit tests

Wed, Nov 5, 15:48
PiRK updated the diff for D18876: [checkqueue] support user-defined return type through std::optional.

try to workaround a false positive [-Werror=maybe-uninitialized]

Wed, Nov 5, 15:09
PiRK accepted D18875: Early logging improvements.
Wed, Nov 5, 15:00
PiRK accepted D18874: refactor: Replace GetTimeMicros by SystemClock.
Wed, Nov 5, 14:48
PiRK planned changes to D18880: [validation] merge all ConnectBlock debug logging code paths.
Wed, Nov 5, 14:46
PiRK planned changes to D18878: [validation] Add detailed txin/txout information for script error messages.
Wed, Nov 5, 14:45
PiRK planned changes to D18877: [validation] Make script error messages uniform for parallel/single validation.
Wed, Nov 5, 14:45
PiRK planned changes to D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 14:45
PiRK planned changes to D18879: [validation] include all logged information in BlockValidationState.
Wed, Nov 5, 14:45
PiRK accepted D18873: log: Use steady clock for bench logging.
Wed, Nov 5, 14:37
PiRK accepted D18868: [chronik] Bump the build to c++20.
Wed, Nov 5, 14:30
PiRK requested review of D18880: [validation] merge all ConnectBlock debug logging code paths.
Wed, Nov 5, 14:29
PiRK requested review of D18879: [validation] include all logged information in BlockValidationState.
Wed, Nov 5, 14:23
PiRK requested review of D18878: [validation] Add detailed txin/txout information for script error messages.
Wed, Nov 5, 14:22
PiRK updated the summary of D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 14:21
PiRK requested review of D18877: [validation] Make script error messages uniform for parallel/single validation.
Wed, Nov 5, 14:21
PiRK requested review of D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 14:12
PiRK closed D18869: Bump version to 0.32.2.
Wed, Nov 5, 13:10
PiRK committed rABC02bb953b737c: Bump version to 0.32.2 (authored by PiRK).
Bump version to 0.32.2
Wed, Nov 5, 13:10
PiRK added inline comments to D18872: Add std::optional support to Boost's equality check.
Wed, Nov 5, 12:31
PiRK added inline comments to D18870: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().
Wed, Nov 5, 12:30
PiRK requested review of D18872: Add std::optional support to Boost's equality check.
Wed, Nov 5, 12:29
PiRK requested review of D18871: test: uint256 - Garbage suffixes and zero padding.
Wed, Nov 5, 12:26
PiRK requested review of D18870: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().
Wed, Nov 5, 12:25
PiRK requested review of D18869: Bump version to 0.32.2.
Wed, Nov 5, 11:16

Tue, Nov 4

PiRK closed D18865: [depends] bump Makefile to c++20.
Tue, Nov 4, 19:32
PiRK committed rABC14d68f0db0f0: [depends] bump Makefile to c++20 (authored by PiRK).
[depends] bump Makefile to c++20
Tue, Nov 4, 19:32
PiRK committed rABC2514eb2e09c7: guix: use GCC 13.3.0 for base toolchain. (authored by fanquake <fanquake@gmail.com>).
guix: use GCC 13.3.0 for base toolchain.
Tue, Nov 4, 19:32
PiRK closed D18866: guix: use GCC 13.3.0 for base toolchain..
Tue, Nov 4, 19:32
PiRK published D18866: guix: use GCC 13.3.0 for base toolchain. for review.
Tue, Nov 4, 16:45
teamcity awarded D18866: guix: use GCC 13.3.0 for base toolchain. a Piece of Eight token.
Tue, Nov 4, 16:45
teamcity awarded D18866: guix: use GCC 13.3.0 for base toolchain. a Haypence token.
Tue, Nov 4, 15:33
PiRK published D18865: [depends] bump Makefile to c++20 for review.
Tue, Nov 4, 15:20
teamcity awarded D18865: [depends] bump Makefile to c++20 a Piece of Eight token.
Tue, Nov 4, 14:25
teamcity awarded D18865: [depends] bump Makefile to c++20 a Haypence token.
Tue, Nov 4, 14:12
PiRK closed D18862: [cpp] move to c++20.
Tue, Nov 4, 13:37
PiRK committed rABC60040bd1a459: [cpp] move to c++20 (authored by PiRK).
[cpp] move to c++20
Tue, Nov 4, 13:37
teamcity awarded D18862: [cpp] move to c++20 a Like token.
Tue, Nov 4, 12:10
PiRK added a comment to D18862: [cpp] move to c++20.

@bot guix-win guix-linux guix-osx

Tue, Nov 4, 12:10
PiRK updated the summary of D18862: [cpp] move to c++20.
Tue, Nov 4, 12:10
PiRK updated the diff for D18862: [cpp] move to c++20.

bump to c++20 in .clang-format, back to c++17 in chronik until the clang issue is fixed or worked around (https://github.com/llvm/llvm-project/issues/67449), revert the CXX_EXTENSIONS change to fix the guix-win issue (can be fixed in a follow-up with a WIN32 definition)

Tue, Nov 4, 12:09
teamcity awarded D18862: [cpp] move to c++20 a Love token.
Tue, Nov 4, 09:57
PiRK added a comment to D18862: [cpp] move to c++20.

@bot guix-win guix-linux

Tue, Nov 4, 09:57
teamcity awarded D18862: [cpp] move to c++20 a Like token.
Tue, Nov 4, 09:46
PiRK added a comment to D18862: [cpp] move to c++20.

@bot guix-osx

Tue, Nov 4, 09:46
PiRK updated the diff for D18862: [cpp] move to c++20.

set(CMAKE_CXX_EXTENSIONS OFF)

Tue, Nov 4, 09:44
PiRK closed D18863: bench: Avoid deprecated use of volatile +=.
Tue, Nov 4, 09:41
PiRK closed D18861: refactor: Remove redundant checks in compat/assumptions.h.
Tue, Nov 4, 09:41
PiRK closed D18864: [seeder] avoid creating copy in loop variable.
Tue, Nov 4, 09:40
PiRK committed rABC31e37f5c0a0a: bench: Avoid deprecated use of volatile += (authored by MarcoFalke <falke.marco@gmail.com>).
bench: Avoid deprecated use of volatile +=
Tue, Nov 4, 09:40
PiRK committed rABCc391821a705e: [seeder] avoid creating copy in loop variable (authored by PiRK).
[seeder] avoid creating copy in loop variable
Tue, Nov 4, 09:40
PiRK committed rABCb963e3656f40: refactor: Remove redundant checks in compat/assumptions.h (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
refactor: Remove redundant checks in compat/assumptions.h
Tue, Nov 4, 09:40

Mon, Nov 3

PiRK planned changes to D18862: [cpp] move to c++20.

i rebased to check whether d18664 fixes all the seeder issues, but we still have a guix-osx issue to deal with.

Mon, Nov 3, 19:47
PiRK updated the diff for D18862: [cpp] move to c++20.

rebase on D18664

Mon, Nov 3, 19:46
PiRK requested review of D18864: [seeder] avoid creating copy in loop variable.
Mon, Nov 3, 19:44
teamcity awarded D18862: [cpp] move to c++20 a Mountain of Wealth token.
Mon, Nov 3, 18:32
PiRK added a comment to D18862: [cpp] move to c++20.

@bot build-ubsan

Mon, Nov 3, 18:32
teamcity awarded D18862: [cpp] move to c++20 a Doubloon token.
Mon, Nov 3, 18:31
PiRK added a comment to D18862: [cpp] move to c++20.

@bot guix-linux guix-win guix-osx

Mon, Nov 3, 18:31
PiRK updated the diff for D18862: [cpp] move to c++20.

rebase on D18863

Mon, Nov 3, 18:30
PiRK requested review of D18863: bench: Avoid deprecated use of volatile +=.
Mon, Nov 3, 18:29
teamcity awarded D18861: refactor: Remove redundant checks in compat/assumptions.h a Haypence token.
Mon, Nov 3, 18:24
PiRK added a comment to D18861: refactor: Remove redundant checks in compat/assumptions.h.

@bot guix-win

Mon, Nov 3, 18:24
PiRK updated the diff for D18861: refactor: Remove redundant checks in compat/assumptions.h.

fix include

Mon, Nov 3, 18:24
PiRK updated the summary of D18861: refactor: Remove redundant checks in compat/assumptions.h.
Mon, Nov 3, 18:21
PiRK updated the summary of D18861: refactor: Remove redundant checks in compat/assumptions.h.
Mon, Nov 3, 18:21
teamcity awarded D18862: [cpp] move to c++20 a Piece of Eight token.
Mon, Nov 3, 16:58
teamcity awarded D18862: [cpp] move to c++20 a Haypence token.
Mon, Nov 3, 16:57
PiRK added a comment to D18862: [cpp] move to c++20.

@bot guix-linux guix-win guix-osx

Mon, Nov 3, 16:07
PiRK requested review of D18862: [cpp] move to c++20.
Mon, Nov 3, 16:07
PiRK requested review of D18861: refactor: Remove redundant checks in compat/assumptions.h.
Mon, Nov 3, 15:57
PiRK closed D18860: kernel: De-globalize signature cache.
Mon, Nov 3, 09:25
PiRK committed rABCba5f2d10c953: kernel: De-globalize signature cache (authored by TheCharlatan <seb.kung@gmail.com>).
kernel: De-globalize signature cache
Mon, Nov 3, 09:25
PiRK closed D18856: kernel: De-globalize script execution cache.
Mon, Nov 3, 09:25
PiRK closed D18859: Expose CSignatureCache class in header.
Mon, Nov 3, 09:25
PiRK committed rABC2a0800e3e55b: Expose CSignatureCache class in header (authored by TheCharlatan <seb.kung@gmail.com>).
Expose CSignatureCache class in header
Mon, Nov 3, 09:25
PiRK closed D18858: kernel: De-globalize script execution cache hasher.
Mon, Nov 3, 09:25
PiRK closed D18855: validation: Don't error if maxsigcachesize exceeds uint32::max.
Mon, Nov 3, 09:25
PiRK committed rABCdbd59bfd4e31: validation: Don't error if maxsigcachesize exceeds uint32::max (authored by TheCharlatan <seb.kung@gmail.com>).
validation: Don't error if maxsigcachesize exceeds uint32::max
Mon, Nov 3, 09:25
PiRK committed rABC42e6cb1cbab9: kernel: De-globalize script execution cache hasher (authored by TheCharlatan <seb.kung@gmail.com>).
kernel: De-globalize script execution cache hasher
Mon, Nov 3, 09:25
PiRK committed rABCc6018810283f: kernel: De-globalize script execution cache (authored by TheCharlatan <seb.kung@gmail.com>).
kernel: De-globalize script execution cache
Mon, Nov 3, 09:25

Nov 1 2025

PiRK updated the diff for D18858: kernel: De-globalize script execution cache hasher.

force the ScriptCacheKey constructor to take the hasher as a rvalue, to avoid intermediate copies. Adjust the txvalidationcache_tests accordingly.

Nov 1 2025, 07:55
PiRK updated the diff for D18856: kernel: De-globalize script execution cache.

add lock annotation and add back compile time assertion for IsKeyInScriptCache and AddKeyInScriptCache

Nov 1 2025, 07:26

Oct 31 2025

PiRK updated the diff for D18859: Expose CSignatureCache class in header.

remove unneeded XOnlyPubKey forward declaration. We keep CTransaction even if it is unrelated to the rest of the commit, because it is correct (used in CachingTransactionSignatureChecker)

Oct 31 2025, 17:37
PiRK requested review of D18858: kernel: De-globalize script execution cache hasher.
Oct 31 2025, 17:30
PiRK added a comment to D18858: kernel: De-globalize script execution cache hasher.

It is the right commit but we are doing some extra stuff, like moving the ValidationCache ctor to validation.h after dropping the dependency on scriptcache.cpp globals. And we have to deal with an extra layer of wrapper around uint256 for the cache key: ScriptCacheKey, introduced in D4834. This class needs the hasher as a param in its ctor.

Oct 31 2025, 17:30
PiRK added inline comments to D18860: kernel: De-globalize signature cache.
Oct 31 2025, 17:22
PiRK published D18860: kernel: De-globalize signature cache for review.
Oct 31 2025, 16:10
PiRK published D18859: Expose CSignatureCache class in header for review.
Oct 31 2025, 16:09
PiRK published D18858: kernel: De-globalize script execution cache hasher for review.
Oct 31 2025, 16:09
PiRK added inline comments to D18856: kernel: De-globalize script execution cache.
Oct 31 2025, 15:51
PiRK published D18856: kernel: De-globalize script execution cache for review.
Oct 31 2025, 15:50
PiRK published D18855: validation: Don't error if maxsigcachesize exceeds uint32::max for review.
Oct 31 2025, 15:39
PiRK closed D18849: script: (optimization) introduce sighash midstate caching.
Oct 31 2025, 09:57
PiRK committed rABC36bd4d929e25: script: (optimization) introduce sighash midstate caching (authored by Pieter Wuille <pieter@wuille.net>).
script: (optimization) introduce sighash midstate caching
Oct 31 2025, 09:57
PiRK closed D18851: test: add vectors for the SIGHASH single bug.
Oct 31 2025, 09:57