Page MenuHomePhabricator
Feed Advanced Search

Feb 7 2020

deadalnix accepted D5184: Merge #14180: qa: Run all tests even if wallet is not compiled.
Feb 7 2020, 02:05

Feb 6 2020

deadalnix accepted D5029: deactivate sigops limits in phonon upgrade.
Feb 6 2020, 15:32
deadalnix requested changes to D5181: Add build support for 'gprof' profiling..
Feb 6 2020, 15:31
deadalnix accepted D5169: Merge #12917: qa: Windows fixups for functional tests.
Feb 6 2020, 02:11
deadalnix accepted D5168: Merge #16538: test: Add missing sync_blocks to feature_pruning.

Well then :)

Feb 6 2020, 02:10
deadalnix added inline comments to D5162: Fix flakey feature_pruning.
Feb 6 2020, 02:10
deadalnix accepted D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Feb 6 2020, 00:00

Feb 5 2020

deadalnix accepted D5166: Merge #14094: refactoring: Remove unreferenced local variables.
Feb 5 2020, 23:59
deadalnix added a comment to D5029: deactivate sigops limits in phonon upgrade.

While there is nothing wrong with that patch per se, it would be better to get the sigcheck nailed before landing this.

Feb 5 2020, 23:58
deadalnix committed rABC33c735931731: Disable clang-tidy by default (authored by deadalnix).
Disable clang-tidy by default
Feb 5 2020, 19:06
deadalnix closed D5163: Disable clang-tidy by default.
Feb 5 2020, 19:06
deadalnix committed rABCadcba09b85d2: Remove redundant std::move (authored by deadalnix).
Remove redundant std::move
Feb 5 2020, 19:02
deadalnix closed D5164: Remove redundant std::move.
Feb 5 2020, 19:02
deadalnix requested changes to D5162: Fix flakey feature_pruning.

Good catch, this has been bugging me too.

Feb 5 2020, 19:00
deadalnix created D5164: Remove redundant std::move.
Feb 5 2020, 17:50
deadalnix created D5163: Disable clang-tidy by default.
Feb 5 2020, 17:40
deadalnix accepted D5160: fix AreInputsStandard sigops counting.
Feb 5 2020, 16:37
deadalnix committed rABC78a23457ff35: scratch space: use single allocation (authored by Andrew Poelstra <apoelstra@wpsoftware.net>).
scratch space: use single allocation
Feb 5 2020, 16:35
deadalnix closed D5146: scratch space: use single allocation.
Feb 5 2020, 16:35
deadalnix accepted D5045: Add a script for building and pushing automated commits.

This doesn't seems to me like this is building capital toward more automation, but this is something.

Feb 5 2020, 01:00
deadalnix requested changes to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

One small change, but I think this is pretty much good to go.

Feb 5 2020, 00:11

Feb 4 2020

deadalnix committed rABC29c29d3acae1: Remove unecessary include of iostream (authored by deadalnix).
Remove unecessary include of iostream
Feb 4 2020, 23:53
deadalnix closed D5158: Remove unecessary include of iostream.
Feb 4 2020, 23:52
deadalnix created D5158: Remove unecessary include of iostream.
Feb 4 2020, 23:12
deadalnix accepted D5155: Update copyright for various files.
Feb 4 2020, 22:26
deadalnix committed rABC792ee59a0321: Avoid redundant calls to GetChainParams and GetConsensus in CChainState… (authored by deadalnix).
Avoid redundant calls to GetChainParams and GetConsensus in CChainState…
Feb 4 2020, 17:24
deadalnix closed D5154: Avoid redundant calls to GetChainParams and GetConsensus in CChainState::AcceptBlock.
Feb 4 2020, 17:24
deadalnix accepted D5149: Fix the build with GCC < 8.
Feb 4 2020, 16:13
deadalnix accepted D5127: add sigchecks limiter to CheckInputs.
Feb 4 2020, 16:12
deadalnix requested changes to D5149: Fix the build with GCC < 8.
Feb 4 2020, 15:19
deadalnix created D5154: Avoid redundant calls to GetChainParams and GetConsensus in CChainState::AcceptBlock.
Feb 4 2020, 15:15
deadalnix requested changes to D5029: deactivate sigops limits in phonon upgrade.
Feb 4 2020, 15:14
deadalnix added inline comments to D5152: Increase timeout in avalanche test.
Feb 4 2020, 15:04
deadalnix accepted D5152: Increase timeout in avalanche test.
Feb 4 2020, 15:02
deadalnix requested changes to D5149: Fix the build with GCC < 8.
Feb 4 2020, 15:01
deadalnix requested changes to D5144: Add LogPrint Benchmark.

Would this have detected the perf regression in PR17218? It really doesn't look obvious looking at this benchmark - in fact, I'd bet it's probably not obvious at all. But there are no numbers anywhere, we can all keep guessing.

Feb 4 2020, 01:01
deadalnix accepted D5145: Bump version to 0.20.13.
Feb 4 2020, 00:56
deadalnix created D5146: scratch space: use single allocation.
Feb 4 2020, 00:45

Feb 3 2020

deadalnix committed rABC34398ab486ea: Ensure the thresold for BIP9 can be configured on a per activation basis. (authored by deadalnix).
Ensure the thresold for BIP9 can be configured on a per activation basis.
Feb 3 2020, 23:39
deadalnix closed D5139: Ensure the thresold for BIP9 can be configured on a per activation basis..
Feb 3 2020, 23:39
deadalnix committed rABC42e749c2b184: Restore BIP9 RPC support in getblockchaininfo (authored by deadalnix).
Restore BIP9 RPC support in getblockchaininfo
Feb 3 2020, 23:31
deadalnix closed D5135: Restore BIP9 RPC support in getblockchaininfo.
Feb 3 2020, 23:31
deadalnix updated the diff for D5135: Restore BIP9 RPC support in getblockchaininfo.

braces

Feb 3 2020, 23:31
deadalnix updated the diff for D5135: Restore BIP9 RPC support in getblockchaininfo.

rebase

Feb 3 2020, 23:23
deadalnix committed rABC02de5cf341b3: Ressurect BIP9 style activation mechanism (authored by deadalnix).
Ressurect BIP9 style activation mechanism
Feb 3 2020, 23:14
deadalnix closed D5134: Ressurect BIP9 style activation mechanism.
Feb 3 2020, 23:14
deadalnix accepted D5142: Fix ubsan failure in excessiveblock_tests.
Feb 3 2020, 18:30
deadalnix requested changes to D5029: deactivate sigops limits in phonon upgrade.

The approach is needlessly branchy. You can simplify this.

Feb 3 2020, 18:27
deadalnix accepted D5119: Automatically add missing braces.
Feb 3 2020, 17:45
deadalnix accepted D5140: synchronize validation queue during submitblock.
Feb 3 2020, 17:18
deadalnix committed rABC274bff60cdb9: doxygen: Remove misleading checkpoints comment in CMainParams (authored by MarcoFalke <falke.marco@gmail.com>).
doxygen: Remove misleading checkpoints comment in CMainParams
Feb 3 2020, 17:01
deadalnix closed D5131: doxygen: Remove misleading checkpoints comment in CMainParams.
Feb 3 2020, 17:01
deadalnix committed rABC3ee864ad7392: Chainparams: Use name constants in chainparams initialization (authored by Jorge Timón <jtimon@jtimon.cc>).
Chainparams: Use name constants in chainparams initialization
Feb 3 2020, 16:38
deadalnix closed D5132: Chainparams: Use name constants in chainparams initialization.
Feb 3 2020, 16:38
deadalnix accepted D5138: [CMAKE] Enable clang-tidy.
Feb 3 2020, 16:33
deadalnix created D5139: Ensure the thresold for BIP9 can be configured on a per activation basis..
Feb 3 2020, 15:57
deadalnix accepted D5136: Prevent wrapping in setexcessiveblock RPC.
Feb 3 2020, 13:10
deadalnix committed rABC2598d7033af5: arc lint --everything (authored by deadalnix).
arc lint --everything
Feb 3 2020, 13:09
deadalnix closed D5133: arc lint --everything.
Feb 3 2020, 13:08
deadalnix accepted D5124: Merge #13938: refactoring: Cleanup StartRest().
Feb 3 2020, 01:42
deadalnix accepted D5047: Merge #14209/#17218: logging: Replace LogPrintf macro with regular function.
Feb 3 2020, 01:38
deadalnix created D5135: Restore BIP9 RPC support in getblockchaininfo.
Feb 3 2020, 01:20
deadalnix created D5134: Ressurect BIP9 style activation mechanism.
Feb 3 2020, 00:55
deadalnix created D5133: arc lint --everything.
Feb 3 2020, 00:08

Feb 2 2020

deadalnix created D5132: Chainparams: Use name constants in chainparams initialization.
Feb 2 2020, 23:56
deadalnix created D5131: doxygen: Remove misleading checkpoints comment in CMainParams.
Feb 2 2020, 23:52
deadalnix added inline comments to D5130: OP_REVERSEBYTES activation logic.
Feb 2 2020, 23:42
deadalnix requested changes to D5127: add sigchecks limiter to CheckInputs.
Feb 2 2020, 23:00
deadalnix accepted D5081: ConnectBlock: fix slow usage of AddCoins.

After more digging, it looks like this is what's core is doing. Let's go for it.

Feb 2 2020, 22:26
deadalnix added a comment to D5128: rearrange ATMP in preparation for SigChecks accounting in mempool.

It's all good. With the change we did around NULLFAIL and multisig, we should move things toward verifying signature lazily anyways.

Feb 2 2020, 22:18
deadalnix accepted D5128: rearrange ATMP in preparation for SigChecks accounting in mempool.
Feb 2 2020, 22:18
deadalnix accepted D5129: nit: functional test chmod +x.
Feb 2 2020, 14:57

Feb 1 2020

deadalnix accepted D5126: track nSigChecks in CheckInputs.
Feb 1 2020, 23:43
deadalnix requested changes to D5123: [Review ONLY] Migrate abcbot codebase into the ABC repo.

I don't think it makes sense to add a new folder for every tool out there. This dilutes the signal that something at the root is important.

Feb 1 2020, 02:45
deadalnix requested changes to D5122: [Review ONLY] Migrate bitcoinabc.org codebase into the ABC repo.

1/ Name it web; www or something.
2/ This needs to reworked. I don't think we want blogs posts in there for instance.

Feb 1 2020, 02:31

Jan 31 2020

deadalnix requested changes to D5119: Automatically add missing braces.
Jan 31 2020, 18:09
deadalnix accepted D5121: [CMAKE] Make Qt protobuf an object library.
Jan 31 2020, 15:22
deadalnix accepted D4834: add sigChecks value to script cache.
Jan 31 2020, 15:18
deadalnix requested changes to D5119: Automatically add missing braces.
Jan 31 2020, 01:55

Jan 30 2020

deadalnix accepted D5106: [SECP256K1] CMake: set default build configuration and optimization.
Jan 30 2020, 17:40
deadalnix accepted D5080: rpc: Make unloadwallet wait for complete wallet unload.
Jan 30 2020, 01:49

Jan 29 2020

deadalnix accepted D5100: [SECP256K1] CMake: add an install target.
Jan 29 2020, 18:01
deadalnix accepted D5099: [CMAKE] Allow for component based installation.
Jan 29 2020, 17:58
deadalnix accepted D5098: [CMAKE] Minor improvements to the install_shared_library function.
Jan 29 2020, 17:57
deadalnix accepted D5097: [SECP256K1] CMake: Fix in-tree build.
Jan 29 2020, 15:39
deadalnix requested changes to D5097: [SECP256K1] CMake: Fix in-tree build.

This disallow deleting the native folder and have it be rebuilt.

Jan 29 2020, 14:03
deadalnix accepted D5092: [SECP256K1] CMake: make the GMP bignum support optional.
Jan 29 2020, 14:01

Jan 28 2020

deadalnix accepted D5094: [SECP256K1] Travis: pass extra flags to the CMake build.
Jan 28 2020, 23:45
deadalnix accepted D5088: [SECP256K1] CMake: allow to select field and scalar implementation.
Jan 28 2020, 17:37
deadalnix added a comment to D4834: add sigChecks value to script cache.

Let just use an int in the cache and not a ScriptExecutionMetric in the cache.

Jan 28 2020, 15:38
deadalnix accepted D5089: [SECP256K1] CMake: add an option to enable endomorphism.
Jan 28 2020, 15:21
deadalnix accepted D5087: [SECP256K1] Travis : run a 64 bits ninja for building 32 bits targets.
Jan 28 2020, 13:45

Jan 27 2020

deadalnix requested changes to D5080: rpc: Make unloadwallet wait for complete wallet unload.

This introduce several bugs, cf the discussion on the PR.

Jan 27 2020, 22:45
deadalnix accepted D5069: FinalizeBlockAndInvalidate: just use chainActive.

If the index is a child of tip, shouldn't we invalidate its siblings?

Jan 27 2020, 16:46
deadalnix accepted D5078: Pass chain locked variables where needed.
Jan 27 2020, 16:28
deadalnix accepted D5075: Remove uses of cs_main in wallet code.
Jan 27 2020, 16:14
deadalnix accepted D5074: Pass chain and client variables where needed.
Jan 27 2020, 15:38
deadalnix accepted D5054: Prevent shared conf files from failing with different available options in different binaries.
Jan 27 2020, 14:21
deadalnix accepted D5077: ConnectBlock : count sigops in one place.
Jan 27 2020, 14:04
deadalnix accepted D5076: make per-tx sigops limit contextual.

I think the change to accept to memory pool would be better with a static_assert but overall, LGTM.

Jan 27 2020, 14:03