Page MenuHomePhabricator
Feed Advanced Search

Jun 27 2020

deadalnix accepted D6757: [CI] Fix wrong configuration when there is no template.
Jun 27 2020, 12:37
deadalnix requested changes to D6751: [CMAKE] Run the leveldb tests serially.

The difference is very relevent because this adds to the serial path for no good reasons.

Jun 27 2020, 12:37
deadalnix committed rABC0662e0785d44: Add missing fi in secp256k1's travis script (authored by deadalnix).
Add missing fi in secp256k1's travis script
Jun 27 2020, 12:29
deadalnix closed D6754: Add missing fi in secp256k1's travis script.
Jun 27 2020, 12:29
deadalnix requested review of D6754: Add missing fi in secp256k1's travis script.
Jun 27 2020, 00:21

Jun 26 2020

deadalnix added a comment to D6751: [CMAKE] Run the leveldb tests serially.

Also: https://reviews.llvm.org/D6304

Jun 26 2020, 19:16
deadalnix requested changes to D6751: [CMAKE] Run the leveldb tests serially.

You can create a specific job pool for this and set the job count to 1 rather than simply use terminal.

Jun 26 2020, 19:14
deadalnix accepted D6750: [CI] Refactor the build by making it a class.
Jun 26 2020, 18:48
deadalnix accepted D6749: [CI] Make the build configuration a class.
Jun 26 2020, 18:47
deadalnix accepted D6748: [CI] Filter what is printed to the console and log it to files.
Jun 26 2020, 13:34
deadalnix committed rABC06c3f0a88f0c: Separate reason for premature spends (coinbase/locktime) (authored by Suhas Daftuar <sdaftuar@gmail.com>).
Separate reason for premature spends (coinbase/locktime)
Jun 26 2020, 12:27
deadalnix closed D6743: Separate reason for premature spends (coinbase/locktime).
Jun 26 2020, 12:27
deadalnix committed rABC28819304c274: Assert validation reasons are contextually correct (authored by Suhas Daftuar <sdaftuar@gmail.com>).
Assert validation reasons are contextually correct
Jun 26 2020, 12:23
deadalnix closed D6742: Assert validation reasons are contextually correct.
Jun 26 2020, 12:22
deadalnix committed rABC1eea7d56ce99: [avalanche] Add test for the parking scenario (authored by deadalnix).
[avalanche] Add test for the parking scenario
Jun 26 2020, 12:03
deadalnix closed D6731: [avalanche] Add test for the parking scenario.
Jun 26 2020, 12:02

Jun 25 2020

deadalnix accepted D6745: [backport#17009] tests: Add EvalScript(...) fuzzing harness.
Jun 25 2020, 22:55
deadalnix requested review of D6743: Separate reason for premature spends (coinbase/locktime).
Jun 25 2020, 22:13
deadalnix requested review of D6742: Assert validation reasons are contextually correct.
Jun 25 2020, 21:32
deadalnix committed rABC5f2783164fcd: [refactor] Update some comments in validation.cpp as we arent doing DoS there (authored by Matt Corallo <git@bluematt.me>).
[refactor] Update some comments in validation.cpp as we arent doing DoS there
Jun 25 2020, 21:08
deadalnix closed D6738: [refactor] Update some comments in validation.cpp as we arent doing DoS there.
Jun 25 2020, 21:08
deadalnix committed rABC3534a7e7ef6a: [refactor] Drop unused state.DoS(), state.GetDoS(), state.CorruptionPossible() (authored by Matt Corallo <git@bluematt.me>).
[refactor] Drop unused state.DoS(), state.GetDoS(), state.CorruptionPossible()
Jun 25 2020, 21:05
deadalnix closed D6737: [refactor] Drop unused state.DoS(), state.GetDoS(), state.CorruptionPossible().
Jun 25 2020, 21:05
deadalnix committed rABC70ddc1747307: CorruptionPossible -> TX_WITNESS_MUTATED (authored by Matt Corallo <git@bluematt.me>).
CorruptionPossible -> TX_WITNESS_MUTATED
Jun 25 2020, 17:17
deadalnix closed D6734: CorruptionPossible -> TX_WITNESS_MUTATED.
Jun 25 2020, 17:17
deadalnix committed rABC4a7d44cfebb9: Use reason for checking for sigcheck in txvalidationcache (authored by deadalnix).
Use reason for checking for sigcheck in txvalidationcache
Jun 25 2020, 16:36
deadalnix closed D6736: Use reason for checking for sigcheck in txvalidationcache.
Jun 25 2020, 16:36
deadalnix updated the diff for D6738: [refactor] Update some comments in validation.cpp as we arent doing DoS there.

branch name

Jun 25 2020, 15:08
deadalnix requested review of D6738: [refactor] Update some comments in validation.cpp as we arent doing DoS there.
Jun 25 2020, 15:06
deadalnix updated the summary of D6737: [refactor] Drop unused state.DoS(), state.GetDoS(), state.CorruptionPossible().
Jun 25 2020, 14:51
deadalnix requested review of D6737: [refactor] Drop unused state.DoS(), state.GetDoS(), state.CorruptionPossible().
Jun 25 2020, 14:47
deadalnix requested review of D6736: Use reason for checking for sigcheck in txvalidationcache.
Jun 25 2020, 14:42
deadalnix requested review of D6734: CorruptionPossible -> TX_WITNESS_MUTATED.
Jun 25 2020, 14:18
deadalnix committed rABCcc54e8f8bc35: scripted-diff: Remove DoS calls to CValidationState (authored by Matt Corallo <git@bluematt.me>).
scripted-diff: Remove DoS calls to CValidationState
Jun 25 2020, 12:41
deadalnix closed D6730: scripted-diff: Remove DoS calls to CValidationState.
Jun 25 2020, 12:41
deadalnix committed rABCbc3fa66b8393: [refactor] Prep for scripted-diff by removing some \ns which annoy sed. (authored by Matt Corallo <git@bluematt.me>).
[refactor] Prep for scripted-diff by removing some \ns which annoy sed.
Jun 25 2020, 12:31
deadalnix closed D6729: [refactor] Prep for scripted-diff by removing some \ns which annoy sed..
Jun 25 2020, 12:31
deadalnix committed rABC46872d36ce46: Allow use of state.Invalid() for all reasons (authored by Matt Corallo <git@bluematt.me>).
Allow use of state.Invalid() for all reasons
Jun 25 2020, 12:15
deadalnix closed D6728: Allow use of state.Invalid() for all reasons.
Jun 25 2020, 12:15
deadalnix added a comment to T89: Consider adding -maxoutconnections to command-line and config file (like BU has).

What problem does this solves?

Jun 25 2020, 12:10 · Restricted Project
deadalnix committed rABC599693863bae: Fix handling of invalid headers (authored by Suhas Daftuar <sdaftuar@gmail.com>).
Fix handling of invalid headers
Jun 25 2020, 12:08
deadalnix closed D6727: Fix handling of invalid headers.
Jun 25 2020, 12:08
deadalnix requested review of D6731: [avalanche] Add test for the parking scenario.
Jun 25 2020, 12:02
deadalnix requested review of D6731: [avalanche] Add test for the parking scenario.
Jun 25 2020, 00:50

Jun 24 2020

deadalnix accepted D6719: [CI] Make sure every build directory is under a common 'build' directory.
Jun 24 2020, 23:45
deadalnix updated the summary of D6730: scripted-diff: Remove DoS calls to CValidationState.
Jun 24 2020, 23:31
deadalnix requested review of D6730: scripted-diff: Remove DoS calls to CValidationState.
Jun 24 2020, 23:31
deadalnix committed rABCb4ec6eddeb2a: Use BlockHash in net_processing.cpp (authored by deadalnix).
Use BlockHash in net_processing.cpp
Jun 24 2020, 23:14
deadalnix closed D6725: Use BlockHash in net_processing.cpp.
Jun 24 2020, 23:14
deadalnix added a comment to D6729: [refactor] Prep for scripted-diff by removing some \ns which annoy sed..

Lint violations are the whole purpose of that patch.

Jun 24 2020, 23:10
deadalnix requested review of D6729: [refactor] Prep for scripted-diff by removing some \ns which annoy sed..
Jun 24 2020, 23:09
deadalnix requested review of D6728: Allow use of state.Invalid() for all reasons.
Jun 24 2020, 23:03
deadalnix requested review of D6727: Fix handling of invalid headers.
Jun 24 2020, 22:57
deadalnix committed rABCf0b9e1055c7f: [refactor] Use Reasons directly instead of DoS codes (authored by Matt Corallo <git@bluematt.me>).
[refactor] Use Reasons directly instead of DoS codes
Jun 24 2020, 22:31
deadalnix closed D6708: [refactor] Use Reasons directly instead of DoS codes.
Jun 24 2020, 22:31
deadalnix committed rABC6c56712051e4: CorruptionPossible -> BLOCK_MUTATED (authored by Matt Corallo <git@bluematt.me>).
CorruptionPossible -> BLOCK_MUTATED
Jun 24 2020, 22:25
deadalnix closed D6707: CorruptionPossible -> BLOCK_MUTATED.
Jun 24 2020, 22:25
deadalnix requested review of D6725: Use BlockHash in net_processing.cpp.
Jun 24 2020, 22:17
deadalnix requested changes to D6692: [land-bot] Preserve committer name and email.

Why don't pull the change from the statging repo rather than doing this?

Jun 24 2020, 16:28
deadalnix requested review of D6708: [refactor] Use Reasons directly instead of DoS codes.
Jun 24 2020, 15:57
deadalnix accepted D6701: [CI] Extract the CI build facitilties to it's own script and source it.
Jun 24 2020, 15:24
deadalnix added inline comments to D6692: [land-bot] Preserve committer name and email.
Jun 24 2020, 15:23
deadalnix accepted D6703: [CI] Split build-configurations.sh into individual scripts.
Jun 24 2020, 15:22
deadalnix accepted D6706: [WEB] Update .arcconfig phabricator URI to the new syntax.
Jun 24 2020, 15:22
deadalnix requested review of D6707: CorruptionPossible -> BLOCK_MUTATED.
Jun 24 2020, 14:51
deadalnix accepted D6704: Update .arcconfig phabricator URI to the new syntax.
Jun 24 2020, 14:19
deadalnix committed rABC4b7d6a093c38: LookupBlockIndex -> CACHED_INVALID (authored by Matt Corallo <git@bluematt.me>).
LookupBlockIndex -> CACHED_INVALID
Jun 24 2020, 13:35
deadalnix closed D6700: LookupBlockIndex -> CACHED_INVALID.
Jun 24 2020, 13:35
deadalnix committed rABCf74ee657f02c: [refactor] Drop redundant nDoS, corruptionPossible, SetCorruptionPossible (authored by Matt Corallo <git@bluematt.me>).
[refactor] Drop redundant nDoS, corruptionPossible, SetCorruptionPossible
Jun 24 2020, 13:34
deadalnix closed D6699: [refactor] Drop redundant nDoS, corruptionPossible, SetCorruptionPossible.
Jun 24 2020, 13:34
deadalnix committed rABC4ee2470e29ce: [refactor] Add useful-for-dos "reason" field to CValidationState (authored by Matt Corallo <git@bluematt.me>).
[refactor] Add useful-for-dos "reason" field to CValidationState
Jun 24 2020, 13:33
deadalnix closed D6698: [refactor] Add useful-for-dos "reason" field to CValidationState.
Jun 24 2020, 13:33
deadalnix updated the diff for D6698: [refactor] Add useful-for-dos "reason" field to CValidationState.

dewitnessify

Jun 24 2020, 13:19
deadalnix updated the summary of D6700: LookupBlockIndex -> CACHED_INVALID.
Jun 24 2020, 01:38
deadalnix updated the summary of D6699: [refactor] Drop redundant nDoS, corruptionPossible, SetCorruptionPossible.
Jun 24 2020, 01:38
deadalnix requested review of D6700: LookupBlockIndex -> CACHED_INVALID.
Jun 24 2020, 01:35
deadalnix requested review of D6699: [refactor] Drop redundant nDoS, corruptionPossible, SetCorruptionPossible.
Jun 24 2020, 01:26
deadalnix requested review of D6698: [refactor] Add useful-for-dos "reason" field to CValidationState.
Jun 24 2020, 01:00
deadalnix accepted D6696: Merge #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string.
Jun 24 2020, 00:57
deadalnix accepted D6697: Merge #11418: Add error string for CLEANSTACK script violation.
Jun 24 2020, 00:57
deadalnix committed rABC70d3cdf9fc1a: Do not resuse state in checkpoints_tests.cpp (authored by deadalnix).
Do not resuse state in checkpoints_tests.cpp
Jun 24 2020, 00:53
deadalnix closed D6694: Do not resuse state in checkpoints_tests.cpp.
Jun 24 2020, 00:53
deadalnix committed rABC0c22fdc614fb: Make sigcheck violation report invaid rather than non standard (authored by deadalnix).
Make sigcheck violation report invaid rather than non standard
Jun 24 2020, 00:51
deadalnix closed D6693: Make sigcheck violation report invaid rather than non standard.
Jun 24 2020, 00:51

Jun 23 2020

deadalnix requested review of D6694: Do not resuse state in checkpoints_tests.cpp.
Jun 23 2020, 23:37
deadalnix requested review of D6693: Make sigcheck violation report invaid rather than non standard.
Jun 23 2020, 23:03
deadalnix committed rABC980b086d1896: Clean up banning levels (authored by Matt Corallo <git@bluematt.me>).
Clean up banning levels
Jun 23 2020, 16:49
deadalnix closed D6685: Clean up banning levels.
Jun 23 2020, 16:49
deadalnix accepted D6688: [CI] Remove duplicated `cd` to the build dir with build-make-generator.
Jun 23 2020, 16:44
deadalnix committed rABC6523d29f7cf4: [refactor] drop IsInvalid(nDoSOut) (authored by Matt Corallo <git@bluematt.me>).
[refactor] drop IsInvalid(nDoSOut)
Jun 23 2020, 16:43
deadalnix closed D6684: [refactor] drop IsInvalid(nDoSOut).
Jun 23 2020, 16:43
deadalnix committed rABCc02c6c9966ce: [refactor] Refactor misbehavior ban decisions to MaybePunishNode() (authored by Matt Corallo <git@bluematt.me>).
[refactor] Refactor misbehavior ban decisions to MaybePunishNode()
Jun 23 2020, 16:42
deadalnix closed D6683: [refactor] Refactor misbehavior ban decisions to MaybePunishNode().
Jun 23 2020, 16:42
deadalnix updated the diff for D6683: [refactor] Refactor misbehavior ban decisions to MaybePunishNode().

nits

Jun 23 2020, 16:41
deadalnix accepted D6686: [CI] Make the build_autotools.sh script take a list of targets.
Jun 23 2020, 16:38
deadalnix accepted D6687: [CI] Wrap the build_autotools.sh script in a function.
Jun 23 2020, 16:37
deadalnix requested review of D6685: Clean up banning levels.
Jun 23 2020, 15:37
deadalnix requested review of D6684: [refactor] drop IsInvalid(nDoSOut).
Jun 23 2020, 15:28
deadalnix requested review of D6683: [refactor] Refactor misbehavior ban decisions to MaybePunishNode().
Jun 23 2020, 15:16
deadalnix committed rABCa41c791355ca: Remove double if in tx_verify.cpp (authored by deadalnix).
Remove double if in tx_verify.cpp
Jun 23 2020, 14:45