It doesn't looks like it is using any state of the object, so why should this be a member method of that object? That doesn't make sense.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 19 2022
May 19 2022
deadalnix requested changes to D11498: [avalanche] Maintain a count of the proofs in the proof pool.
This count cannot be simply retrieved using size() because it is a multimap like structure.
deadalnix requested changes to D11494: [avalanche] Fix underflow when clearing too many inflight requests.
I don't understand what problem this is solving. First, this is using low free gizmo that seem completely unecessary - aren't VoteReccord owned by locks to begin with?
deadalnix requested changes to D11474: [avalanche] Drop stale votes after too many rounds without finalization.
deadalnix added inline comments to D11474: [avalanche] Drop stale votes after too many rounds without finalization.
May 14 2022
May 14 2022
No, compare the address.
May 13 2022
May 13 2022
ProofComparator does complex computation, when it was before just comparing pointers. This solves a real problem, but the solution is not good.
I don't think this patch helps with anything.
This is good, I left a few comments on ways the code could be improved upon.
deadalnix committed rABC28064258b769: [RCU] Run a lazy round of cleanup when unlocking the RCULock (authored by deadalnix).
[RCU] Run a lazy round of cleanup when unlocking the RCULock
deadalnix retitled D11458: [RCU] Run a lazy round of cleanup when unlocking the RCULock from [radix] Run a lazy round of cleanup when unlocking the RCULock to [RCU] Run a lazy round of cleanup when unlocking the RCULock.
deadalnix added inline comments to D11458: [RCU] Run a lazy round of cleanup when unlocking the RCULock.
deadalnix requested changes to D11457: [avalanche] Reject votes that have been inconclusive for too many rounds.
This is obviously unsound. How can this make consistent conclusion with the rest of the network?
May 12 2022
May 12 2022
deadalnix requested review of D11456: [radix] Adds the capability to use an adapter for key manipulation.
May 10 2022
May 10 2022
deadalnix committed rABC826544525ee7: Make iteration type explicit, this is very important here. (authored by deadalnix).
Make iteration type explicit, this is very important here.
May 7 2022
May 7 2022
As per our discussion, I think the main problem with this is that, while the existing code indeed looks funny, not in a good way, it's not clear what the correct structure actually is. I think we should put this on hold untill we actually have a a problem that would benefit from restructuring this code, then we'll have a better idea of what it should look like.
May 6 2022
May 6 2022
May 5 2022
May 5 2022
deadalnix requested changes to D11414: [avalanche] Rename the `Invalid` vote status for consistency with other status.
They are all adjective, I don't see any of this is consistent, and in fact, Invalidated imply that they were made invalid at some point in the past, which may not be the case at all (they might always have been invalid, for instance, and therefore, never invalidated).
May 1 2022
May 1 2022
There is pretty much the same code stamped 3 times in a row now. This is clearly an indication that it is time to stop piling up and go to the design board.
Apr 28 2022
Apr 28 2022
deadalnix requested changes to D11390: [avalanche] Bypass net group limits by default for avalanche outbounds.
Also, the test plan doesn't test the change.
deadalnix committed rABCc75b34181a2b: Use incrementRefCount and decrementRefCount in the radix code too (authored by deadalnix).
Use incrementRefCount and decrementRefCount in the radix code too
deadalnix requested review of D11396: Use incrementRefCount and decrementRefCount in the radix code too.
deadalnix committed rABC7c944d278dae: Change the name of the refcount operations on RCU elements (authored by deadalnix).
Change the name of the refcount operations on RCU elements
Tests are failing, back on your queue.
Implement COW for the radix tree
Apr 27 2022
Apr 27 2022
deadalnix committed rABCf72f9f3c9b61: Use using instead of typedef int he radix code (authored by deadalnix).
Use using instead of typedef int he radix code
deadalnix requested changes to D11389: [avalanche] Send getavalancheproofs request upon receipt of a new valid proof.
This is O(n^2)
deadalnix added inline comments to D11388: [avalanche] Answer getavaproofs message with short proof ids.
Mar 14 2022
Mar 14 2022
Mar 13 2022
Mar 13 2022
Feb 8 2022
Feb 8 2022
Jan 14 2022
Jan 14 2022
Jan 13 2022
Jan 13 2022
Jan 5 2022
Jan 5 2022
Dec 20 2021
Dec 20 2021
Clearing my queue.
Clearing my queue.
Dec 16 2021
Dec 16 2021
deadalnix requested changes to D10686: [avalanche] Move block-vote decision into getAvalancheVoteForBlock..
Dec 15 2021
Dec 15 2021
deadalnix committed rABCfa6a6071853b: Refactor ProofPool::addProofIfPreferred (authored by deadalnix).
Refactor ProofPool::addProofIfPreferred
deadalnix added inline comments to D10686: [avalanche] Move block-vote decision into getAvalancheVoteForBlock..
Dec 14 2021
Dec 14 2021
Remove createPeer
Remove code moved by mistake.
Where is this tested?
Dec 12 2021
Dec 12 2021
Dec 10 2021
Dec 10 2021
The behavior changed, and yet no test changed. This indicates to me the current behavior is not tested appropriately. This is the first step that needs to be taken here.
Dec 7 2021
Dec 7 2021
deadalnix requested changes to D10605: [avalanche] Move the proof registration time from the peer to the proof pool.
The registration time is now stored for each UTXO, I don't think this really makes sense.
deadalnix requested changes to D10524: [avalanche] Select the favorite orphan in case of a conflict.
Dec 3 2021
Dec 3 2021
Dec 1 2021
Dec 1 2021
Nov 30 2021
Nov 30 2021
The dependencies are almost certainly wrong here. This could go in fairly quickly.