addressed comments
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 22 2020
Jun 22 2020
majcosta updated the diff for D6626: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt.
Jun 21 2020
Jun 21 2020
majcosta committed rABC4957ae63d6dc: [backport#14818] Bugfix: test/functional/rpc_psbt: Remove check for specific… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#14818] Bugfix: test/functional/rpc_psbt: Remove check for specific…
majcosta updated the summary of D6643: [backport#pr16542 2/4] Give more errors for specific failure conditions.
Jun 20 2020
Jun 20 2020
majcosta updated the diff for D6651: [backport#14818] Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions.
fixed comment
deadalnix committed rABCdc3ff568b9fd: [avalanche] Increase quorum size in the test. (authored by deadalnix).
[avalanche] Increase quorum size in the test.
deadalnix committed rABCb21d282f5a34: [avalanche] Remove blocks not worth pollling from the vote reccords rather than… (authored by deadalnix).
[avalanche] Remove blocks not worth pollling from the vote reccords rather than…
teamcity closed T965: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o CLI is broken. as Resolved.
Fabien committed rABCb25c0bf30ae0: [CI] Install the latest wine version from the winehq repository (authored by Fabien).
[CI] Install the latest wine version from the winehq repository
deadalnix requested changes to D6626: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt.
teamcity closed T961: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
teamcity closed T964: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o ZMQ is broken. as Resolved.
teamcity triaged T965: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o CLI is broken. as Unbreak Now! priority.
teamcity triaged T964: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o ZMQ is broken. as Unbreak Now! priority.
teamcity triaged T963: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
teamcity triaged T962: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
teamcity triaged T961: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Unbreak Now! priority.
deadalnix committed rABC6f74431345ff: Merge #18563: test: Fix unregister_all_during_call cleanup (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #18563: test: Fix unregister_all_during_call cleanup
teamcity triaged T960: Build Bitcoin-ABC / Master / Bitcoin-ABC Master UBSAN is broken. as Unbreak Now! priority.
deadalnix committed rABC1064bda6981c: Merge #18551: Do not clear validationinterface entries being executed (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #18551: Do not clear validationinterface entries being executed
deadalnix committed rABC27fc0488693b: Merge #18524: refactor: drop boost::signals2 in validationinterface (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #18524: refactor: drop boost::signals2 in validationinterface
deadalnix added a comment to D6654: Merge #18551: Do not clear validationinterface entries being executed.
It would have been wiser to merge both.
The title/description do not match what is actually backported.
Jun 19 2020
Jun 19 2020
abc-bot committed rABC04394f92dce5: Merge #16688: log: Add validation interface logging (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #16688: log: Add validation interface logging
jasonbcox updated the diff for D6653: Merge #18524: refactor: drop boost::signals2 in validationinterface.
Fixed braces
Talked offline, the change that requires a lot of other backports is the removal of the error code from the message.
Since the message change is not related with the intent of this PR, let's move forward.
made addToBlock require exclusive lock on ::g_mempool and extended lock to callsite
In D6652#162338, @Fabien wrote:I don't see what is preventing the change to FormatStateMessage to be part of the backport ? AFAIK the massive stack you mention is a class rename but all the changes from the PR can be done now without conflict.
Prevent 301
Teamcity is a useful software to managing the build and continuous integration some particular ways. You will give your experience paperfellows.com review to allow disabling and change the default setting of Team City.
Fabien added a comment to D6654: Merge #18551: Do not clear validationinterface entries being executed.
Build failures are fixed in D6655
I don't see what is preventing the change to FormatStateMessage to be part of the backport ? AFAIK the massive stack you mention is a class rename but all the changes from the PR can be done now without conflict.
teamcity added a comment to D6654: Merge #18551: Do not clear validationinterface entries being executed.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
teamcity triaged T959: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Cross Build Windows 64-bit is broken. as Unbreak Now! priority.
teamcity added a comment to D6654: Merge #18551: Do not clear validationinterface entries being executed.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity updated the summary of D6654: Merge #18551: Do not clear validationinterface entries being executed.
teamcity added a comment to D6654: Merge #18551: Do not clear validationinterface entries being executed.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
jasonbcox requested review of D6654: Merge #18551: Do not clear validationinterface entries being executed.
teamcity added a comment to D6653: Merge #18524: refactor: drop boost::signals2 in validationinterface.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity updated the summary of D6653: Merge #18524: refactor: drop boost::signals2 in validationinterface.
jasonbcox requested review of D6653: Merge #18524: refactor: drop boost::signals2 in validationinterface.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity triaged T958: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Cross Build Linux ARM is broken. as Unbreak Now! priority.
nakihito committed rABC094184ba4325: Merge #15999: init: Remove dead code in LoadChainTip (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15999: init: Remove dead code in LoadChainTip
teamcity triaged T957: Build Bitcoin-ABC / Master / Bitcoin-ABC Master ASAN is broken. as Unbreak Now! priority.
teamcity closed T955: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o CLI is broken. as Resolved.
teamcity triaged T956: Build Bitcoin-ABC / Master / Bitcoin-ABC Master UBSAN is broken. as Unbreak Now! priority.
majcosta updated the diff for D6651: [backport#14818] Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions.
fixed comment
Jun 18 2020
Jun 18 2020
teamcity triaged T955: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o CLI is broken. as Unbreak Now! priority.
teamcity added a comment to D6651: [backport#14818] Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
abc-bot committed rABC28038bfc3092: [backport#15559] doc: correct analysepsbt rpc doc (authored by fanquake <fanquake@gmail.com>).
[backport#15559] doc: correct analysepsbt rpc doc
teamcity triaged T954: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Cross Build Linux ARM is broken. as Unbreak Now! priority.
abc-bot committed rABCb49716c1263f: Merge #18338: Fix wallet unload race condition (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #18338: Fix wallet unload race condition
deadalnix requested changes to D6649: [backport#16542 4/4] Additional tests for other failure cases.
dito
deadalnix requested changes to D6648: [backport#16542 3/4] Check error messages in descriptor tests.
Investigate failure.