Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Jul 14 2021

bytesofman requested review of D9785: [Cashtab] prevent translation of user mnemonics.

Jul 14 2021, 13:07

teamcity updated the summary of D9784: Remove mempool global from interfaces.

Jul 14 2021, 08:32

PiRK requested review of D9784: Remove mempool global from interfaces.

Jul 14 2021, 08:32

teamcity updated the summary of D9783: rpc: Avoid useless mempool query in gettxoutproof.

Jul 14 2021, 07:55

PiRK requested review of D9783: rpc: Avoid useless mempool query in gettxoutproof.

Jul 14 2021, 07:55

• cannonxprinter updated • cannonxprinter.

Jul 14 2021, 06:54

• cannonxprinter updated • cannonxprinter.

Jul 14 2021, 06:53

Jul 13 2021

bytesofman requested review of D9782: [cashtab-components] rebrand support.

Jul 13 2021, 22:53

majcosta updated the test plan for D9781: [avalanche] create an avalanche log category and use it.

Jul 13 2021, 22:07

majcosta requested review of D9781: [avalanche] create an avalanche log category and use it.

Jul 13 2021, 21:22

teamcity closed T1671: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.

Jul 13 2021, 20:51

teamcity updated the summary of D9780: Pass mempool reference to chainstate constructor.

Jul 13 2021, 20:44

PiRK requested review of D9780: Pass mempool reference to chainstate constructor.

Jul 13 2021, 20:44

Joey King <joseph.roy.king@gmail.com> closed D9748: [Cashtab] icon improvements for PWA.

Jul 13 2021, 20:27

Joey King <joseph.roy.king@gmail.com> committed rABCd1507cac27aa: [Cashtab] icon improvements for PWA (authored by Joey King <joseph.roy.king@gmail.com>).

[Cashtab] icon improvements for PWA

Jul 13 2021, 20:27

majcosta accepted D9779: [avalanche] Improve the delegateavalancheproof error messages.

Jul 13 2021, 15:42

teamcity triaged T1671: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.

Jul 13 2021, 15:14

Fabien requested review of D9779: [avalanche] Improve the delegateavalancheproof error messages.

Jul 13 2021, 14:54

PiRK closed D9778: [core#19724 9/9][doc] Follow developer notes, add comment about missing default..

Jul 13 2021, 14:48

PiRK committed rABCf4f912e5ca2d: [core#19724 9/9][doc] Follow developer notes, add comment about missing default. (authored by Amiti Uttarwar <amiti@uttarwar.org>).

[core#19724 9/9][doc] Follow developer notes, add comment about missing default.

Jul 13 2021, 14:48

PiRK closed D9777: [core#19724 8/9][doc] Describe connection types in more depth..

Jul 13 2021, 14:47

PiRK committed rABCa508b5b670f4: [core#19724 8/9][doc] Describe connection types in more depth. (authored by Amiti Uttarwar <amiti@uttarwar.org>).

[core#19724 8/9][doc] Describe connection types in more depth.

Jul 13 2021, 14:47

PiRK closed D9776: [core#19724 7/9][refactor] Simplify connection type logic in ThreadOpenConnections.

Jul 13 2021, 14:46

PiRK committed rABC45b19beb72a9: [core#19724 7/9][refactor] Simplify connection type logic in… (authored by Amiti Uttarwar <amiti@uttarwar.org>).

[core#19724 7/9][refactor] Simplify connection type logic in…

Jul 13 2021, 14:46

PiRK closed D9775: [core#19724 6/9][refactor] Simplify check for block-relay-only connection..

Jul 13 2021, 14:44

PiRK committed rABC74e38fe222eb: [core#19724 6/9][refactor] Simplify check for block-relay-only connection. (authored by Amiti Uttarwar <amiti@uttarwar.org>).

[core#19724 6/9][refactor] Simplify check for block-relay-only connection.

Jul 13 2021, 14:44

PiRK closed D9774: [core#19724 5/9][test] Add explicit tests that connection types get set correctly.

Jul 13 2021, 14:43

PiRK committed rABC54e18211fbaf: [core#19724 5/9][test] Add explicit tests that connection types get set… (authored by Amiti Uttarwar <amiti@uttarwar.org>).

[core#19724 5/9][test] Add explicit tests that connection types get set…

Jul 13 2021, 14:43

PiRK closed D9773: [core#19724 4/9][doc] Explain address handling logic in process messages.

Jul 13 2021, 14:42

PiRK committed rABC6166450c9c2b: [core#19724 4/9][doc] Explain address handling logic in process messages (authored by Amiti Uttarwar <amiti@uttarwar.org>).

[core#19724 4/9][doc] Explain address handling logic in process messages

Jul 13 2021, 14:42

PiRK closed D9772: [core#19724 3/9][refactor] Restructure logic to check for addr relay..

Jul 13 2021, 14:28

PiRK committed rABC6ad16ebd6d08: [core#19724 3/9][refactor] Restructure logic to check for addr relay. (authored by Amiti Uttarwar <amiti@uttarwar.org>).

[core#19724 3/9][refactor] Restructure logic to check for addr relay.

Jul 13 2021, 14:28

PiRK closed D9771: [core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection.

Jul 13 2021, 14:24

PiRK committed rABC86e28fbbbf28: [core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection (authored by Amiti Uttarwar <amiti@uttarwar.org>).

[core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection

Jul 13 2021, 14:24

PiRK closed D9770: [core#19724 1/9] scripted-diff: Rename OUTBOUND ConnectionType to OUTBOUND_FULL_RELAY.

Jul 13 2021, 14:23

PiRK committed rABC7ef27e505c10: [core#19724 1/9] scripted-diff: Rename OUTBOUND ConnectionType to… (authored by PiRK).

[core#19724 1/9] scripted-diff: Rename OUTBOUND ConnectionType to…

Jul 13 2021, 14:23

majcosta accepted D9775: [core#19724 6/9][refactor] Simplify check for block-relay-only connection..

Jul 13 2021, 14:17

Fabien accepted D9775: [core#19724 6/9][refactor] Simplify check for block-relay-only connection..

Jul 13 2021, 12:38

Fabien added a comment to D9739: [avalanche] Activate automated peer discovery.

Unrelated spurious failure

Jul 13 2021, 12:35

teamcity closed T1670: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.

Jul 13 2021, 11:10

PiRK closed D9742: [avalanche] register local proof at first tip update.

Jul 13 2021, 10:47

PiRK committed rABCc38a045e1ba0: [avalanche] register local proof at first tip update (authored by PiRK).

[avalanche] register local proof at first tip update

Jul 13 2021, 10:47

PiRK updated the diff for D9775: [core#19724 6/9][refactor] Simplify check for block-relay-only connection..

I wasn't able to reproduce that error locally. Try to re-reun the CI

Jul 13 2021, 10:16

teamcity added a comment to D9739: [avalanche] Activate automated peer discovery.

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Jul 13 2021, 10:06

PiRK abandoned D9686: [avalanche] add a lock to CNode::AvalancheState.

All accesses to that data are done in the same thread (ProcessMessages), except for an RPC call. So the lock is unnecessary. It is very unlikely that a addavalanchenode call happens exactly at the same time as the same node sending the data.

Jul 13 2021, 09:59

Fabien updated the diff for D9739: [avalanche] Activate automated peer discovery.

Rebase, fix nit

Jul 13 2021, 09:58

Fabien updated the diff for D9703: [avalanche] Remember nodes pending a proof and bind them when available.

Address feedback:

Rebase over various refactors
There are now only 4 places with code change (the 4th one being the node removal)
The getNodeCount method is replaced by a friend test structure for better test accuracy

Jul 13 2021, 09:58

Fabien updated the summary of D9703: [avalanche] Remember nodes pending a proof and bind them when available.

Jul 13 2021, 09:42

PiRK planned changes to D9686: [avalanche] add a lock to CNode::AvalancheState.

You are right about the description, sorry about that. It definitely needs to be updated.

Jul 13 2021, 09:29

teamcity triaged T1670: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.

Jul 13 2021, 07:06

Fabien closed D9769: [avalanche] Do not bucket brigade (orphan) proof accessor.

Jul 13 2021, 06:33

Fabien committed rABC4a8cb5dd0cdb: [avalanche] Do not bucket brigade (orphan) proof accessor (authored by Fabien).

[avalanche] Do not bucket brigade (orphan) proof accessor

Jul 13 2021, 06:33

Fabien closed D9768: [avalanche] Do not bucket brigade proof registration.

Jul 13 2021, 06:29

Fabien committed rABC7cb36e0d6975: [avalanche] Do not bucket brigade proof registration (authored by Fabien).

[avalanche] Do not bucket brigade proof registration

Jul 13 2021, 06:29

Fabien accepted D9742: [avalanche] register local proof at first tip update.

Jul 13 2021, 06:07

Jul 12 2021

majcosta accepted D9778: [core#19724 9/9][doc] Follow developer notes, add comment about missing default..

Jul 12 2021, 21:24

majcosta accepted D9777: [core#19724 8/9][doc] Describe connection types in more depth..

Jul 12 2021, 21:24

majcosta accepted D9776: [core#19724 7/9][refactor] Simplify connection type logic in ThreadOpenConnections.

Jul 12 2021, 21:21

majcosta requested changes to D9775: [core#19724 6/9][refactor] Simplify check for block-relay-only connection..

tests broke

Jul 12 2021, 21:19

majcosta accepted D9774: [core#19724 5/9][test] Add explicit tests that connection types get set correctly.

Jul 12 2021, 21:14

deadalnix accepted D9742: [avalanche] register local proof at first tip update.

Jul 12 2021, 20:24

deadalnix requested changes to D9686: [avalanche] add a lock to CNode::AvalancheState.

Jul 12 2021, 20:22

deadalnix added a comment to D9686: [avalanche] add a lock to CNode::AvalancheState.

The description fo this patch makes no sense. We aren't using the scheduler to read delegations. I do not know why this lock is needed. It seems to me that creating the avalanche state once the delegation has been verified should be enough.

Jul 12 2021, 20:22

majcosta accepted D9773: [core#19724 4/9][doc] Explain address handling logic in process messages.

Jul 12 2021, 19:14

PiRK updated the diff for D9772: [core#19724 3/9][refactor] Restructure logic to check for addr relay..

remove accidental blank line:

Jul 12 2021, 18:39

majcosta accepted D9772: [core#19724 3/9][refactor] Restructure logic to check for addr relay..

Jul 12 2021, 18:17

majcosta accepted D9771: [core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection.

Jul 12 2021, 17:52

majcosta accepted D9770: [core#19724 1/9] scripted-diff: Rename OUTBOUND ConnectionType to OUTBOUND_FULL_RELAY.

Jul 12 2021, 17:41

majcosta accepted D9768: [avalanche] Do not bucket brigade proof registration.

Jul 12 2021, 17:29

PiRK accepted D9768: [avalanche] Do not bucket brigade proof registration.

Jul 12 2021, 17:25

teamcity added a comment to D9775: [core#19724 6/9][refactor] Simplify check for block-relay-only connection..

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Jul 12 2021, 16:25

teamcity updated the summary of D9778: [core#19724 9/9][doc] Follow developer notes, add comment about missing default..

Jul 12 2021, 16:13

PiRK accepted D9769: [avalanche] Do not bucket brigade (orphan) proof accessor.

Jul 12 2021, 16:13

PiRK requested review of D9778: [core#19724 9/9][doc] Follow developer notes, add comment about missing default..

Jul 12 2021, 16:12

teamcity updated the summary of D9777: [core#19724 8/9][doc] Describe connection types in more depth..

Jul 12 2021, 16:05

PiRK requested review of D9777: [core#19724 8/9][doc] Describe connection types in more depth..

Jul 12 2021, 16:04

teamcity updated the summary of D9776: [core#19724 7/9][refactor] Simplify connection type logic in ThreadOpenConnections.

Jul 12 2021, 16:02

PiRK requested review of D9776: [core#19724 7/9][refactor] Simplify connection type logic in ThreadOpenConnections.

Jul 12 2021, 16:02

teamcity updated the summary of D9775: [core#19724 6/9][refactor] Simplify check for block-relay-only connection..

Jul 12 2021, 16:01

PiRK requested review of D9775: [core#19724 6/9][refactor] Simplify check for block-relay-only connection..

Jul 12 2021, 16:01

teamcity updated the summary of D9774: [core#19724 5/9][test] Add explicit tests that connection types get set correctly.

Jul 12 2021, 15:59

PiRK requested review of D9774: [core#19724 5/9][test] Add explicit tests that connection types get set correctly.

Jul 12 2021, 15:59

PiRK updated the summary of D9773: [core#19724 4/9][doc] Explain address handling logic in process messages.

Jul 12 2021, 15:58

teamcity updated the summary of D9773: [core#19724 4/9][doc] Explain address handling logic in process messages.

Jul 12 2021, 15:58

PiRK requested review of D9773: [core#19724 4/9][doc] Explain address handling logic in process messages.

Jul 12 2021, 15:57

teamcity updated the summary of D9772: [core#19724 3/9][refactor] Restructure logic to check for addr relay..

Jul 12 2021, 15:55

PiRK requested review of D9772: [core#19724 3/9][refactor] Restructure logic to check for addr relay..

Jul 12 2021, 15:55

PiRK updated the summary of D9771: [core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection.

Jul 12 2021, 15:54

teamcity updated the summary of D9771: [core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection.

Jul 12 2021, 15:53

PiRK requested review of D9771: [core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection.

Jul 12 2021, 15:53

teamcity updated the summary of D9770: [core#19724 1/9] scripted-diff: Rename OUTBOUND ConnectionType to OUTBOUND_FULL_RELAY.

Jul 12 2021, 15:51

PiRK requested review of D9770: [core#19724 1/9] scripted-diff: Rename OUTBOUND ConnectionType to OUTBOUND_FULL_RELAY.

Jul 12 2021, 15:51

Fabien requested review of D9769: [avalanche] Do not bucket brigade (orphan) proof accessor.

Jul 12 2021, 14:48

Fabien requested review of D9768: [avalanche] Do not bucket brigade proof registration.

Jul 12 2021, 14:11

Fabien closed D9767: [avalanche] Move the proof accessor tests to the peer manager tests.

Jul 12 2021, 14:06

Fabien committed rABC665d9bc0639a: [avalanche] Move the proof accessor tests to the peer manager tests (authored by Fabien).

[avalanche] Move the proof accessor tests to the peer manager tests

Jul 12 2021, 14:06

Fabien closed D9766: [avalanche] Remove the unused processor addNode() method.

Jul 12 2021, 14:03

Fabien committed rABC61da28443dcb: [avalanche] Remove the unused processor addNode() method (authored by Fabien).

[avalanche] Remove the unused processor addNode() method

Jul 12 2021, 14:03

Fabien closed D9765: [LINTER] Work around a cppcheck false positive.

Jul 12 2021, 14:01

Fabien committed rABC5825de5b0cc5: [LINTER] Work around a cppcheck false positive (authored by Fabien).

[LINTER] Work around a cppcheck false positive

Jul 12 2021, 14:01