Page MenuHomePhabricator
Feed All Stories

Nov 3 2023

Fabien committed rABCd38b7d6f241d: Bump version to 0.28.3 (authored by Fabien).
Bump version to 0.28.3
Nov 3 2023, 11:00
teamcity awarded D14731: refactor: replace RecursiveMutex m_cs_callbacks_pending with Mutex (and rename) a Haypence token.
Nov 3 2023, 09:22
PiRK added a comment to D14731: refactor: replace RecursiveMutex m_cs_callbacks_pending with Mutex (and rename).

@bot build-tsan

Nov 3 2023, 09:22
PiRK published D14731: refactor: replace RecursiveMutex m_cs_callbacks_pending with Mutex (and rename) for review.
Nov 3 2023, 09:21
PiRK published D14730: wallet: Avoid locking cs_wallet recursively for review.
Nov 3 2023, 09:20
teamcity awarded D14730: wallet: Avoid locking cs_wallet recursively a Piece of Eight token.
Nov 3 2023, 09:03
teamcity awarded D14730: wallet: Avoid locking cs_wallet recursively a Haypence token.
Nov 3 2023, 08:07
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

Updated processChronikWsMsg() to refresh pricing every 90 blocks rather than every block

Nov 3 2023, 07:19
emack updated the diff for D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.

Updated UI as follows

Nov 3 2023, 00:11

Nov 2 2023

bytesofman added a comment to D14729: [electrum] clear the wallet password from memory when no longer needed.

are these proof editor improvements driven by user stories?

Nov 2 2023, 22:33
bytesofman added a comment to D14726: [electrum] detect the master private key when loading a proof.

Is this diff in response to user complaints? what's the root cause of wanting to add this functionality?

Nov 2 2023, 22:25
emack closed D14719: [Cashtab] Seed warning confirmation check.
Nov 2 2023, 22:04
emack committed rABC7d6047f1d2a8: [Cashtab] Seed warning confirmation check (authored by emack).
[Cashtab] Seed warning confirmation check
Nov 2 2023, 22:04
emack requested review of D14713: [Cashtab][Alias] Check Alias function.

You should do an API call on each block and store the value locally, obviously a lookup for each keystroke is the wrong design.

this is a good idea but imo should be it's own diff. not necessarily related to just this UI change, easy enough to add into this UI -- but does require some new logic.

Nov 2 2023, 21:59
PiRK added inline comments to D14726: [electrum] detect the master private key when loading a proof.
Nov 2 2023, 21:54
PiRK requested review of D14726: [electrum] detect the master private key when loading a proof.
Nov 2 2023, 21:51
bytesofman requested changes to D14728: [Cashtab][Alias] Sync pricing on new blocks.
Nov 2 2023, 19:30
bytesofman requested changes to D14726: [electrum] detect the master private key when loading a proof.

see inline comments. potentially i'm just misunderstanding a normal pything / electrum thing. if so, please let me know what's going on 🙏

Nov 2 2023, 19:21
bytesofman accepted D14713: [Cashtab][Alias] Check Alias function.

nice, buttons look way better now

Nov 2 2023, 19:06
bytesofman accepted D14722: [e.cash] Use camelCase for constant.
Nov 2 2023, 19:02
bytesofman accepted D14719: [Cashtab] Seed warning confirmation check.
Nov 2 2023, 16:48
johnkuney updated the diff for D14707: [e.cash] Filter out low exchange scores.

add more robust unit test

Nov 2 2023, 16:32
PiRK accepted D14727: Bump version to 0.28.3.
Nov 2 2023, 15:20
PiRK updated the summary of D14729: [electrum] clear the wallet password from memory when no longer needed.
Nov 2 2023, 14:48
PiRK requested review of D14729: [electrum] clear the wallet password from memory when no longer needed.
Nov 2 2023, 14:43
emack updated the test plan for D14728: [Cashtab][Alias] Sync pricing on new blocks.
Nov 2 2023, 14:31
emack requested review of D14728: [Cashtab][Alias] Sync pricing on new blocks.
Nov 2 2023, 14:31
Fabien requested review of D14727: Bump version to 0.28.3.
Nov 2 2023, 13:59
bytesofman closed D14724: [ecash-herald] CashFusion with no space.
Nov 2 2023, 13:57
bytesofman committed rABC231a0b79f129: [ecash-herald] CashFusion with no space (authored by bytesofman).
[ecash-herald] CashFusion with no space
Nov 2 2023, 13:57
bytesofman closed D14723: [ecash-herald] Fix legacy chronik client mock import.
Nov 2 2023, 13:57
bytesofman committed rABC342d855f948a: [ecash-herald] Fix legacy chronik client mock import (authored by bytesofman).
[ecash-herald] Fix legacy chronik client mock import
Nov 2 2023, 13:57
bytesofman closed D14577: [Cashtab] Remove encrypted msg sending.
Nov 2 2023, 13:38
bytesofman committed rABC1c6a6e804070: [Cashtab] Remove encrypted msg sending (authored by bytesofman).
[Cashtab] Remove encrypted msg sending
Nov 2 2023, 13:38
Fabien accepted D14577: [Cashtab] Remove encrypted msg sending.
Nov 2 2023, 13:37
bytesofman retitled D14577: [Cashtab] Remove encrypted msg sending from [Cashtab] Deprecate encrypted msg sending to [Cashtab] Remove encrypted msg sending.
Nov 2 2023, 13:36
PiRK added inline comments to D14726: [electrum] detect the master private key when loading a proof.
Nov 2 2023, 11:50
Fabien accepted D14723: [ecash-herald] Fix legacy chronik client mock import.
Nov 2 2023, 11:21
Fabien requested changes to D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.

In the case there are pending alias you should not have the green "everything is fine" register confirmation text, but rather something purple like "Continue the registration anyway ?"

Nov 2 2023, 11:20
Fabien requested changes to D14707: [e.cash] Filter out low exchange scores.

The unit test needs to give confidence the code is working, not only testing the happy path (as per telegram discussion)

Nov 2 2023, 11:16
Fabien added a comment to D14713: [Cashtab][Alias] Check Alias function.

I don't see the registration fee in the snapshots ? Otherwise the last one LGTM

Nov 2 2023, 11:08
Fabien requested changes to D14713: [Cashtab][Alias] Check Alias function.

Re-arranged UI per feedback, updated label for active wallet registration checkbox.

The register button could show the registration fee, like "Register alias for 556 XEC".

This was a design decision to not show the price here because it would be an API call per keystroke to get the price for current length. Even though the price is not expected to change frequently we felt it was better to have a single source of truth on the server side, which is called only once at the registration confirmation dialogue. Alternatively I can keep a copy of the pricing array in Cashtab so it can achieve pricing reads on the fly without calling the API but I'll need to manually keep it in sync with any pricing changes on the server.

Nov 2 2023, 11:08
PiRK updated the summary of D14724: [ecash-herald] CashFusion with no space.
Nov 2 2023, 11:04
PiRK accepted D14724: [ecash-herald] CashFusion with no space.

code OK, i fixed the summary

Nov 2 2023, 11:04
teamcity added a comment to D14694: [e.cash] Remove mention of bits for the denomination.
Nov 2 2023, 10:00
teamcity awarded D14694: [e.cash] Remove mention of bits for the denomination a Doubloon token.
Nov 2 2023, 09:51
PiRK added a comment to D14694: [e.cash] Remove mention of bits for the denomination.

@bot build-win64

Nov 2 2023, 09:51
PiRK requested review of D14726: [electrum] detect the master private key when loading a proof.
Nov 2 2023, 09:38
teamcity added a comment to D14694: [e.cash] Remove mention of bits for the denomination.
Nov 2 2023, 07:59
PiRK added a comment to D14694: [e.cash] Remove mention of bits for the denomination.

This was the last diff for which the windows crossbuild succeeded, so I'm running it to check if it still works at this commit, or if the failure is not related to a change in code (change in CI hardware?)

Nov 2 2023, 07:47
teamcity awarded D14694: [e.cash] Remove mention of bits for the denomination a Piece of Eight token.
Nov 2 2023, 07:46
PiRK added a comment to D14694: [e.cash] Remove mention of bits for the denomination.

@bot build-win64

Nov 2 2023, 07:46
emack updated the test plan for D14719: [Cashtab] Seed warning confirmation check.
Nov 2 2023, 03:57
emack updated the diff for D14719: [Cashtab] Seed warning confirmation check.

Updated checkbox logic to toggle between showing and hiding the seed phrase in addition to the updated static warning message.

Nov 2 2023, 03:56
emack updated the diff for D14713: [Cashtab][Alias] Check Alias function.

Updated UI per feedback.

Nov 2 2023, 03:13
emack updated the summary of D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.
Nov 2 2023, 02:02
emack requested review of D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.
Nov 2 2023, 02:01
bytesofman added a comment to D14724: [ecash-herald] CashFusion with no space.

image.png (95×567 px, 17 KB)

Nov 2 2023, 01:04
bytesofman requested review of D14724: [ecash-herald] CashFusion with no space.
Nov 2 2023, 01:03
bytesofman requested review of D14723: [ecash-herald] Fix legacy chronik client mock import.
Nov 2 2023, 01:02

Nov 1 2023

Mengerian added inline comments to D14722: [e.cash] Use camelCase for constant.
Nov 1 2023, 23:52
teamcity closed T3330: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 32 is broken. as Resolved.
Nov 1 2023, 23:21
emack closed D14611: [Cashtab][Alias] Pending Aliases.
Nov 1 2023, 22:49
emack committed rABC8e4b8d528fd7: [Cashtab][Alias] Pending Aliases (authored by emack).
[Cashtab][Alias] Pending Aliases
Nov 1 2023, 22:49
bytesofman requested changes to D14722: [e.cash] Use camelCase for constant.
Nov 1 2023, 22:16
Mengerian requested review of D14722: [e.cash] Use camelCase for constant.
Nov 1 2023, 20:52
Mengerian closed D14721: [e.cash] Use constant for latest version on upgrade page.
Nov 1 2023, 20:49
Mengerian committed rABC2d7735456310: [e.cash] Use constant for latest version on upgrade page (authored by Mengerian).
[e.cash] Use constant for latest version on upgrade page
Nov 1 2023, 20:49
johnkuney accepted D14721: [e.cash] Use constant for latest version on upgrade page.
Nov 1 2023, 20:46
bytesofman accepted D14721: [e.cash] Use constant for latest version on upgrade page.
Nov 1 2023, 18:36
teamcity added a comment to D14721: [e.cash] Use constant for latest version on upgrade page.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41659 for the next 60 minutes.

Nov 1 2023, 18:19
teamcity awarded D14721: [e.cash] Use constant for latest version on upgrade page a Haypence token.
Nov 1 2023, 18:17
bytesofman added a comment to D14721: [e.cash] Use constant for latest version on upgrade page.

@bot preview-e.cash

Nov 1 2023, 18:17
bytesofman added a comment to D14708: [Cashtab][Swap] Add swap component with SideShift integration.

I raised with the SideShift team yesterday via tg and they fixed it along with the cancel order bug.

Nov 1 2023, 18:01
bytesofman requested changes to D14713: [Cashtab][Alias] Check Alias function.
  • add some space between the alias length and the check button
  • the check and register buttons should not look identical. maybe include a magnifying glass ("search") icon on the check button, and a dollar sign or some other appropriate icon on the register button. Also different colors.
Nov 1 2023, 17:57
teamcity triaged T3330: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 32 is broken. as Unbreak Now! priority.
Nov 1 2023, 17:34
bytesofman accepted D14611: [Cashtab][Alias] Pending Aliases.

actually -- seeing how these are implemented, I don't think my previous feedback needs to be handled in this diff. Should have separate diffs to get better modal appearance.

Nov 1 2023, 17:31
bytesofman requested changes to D14611: [Cashtab][Alias] Pending Aliases.

let's make the fact that there are pending aliases here a little scarier

Nov 1 2023, 17:29
PiRK closed D14712: net_processing: move CNode data access out of lock.
Nov 1 2023, 16:54
PiRK committed rABCa47ba0f32e18: net_processing: move CNode data access out of lock (authored by John Newbery <john@johnnewbery.com>).
net_processing: move CNode data access out of lock
Nov 1 2023, 16:54
PiRK closed D14711: scripted-diff: rename TxRelay & TxProof members.
Nov 1 2023, 16:54
PiRK closed D14710: [net processing] Move tx & proof relay data to Peer.
Nov 1 2023, 16:54
PiRK committed rABCa3fde16a0c14: [net processing] Move tx & proof relay data to Peer (authored by John Newbery <john@johnnewbery.com>).
[net processing] Move tx & proof relay data to Peer
Nov 1 2023, 16:54
PiRK committed rABC5143480f5ec8: scripted-diff: rename TxRelay & TxProof members (authored by PiRK).
scripted-diff: rename TxRelay & TxProof members
Nov 1 2023, 16:54
PiRK closed D14709: [net] Add CNode.m_relays_txs and CNode.m_bloom_filter_loaded.
Nov 1 2023, 16:54
PiRK committed rABCccb6beeb0367: [net] Add CNode.m_relays_txs and CNode.m_bloom_filter_loaded (authored by John Newbery <john@johnnewbery.com>).
[net] Add CNode.m_relays_txs and CNode.m_bloom_filter_loaded
Nov 1 2023, 16:54
PiRK closed D14715: tests: add feature_bind_port_*.py to EXTRA_PRIVILEGES_TESTS.
Nov 1 2023, 16:54
PiRK committed rABC480c16cf2ec7: tests: add feature_bind_port_*.py to EXTRA_PRIVILEGES_TESTS (authored by PiRK).
tests: add feature_bind_port_*.py to EXTRA_PRIVILEGES_TESTS
Nov 1 2023, 16:54
Mengerian updated the diff for D14721: [e.cash] Use constant for latest version on upgrade page.

Use camel case
Add space

Nov 1 2023, 16:51
johnkuney requested changes to D14721: [e.cash] Use constant for latest version on upgrade page.
Nov 1 2023, 16:31
Mengerian requested review of D14721: [e.cash] Use constant for latest version on upgrade page.
Nov 1 2023, 16:20
Mengerian closed D14720: [e.cash] Bump version to 0.28.2 on upgrade page.
Nov 1 2023, 15:57
Mengerian committed rABCaf056c1e9a7d: [e.cash] Bump version to 0.28.2 on upgrade page (authored by Mengerian).
[e.cash] Bump version to 0.28.2 on upgrade page
Nov 1 2023, 15:57
johnkuney accepted D14720: [e.cash] Bump version to 0.28.2 on upgrade page.

For next time could move the version number to a variable so you only have to change it in one place

Nov 1 2023, 15:22
teamcity added a comment to D14720: [e.cash] Bump version to 0.28.2 on upgrade page.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Nov 1 2023, 15:18
teamcity added a comment to D14720: [e.cash] Bump version to 0.28.2 on upgrade page.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Nov 1 2023, 15:16
teamcity awarded D14720: [e.cash] Bump version to 0.28.2 on upgrade page a Haypence token.
Nov 1 2023, 15:15
johnkuney added a comment to D14720: [e.cash] Bump version to 0.28.2 on upgrade page.

@bot preview e.cash

Nov 1 2023, 15:15
Mengerian requested review of D14720: [e.cash] Bump version to 0.28.2 on upgrade page.
Nov 1 2023, 14:46
bytesofman requested changes to D14719: [Cashtab] Seed warning confirmation check.

We should still show the warning when the seed phrase is displayed.

Nov 1 2023, 12:54