remove echo statements, remove comments describing build steps of deps, add ordering matters comments on first depends key

A sum of nits but this looks good otherwise

• Do not npm ci && npm run build if node_modules and dist dirs exist for any given lib

looks like a timeout failure, which we seem to seen somewhat often when we ask the bot to do a bunch of builds at once. imo unrelated to this diff.

In D17402#396020, @emack wrote:

Also the first toggle's functionality being different to the bottom 2 should be more obvious, like using Tabs for Buy/Manage and toggles for sorting. Or simply a dropdown for sorting so you don't end up with 5 toggles for 5 sorting options.

first diff was to handle BCHA decimals going from 8 to 2: D9280

Also the first toggle's functionality being different to the bottom 2 should be more obvious, like using Tabs for Buy/Manage and toggles for sorting. Or simply a dropdown for sorting so you don't end up with 5 toggles for 5 sorting options.

add detailed spec, use consume to parse empp push

@bot b58-ts-tests

In D17398#395986, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (b58-ts-tests) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #N/A, branch 'refs/tags/phabricator/diff/51800'
Triggered 2024-12-28 22:26:38 by 'Phabricator Staging (phabricator-staging)'
Started 2024-12-28 22:26:46 on agent 'N/A'
Finished 2024-12-28 22:26:46 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): '5a42bd49eab8e8cfcc42f3a751c1dc0c4052edd4' (branch: 'refs/tags/phabricator/diff/51800', checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/876336 
TeamCity server version is 2024.12 (build 174331), server timezone: GMT (UTC)

[22:26:38]W: bt15 (7s)
[22:26:38]i: TeamCity server version is 2024.12 (build 174331)
[22:26:38] : Finalize build settings
[22:26:38] : Collecting changes in 2 VCS roots
[22:26:38] :	 [Collecting changes in 2 VCS roots] VCS Root details
[22:26:38] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[22:26:38] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[22:26:38]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (7s)
[22:26:38]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure' (7s)
[22:26:38]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper1165154239972118338.sh ls-remote origin
[22:26:38]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper1616784882368232137.sh ls-remote origin
[22:26:38]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': kex_exchange_identification: Connection closed by remote host
[22:26:38]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Connection closed by 51.161.87.173 port 2221
[22:26:38]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': fatal: Could not read from remote repository.
[22:26:38]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': 
[22:26:38]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Please make sure you have the correct access rights
[22:26:38]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': and the repository exists.
[22:26:38]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[22:26:39]i: Waiting for completion of current operations for the VCS root 'Bitcoin ABC Staging'
[22:26:46]i: Detecting changes in VCS root 'Bitcoin ABC Staging' (used in 'Diff Testing', 'Staging Checkout Dummy')
[22:26:46]i: Will collect changes for 'Bitcoin ABC Staging' starting from revision ee625b89b9cabf2aa0a6fa91879da9ba018c8509
[22:26:46] : Compute revision for 'Bitcoin ABC Staging'
[22:26:46] :	 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: 5a42bd49eab8e8cfcc42f3a751c1dc0c4052edd4
[22:26:46]i:	 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 77033
[22:26:46] :	 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: 5a42bd49eab8e8cfcc42f3a751c1dc0c4052edd4
[22:26:46]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start

while this approach does now support dependencies of dependencies, I do not think we want to update the "depends" just yet in the JS app test plans. imo easier to review if we do that one test plan at a time. We might also want to modify the script(s) a bit so that they do not npm ci and npm run build if this has already been done; for example some JS apps depend on ecashaddrjs, mock-chronik-client, and ecash-lib .... well, ecash-lib depends on ecashaddrjs, so we don't want to build it twice.

@bot ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests

lint

use more flexible approach that allows dependencies to have dependencies

In D17402#395972, @Fabien wrote:

Do you know where you want to go with this change ? I mean the end filters.

Do you know where you want to go with this change ? I mean the end filters.

we need more stablecoins. cashtab already supports token features

cashtab should not do this. really the contact list is too much already.

no

too much for cashtab. i don't think cashtab should be as "permanent" as poweruser wallet like electrum.

@bot ecash-lib-integration-tests

In D17398#395903, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Tail of the build log:

File                        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s            
----------------------------|---------|----------|---------|---------|------------------------------
All files                   |   28.33 |     26.4 |   28.35 |   44.85 |                              
 ecash-lib                  |       0 |        0 |       0 |       0 |                              
  eslint.config.js          |       0 |        0 |       0 |       0 |                              
 ecash-lib/dist/ffi         |       0 |        0 |       0 |       0 |                              
  ecash_lib_wasm_browser.js |       0 |        0 |       0 |       0 | 3-336                        
  ecash_lib_wasm_nodejs.js  |       0 |        0 |       0 |       0 | 1-264                        
 ecash-lib/src              |   35.84 |     28.6 |   39.24 |   68.05 |                              
  consts.ts                 |       0 |      100 |     100 |       0 | 6-8                          
  ecc.ts                    |   30.76 |    83.33 |   22.22 |   57.14 | 23-31                        
  hash.ts                   |   47.05 |    83.33 |   44.44 |   88.88 | 14                           
  index.ts                  |       0 |        0 |       0 |       0 |                              
  indexBrowser.ts           |       0 |        0 |       0 |       0 |                              
  indexNodeJs.ts            |       0 |        0 |       0 |       0 |                              
  initBrowser.ts            |       0 |      100 |       0 |       0 | 11-13                        
  initNodeJs.ts             |   53.84 |      100 |   66.66 |   85.71 | 12                           
  op.ts                     |   20.13 |    23.33 |   36.36 |   39.47 | ...4,107,109,117-122,133-161 
  opcode.ts                 |    50.2 |    83.33 |     100 |     100 | 1                            
  script.ts                 |   28.97 |    20.58 |   31.03 |   51.78 | ...1-122,133,143,153,175-186 
  sigHashType.ts            |      40 |       25 |   46.15 |   78.94 | 26-38                        
  tx.ts                     |   47.25 |    45.23 |   47.61 |   87.23 | 110,114,123-125,144          
  txBuilder.ts              |   40.64 |    32.69 |   54.54 |   80.21 | ...1,154,173-178,183,253-257 
  unsignedTx.ts             |   25.27 |       16 |   30.76 |   46.15 | ...9,312,320,326-329,345,357 
 ecash-lib/src/address      |   11.35 |    15.15 |    5.12 |   22.41 |                              
  address.ts                |   10.95 |    11.36 |    3.22 |   21.05 | ...3,239-240,255-256,266-344 
  legacyaddr.ts             |   12.04 |    22.72 |    12.5 |      25 | 15-19,23-38,70-111,124-128   
 ecash-lib/src/ffi          |   28.26 |    15.94 |   16.98 |   28.98 |                              
  ecash_lib_wasm_browser.js |       0 |        0 |       0 |       0 | 3-336                        
  ecash_lib_wasm_nodejs.js  |    61.9 |       55 |   39.13 |   62.75 | ...1,197-215,237,250-251,255 
 ecash-lib/src/io           |   30.45 |       41 |    38.7 |   58.77 |                              
  bytes.ts                  |    3.77 |     62.5 |    6.66 |     7.4 | 13-64                        
  hex.ts                    |   41.55 |       50 |   44.44 |   82.35 | 41-45,50,58                  
  int.ts                    |       0 |        0 |       0 |       0 |                              
  str.ts                    |   46.15 |    83.33 |      40 |   85.71 | 15                           
  varsize.ts                |   16.32 |    21.05 |      40 |      32 | 14-24,40-47                  
  writer.ts                 |       0 |        0 |       0 |       0 |                              
  writerbytes.ts            |   42.37 |    40.62 |   53.33 |   83.33 | 33,43,53,63,79               
  writerlength.ts           |   53.33 |    83.33 |   53.84 |     100 | 1                            
 ecash-lib/src/test         |   44.93 |    36.23 |   47.05 |   86.84 |                              
  testRunner.ts             |   44.93 |    36.23 |   47.05 |   86.84 | 73-75,87-89,112,123,166,203  
 ecash-lib/src/token        |   31.48 |    28.44 |   28.57 |   60.11 |                              
  alp.ts                    |    42.5 |    53.12 |   43.47 |   82.92 | 110-123,142                  
  common.ts                 |   54.54 |    83.33 |     100 |     100 | 1                            
  empp.ts                   |   52.17 |       60 |   57.14 |   91.66 | 12                           
  slp.ts                    |   14.76 |     7.35 |       4 |    28.2 | ...7,174-178,185-197,201-211 
----------------------------|---------|----------|---------|---------|------------------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='796']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='2809']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='239']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='905']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='129']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='455']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='776']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='1730']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/ecash-lib-integration-tests-junit.xml': No such file or directory
Build ecash-lib-integration-tests failed with exit code 1

@bot ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests

@bot ecash-agora-tests

chronik-client is a dev dep of ecash-lib, add for ecash-agora-tests

@bot ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests

rebase (removing alias-server-tests)

move doc, add return type, remove obsolete types from the doc

@bot ecash-agora-integration-tests

@bot alias-server-tests ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests

lint

correct order of ecash-lib and chronik-client since ecash-lib takes chronik-client as a dev dependency, make sure deps are built for js-mocha-integration-tests builds

CI says it's not working

You should move the doc as well