Page MenuHomePhabricator
Feed All Stories

Jan 2 2025

Fabien updated the summary of D17451: [cashtab] Always show 2 decimals for amounts < 1k XEC.
Jan 2 2025, 13:49
Fabien updated the diff for D17451: [cashtab] Always show 2 decimals for amounts < 1k XEC.

Don't change the mock, but reuse the existing ones to add a test case.
Bump the version

Jan 2 2025, 13:48
Fabien updated the diff for D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.

Rebase

Jan 2 2025, 13:46
Fabien updated the diff for D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.

Bump version

Jan 2 2025, 13:29
bytesofman published D17448: [Cashtab] Implement exhaustive parsing of tx notifications for review.

image.png (366×682 px, 508 KB)

Jan 2 2025, 13:24
Fabien closed D17452: [cashtab] Fix misplaced comments.
Jan 2 2025, 13:23
Fabien committed rABC2018e84576e4: [cashtab] Fix misplaced comments (authored by Fabien).
[cashtab] Fix misplaced comments
Jan 2 2025, 13:23
bytesofman accepted D17452: [cashtab] Fix misplaced comments.
Jan 2 2025, 13:22
bytesofman requested changes to D17451: [cashtab] Always show 2 decimals for amounts < 1k XEC.

I think the change is good but should implement by adding a new mock tx and test instead of changing the values of an existing mock.

Jan 2 2025, 13:22
Fabien requested review of D17452: [cashtab] Fix misplaced comments.
Jan 2 2025, 12:15
Fabien requested review of D17451: [cashtab] Always show 2 decimals for amounts < 1k XEC.
Jan 2 2025, 10:35
emack accepted D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.
Jan 2 2025, 10:33
Fabien requested review of D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.
Jan 2 2025, 09:55

Jan 1 2025

bytesofman closed D17446: [Cashtab] Remove artifact CashtabSettings type from formatting.
Jan 1 2025, 15:18
bytesofman committed rABCd5e2de595f89: [Cashtab] Remove artifact CashtabSettings type from formatting (authored by bytesofman).
[Cashtab] Remove artifact CashtabSettings type from formatting
Jan 1 2025, 15:18
bytesofman closed D17447: [Cashtab] More refinements to spot price presentation in agora.
Jan 1 2025, 14:36
bytesofman committed rABCf9f40e88249b: [Cashtab] More refinements to spot price presentation in agora (authored by bytesofman).
[Cashtab] More refinements to spot price presentation in agora
Jan 1 2025, 14:36
bytesofman added inline comments to D17447: [Cashtab] More refinements to spot price presentation in agora.
Jan 1 2025, 14:31
Fabien accepted D17447: [Cashtab] More refinements to spot price presentation in agora.
Jan 1 2025, 14:24
Fabien accepted D17446: [Cashtab] Remove artifact CashtabSettings type from formatting.
Jan 1 2025, 14:07
Fabien closed D17445: [cashtab] Don't open agora offers on a new tab.
Jan 1 2025, 14:07
Fabien committed rABCd72d9d5b7883: [cashtab] Don't open agora offers on a new tab (authored by Fabien).
[cashtab] Don't open agora offers on a new tab
Jan 1 2025, 14:07
bytesofman published D17447: [Cashtab] More refinements to spot price presentation in agora for review.
Jan 1 2025, 13:33
bytesofman published D17446: [Cashtab] Remove artifact CashtabSettings type from formatting for review.
Jan 1 2025, 13:05
bytesofman accepted D17445: [cashtab] Don't open agora offers on a new tab.
Jan 1 2025, 13:05
emack accepted D17445: [cashtab] Don't open agora offers on a new tab.

@bytesofman - as a side note, current versions of major browsers are all automatically assuming rel="noopener noreferrer" when opening links in a new window.

Jan 1 2025, 10:20
Fabien updated the summary of D17445: [cashtab] Don't open agora offers on a new tab.
Jan 1 2025, 08:19
Fabien requested review of D17445: [cashtab] Don't open agora offers on a new tab.
Jan 1 2025, 08:17
bytesofman closed D17444: [e.cash] Add clarificatio to XECX link page.
Jan 1 2025, 01:57
bytesofman committed rABC76fdd96fd56f: [e.cash] Add clarificatio to XECX link page (authored by bytesofman).
[e.cash] Add clarificatio to XECX link page
Jan 1 2025, 01:57
emack accepted D17444: [e.cash] Add clarificatio to XECX link page.
Jan 1 2025, 01:48
bytesofman published D17444: [e.cash] Add clarificatio to XECX link page for review.
Jan 1 2025, 01:02
bytesofman closed D17438: [Cashtab] Allow typed input for agora quantity selection.
Jan 1 2025, 00:52
bytesofman committed rABC2b6af5403027: [Cashtab] Allow typed input for agora quantity selection (authored by bytesofman).
[Cashtab] Allow typed input for agora quantity selection
Jan 1 2025, 00:52
bytesofman closed D17443: [Cashtab] Improve price precision for Agora spot prices.
Jan 1 2025, 00:20
bytesofman committed rABC90306ee11482: [Cashtab] Improve price precision for Agora spot prices (authored by bytesofman).
[Cashtab] Improve price precision for Agora spot prices
Jan 1 2025, 00:20
emack accepted D17443: [Cashtab] Improve price precision for Agora spot prices.
Jan 1 2025, 00:00

Dec 31 2024

emack accepted D17438: [Cashtab] Allow typed input for agora quantity selection.
Dec 31 2024, 23:44
abc-bot committed rABC60400b6149ea: [Automated] Update electrum checkpoints (authored by abc-bot).
[Automated] Update electrum checkpoints
Dec 31 2024, 23:09
bytesofman published D17443: [Cashtab] Improve price precision for Agora spot prices for review.
Dec 31 2024, 19:44
bytesofman requested changes to D17439: [e.cash] Add Swapspace widget.

hmm I wasn't able to target the iframe scrollbars afaict. Thats weird yours are looking like that though, mine have the custom scrollbar styles
How does the widget look for you on this page https://swapzone.io/partners/exchange-widget ?

Dec 31 2024, 19:42
teamcity added a comment to D17439: [e.cash] Add Swapspace widget.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41732 for the next 60 minutes.

Dec 31 2024, 19:37
teamcity awarded D17439: [e.cash] Add Swapspace widget a Piece of Eight token.
Dec 31 2024, 19:36
bytesofman added a comment to D17439: [e.cash] Add Swapspace widget.

@bot preview-e.cash

Dec 31 2024, 19:36
johnkuney added a comment to D17439: [e.cash] Add Swapspace widget.

hmm I wasn't able to target the iframe scrollbars afaict. Thats weird yours are looking like that though, mine have the custom scrollbar styles
How does the widget look for you on this page https://swapzone.io/partners/exchange-widget ?

Dec 31 2024, 18:34
johnkuney updated the diff for D17439: [e.cash] Add Swapspace widget.

fix copy

Dec 31 2024, 18:31
bytesofman updated the diff for D17438: [Cashtab] Allow typed input for agora quantity selection.

rebase

Dec 31 2024, 17:25
bytesofman closed D17441: [Cashtab] Add tooltipped icon on Agora Offers created by the token creator.
Dec 31 2024, 16:47
bytesofman committed rABC064ad0851df0: [Cashtab] Add tooltipped icon on Agora Offers created by the token creator (authored by bytesofman).
[Cashtab] Add tooltipped icon on Agora Offers created by the token creator
Dec 31 2024, 16:47
bytesofman closed D17442: [Cashtab] Show one more character on token urls.
Dec 31 2024, 16:43
bytesofman committed rABCd8d783a44134: [Cashtab] Show one more character on token urls (authored by bytesofman).
[Cashtab] Show one more character on token urls
Dec 31 2024, 16:43
Fabien accepted D17441: [Cashtab] Add tooltipped icon on Agora Offers created by the token creator.
Dec 31 2024, 16:38
Fabien accepted D17442: [Cashtab] Show one more character on token urls.
Dec 31 2024, 16:38
bytesofman updated the diff for D17442: [Cashtab] Show one more character on token urls.

use available space with breakpoints

Dec 31 2024, 15:43
bytesofman added a comment to D17442: [Cashtab] Show one more character on token urls.

If you have more space, why not add more ?

Dec 31 2024, 15:43
bytesofman added a comment to D17441: [Cashtab] Add tooltipped icon on Agora Offers created by the token creator.

I thought about that but you can't really know if it's the creator, right ? I mean the creator can have several addresses

Dec 31 2024, 15:29
Fabien accepted D17438: [Cashtab] Allow typed input for agora quantity selection.
Dec 31 2024, 15:27
Fabien requested changes to D17442: [Cashtab] Show one more character on token urls.

If you have more space, why not add more ?

Dec 31 2024, 15:27
Fabien added a comment to D17441: [Cashtab] Add tooltipped icon on Agora Offers created by the token creator.

I thought about that but you can't really know if it's the creator, right ? I mean the creator can have several addresses

Dec 31 2024, 15:26
bytesofman updated the diff for D17438: [Cashtab] Allow typed input for agora quantity selection.

locale decimalized format in the notification

Dec 31 2024, 15:16
PiRK planned changes to D17440: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot.

I have a test failing in a later commit due to an assertion in validation.cpp on line 6093 (Assertion pindex->nStatus.isOnParkedChain() || setBlockIndexCandidates.count(pindex)' failed..) I need to check if I missed something here, or if the issue is introduced later.

Dec 31 2024, 15:15
bytesofman updated the diff for D17438: [Cashtab] Allow typed input for agora quantity selection.

typo fix, make sure you display the actual amount bought in the buy success notification

Dec 31 2024, 15:11
bytesofman published D17442: [Cashtab] Show one more character on token urls for review.
Dec 31 2024, 14:46
bytesofman updated the diff for D17441: [Cashtab] Add tooltipped icon on Agora Offers created by the token creator.

remove unused mock rawtx from new test

Dec 31 2024, 14:41
bytesofman published D17441: [Cashtab] Add tooltipped icon on Agora Offers created by the token creator for review.
Dec 31 2024, 14:40
bytesofman added inline comments to D17438: [Cashtab] Allow typed input for agora quantity selection.
Dec 31 2024, 13:43
bytesofman added a comment to D17438: [Cashtab] Allow typed input for agora quantity selection.

Is there a guarantee that the selected buy amount is <= to the user requested amount ?

Dec 31 2024, 13:42
PiRK updated the summary of D17440: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot.
Dec 31 2024, 10:51
teamcity updated the summary of D17440: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot.
Dec 31 2024, 10:51
PiRK requested review of D17440: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot.
Dec 31 2024, 10:50
Fabien added a comment to D17438: [Cashtab] Allow typed input for agora quantity selection.

Is there a guarantee that the selected buy amount is <= to the user requested amount ?

Dec 31 2024, 10:28
Fabien closed D17431: [cmake] Handle FindBoost.cmake deprecation.
Dec 31 2024, 09:52
Fabien committed rABCe2f5b0bdbd81: [cmake] Handle FindBoost.cmake deprecation (authored by Fabien).
[cmake] Handle FindBoost.cmake deprecation
Dec 31 2024, 09:51
Fabien closed D17436: Increase the debug log assertion timeout in abc_feature_minerfund.py test.
Dec 31 2024, 09:51
Fabien committed rABCe5d86643ef8a: Increase the debug log assertion timeout in abc_feature_minerfund.py test (authored by Fabien).
Increase the debug log assertion timeout in abc_feature_minerfund.py test
Dec 31 2024, 09:51
PiRK accepted D17436: Increase the debug log assertion timeout in abc_feature_minerfund.py test.
Dec 31 2024, 09:49
PiRK accepted D17431: [cmake] Handle FindBoost.cmake deprecation.
Dec 31 2024, 09:49
bytesofman updated the test plan for D17438: [Cashtab] Allow typed input for agora quantity selection.
Dec 31 2024, 06:51
bytesofman requested changes to D17439: [e.cash] Add Swapspace widget.

any way we can clean up this scrollbar?

Dec 31 2024, 06:34
teamcity added a comment to D17439: [e.cash] Add Swapspace widget.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41622 for the next 60 minutes.

Dec 31 2024, 06:20
teamcity awarded D17439: [e.cash] Add Swapspace widget a Haypence token.
Dec 31 2024, 06:19
bytesofman added a comment to D17439: [e.cash] Add Swapspace widget.

@bot preview-e.cash

Dec 31 2024, 06:19
bytesofman updated the diff for D17438: [Cashtab] Allow typed input for agora quantity selection.

back out unrelated line break removal

Dec 31 2024, 05:51
bytesofman updated the diff for D17438: [Cashtab] Allow typed input for agora quantity selection.

add new mock and test case to confirm rendering of delta from input and actual

Dec 31 2024, 05:49
johnkuney requested review of D17439: [e.cash] Add Swapspace widget.
Dec 31 2024, 04:31
bytesofman added inline comments to D17438: [Cashtab] Allow typed input for agora quantity selection.
Dec 31 2024, 04:13
emack requested changes to D17438: [Cashtab] Allow typed input for agora quantity selection.
Dec 31 2024, 01:49
bytesofman published D17438: [Cashtab] Allow typed input for agora quantity selection for review.
Dec 31 2024, 00:26

Dec 30 2024

Fabien requested review of D17436: Increase the debug log assertion timeout in abc_feature_minerfund.py test.
Dec 30 2024, 22:36
teamcity awarded D17431: [cmake] Handle FindBoost.cmake deprecation a Doubloon token.
Dec 30 2024, 21:49
Fabien added a comment to D17431: [cmake] Handle FindBoost.cmake deprecation.

@bot guix-linux guix-osx guix-win

Dec 30 2024, 21:49
Fabien updated the diff for D17431: [cmake] Handle FindBoost.cmake deprecation.

Fix tab vs spaces

Dec 30 2024, 21:48
Fabien updated the diff for D17431: [cmake] Handle FindBoost.cmake deprecation.

Fix indentation

Dec 30 2024, 21:44
Fabien updated the diff for D17431: [cmake] Handle FindBoost.cmake deprecation.

There is no component on FindBoost for the headers target

Dec 30 2024, 21:42
teamcity added a comment to D17431: [cmake] Handle FindBoost.cmake deprecation.
Dec 30 2024, 21:13
teamcity added a comment to D17431: [cmake] Handle FindBoost.cmake deprecation.
Dec 30 2024, 21:12
teamcity added a comment to D17431: [cmake] Handle FindBoost.cmake deprecation.
Dec 30 2024, 21:10
teamcity awarded D17431: [cmake] Handle FindBoost.cmake deprecation a Piece of Eight token.
Dec 30 2024, 20:51
Fabien added a comment to D17431: [cmake] Handle FindBoost.cmake deprecation.

@bot guix-linux guix-osx guix-win

Dec 30 2024, 20:50
Fabien updated the diff for D17431: [cmake] Handle FindBoost.cmake deprecation.

Only set the policy if it exists

Dec 30 2024, 20:50