Page MenuHomePhabricator
Feed All Stories

Apr 18 2019

Fabien requested changes to D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.
Apr 18 2019, 06:13
teamcity added a comment to D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 18 2019, 06:03
Fabien updated the diff for D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.

Change configuration before removing the NDEBUG flag

Apr 18 2019, 06:02
teamcity added a comment to D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 18 2019, 00:59
teamcity added a comment to D2825: Remove the boost/algorithm/string/case_conv.hpp dependency.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 18 2019, 00:52
teamcity added a comment to D2824: scripted-diff: Replace NET_TOR with NET_ONION.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 18 2019, 00:45
teamcity added a comment to D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 18 2019, 00:45
jasonbcox updated the diff for D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.

Fixed qt includes. Ongoing discussion in Slack for how to tackle this problem more permanently.

Apr 18 2019, 00:45
jasonbcox updated the test plan for D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.
Apr 18 2019, 00:42
teamcity added a comment to D2825: Remove the boost/algorithm/string/case_conv.hpp dependency.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 18 2019, 00:39
Herald added a reviewer for D2825: Remove the boost/algorithm/string/case_conv.hpp dependency: Restricted Project.
Apr 18 2019, 00:38
teamcity added a comment to D2823: Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 18 2019, 00:36
teamcity added a comment to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 18 2019, 00:33
teamcity added a comment to D2824: scripted-diff: Replace NET_TOR with NET_ONION.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 18 2019, 00:31
Herald added a reviewer for D2824: scripted-diff: Replace NET_TOR with NET_ONION: Restricted Project.
Apr 18 2019, 00:30
teamcity added a comment to D2823: Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 18 2019, 00:23
Herald added a reviewer for D2823: Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor): Restricted Project.
Apr 18 2019, 00:22
teamcity added a comment to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 18 2019, 00:20
jasonbcox updated the diff for D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.

C++ style includes

Apr 18 2019, 00:19
jasonbcox updated the test plan for D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Apr 18 2019, 00:12
jasonbcox requested review of D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.
Apr 18 2019, 00:10
jasonbcox updated the test plan for D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.
Apr 18 2019, 00:09

Apr 17 2019

teamcity added a comment to D2822: Remove direct bitcoin calls from qt/bantablemodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 23:37
teamcity added a comment to D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 23:27
teamcity added a comment to D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 23:25
teamcity added a comment to D2822: Remove direct bitcoin calls from qt/bantablemodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 23:23
Herald added a reviewer for D2822: Remove direct bitcoin calls from qt/bantablemodel.cpp: Restricted Project.
Apr 17 2019, 23:23
teamcity added a comment to D2820: Remove Safe mode.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 23:21
deadalnix requested changes to D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.
Apr 17 2019, 23:20
deadalnix requested changes to D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.
Apr 17 2019, 23:18
deadalnix accepted D2819: Remove direct bitcoin calls from qt/intro.cpp.
Apr 17 2019, 23:14
teamcity added a comment to D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 23:13
jasonbcox updated the diff for D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.

Removed QT_VERSION check for an old version that we do not support

Apr 17 2019, 23:12
deadalnix requested changes to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Apr 17 2019, 23:11
deadalnix requested changes to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Apr 17 2019, 23:11
teamcity added a comment to D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 23:10
Herald added a reviewer for D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp: Restricted Project.
Apr 17 2019, 23:10
deadalnix requested changes to D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.
Apr 17 2019, 23:08
teamcity added a comment to D2820: Remove Safe mode.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 23:07
Herald added a reviewer for D2820: Remove Safe mode: Restricted Project.
Apr 17 2019, 23:06
deadalnix committed rABC2cf668a35ebd: Use angle bracket in include for net and netbase (authored by deadalnix).
Use angle bracket in include for net and netbase
Apr 17 2019, 22:24
deadalnix closed D2812: Use angle bracket in include for net and netbase.
Apr 17 2019, 22:24
jasonbcox accepted D2812: Use angle bracket in include for net and netbase.
Apr 17 2019, 22:08
teamcity added a comment to D2819: Remove direct bitcoin calls from qt/intro.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 19:09
jasonbcox committed rABC767c84e6195a: Remove direct bitcoin calls from qt/bitcoingui.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/bitcoingui.cpp
Apr 17 2019, 19:02
jasonbcox closed D2815: Remove direct bitcoin calls from qt/bitcoingui.cpp.
Apr 17 2019, 19:02
jasonbcox committed rABCabe5b965ab11: Remove direct bitcoin calls from qt/optionsmodel.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/optionsmodel.cpp
Apr 17 2019, 19:00
jasonbcox closed D2814: Remove direct bitcoin calls from qt/optionsmodel.cpp.
Apr 17 2019, 19:00
jasonbcox committed rABCce73c1b1e925: Remove direct bitcoin calls from qt/bitcoin.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/bitcoin.cpp
Apr 17 2019, 18:59
jasonbcox closed D2813: Remove direct bitcoin calls from qt/bitcoin.cpp.
Apr 17 2019, 18:59
teamcity added a comment to D2819: Remove direct bitcoin calls from qt/intro.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 18:55
Herald added a reviewer for D2819: Remove direct bitcoin calls from qt/intro.cpp: Restricted Project.
Apr 17 2019, 18:54
teamcity added a comment to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 18:41
jasonbcox added inline comments to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Apr 17 2019, 18:28
teamcity added a comment to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 18:27
Herald added a reviewer for D2818: Remove direct bitcoin calls from qt/clientmodel.cpp: Restricted Project.
Apr 17 2019, 18:25
Fabien requested changes to D2002: Disallow using addresses in createmultisig.

Can you rename deprecated_rpc.py to rpc_deprecated.py to follow the new naming convention ?

Apr 17 2019, 18:18
jasonbcox updated the test plan for D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Apr 17 2019, 18:17
teamcity added a comment to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 17:50
teamcity added a comment to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 17:43
teamcity added a comment to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 17:36
jasonbcox updated the diff for D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Fixed linker issues in the CMake build

Apr 17 2019, 17:35
teamcity added a comment to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 17:29
Herald added a reviewer for D2817: Remove direct bitcoin calls from qt/splashscreen.cpp: Restricted Project.
Apr 17 2019, 17:29
teamcity added a comment to D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 17:26
teamcity added a comment to D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 17:12
Herald added a reviewer for D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp: Restricted Project.
Apr 17 2019, 17:12
teamcity added a comment to D2815: Remove direct bitcoin calls from qt/bitcoingui.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 17:08
deadalnix accepted D2815: Remove direct bitcoin calls from qt/bitcoingui.cpp.
Apr 17 2019, 17:05
teamcity added a comment to D2814: Remove direct bitcoin calls from qt/optionsmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 17:05
teamcity added a comment to D2815: Remove direct bitcoin calls from qt/bitcoingui.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 17:03
teamcity added a comment to D2815: Remove direct bitcoin calls from qt/bitcoingui.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 16:54
jasonbcox updated the diff for D2815: Remove direct bitcoin calls from qt/bitcoingui.cpp.

Rebase

Apr 17 2019, 16:53
deadalnix accepted D2814: Remove direct bitcoin calls from qt/optionsmodel.cpp.
Apr 17 2019, 16:53
teamcity added a comment to D2814: Remove direct bitcoin calls from qt/optionsmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 16:51
jasonbcox updated the diff for D2814: Remove direct bitcoin calls from qt/optionsmodel.cpp.

Fixed forward declaration order

Apr 17 2019, 16:51
teamcity added a comment to D2815: Remove direct bitcoin calls from qt/bitcoingui.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 16:50
Herald added a reviewer for D2815: Remove direct bitcoin calls from qt/bitcoingui.cpp: Restricted Project.
Apr 17 2019, 16:49
teamcity added a comment to D2814: Remove direct bitcoin calls from qt/optionsmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 16:38
jasonbcox updated the summary of D2814: Remove direct bitcoin calls from qt/optionsmodel.cpp.
Apr 17 2019, 16:25
teamcity added a comment to D2814: Remove direct bitcoin calls from qt/optionsmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 16:24
Herald added a reviewer for D2814: Remove direct bitcoin calls from qt/optionsmodel.cpp: Restricted Project.
Apr 17 2019, 16:23
teamcity added a comment to D2813: Remove direct bitcoin calls from qt/bitcoin.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 16:14
deadalnix accepted D2813: Remove direct bitcoin calls from qt/bitcoin.cpp.
Apr 17 2019, 16:11
teamcity added a comment to D2813: Remove direct bitcoin calls from qt/bitcoin.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 15:59
Herald added a reviewer for D2813: Remove direct bitcoin calls from qt/bitcoin.cpp: Restricted Project.
Apr 17 2019, 15:59
teamcity added a comment to D2457: [schnorr] Refactor the signature process in reusable component.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 15:49
teamcity added a comment to D2457: [schnorr] Refactor the signature process in reusable component.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 15:35
deadalnix updated the diff for D2457: [schnorr] Refactor the signature process in reusable component.

dd a check for the point at infinity in secp256k1_schnorr_compute_sig

Apr 17 2019, 15:35
deadalnix added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
Apr 17 2019, 15:30
teamcity added a comment to D2002: Disallow using addresses in createmultisig.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 17 2019, 15:27
teamcity added a comment to D2002: Disallow using addresses in createmultisig.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 17 2019, 15:13
deadalnix updated the diff for D2002: Disallow using addresses in createmultisig.

Put that diff back in shape

Apr 17 2019, 15:12
jasonbcox closed T605: Backport Core PR 12630, a subtask of T417: Backport PR10244 from core, as Resolved.
Apr 17 2019, 15:07 · Backport
jasonbcox closed T605: Backport Core PR 12630 as Resolved.
Apr 17 2019, 15:07 · Backport
jasonbcox committed rABC297d67419ba8: Merge #12630: Provide useful error message if datadir is not writable. (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12630: Provide useful error message if datadir is not writable.
Apr 17 2019, 15:06
jasonbcox closed D2810: Merge #12630: Provide useful error message if datadir is not writable..
Apr 17 2019, 15:06
jasonbcox committed rABC00cda234b751: Merge #12422: util: Make LockDirectory thread-safe, consistent (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12422: util: Make LockDirectory thread-safe, consistent
Apr 17 2019, 15:04
jasonbcox closed T607: Backport Core PR 12422 as Resolved.
Apr 17 2019, 15:04 · Backport
jasonbcox closed T607: Backport Core PR 12422, a subtask of T605: Backport Core PR 12630, as Resolved.
Apr 17 2019, 15:04 · Backport